[jira] [Commented] (DRILL-5980) Make queryType param for REST API case insensitive
[ https://issues.apache.org/jira/browse/DRILL-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263511#comment-16263511 ] ASF GitHub Bot commented on DRILL-5980: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1044 > Make queryType param for REST API case insensitive > -- > > Key: DRILL-5980 > URL: https://issues.apache.org/jira/browse/DRILL-5980 > Project: Apache Drill > Issue Type: Improvement > Components: Web Server >Affects Versions: 1.11.0 >Reporter: Chris Sandison >Assignee: Chris Sandison >Priority: Minor > Labels: ready-to-commit > Fix For: 1.12.0 > > Original Estimate: 3h > Remaining Estimate: 3h > > QueryType uses `valueOf` to load appropriate enum, but this fails on > incorrect case for the argument. I have found this to be a breaking change > between 1.10 and 1.11. This could be improve to use `upcase()` to get the > enum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5980) Make queryType param for REST API case insensitive
[ https://issues.apache.org/jira/browse/DRILL-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262410#comment-16262410 ] ASF GitHub Bot commented on DRILL-5980: --- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1044 +1, LGTM. > Make queryType param for REST API case insensitive > -- > > Key: DRILL-5980 > URL: https://issues.apache.org/jira/browse/DRILL-5980 > Project: Apache Drill > Issue Type: Wish > Components: Web Server >Affects Versions: 1.11.0 >Reporter: Chris Sandison >Assignee: Chris Sandison >Priority: Minor > Labels: ready-to-commit > Fix For: 1.12.0 > > Original Estimate: 3h > Remaining Estimate: 3h > > QueryType uses `valueOf` to load appropriate enum, but this fails on > incorrect case for the argument. I have found this to be a breaking change > between 1.10 and 1.11. This could be improve to use `upcase()` to get the > enum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5980) Make queryType param for REST API case insensitive
[ https://issues.apache.org/jira/browse/DRILL-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261475#comment-16261475 ] ASF GitHub Bot commented on DRILL-5980: --- GitHub user ChrisSandison opened a pull request: https://github.com/apache/drill/pull/1044 DRILL-5980: Making queryType param for REST client case-insensitive Fixes #5980 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChrisSandison/drill DRILL-5980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/1044.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1044 commit 4ee5f80839ef9afdb1ba4132e23b14013a3330d4 Author: chris Date: 2017-11-21T20:53:45Z DRILL-5980: Making queryType param for REST client case-insensitive Fixes #5980 > Make queryType param for REST API case insensitive > -- > > Key: DRILL-5980 > URL: https://issues.apache.org/jira/browse/DRILL-5980 > Project: Apache Drill > Issue Type: Wish >Reporter: Chris Sandison >Assignee: Chris Sandison >Priority: Minor > Original Estimate: 3h > Remaining Estimate: 3h > > QueryType uses `valueOf` to load appropriate enum, but this fails on > incorrect case for the argument. I have found this to be a breaking change > between 1.10 and 1.11. This could be improve to use `upcase()` to get the > enum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5980) Make queryType param for REST API case insensitive
[ https://issues.apache.org/jira/browse/DRILL-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260810#comment-16260810 ] Chris Sandison commented on DRILL-5980: --- [~arina] I will have a PR for this shortly > Make queryType param for REST API case insensitive > -- > > Key: DRILL-5980 > URL: https://issues.apache.org/jira/browse/DRILL-5980 > Project: Apache Drill > Issue Type: Wish >Reporter: Chris Sandison >Assignee: Chris Sandison >Priority: Minor > Original Estimate: 3h > Remaining Estimate: 3h > > QueryType uses `valueOf` to load appropriate enum, but this fails on > incorrect case for the argument. I have found this to be a breaking change > between 1.10 and 1.11. This could be improve to use `upcase()` to get the > enum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DRILL-5980) Make queryType param for REST API case insensitive
[ https://issues.apache.org/jira/browse/DRILL-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259386#comment-16259386 ] Arina Ielchiieva commented on DRILL-5980: - Could you please add link to Drill code where change should be done? > Make queryType param for REST API case insensitive > -- > > Key: DRILL-5980 > URL: https://issues.apache.org/jira/browse/DRILL-5980 > Project: Apache Drill > Issue Type: Wish >Reporter: Chris Sandison >Assignee: Chris Sandison >Priority: Minor > Original Estimate: 3h > Remaining Estimate: 3h > > QueryType uses `valueOf` to load appropriate enum, but this fails on > incorrect case for the argument. I have found this to be a breaking change > between 1.10 and 1.11. This could be improve to use `upcase()` to get the > enum. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
