[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420566#comment-16420566
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1178


> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413106#comment-16413106
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

Github user ilooner commented on a diff in the pull request:

https://github.com/apache/drill/pull/1178#discussion_r176947145
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
 ---
@@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws 
Exception {
   @Test
   public void sortOneKeyAscending() throws Throwable {
 ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
-  .configProperty(ClassBuilder.CODE_DIR_OPTION, 
dirTestWatcher.getDir().getAbsolutePath())
   .configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
--- End diff --

Thanks for catching. Removed it.


> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412982#comment-16412982
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

Github user vvysotskyi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1178#discussion_r176936575
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
 ---
@@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws 
Exception {
   @Test
   public void sortOneKeyAscending() throws Throwable {
 ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
-  .configProperty(ClassBuilder.CODE_DIR_OPTION, 
dirTestWatcher.getDir().getAbsolutePath())
   .configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
--- End diff --

I think this line should be also removed since 
`ENABLE_SAVE_CODE_FOR_DEBUG_TOPN` should be disabled for tests.


> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412863#comment-16412863
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

Github user ilooner-mapr commented on the issue:

https://github.com/apache/drill/pull/1178
  
@vvysotskyi thanks for catching this. I've removed it from TopNBatchTest .


> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408340#comment-16408340
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

Github user vvysotskyi commented on the issue:

https://github.com/apache/drill/pull/1178
  
@ilooner, I have noticed that `ClassBuilder.CODE_DIR_OPTION` is used in 
`TopNBatchTest` class. Shoul we also remove it?


> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408329#comment-16408329
 ] 

ASF GitHub Bot commented on DRILL-6278:
---

GitHub user ilooner opened a pull request:

https://github.com/apache/drill/pull/1178

DRILL-6278: Removed temp codegen directory in testing framework.

@vvysotskyi Please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner/drill DRILL-6278

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1178


commit bde89d68b570eaa8792baa2517fab3c9765c28a4
Author: Timothy Farkas 
Date:   2018-03-21T06:00:22Z

DRILL-6278: Removed temp codegen directory in testing framework.




> DRILL-5993 Made Debugging Generated Code Harder
> ---
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
>  Issue Type: Bug
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored 
> generated code in unique directories in target. This required adding possibly 
> many tmp directories as source folders in order to be able to set break 
> points in generated code for different tests. This change should be reverted 
> to store generated code in the original default /tmp/drill/codegen directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)