[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413724#comment-16413724
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1177


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>  Labels: ready-to-commit
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.
> {noformat}
> [INFO] --- exec-maven-plugin:1.2.1:java (default) @ drill-common ---
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
> details.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410620#comment-16410620
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176608901
  
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
   
 
   
-   
+  
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-org.apache.drill
-drill-common
-${project.version}
-tests
-  
-
-
-  
-process-classes
-java
-  
-
-
-  
org.apache.drill.common.scanner.BuildTimeScan
-  true
--- End diff --

This is a nice move. 
I asked about ``, but you have already answered 
above, we just use project dependencies for now.


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.
> {noformat}
> [INFO] --- exec-maven-plugin:1.2.1:java (default) @ drill-common ---
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
> details.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408759#comment-16408759
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1177
  
@vdiravka Please clarify your concern regarding logback-classic. Without 
the fix, logback-classic is not on the classpath during `exec:java` maven 
plugin execution. This causes the following issue:
```
[INFO] --- exec-maven-plugin:1.2.1:java (default) @ drill-common ---
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
```


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408721#comment-16408721
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176263130
  
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
   
 
   
-   
+  
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-org.apache.drill
-drill-common
--- End diff --

`drill-common` and `drill-common-test` are included as part of `test` scope 
dependencies


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408714#comment-16408714
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176262322
  
--- Diff: common/pom.xml ---
@@ -113,20 +113,10 @@
   
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-process-classes
-
-  java
-
-  
-
 
-  
org.apache.drill.common.scanner.BuildTimeScan
-  
-${project.build.outputDirectory}
-  
+  
+
${project.basedir}/src/test/resources/
--- End diff --

The `logback-test.xml` was not in the classpath before, but it did not 
matter as slf4j did not bind to logback classic before anyway (it was not on 
classpath).


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408690#comment-16408690
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176260351
  
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
   
 
   
-   
+  
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-org.apache.drill
-drill-common
-${project.version}
-tests
-  
-
-
-  
-process-classes
-java
-  
-
-
-  
org.apache.drill.common.scanner.BuildTimeScan
-  true
--- End diff --

The plugin is now configured in the `PluginManagement` section in the drill 
root pom.


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408395#comment-16408395
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176195052
  
--- Diff: common/pom.xml ---
@@ -113,20 +113,10 @@
   
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-process-classes
-
-  java
-
-  
-
 
-  
org.apache.drill.common.scanner.BuildTimeScan
-  
-${project.build.outputDirectory}
-  
+  
+
${project.basedir}/src/test/resources/
--- End diff --

How it was in classpath earlier?


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408396#comment-16408396
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176195852
  
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
   
 
   
-   
+  
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-org.apache.drill
-drill-common
--- End diff --

We don't need dependency onto `drill-common` or it is specified in some 
other place?


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408397#comment-16408397
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176178853
  
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
   
 
   
-   
+  
 org.codehaus.mojo
 exec-maven-plugin
-1.2.1
-
-  
-org.apache.drill
-drill-common
-${project.version}
-tests
-  
-
-
-  
-process-classes
-java
-  
-
-
-  
org.apache.drill.common.scanner.BuildTimeScan
-  true
--- End diff --

It is no more needed?


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408394#comment-16408394
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1177#discussion_r176165870
  
--- Diff: 
common/src/main/java/org/apache/drill/common/scanner/BuildTimeScan.java ---
@@ -118,10 +118,10 @@ private static void save(ScanResult scanResult, File 
file) {
*/
   public static void main(String[] args) throws Exception {
 if (args.length != 1) {
-  throw new IllegalArgumentException("Usage: java {cp} " + 
ClassPathScanner.class.getName() + " path/to/scan");
+  throw new IllegalArgumentException("Usage: java {cp} " + 
BuildTimeScan.class.getName() + " path/to/scan");
--- End diff --

Consider String.format


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408216#comment-16408216
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1177
  
@vdiravka Please review


> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available 
> in {{test}} scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408195#comment-16408195
 ] 

ASF GitHub Bot commented on DRILL-6280:
---

GitHub user vrozov opened a pull request:

https://github.com/apache/drill/pull/1177

DRILL-6280: Cleanup execution of BuildTimeScan during maven build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vrozov/drill DRILL-6280

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1177


commit 5305320bb3745102dae071a035648f377de84464
Author: Vlad Rozov 
Date:   2018-03-21T02:24:11Z

DRILL-6280: Cleanup execution of BuildTimeScan during maven build




> Cleanup execution of BuildTimeScan during maven build
> -
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Vlad Rozov
>Assignee: Vlad Rozov
>Priority: Minor
>
> {{exec:java}} requires {{test}} scope due to dependency on 
> {{logback-classic}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)