[jira] [Commented] (DRILL-6562) Plugin Management improvements
[
https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822579#comment-16822579
]
Vitalii Diravka commented on DRILL-6562:
[~bbevens]
As for me the doc is good.
The process is the same, but Drill's Plugins Handler can be used to upload
Storage Plugins configs:
[https://drill.apache.org/docs/configuring-storage-plugins/#configuring-storage-plugins-with-the-storage-plugins-override-conf-file
] [~khfaraaz]
You are right there are few tests for Drill UI. There weren't unit tests for
Drill Storage REST API. Please create a separate Jira ticket for it.
Regarding functional testing, there is in_progress work - Drill Test framework
for Drill UI. Looks like it will cover Drill REST API too.
> Plugin Management improvements
> --
>
> Key: DRILL-6562
> URL: https://issues.apache.org/jira/browse/DRILL-6562
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
>Affects Versions: 1.14.0
>Reporter: Abhishek Girish
>Assignee: Vitalii Diravka
>Priority: Major
> Labels: doc-complete, ready-to-commit
> Fix For: 1.16.0
>
> Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21
> 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png,
> UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png,
> image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png
>
>
> Follow-up to DRILL-4580.
> Drill Storage UI improvements are shown in attached screenshots.
> The changes for this ticket also provide Drill REST API improvements:
> [https://drill.apache.org/docs/rest-api-introduction/#get-storage-json]
> export all plugins: {{/storage.json}} or {{/storage/all-plugins.json}}
> export enabled plugins: {{/storage/enabled-plugins.json}}
> export disabled plugins: {{/storage/disabled-plugins.json}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[ https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822149#comment-16822149 ] Khurram Faraaz commented on DRILL-6562: --- [~vitalii] Please add unit tests, there are no unit tests here [https://github.com/apache/drill/pull/1692] We will also have to add Functional tests to the test framework to test this. > Plugin Management improvements > -- > > Key: DRILL-6562 > URL: https://issues.apache.org/jira/browse/DRILL-6562 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.14.0 >Reporter: Abhishek Girish >Assignee: Vitalii Diravka >Priority: Major > Labels: doc-complete, ready-to-commit > Fix For: 1.16.0 > > Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21 > 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png, > UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png, > image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png > > > Follow-up to DRILL-4580. > Provide ability to export all storage plugin configurations at once, with a > new "Export All" option on the Storage page of the Drill web UI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[ https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821460#comment-16821460 ] Bridget Bevens commented on DRILL-6562: --- Hi [~vitalii], I added info about exporting all storage plugins here: https://drill.apache.org/docs/configuring-storage-plugins/#exporting-storage-plugin-configurations I’m still not sure how the .conf file works – do you copy and paste the configurations into each storage plugin configuration manually, or is there an easier way to import the file? Thanks, Bridget > Plugin Management improvements > -- > > Key: DRILL-6562 > URL: https://issues.apache.org/jira/browse/DRILL-6562 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.14.0 >Reporter: Abhishek Girish >Assignee: Vitalii Diravka >Priority: Major > Labels: doc-impacting, ready-to-commit > Fix For: 1.16.0 > > Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21 > 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png, > UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png, > image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png > > > Follow-up to DRILL-4580. > Provide ability to export all storage plugin configurations at once, with a > new "Export All" option on the Storage page of the Drill web UI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[ https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819625#comment-16819625 ] Bridget Bevens commented on DRILL-6562: --- Hi [~vitalii], If you use the Export All button to export all storage plugin configurations to HOCON format (.conf file), how do you import those configurations back into Drill? My guess is that you would name the file storage-plugins-override.conf and then copy it to the /conf directory, but I'm not sure. Thanks, Bridget > Plugin Management improvements > -- > > Key: DRILL-6562 > URL: https://issues.apache.org/jira/browse/DRILL-6562 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.14.0 >Reporter: Abhishek Girish >Assignee: Vitalii Diravka >Priority: Major > Labels: doc-impacting, ready-to-commit > Fix For: 1.16.0 > > Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21 > 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png, > UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png, > image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png > > > Follow-up to DRILL-4580. > Provide ability to export all storage plugin configurations at once, with a > new "Export All" option on the Storage page of the Drill web UI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[
https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800223#comment-16800223
]
ASF GitHub Bot commented on DRILL-6562:
---
vdiravka commented on pull request #1692: DRILL-6562: Plugin Management
improvements
URL: https://github.com/apache/drill/pull/1692#discussion_r268461626
##
File path: exec/java-exec/src/main/resources/rest/storage/list.ftl
##
@@ -17,79 +17,280 @@
limitations under the License.
-->
+
<#include "*/generic.ftl">
<#macro page_head>
+
+
+
+
+
<#macro page_body>
- Enabled Storage Plugins
-
+
+ Plugin Management
+
+
+
+
+
+ Create
+
+
+ Export all
+
+
+
+
+
+
+
+
+
+Enabled Storage Plugins
<#list model as plugin>
<#if plugin.enabled() == true>
-
+
${plugin.getName()}
-Update
-Disable
-Export
+
+ Update
+
+
+ Disable
+
+
+ Export
+
-
-
- Disabled Storage Plugins
-
+
+
+Disabled Storage Plugins
<#list model as plugin>
<#if plugin.enabled() == false>
-
+
${plugin.getName()}
-Update
-Enable
+
+ Update
+
+
+ Enable
+
+
+ Export
+
-
+
+
+ <#-- Modal window for exporting plugin config (including group plugins
modal) -->
+
+
+
+
+
+ Plugin config
+
+
+
+Format
+
+
+
+JSON
+
+
+
+
+
+HOCON
+
+
+
+
+
+Plugin group
+
+
+
+ALL
+
+
+
+
+
+ENABLED
+
+
+
+
+
+DISABLED
+
+
+
+
+
+
+ Close
+ Export
+
+
+
-
-New Storage Plugin
-
-
-
+ <#-- Modal window for exporting plugin config (including group plugins
modal) -->
+
+ <#-- Modal window for creating plugin -->
+
+
+
+
+
+ New Storage Plugin
+
+
+
+
+
+Configuration
+
+
+
+
+
+
+ Close
+ Create
+
+
+
+
+
+
- Create
-
+
+ <#-- Modal window for creating plugin -->
+
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[ https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800206#comment-16800206 ] ASF GitHub Bot commented on DRILL-6562: --- asfgit commented on pull request #1692: DRILL-6562: Plugin Management improvements URL: https://github.com/apache/drill/pull/1692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Plugin Management improvements > -- > > Key: DRILL-6562 > URL: https://issues.apache.org/jira/browse/DRILL-6562 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.14.0 >Reporter: Abhishek Girish >Assignee: Vitalii Diravka >Priority: Major > Labels: doc-impacting, ready-to-commit > Fix For: 1.16.0 > > Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21 > 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png, > UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png, > image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png > > > Follow-up to DRILL-4580. > Provide ability to export all storage plugin configurations at once, with a > new "Export All" option on the Storage page of the Drill web UI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
