[jira] [Commented] (DRILL-8446) Incorrect use of OperatingSystemMXBean
[ https://issues.apache.org/jira/browse/DRILL-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783443#comment-17783443 ] ASF GitHub Bot commented on DRILL-8446: --- jnturton merged PR #2843: URL: https://github.com/apache/drill/pull/2843 > Incorrect use of OperatingSystemMXBean > -- > > Key: DRILL-8446 > URL: https://issues.apache.org/jira/browse/DRILL-8446 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Mahmoud Ouali Alami >Assignee: James Turton >Priority: Major > Attachments: image-2023-07-04-15-36-42-905.png, > image-2023-07-04-16-24-59-662.png > > > *Context :* > In Drill "CpuGaugeSet" class, we use an internal class instead of a public > class : com.sun.management.OperatingSystemMXBean; > !image-2023-07-04-15-36-42-905.png|width=387,height=257! > This can result to a NoClassDefFoundError: > !image-2023-07-04-16-24-59-662.png|width=845,height=108! > *To do :* > Replace the private class "com.sun.managemenet.OperatingSystemMXBean" with > "java.lang.management.OperatingSystemMXBean", > > Kind regards, > Mahmoud > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8446) Incorrect use of OperatingSystemMXBean
[ https://issues.apache.org/jira/browse/DRILL-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783441#comment-17783441 ] ASF GitHub Bot commented on DRILL-8446: --- jnturton commented on PR #2843: URL: https://github.com/apache/drill/pull/2843#issuecomment-1797131001 > LGTM +1 > > @jnturton Does this fix the Splunk flaky test? Hopefully. > Incorrect use of OperatingSystemMXBean > -- > > Key: DRILL-8446 > URL: https://issues.apache.org/jira/browse/DRILL-8446 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Mahmoud Ouali Alami >Assignee: James Turton >Priority: Major > Attachments: image-2023-07-04-15-36-42-905.png, > image-2023-07-04-16-24-59-662.png > > > *Context :* > In Drill "CpuGaugeSet" class, we use an internal class instead of a public > class : com.sun.management.OperatingSystemMXBean; > !image-2023-07-04-15-36-42-905.png|width=387,height=257! > This can result to a NoClassDefFoundError: > !image-2023-07-04-16-24-59-662.png|width=845,height=108! > *To do :* > Replace the private class "com.sun.managemenet.OperatingSystemMXBean" with > "java.lang.management.OperatingSystemMXBean", > > Kind regards, > Mahmoud > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8446) Incorrect use of OperatingSystemMXBean
[ https://issues.apache.org/jira/browse/DRILL-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781617#comment-17781617 ] ASF GitHub Bot commented on DRILL-8446: --- jnturton opened a new pull request, #2843: URL: https://github.com/apache/drill/pull/2843 # [DRILL-8446](https://issues.apache.org/jira/browse/DRILL-8446): Incorrect use of OperatingSystemMXBean ## Description Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process. Even though code to handle non-Sun/Oracle runtimes for the OperatingSystemMXBean was present, it would still cause them to attempt to load a class from com.sun.management causing a NoClassDefFoundError. ## Documentation N/A ## Testing Launch Drill and check the affected gauges in - OpenJDK 64-Bit Server VM (build 17.0.9+9-Debian-1, mixed mode, sharing) - IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20230817_56476 (JIT enabled, AOT enabled) > Incorrect use of OperatingSystemMXBean > -- > > Key: DRILL-8446 > URL: https://issues.apache.org/jira/browse/DRILL-8446 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.21.1 >Reporter: Mahmoud Ouali Alami >Assignee: James Turton >Priority: Major > Attachments: image-2023-07-04-15-36-42-905.png, > image-2023-07-04-16-24-59-662.png > > > *Context :* > In Drill "CpuGaugeSet" class, we use an internal class instead of a public > class : com.sun.management.OperatingSystemMXBean; > !image-2023-07-04-15-36-42-905.png|width=387,height=257! > This can result to a NoClassDefFoundError: > !image-2023-07-04-16-24-59-662.png|width=845,height=108! > *To do :* > Replace the private class "com.sun.managemenet.OperatingSystemMXBean" with > "java.lang.management.OperatingSystemMXBean", > > Kind regards, > Mahmoud > -- This message was sent by Atlassian Jira (v8.20.10#820010)
