[jira] [Commented] (DRILL-8449) Typo in FreeMarker templates

2023-08-10 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/DRILL-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752839#comment-17752839
 ] 

ASF GitHub Bot commented on DRILL-8449:
---

cgivre merged PR #2818:
URL: https://github.com/apache/drill/pull/2818




> Typo in FreeMarker templates
> 
>
> Key: DRILL-8449
> URL: https://issues.apache.org/jira/browse/DRILL-8449
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.16.0
>Reporter: Maksym Rymar
>Assignee: Maksym Rymar
>Priority: Minor
> Fix For: 1.22.0
>
> Attachments: image-2023-08-07-21-15-56-847.png
>
>
> Css based properties use colon({{{}:{}}}) to assign values. The 
> {{result.ftl}} and {{options.ftl have property }}width{{{} with equal 
> sign({}}}={{{}) instead of colon({}}}:{{{}).{}}}
>  
> This typo makes query result table has incorrect display.
> Steps to reproduce:
>  # Execute example query: {{select full_name from cp.`employee.json` limit 1}}
>  # Push on "Column visibility" button and togle "full_name" column visibility 
> off and turn back on.
> !image-2023-08-07-21-15-56-847.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (DRILL-8449) Typo in FreeMarker templates

2023-08-07 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/DRILL-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751778#comment-17751778
 ] 

ASF GitHub Bot commented on DRILL-8449:
---

cgivre commented on PR #2818:
URL: https://github.com/apache/drill/pull/2818#issuecomment-1668420106

   Thanks @rymarm 
   I'll merge once the CI passes.




> Typo in FreeMarker templates
> 
>
> Key: DRILL-8449
> URL: https://issues.apache.org/jira/browse/DRILL-8449
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.16.0
>Reporter: Maksym Rymar
>Assignee: Maksym Rymar
>Priority: Minor
> Fix For: 1.22.0
>
> Attachments: image-2023-08-07-21-15-56-847.png
>
>
> Css based properties use colon({{{}:{}}}) to assign values. The 
> {{result.ftl}} and {{options.ftl have property }}width{{{} with equal 
> sign({}}}={{{}) instead of colon({}}}:{{{}).{}}}
>  
> This typo makes query result table has incorrect display.
> Steps to reproduce:
>  # Execute example query: {{select full_name from cp.`employee.json` limit 1}}
>  # Push on "Column visibility" button and togle "full_name" column visibility 
> off and turn back on.
> !image-2023-08-07-21-15-56-847.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (DRILL-8449) Typo in FreeMarker templates

2023-08-07 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/DRILL-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751772#comment-17751772
 ] 

ASF GitHub Bot commented on DRILL-8449:
---

rymarm opened a new pull request, #2818:
URL: https://github.com/apache/drill/pull/2818

   # [DRILL-8449](https://issues.apache.org/jira/browse/DRILL-8449): Typo in 
FreeMarker templates
   
   ## Description
   
   CSS-based properties use a colon(`:`) to assign values. The `result.ftl` and 
`options.ftl` have the property `width` with an equal sign(`=`) instead of a 
colon(`:`).
   
   This typo makes a query result table has an incorrect display.
   
   Steps to reproduce:
   1. Execute example query: `select full_name from cp.`employee.json` limit 1`;
   2. Push the "Column visibility" button, toggle "full_name" column visibility 
off, and turn it back on.
   
   
   ## Documentation
   None requerid
   
   ## Testing
   Visual test of UI
   




> Typo in FreeMarker templates
> 
>
> Key: DRILL-8449
> URL: https://issues.apache.org/jira/browse/DRILL-8449
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Web Server
>Affects Versions: 1.16.0
>Reporter: Maksym Rymar
>Assignee: Maksym Rymar
>Priority: Minor
> Fix For: 1.22.0
>
> Attachments: image-2023-08-07-21-15-56-847.png
>
>
> Css based properties use colon({{{}:{}}}) to assign values. The 
> {{result.ftl}} and {{options.ftl have property }}width{{{} with equal 
> sign({}}}={{{}) instead of colon({}}}:{{{}).{}}}
>  
> This typo makes query result table has incorrect display.
> Steps to reproduce:
>  # Execute example query: {{select full_name from cp.`employee.json` limit 1}}
>  # Push on "Column visibility" button and togle "full_name" column visibility 
> off and turn back on.
> !image-2023-08-07-21-15-56-847.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)