[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[
https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=316945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316945
]
ASF GitHub Bot logged work on EAGLE-1068:
-
Author: ASF GitHub Bot
Created on: 23/Sep/19 19:46
Start Date: 23/Sep/19 19:46
Worklog Time Spent: 10m
Work Description: haoch commented on pull request #1003: [EAGLE-1068]
Upgrade Siddhi dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327296261
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@grainier Why remove this assertion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 316945)
Time Spent: 40m (was: 0.5h)
> Upgrade siddhi dependency to v5.1.4
> ---
>
> Key: EAGLE-1068
> URL: https://issues.apache.org/jira/browse/EAGLE-1068
> Project: Eagle
> Issue Type: Improvement
> Components: Core::Alert Engine
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Grainier Perera
>Priority: Blocker
> Fix For: v0.5.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [eagle] haoch commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
haoch commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi
dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327296261
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@grainier Why remove this assertion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[ https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=316944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316944 ] ASF GitHub Bot logged work on EAGLE-1068: - Author: ASF GitHub Bot Created on: 23/Sep/19 19:42 Start Date: 23/Sep/19 19:42 Worklog Time Spent: 10m Work Description: haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-534253270 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316944) Time Spent: 0.5h (was: 20m) > Upgrade siddhi dependency to v5.1.4 > --- > > Key: EAGLE-1068 > URL: https://issues.apache.org/jira/browse/EAGLE-1068 > Project: Eagle > Issue Type: Improvement > Components: Core::Alert Engine >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Grainier Perera >Priority: Blocker > Fix For: v0.5.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [eagle] haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-534253270 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
