[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version

2017-07-18 Thread rushikesavareddy 
Github user rushikesavareddy commented on the issue:

https://github.com/apache/eagle/pull/941
  
@jhsenjaliya 
build was successful with checkStyleFlag enabled. Changed base/target 
branch to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-06-13 Thread rushikesavareddy 
Github user rushikesavareddy commented on a diff in the pull request:

https://github.com/apache/eagle/pull/941#discussion_r121674223
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
 ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
 velocityEngine = new VelocityEngine();
 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, 
"classpath");
 velocityEngine.setProperty("classpath.resource.loader.class", 
ClasspathResourceLoader.class.getName());
+
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+
velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
 velocityEngine.init();
 
 config.put("mail.transport.protocol", "smtp");
 if 
(Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
 session = Session.getInstance(config, new Authenticator() {
 protected PasswordAuthentication 
getPasswordAuthentication() {
 return new PasswordAuthentication(
-
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
-
config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
-);
+
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --

@jhsenjaliya fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-06-13 Thread rushikesavareddy 
Github user rushikesavareddy commented on a diff in the pull request:

https://github.com/apache/eagle/pull/941#discussion_r121674210
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
 ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
 velocityEngine = new VelocityEngine();
 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, 
"classpath");
 velocityEngine.setProperty("classpath.resource.loader.class", 
ClasspathResourceLoader.class.getName());
+
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+
velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
 velocityEngine.init();
 
 config.put("mail.transport.protocol", "smtp");
 if 
(Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
 session = Session.getInstance(config, new Authenticator() {
 protected PasswordAuthentication 
getPasswordAuthentication() {
 return new PasswordAuthentication(
-
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
-
config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
-);
+
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
+
config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
+);
 }
 });
 } else {
 session = Session.getInstance(config, new Authenticator() {
 });
 }
-
--- End diff --

@jhsenjaliya fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-06-13 Thread rushikesavareddy 
Github user rushikesavareddy commented on a diff in the pull request:

https://github.com/apache/eagle/pull/941#discussion_r121674160
  
--- Diff: 
eagle-core/eagle-common/src/main/java/org/apache/eagle/common/mail/EagleMailClient.java
 ---
@@ -53,16 +53,18 @@ public EagleMailClient(final Properties config) {
 velocityEngine = new VelocityEngine();
 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, 
"classpath");
 velocityEngine.setProperty("classpath.resource.loader.class", 
ClasspathResourceLoader.class.getName());
+
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, 
Log4JLogChute.class.getName());
+
velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
 velocityEngine.init();
 
 config.put("mail.transport.protocol", "smtp");
 if 
(Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
 session = Session.getInstance(config, new Authenticator() {
 protected PasswordAuthentication 
getPasswordAuthentication() {
 return new PasswordAuthentication(
-
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
-
config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
-);
+
config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --

@jhsenjaliya fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-06-06 Thread rushikesavareddy 
Github user rushikesavareddy commented on a diff in the pull request:

https://github.com/apache/eagle/pull/941#discussion_r120271788
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
 ---
@@ -25,7 +25,7 @@
 import org.apache.velocity.runtime.resource.loader.ClasspathResourceLoader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-
--- End diff --

@jhsenjaliya done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-06-06 Thread rushikesavareddy 
Github user rushikesavareddy commented on a diff in the pull request:

https://github.com/apache/eagle/pull/941#discussion_r120271781
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
 ---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
 velocityEngine = new VelocityEngine();
 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, 
"classpath");
 velocityEngine.setProperty("classpath.resource.loader.class", 
ClasspathResourceLoader.class.getName());
+ 
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
--- End diff --

@jhsenjaliya incorporated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

2017-05-31 Thread rushikesavareddy 
GitHub user rushikesavareddy opened a pull request:

https://github.com/apache/eagle/pull/941

[EAGLE-968] Fix for email issue in 0.5 eagle version



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rushikesavareddy/eagle branch-0.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #941


commit 215329d7fb13e1e5576b18ad09c0b23e698e14a9
Author: kreddylh <kredd...@paypal.com>
Date:   2017-05-31T08:43:09Z

Fix for email issue in 0.5 eagle version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---