[GitHub] eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/647 I spent lot of time in rebasing this, but eventually it got very confusing since there are lot of files ( ~1500) to be rebased, which i did (jhsenjaliya:EAGLE-740-rebased) but there are multiple layers of rebase needs to be done, and i afraid i cant pick the right candidate wherever there are conflicts. so I am leaving this aside for 0.5 release, and we can get to this afterwards. this is important and we should take this change eventually. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/647 Hi @koone, This would be good to add in 0.5 branch, would you have time to rebase this and address comments from @haoch ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/647 @haoch , do you need any help on reviewing this? @koone, Can you please rebase this PR ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---