[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689660#comment-16689660 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 closed the pull request at: https://github.com/apache/eagle/pull/925 > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.5.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin >Priority: Major > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994135#comment-15994135 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on the issue: https://github.com/apache/eagle/pull/925 @jhsenjaliya You are welcome. Sorry, i just note it. Let’s finish this after `v0.5.0` together. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.5.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993451#comment-15993451 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/925 @asdf2014 Thanks again, lets work on this after 0.5 > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.5.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992597#comment-15992597 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114278551 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java --- @@ -62,10 +60,9 @@ public void onAlert(AlertStreamEvent event) throws Exception { if (eventList == null || eventList.isEmpty()) { return; } -List alertEvents = new ArrayList<>(); -for (AlertStreamEvent e : eventList) { -alertEvents.add(AlertPublishEvent.createAlertPublishEvent(e)); -} +List alertEvents = eventList.stream().map( --- End diff -- I have created a non-professional benchmark [test](https://github.com/asdf2014/yuzhouwan/blob/master/yuzhouwan-hacker/src/main/java/com/yuzhouwan/hacker/lambda/StreamPerformance.java#L19). After adding `-Xmx2G -Xms2G -Xmn1G -XX:+AlwaysPreTouch` params for reducing the impact from jvm resources, then found the performance gap is not very large, and the performance of `lambda stream` is better than `simple for loop` after the data becomes larger. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.5.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992404#comment-15992404 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114255903 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java --- @@ -62,10 +60,9 @@ public void onAlert(AlertStreamEvent event) throws Exception { if (eventList == null || eventList.isEmpty()) { return; } -List alertEvents = new ArrayList<>(); -for (AlertStreamEvent e : eventList) { -alertEvents.add(AlertPublishEvent.createAlertPublishEvent(e)); -} +List alertEvents = eventList.stream().map( --- End diff -- Maybe you are right, i will roll it back. :+1: > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992392#comment-15992392 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114254748 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java --- @@ -199,7 +194,7 @@ private void closePlugins(List toBeClosed) { try { p.close(); } catch (Exception e) { -LOG.error(String.format("Error when close publish plugin {}!", p.getClass().getCanonicalName()), e); +LOG.error(String.format("Error when close publish plugin %s!", p.getClass().getCanonicalName()), e); --- End diff -- `String.format` should use `%s` rather than `{}` ```java @Test public void testFormat() { assertEquals("a{}c", String.format("a{}c", "b")); assertEquals("abc", String.format("a%sc", "b")); } ``` > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992387#comment-15992387 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on the issue: https://github.com/apache/eagle/pull/925 @jhsenjaliya Okay, i see. Thx for your `code review`. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992384#comment-15992384 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114254151 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java --- @@ -62,10 +60,9 @@ public void onAlert(AlertStreamEvent event) throws Exception { if (eventList == null || eventList.isEmpty()) { return; } -List alertEvents = new ArrayList<>(); -for (AlertStreamEvent e : eventList) { -alertEvents.add(AlertPublishEvent.createAlertPublishEvent(e)); -} +List alertEvents = eventList.stream().map( --- End diff -- I think it will bring better maintainability and [performance](http://blog.takipi.com/benchmark-how-java-8-lambdas-and-streams-can-make-your-code-5-times-slower/). > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992380#comment-15992380 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114253745 --- Diff: eagle-core/eagle-alert-parent/eagle-alert-service/src/main/java/org/apache/eagle/service/alert/resolver/AttributeResolverFactory.java --- @@ -43,8 +43,6 @@ public static AttributeResolvable getAttributeResolver(String fieldResolverName, fieldResolvableCache.put(fieldResolverName, instance); } catch (ClassNotFoundException e) { throw new AttributeResolveException("Attribute Resolver in type of " + fieldResolverName + " is not found", e); -} catch (InstantiationException | IllegalAccessException e) { --- End diff -- I see. I will roll it back. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992378#comment-15992378 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/925 @asdf2014 , i havent gone through all the changes yet, but looks like these are what some particular IDE would recommend, some are real improvements as well. lets check this out after 0.5, Thanks for the efforts ! > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992375#comment-15992375 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user jhsenjaliya commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114253159 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java --- @@ -199,7 +194,7 @@ private void closePlugins(List toBeClosed) { try { p.close(); } catch (Exception e) { -LOG.error(String.format("Error when close publish plugin {}!", p.getClass().getCanonicalName()), e); +LOG.error(String.format("Error when close publish plugin %s!", p.getClass().getCanonicalName()), e); --- End diff -- people are using this interchangeably > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992374#comment-15992374 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user jhsenjaliya commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114253102 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java --- @@ -62,10 +60,9 @@ public void onAlert(AlertStreamEvent event) throws Exception { if (eventList == null || eventList.isEmpty()) { return; } -List alertEvents = new ArrayList<>(); -for (AlertStreamEvent e : eventList) { -alertEvents.add(AlertPublishEvent.createAlertPublishEvent(e)); -} +List alertEvents = eventList.stream().map( --- End diff -- i feel its fancy to use newer java features, but old syntax is more readable, may be its just a coding preference > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992373#comment-15992373 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user jhsenjaliya commented on a diff in the pull request: https://github.com/apache/eagle/pull/925#discussion_r114252915 --- Diff: eagle-core/eagle-alert-parent/eagle-alert-service/src/main/java/org/apache/eagle/service/alert/resolver/AttributeResolverFactory.java --- @@ -43,8 +43,6 @@ public static AttributeResolvable getAttributeResolver(String fieldResolverName, fieldResolvableCache.put(fieldResolverName, instance); } catch (ClassNotFoundException e) { throw new AttributeResolveException("Attribute Resolver in type of " + fieldResolverName + " is not found", e); -} catch (InstantiationException | IllegalAccessException e) { --- End diff -- instead of removing this, it can be used to describe the error, IDE is suggesting to collapse the catch block may be because it has identical error msg (throw new AttributeResolveException(e)). > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991973#comment-15991973 ] ASF GitHub Bot commented on EAGLE-1012: --- Github user asdf2014 commented on the issue: https://github.com/apache/eagle/pull/925 If these improvements are necessary, we should step by step merge to avoid too much code conflict. So, creating multiple sub `PRs` for `EAGLE-1012` will be more suitable for this situation. What do you think? @jhsenjaliya @qingwen220 > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974481#comment-15974481 ] ASF GitHub Bot commented on EAGLE-1012: --- GitHub user asdf2014 opened a pull request: https://github.com/apache/eagle/pull/925 [EAGLE-1012] Some language level problems Some language level problems * Spell * Duplicated * Lambda * Collection * String * instanceof * Complex Method * Exception * AutoClose * Synchronized Details see [attachment files](https://issues.apache.org/jira/secure/attachment/12863947/Eagle%20Language%20Level%20Problems.txt). You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/eagle language_level_problem Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/925.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #925 commit f935407f672b92146f57ad2da5ef7c36dc2931a5 Author: asdf2014 <1571805...@qq.com> Date: 2017-04-19T11:40:16Z Fix spell issues > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974168#comment-15974168 ] Benedict Jin commented on EAGLE-1012: - By the way, i am looking forward to the `Eagle` v0.5.0 :D > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974164#comment-15974164 ] Benedict Jin commented on EAGLE-1012: - [~jhsenjaliya] Hi, Jayesh. Yep, i have installed `Eagle` v0.4.0 for monitoring `HDFS Audit` and `HBase Security`. Those imporvements about `Eagle` is based on newest master branch. As far as I know there is no any special tool for doing this. Maybe, some code quality CI tools could. And i think we should add a code quality tool into `Eagle` check-in system rather than just only `Jenkins`. Details about those problems will be recored in attachment files in succession. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974165#comment-15974165 ] Benedict Jin commented on EAGLE-1012: - Hi, [~jhsenjaliya]. Yep, i have installed `Eagle` v0.4.0 for monitoring `HDFS Audit` and `HBase Security`. Those imporvements about `Eagle` is based on newest master branch. As far as I know there is no any special tool for doing this. Maybe, some code quality CI tools could. And i think we should add a code quality tool into `Eagle` check-in system rather than just only `Jenkins`. Details about those problems will be recored in attachment files in succession. > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (EAGLE-1012) Some language level problems
[ https://issues.apache.org/jira/browse/EAGLE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974138#comment-15974138 ] Jayesh commented on EAGLE-1012: --- are you on 0.4, any plan to move on to 0.5? or do this analysis for 0.5 as well ? btw, what is this tool ? do you have any detail report ? > Some language level problems > > > Key: EAGLE-1012 > URL: https://issues.apache.org/jira/browse/EAGLE-1012 > Project: Eagle > Issue Type: Bug > Components: Project Infrastructure >Affects Versions: v0.4.0 > Environment: Linux 2.6.32-279.el6.x86_64 #1 SMP Wed Jun 13 18:24:36 > EDT 2012 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Benedict Jin > Labels: JDK > Fix For: v0.6.0 > > Attachments: Eagle Language Level Problems.txt > > Original Estimate: 168h > Remaining Estimate: 168h > > Some language level problems > * Spell > * Duplicated > * Lambda > * Collection > * String > * instanceof > * Complex Method > * Exception > Details see attachment files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)