[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347471#comment-16347471 ] ASF GitHub Bot commented on EAGLE-1075: --- Github user asfgit closed the pull request at: https://github.com/apache/eagle/pull/978 > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > Fix For: v0.5.1 > > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347467#comment-16347467 ] ASF GitHub Bot commented on EAGLE-1075: --- Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/978 +1, merging since its improved than earlier and more improvements can be later. Thanks for the PR. > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > Fix For: v0.5.1 > > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347461#comment-16347461
]
ASF GitHub Bot commented on EAGLE-1075:
---
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/978#discussion_r165162632
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertFilePublisher.java
---
@@ -54,13 +54,26 @@ public void init(Config config, Publishment
publishment, Map conf) throws Except
int numOfFiles = DEFAULT_FILE_NUMBER;
if (publishment.getProperties() != null) {
if
(publishment.getProperties().containsKey(PublishConstants.FILE_NAME)) {
-fileName = (String)
publishment.getProperties().get(PublishConstants.FILE_NAME);
+String property = (String)
publishment.getProperties().get(PublishConstants.FILE_NAME);
+if (property != null && !"".equals(property)) {
+fileName = property;
+}
}
if
(publishment.getProperties().containsKey(PublishConstants.ROTATE_EVERY_KB)) {
-rotateSize =
Integer.valueOf(publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB).toString());
+Object property =
publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB);
+if (property instanceof Integer) {
+rotateSize = (Integer)property;
+} else if (property instanceof String &&
!"".equals((String)property)) {
--- End diff --
could also check for null once its is instanceof string.
> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
> Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the
> AlertFilePublisher in the UI. So for example we can't configure the file
> name/path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346991#comment-16346991 ] ASF GitHub Bot commented on EAGLE-1075: --- GitHub user coheigea reopened a pull request: https://github.com/apache/eagle/pull/978 EAGLE-1075 - Can't specify configuration options for AlertFilePublisher Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/coheigea/eagle EAGLE-1075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #978 commit fb3868a8532a6e3b40c305ddd3d317b3fc8e1a29 Author: Colm O hEigeartaigh Date: 2018-01-31T15:15:57Z EAGLE-1075 - Can't specify configuration options for AlertFilePublisher > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > Fix For: v0.5.1 > > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346622#comment-16346622 ] ASF GitHub Bot commented on EAGLE-1075: --- Github user coheigea closed the pull request at: https://github.com/apache/eagle/pull/978 > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > Fix For: v0.5.1 > > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337513#comment-16337513 ] Colm O hEigeartaigh commented on EAGLE-1075: Please ignore the first PR (I accidentally committed the fix to master on my fork instead of a branch. The correct PR is: [https://github.com/apache/eagle/pull/978.patch] I tested this with HDFS audit logging using the default filename as well as specifying a custom path. > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337511#comment-16337511 ] ASF GitHub Bot commented on EAGLE-1075: --- GitHub user coheigea opened a pull request: https://github.com/apache/eagle/pull/978 EAGLE-1075 - Can't specify configuration options for AlertFilePublisher Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/coheigea/eagle EAGLE-1075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #978 commit 1a217025af9080ada64104920e7c6bb434164e99 Author: Colm O hEigeartaigh Date: 2018-01-24T12:28:09Z EAGLE-1075 - Can't specify configuration options for AlertFilePublisher > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337509#comment-16337509 ] ASF GitHub Bot commented on EAGLE-1075: --- Github user coheigea closed the pull request at: https://github.com/apache/eagle/pull/977 > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher
[ https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337505#comment-16337505 ] ASF GitHub Bot commented on EAGLE-1075: --- GitHub user coheigea opened a pull request: https://github.com/apache/eagle/pull/977 EAGLE-1075 - Can't specify configuration options for AlertFilePublisher Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/coheigea/eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/977.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #977 commit 08241fd810803b8c0ba548f4592abefd395b43cc Author: Colm O hEigeartaigh Date: 2018-01-24T12:24:26Z EAGLE-1075 - Can't specify configuration options for AlertFilePublisher > Can't specify configuration options for AlertFilePublisher > -- > > Key: EAGLE-1075 > URL: https://issues.apache.org/jira/browse/EAGLE-1075 > Project: Eagle > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Priority: Major > > Right now it's not possible to specify the configuration options for the > AlertFilePublisher in the UI. So for example we can't configure the file > name/path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
