[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

2018-01-31 Thread Colm O hEigeartaigh (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347533#comment-16347533
 ] 

Colm O hEigeartaigh commented on EAGLE-331:
---

[~jhsenjaliya], I can't assign it to myself as I didn't create it, and I don't 
have the permissions on this project to assign arbitrary issues to myself.

> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

2018-01-31 Thread Jayesh (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347349#comment-16347349
 ] 

Jayesh commented on EAGLE-331:
--

[~coheigea], can u pease assign this to yourself, Jira cant find ur username 
somehow.  Thanks

> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

2018-01-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347334#comment-16347334
 ] 

ASF GitHub Bot commented on EAGLE-331:
--

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/979


> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Assignee: Lingang Deng
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

2018-01-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347166#comment-16347166
 ] 

ASF GitHub Bot commented on EAGLE-331:
--

GitHub user coheigea opened a pull request:

https://github.com/apache/eagle/pull/979

EAGLE-331 - avoid to use junit.framework.Assert



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-331

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/979.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #979


commit 1b72b39893eef46e893bb4295355d67ac477e23a
Author: Colm O hEigeartaigh 
Date:   2018-01-31T16:54:01Z

EAGLE-331 - avoid to use junit.framework.Assert




> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Assignee: Lingang Deng
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)