[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[ https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=322339=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322339 ] ASF GitHub Bot logged work on EAGLE-1068: - Author: ASF GitHub Bot Created on: 02/Oct/19 22:50 Start Date: 02/Oct/19 22:50 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322339) Time Spent: 1h 10m (was: 1h) > Upgrade siddhi dependency to v5.1.4 > --- > > Key: EAGLE-1068 > URL: https://issues.apache.org/jira/browse/EAGLE-1068 > Project: Eagle > Issue Type: Improvement > Components: Core::Alert Engine >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Grainier Perera >Priority: Blocker > Fix For: v0.5.1 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[
https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=317242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317242
]
ASF GitHub Bot logged work on EAGLE-1068:
-
Author: ASF GitHub Bot
Created on: 24/Sep/19 07:53
Start Date: 24/Sep/19 07:53
Worklog Time Spent: 10m
Work Description: grainier commented on pull request #1003: [EAGLE-1068]
Upgrade Siddhi dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327474090
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@haoch, sorry, it was a mistake. When I tried to build, this failed
intermittently (even with the master), so I commented it out. Reverted with
1240042
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317242)
Time Spent: 50m (was: 40m)
> Upgrade siddhi dependency to v5.1.4
> ---
>
> Key: EAGLE-1068
> URL: https://issues.apache.org/jira/browse/EAGLE-1068
> Project: Eagle
> Issue Type: Improvement
> Components: Core::Alert Engine
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Grainier Perera
>Priority: Blocker
> Fix For: v0.5.1
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[
https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=316945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316945
]
ASF GitHub Bot logged work on EAGLE-1068:
-
Author: ASF GitHub Bot
Created on: 23/Sep/19 19:46
Start Date: 23/Sep/19 19:46
Worklog Time Spent: 10m
Work Description: haoch commented on pull request #1003: [EAGLE-1068]
Upgrade Siddhi dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327296261
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@grainier Why remove this assertion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 316945)
Time Spent: 40m (was: 0.5h)
> Upgrade siddhi dependency to v5.1.4
> ---
>
> Key: EAGLE-1068
> URL: https://issues.apache.org/jira/browse/EAGLE-1068
> Project: Eagle
> Issue Type: Improvement
> Components: Core::Alert Engine
>Affects Versions: v0.5.0
>Reporter: Hao Chen
>Assignee: Grainier Perera
>Priority: Blocker
> Fix For: v0.5.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[ https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=316944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316944 ] ASF GitHub Bot logged work on EAGLE-1068: - Author: ASF GitHub Bot Created on: 23/Sep/19 19:42 Start Date: 23/Sep/19 19:42 Worklog Time Spent: 10m Work Description: haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-534253270 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316944) Time Spent: 0.5h (was: 20m) > Upgrade siddhi dependency to v5.1.4 > --- > > Key: EAGLE-1068 > URL: https://issues.apache.org/jira/browse/EAGLE-1068 > Project: Eagle > Issue Type: Improvement > Components: Core::Alert Engine >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Grainier Perera >Priority: Blocker > Fix For: v0.5.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[ https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=312571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312571 ] ASF GitHub Bot logged work on EAGLE-1068: - Author: ASF GitHub Bot Created on: 14/Sep/19 17:12 Start Date: 14/Sep/19 17:12 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-531496811 looking at this PR, all siddhi extension code upgrade looks right, @haoch can u pls help review this PR as well since you have more insights into siddhi's execution engine. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312571) Time Spent: 20m (was: 10m) > Upgrade siddhi dependency to v5.1.4 > --- > > Key: EAGLE-1068 > URL: https://issues.apache.org/jira/browse/EAGLE-1068 > Project: Eagle > Issue Type: Improvement > Components: Core::Alert Engine >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Grainier Perera >Priority: Blocker > Fix For: v0.5.1 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (EAGLE-1068) Upgrade siddhi dependency to v5.1.4
[ https://issues.apache.org/jira/browse/EAGLE-1068?focusedWorklogId=312082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312082 ] ASF GitHub Bot logged work on EAGLE-1068: - Author: ASF GitHub Bot Created on: 13/Sep/19 14:36 Start Date: 13/Sep/19 14:36 Worklog Time Spent: 10m Work Description: grainier commented on pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003 ## Purpose Purpose of this pull request is to upgrade the [Siddhi](https://mvnrepository.com/artifact/io.siddhi) dependency version to `v5.1.4`. With this, it'll also; - Fix `alert-core` and tests to support new Siddhi APIs. - Fix existing custom Siddhi extensions to support new Siddhi APIs. - Improve extension loading (use annotation support instead of `siddhiext`). - Add the following dependencies (since they are now separated from Siddhi core); ```xml io.siddhi.extension.execution.regex siddhi-execution-regex 5.0.5 io.siddhi.extension.execution.string siddhi-execution-string 5.0.5 ``` ## Remarks - Fixes https://issues.apache.org/jira/browse/EAGLE-1068 - https://issues.apache.org/jira/browse/EAGLE-1065 --- Contribution Tasks: - [x] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312082) Remaining Estimate: 0h Time Spent: 10m > Upgrade siddhi dependency to v5.1.4 > --- > > Key: EAGLE-1068 > URL: https://issues.apache.org/jira/browse/EAGLE-1068 > Project: Eagle > Issue Type: Improvement > Components: Core::Alert Engine >Affects Versions: v0.5.0 >Reporter: Hao Chen >Assignee: Grainier Perera >Priority: Blocker > Fix For: v0.5.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
