[GitHub] incubator-eagle issue #699: [MINOR] Add makeSSS and makeSRS in RouteSpec
Github user r7raul1984 commented on the issue: https://github.com/apache/incubator-eagle/pull/699 This refactor has the following advantages: - Reuseability Other object which have RouteSpec instance can reuse the makeSSS and makeSRS logic. - Readability I think the logic is domain logic. So the logic that should be in a domain object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #693: [EAGLE-804] make interface StreamContext ...
GitHub user r7raul1984 opened a pull request: https://github.com/apache/incubator-eagle/pull/693 [EAGLE-804] make interface StreamContext more abstract - Add interface StreamCounter to abstract count https://issues.apache.org/jira/browse/EAGLE-804 You can merge this pull request into a Git repository by running: $ git pull https://github.com/r7raul1984/incubator-eagle EAGLE-804 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/693.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #693 commit d05d9654946646441dda6f0783953ee1ee7f8c14 Author: r7raul1984 <tangji...@yhd.com> Date: 2016-11-28T07:47:43Z [EAGLE-804] make interface StreamContext more abstract - Add interface StreamCounter to abstract count https://issues.apache.org/jira/browse/EAGLE-804 commit e61517f9eb53aec0318cf571156e301be4ab8a53 Author: r7raul1984 <tangji...@yhd.com> Date: 2016-11-28T07:52:47Z Clean up import. commit fe160cdd0ca2b1a3906bee9b6111262523ab58b2 Author: r7raul1984 <tangji...@yhd.com> Date: 2016-11-29T02:02:26Z Reslove confilct problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #690: [EAGLE-804] make interface StreamContext ...
Github user r7raul1984 closed the pull request at: https://github.com/apache/incubator-eagle/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #684: [EAGLE-800] Use InterProcessMutex to sync...
Github user r7raul1984 commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/684#discussion_r89582088
--- Diff:
eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/jobrecover/RunningJobManager.java
---
@@ -49,12 +52,14 @@ private CuratorFramework newCurator(String zkQuorum,
int zkSessionTimeoutMs, int
);
}
-public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int
zkRetryTimes, int zkRetryInterval, String zkRoot) {
+public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int
zkRetryTimes, int zkRetryInterval, String zkRoot, String lockPath) {
this.zkRoot = zkRoot;
+curator = newCurator(zkQuorum, zkSessionTimeoutMs, zkRetryTimes,
zkRetryInterval);
+curator.start();
--- End diff --
In the future,we should follow
http://stackoverflow.com/questions/20384869/when-curatorframeworks-methods-start-and-close-shoud-be-called
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #668: [EAGLE-786] Add unit test for eagle-jpm-m...
GitHub user r7raul1984 opened a pull request: https://github.com/apache/incubator-eagle/pull/668 [EAGLE-786] Add unit test for eagle-jpm-mr-running's MRRunningJobFetc⦠- Add unit test for eagle-jpm-mr-running's MRRunningJobFetchSpout https://issues.apache.org/jira/browse/EAGLE-786 You can merge this pull request into a Git repository by running: $ git pull https://github.com/r7raul1984/incubator-eagle EAGLE-786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #668 commit 52ec975fa89199408abb01eacfc7ca2499d371eb Author: r7raul1984 <tangji...@yhd.com> Date: 2016-11-18T07:28:38Z [EAGLE-786] Add unit test for eagle-jpm-mr-running's MRRunningJobFetchSpout - Add unit test for eagle-jpm-mr-running's MRRunningJobFetchSpout https://issues.apache.org/jira/browse/EAGLE-786 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #663: [EAGLE-783] Add unit test for eagle-jpm-u...
GitHub user r7raul1984 opened a pull request: https://github.com/apache/incubator-eagle/pull/663 [EAGLE-783] Add unit test for eagle-jpm-util. - Add unit test for eagle-jpm-util. https://issues.apache.org/jira/browse/EAGLE-783 You can merge this pull request into a Git repository by running: $ git pull https://github.com/r7raul1984/incubator-eagle EAGLE-783 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/663.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #663 commit 56ee763db684c9c75e3d722bd5693ca0f08b62bb Author: r7raul1984 <tangji...@yhd.com> Date: 2016-11-17T07:03:04Z [EAGLE-783] Add unit test for eagle-jpm-util. - Add unit test for eagle-jpm-util. https://issues.apache.org/jira/browse/EAGLE-783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
