[jira] [Commented] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082053#comment-17082053 ] Awasum Yannick commented on FINERACT-775: - Thanks for looking into this and for trying to resolve it [~vorburger]. > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-809) Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11)
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-809. Resolution: Fixed > Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11) > --- > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081895#comment-17081895 ] Michael Vorburger commented on FINERACT-775: [~awasum] re. ^^^ watch INFRA-20111. > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-809) Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11)
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081891#comment-17081891 ] Michael Vorburger commented on FINERACT-809: I've moved this issue from a sub-task under FINERACT-846 to a standalone Improvement to decouple it, and created FINERACT-884 for future re-upgrade. > Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11) > --- > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-884) Upgrade rest-assured to latest version (later than 3.3.0. from Spring Boot BOM), which requires Java 11/9+
Michael Vorburger created FINERACT-884: -- Summary: Upgrade rest-assured to latest version (later than 3.3.0. from Spring Boot BOM), which requires Java 11/9+ Key: FINERACT-884 URL: https://issues.apache.org/jira/browse/FINERACT-884 Project: Apache Fineract Issue Type: Improvement Reporter: Michael Vorburger This is a follow-up to FINERACT-809 to upgrade rest-assured again, after FINERACT-846. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-809) Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11)
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-809: --- Summary: Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11) (was: Upgrade rest-assured to latest spring boot compatible version) > Upgrade rest-assured to version 3.3.0 (not later, due to Java 8/11) > --- > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-809) Upgrade rest-assured to latest spring boot compatible version
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-809: -- Assignee: Michael Vorburger (was: Yemdjih Kaze Nasser) > Upgrade rest-assured to latest spring boot compatible version > - > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-809) Upgrade rest-assured to latest spring boot compatible version
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-809: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Upgrade rest-assured to latest spring boot compatible version > - > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-809) Upgrade rest-assured to latest spring boot compatible version
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-809: --- Parent: (was: FINERACT-846) Issue Type: Improvement (was: Sub-task) > Upgrade rest-assured to latest spring boot compatible version > - > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Priority: Major > Fix For: 1.5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-809) Upgrade rest-assured to latest spring boot compatible version
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-809: -- Assignee: Yemdjih Kaze Nasser > Upgrade rest-assured to latest spring boot compatible version > - > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Assignee: Yemdjih Kaze Nasser >Priority: Major > Fix For: 1.4.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-826) org.apache.fineract.infrastructure.core.service.DateUtils has un-used line, and should use java.time instead of Joda API
[
https://issues.apache.org/jira/browse/FINERACT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-826:
--
Assignee: Michael Vorburger (was: Percy Ashu)
> org.apache.fineract.infrastructure.core.service.DateUtils has un-used line,
> and should use java.time instead of Joda API
> -
>
> Key: FINERACT-826
> URL: https://issues.apache.org/jira/browse/FINERACT-826
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [http://mail-archives.apache.org/mod_mbox/fineract-dev/201907.mbox/%3ccalix4ib1d32zskzn87kureosbwscjmo9dhgnoqbwydyui-c...@mail.gmail.com%3e,]
> and the original previous and the follow up replies on that thread Subject
> "Questions about my approach to find problems with tenant time zones, and
> about the instance values of SQL migration files.", related to FINERACT-723?
> I think, point out that
> {{org.apache.fineract.infrastructure.core.service.DateUtils}} could do with a
> closer look and fixes, specifically:
> {quote}That DateUtils class is interesting.. do we really need to mix the old
> java.util.Date API and the org.joda.time Time API ? FYI Joda Time has been
> integrated into Java 8 as java.time. So if someone was up for taking up work
> related to cleaning that up, that could be useful IMHO (so converge
> everything to java.time, and eventually remove the Joda dependency, and
> introduce an enforced check via Checkstle or SpotBugs to forbid
> java.util.Date).
>
> The null management in DateUtils is pretty interesting as well. So is this
> per tenant TZ guaranteed to always be in the DB? What does the DB schema say
> - required, never NULL? Does the Java code ensure it's never null? I'm asking
> these questions because something like that getLocalDateTimeOfTenant(),
> despite its name, seems to be actually be written to EITHER give us a "local"
> time based on the tenant, or, if that's null, it just falls back to what l
> suspect (not verified) is dependent on the OS / JVM TZ - that's scary.
> Perhaps it's not a problem in reality, if every tenant is guaranteed to
> always have a TZ, but if someone could double check this, and if so remove
> those null check and system dependent fallbacks, then IMHO that would make
> that utility code clearer.
>
> BTW line 45 in DateUtils seems completely useless, agreed? Would you like to
> raise a PR proposing to ditch that?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-826) org.apache.fineract.infrastructure.core.service.DateUtils has un-used line, and should use java.time instead of Joda API
[
https://issues.apache.org/jira/browse/FINERACT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-826:
---
Fix Version/s: 1.4.0
> org.apache.fineract.infrastructure.core.service.DateUtils has un-used line,
> and should use java.time instead of Joda API
> -
>
> Key: FINERACT-826
> URL: https://issues.apache.org/jira/browse/FINERACT-826
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [http://mail-archives.apache.org/mod_mbox/fineract-dev/201907.mbox/%3ccalix4ib1d32zskzn87kureosbwscjmo9dhgnoqbwydyui-c...@mail.gmail.com%3e,]
> and the original previous and the follow up replies on that thread Subject
> "Questions about my approach to find problems with tenant time zones, and
> about the instance values of SQL migration files.", related to FINERACT-723?
> I think, point out that
> {{org.apache.fineract.infrastructure.core.service.DateUtils}} could do with a
> closer look and fixes, specifically:
> {quote}That DateUtils class is interesting.. do we really need to mix the old
> java.util.Date API and the org.joda.time Time API ? FYI Joda Time has been
> integrated into Java 8 as java.time. So if someone was up for taking up work
> related to cleaning that up, that could be useful IMHO (so converge
> everything to java.time, and eventually remove the Joda dependency, and
> introduce an enforced check via Checkstle or SpotBugs to forbid
> java.util.Date).
>
> The null management in DateUtils is pretty interesting as well. So is this
> per tenant TZ guaranteed to always be in the DB? What does the DB schema say
> - required, never NULL? Does the Java code ensure it's never null? I'm asking
> these questions because something like that getLocalDateTimeOfTenant(),
> despite its name, seems to be actually be written to EITHER give us a "local"
> time based on the tenant, or, if that's null, it just falls back to what l
> suspect (not verified) is dependent on the OS / JVM TZ - that's scary.
> Perhaps it's not a problem in reality, if every tenant is guaranteed to
> always have a TZ, but if someone could double check this, and if so remove
> those null check and system dependent fallbacks, then IMHO that would make
> that utility code clearer.
>
> BTW line 45 in DateUtils seems completely useless, agreed? Would you like to
> raise a PR proposing to ditch that?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-809) Upgrade rest-assured to latest spring boot compatible version
[ https://issues.apache.org/jira/browse/FINERACT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081880#comment-17081880 ] Awasum Yannick commented on FINERACT-809: - See comment here by [~xurror]: [https://github.com/apache/fineract/pull/719#issuecomment-612654106|https://github.com/apache/fineract/pull/719#issuecomment-612654106,] > Upgrade rest-assured to latest spring boot compatible version > - > > Key: FINERACT-809 > URL: https://issues.apache.org/jira/browse/FINERACT-809 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.3.0 >Reporter: Awasum Yannick >Priority: Major > Fix For: 1.5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Upgrade rest-assured to latest spring boot (spring BOM) compatible version. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-248) Two or more SMS Campaigns should not have the same Name.
[ https://issues.apache.org/jira/browse/FINERACT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-248: Description: When we create new SMS campaign and if we give same name of existing SMS campaign, it accepts the name. SMS Campaigns should not accept the same name. (was: When we create new SMS campaign and if we give same name of existing SMS campaign, it accepts the name. ) > Two or more SMS Campaigns should not have the same Name. > - > > Key: FINERACT-248 > URL: https://issues.apache.org/jira/browse/FINERACT-248 > Project: Apache Fineract > Issue Type: Bug > Components: Organization > Environment: Creating SMS campaign >Reporter: Santosh Math >Priority: Minor > Labels: 2019-mifos-gsoc, Volunteer, beginner, gsoc, p2, starter, > technical > Fix For: 1.5.0 > > > When we create new SMS campaign and if we give same name of existing SMS > campaign, it accepts the name. SMS Campaigns should not accept the same name. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-248) Two or more SMS Campaigns should not have the same Name.
[ https://issues.apache.org/jira/browse/FINERACT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-248: Labels: 2019-mifos-gsoc Volunteer beginner gsoc p2 starter technical (was: 2019-mifos-gsoc Volunteer gsoc p2) > Two or more SMS Campaigns should not have the same Name. > - > > Key: FINERACT-248 > URL: https://issues.apache.org/jira/browse/FINERACT-248 > Project: Apache Fineract > Issue Type: Bug > Components: Organization > Environment: Creating SMS campaign >Reporter: Santosh Math >Priority: Minor > Labels: 2019-mifos-gsoc, Volunteer, beginner, gsoc, p2, starter, > technical > Fix For: 1.5.0 > > > When we create new SMS campaign and if we give same name of existing SMS > campaign, it accepts the name. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-248) Two or more SMS Campaigns should not have the same Name.
[ https://issues.apache.org/jira/browse/FINERACT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-248: Summary: Two or more SMS Campaigns should not have the same Name. (was: SMS Campaign- Two or more than two SMS campaigns can accept same name. ) > Two or more SMS Campaigns should not have the same Name. > - > > Key: FINERACT-248 > URL: https://issues.apache.org/jira/browse/FINERACT-248 > Project: Apache Fineract > Issue Type: Bug > Components: Organization > Environment: Creating SMS campaign >Reporter: Santosh Math >Priority: Minor > Labels: 2019-mifos-gsoc, Volunteer, gsoc, p2 > Fix For: 1.5.0 > > > When we create new SMS campaign and if we give same name of existing SMS > campaign, it accepts the name. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-826) org.apache.fineract.infrastructure.core.service.DateUtils has un-used line, and should use java.time instead of Joda API
[
https://issues.apache.org/jira/browse/FINERACT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Percy Ashu reassigned FINERACT-826:
---
Assignee: Percy Ashu
> org.apache.fineract.infrastructure.core.service.DateUtils has un-used line,
> and should use java.time instead of Joda API
> -
>
> Key: FINERACT-826
> URL: https://issues.apache.org/jira/browse/FINERACT-826
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [http://mail-archives.apache.org/mod_mbox/fineract-dev/201907.mbox/%3ccalix4ib1d32zskzn87kureosbwscjmo9dhgnoqbwydyui-c...@mail.gmail.com%3e,]
> and the original previous and the follow up replies on that thread Subject
> "Questions about my approach to find problems with tenant time zones, and
> about the instance values of SQL migration files.", related to FINERACT-723?
> I think, point out that
> {{org.apache.fineract.infrastructure.core.service.DateUtils}} could do with a
> closer look and fixes, specifically:
> {quote}That DateUtils class is interesting.. do we really need to mix the old
> java.util.Date API and the org.joda.time Time API ? FYI Joda Time has been
> integrated into Java 8 as java.time. So if someone was up for taking up work
> related to cleaning that up, that could be useful IMHO (so converge
> everything to java.time, and eventually remove the Joda dependency, and
> introduce an enforced check via Checkstle or SpotBugs to forbid
> java.util.Date).
>
> The null management in DateUtils is pretty interesting as well. So is this
> per tenant TZ guaranteed to always be in the DB? What does the DB schema say
> - required, never NULL? Does the Java code ensure it's never null? I'm asking
> these questions because something like that getLocalDateTimeOfTenant(),
> despite its name, seems to be actually be written to EITHER give us a "local"
> time based on the tenant, or, if that's null, it just falls back to what l
> suspect (not verified) is dependent on the OS / JVM TZ - that's scary.
> Perhaps it's not a problem in reality, if every tenant is guaranteed to
> always have a TZ, but if someone could double check this, and if so remove
> those null check and system dependent fallbacks, then IMHO that would make
> that utility code clearer.
>
> BTW line 45 in DateUtils seems completely useless, agreed? Would you like to
> raise a PR proposing to ditch that?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-254) Add the Ability to Customize the Password Email Notice
[ https://issues.apache.org/jira/browse/FINERACT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-254: Summary: Add the Ability to Customize the Password Email Notice (was: Password Email Notice) > Add the Ability to Customize the Password Email Notice > -- > > Key: FINERACT-254 > URL: https://issues.apache.org/jira/browse/FINERACT-254 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Dayna Harp >Priority: Major > Labels: Volunteer, gsoc, p2 > Fix For: 1.5.0 > > > While requesting documentation be written to describe how an organization can > customize the outgoing message to the user that provides their password, it > was discovered that this is hard coded. > https://mifosforge.jira.com/browse/MXD-107 > The expected result is that an organization can enter their own subject line, > and edit the message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-268) Modification of role name and its decription
[ https://issues.apache.org/jira/browse/FINERACT-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-268: Labels: beginner features starter technical (was: features) > Modification of role name and its decription > > > Key: FINERACT-268 > URL: https://issues.apache.org/jira/browse/FINERACT-268 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Reporter: Mexina Daniel >Priority: Minor > Labels: beginner, features, starter, technical > > Modification of role name and its description is needed especially when it > happens you misspell the role name and already assigned the permissions > Right now we can only edit the role permissions, this feature in Fineract can > reduce the tiresome work of starting to create new role and assign the > permissions again. > You can reproduce by navigate Admin -> System -> "Manage Roles and > Permissions" -> View role -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081816#comment-17081816 ] Awasum Yannick commented on FINERACT-775: - Thanks [~vorburger]. I have access to that. We should maybe remove this limitation where each time we need to add people as contributors before they can be assigned issues. Is there a real advantage to having this rule in place? To me anyone who is logged in to Jira here should be able to assign and unassign themselves from issues. CC [~myrle], [~edcable]. We may need to request this change from Infra, I suppose? Is there any drawback to doing this? > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-762) Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) is sub-optimal for performance
[ https://issues.apache.org/jira/browse/FINERACT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-762: --- Issue Type: Improvement (was: Bug) > Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) > is sub-optimal for performance > > > Key: FINERACT-762 > URL: https://issues.apache.org/jira/browse/FINERACT-762 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Labels: performance, technical > > Creating this issue to clarify that while FINERACT-761 is focused on (only) > the build time use of the Drizzle JDBC driver (which does not lead to it > being included in the final Fineract end-user distribution), this is re. the > use of it at run-time, which is packaged in the distribution. > The two uses are technically unrelated. While the use of Drizzle instead of > Connector/J in the build is a a blocking issue, the use at run-time is not a > blocking problem, currently. It's perhaps still not ideal to maintain on a > completely unmaintained library (Drizzle) for database access, e.g. for > performance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081800#comment-17081800 ] Michael Vorburger commented on FINERACT-775: Closing. PS: [~Percy Ashu] I noticed that you could not assign issues to yourself, and I've just fixed that ([~awasum] we need to add people to the Contributors role on [https://issues.apache.org/jira/plugins/servlet/project-config/FINERACT/roles;] email me if you do not have access to that). > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-775: -- Assignee: Percy Ashu > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-775. Resolution: Fixed > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-875) Remove master branch from Fineract git repo
[ https://issues.apache.org/jira/browse/FINERACT-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081798#comment-17081798 ] Michael Vorburger commented on FINERACT-875: [~awasum] it's a "protected branch" on GitHub, we need to figure out where on ASF Infra that is configured... I've just raised INFRA-20110. > Remove master branch from Fineract git repo > --- > > Key: FINERACT-875 > URL: https://issues.apache.org/jira/browse/FINERACT-875 > Project: Apache Fineract > Issue Type: Wish >Reporter: Michael Vorburger >Priority: Major > > Apache Fineract's git repo currently has both a master and a develop branch. > De facto we only maintain the develop branch, and master hasn't been touched > in 4 years (last commit is 5903a851f4851ed9bf87cdec7c3e52394304141a). > How about, just to reduce future confusion, we simply delete the master > branch? > It's a protected branch on GitHub, we need to figure out where on ASF Infra > that is configured, and propose to change it. > If that's impossible, I guess we could also forget about develop and have > only master. > https://github.com/apache/fineract/commits/develop > https://github.com/apache/fineract/commits/master -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-748) Fixing typos in SPM API
[ https://issues.apache.org/jira/browse/FINERACT-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-748: Labels: beginner starter technical (was: ) > Fixing typos in SPM API > --- > > Key: FINERACT-748 > URL: https://issues.apache.org/jira/browse/FINERACT-748 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Apoorva M K >Priority: Trivial > Labels: beginner, starter, technical > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-749) Client family member date of birth min value set to current year
[ https://issues.apache.org/jira/browse/FINERACT-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081789#comment-17081789 ] Awasum Yannick commented on FINERACT-749: - This seems to be a UI issue. Maybe we close this here as we only track backend Fineract issues here. > Client family member date of birth min value set to current year > > > Key: FINERACT-749 > URL: https://issues.apache.org/jira/browse/FINERACT-749 > Project: Apache Fineract > Issue Type: Bug > Components: Client >Affects Versions: 1.3.1 >Reporter: Sidhant Gupta >Priority: Major > Labels: GCI-2019, beginner, starter > Fix For: 1.5.0 > > > The date of birth value for client family member cannot be set to less than > the first date of the current year. It can be fixed by modifying the input > tag's `min` attribute. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081786#comment-17081786 ] Awasum Yannick commented on FINERACT-775: - There is a PR referencing this issue which has been merged here: [https://github.com/apache/fineract/pull/707] does that completely solve this issue? If so we should close this. [~vorburger], [~Percy Ayuk], > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-775: Fix Version/s: 1.4.0 > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: beginner, starter, technical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-775) Clean up Util in src/test vs src/integrationTest
[ https://issues.apache.org/jira/browse/FINERACT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-775: Labels: beginner starter technical (was: ) > Clean up Util in src/test vs src/integrationTest > > > Key: FINERACT-775 > URL: https://issues.apache.org/jira/browse/FINERACT-775 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: beginner, starter, technical > Time Spent: 20m > Remaining Estimate: 0h > > ./fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java > VS ./fineract-provider/src/test/java/org/apache/fineract/common/Utils.java > is confusing, because some, but not all, of it is copy/paste duplicated. > We need to clean this up and have no duplicated code between these two > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-519) Ability to delete an employee
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081785#comment-17081785 ] Awasum Yannick commented on FINERACT-519: - We should have a disable or deactivate button instead of delete. Finance data is sensitive and should never be deleted even if for a non actual financial case like this. What do you think? > Ability to delete an employee > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Priority: Major > Labels: beginner, functional, gsoc, p2, starter > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-883) Expose Fineract build's Git revision on /actuator/info HTTP API endpoint
Michael Vorburger created FINERACT-883: -- Summary: Expose Fineract build's Git revision on /actuator/info HTTP API endpoint Key: FINERACT-883 URL: https://issues.apache.org/jira/browse/FINERACT-883 Project: Apache Fineract Issue Type: New Feature Reporter: Michael Vorburger It can be useful to be able to know what exact build of Fineract is running on a given server. This can be achieved by automatically including Git revision etc. details in a properties file during build time, and then exposing that information on an HTTP API endpoint. Spring Boot's "Production-ready Features" (formerly known as its Actuator), provides this more or less out of the box; the goal of this issue is to (a) add the required Gradle plugin to the build, (b) do whatever is required so that /actuator/info includes Git details (may be it "just works" out of the box...), and add a few lines of integration test for this. Background: * [https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-features.html#production-ready-application-info] * [https://rieckpil.de/howto-expose-git-information-with-spring-boots-actuator/] * [https://medium.com/@d.lopez.j/springboot-maven-jenkins-git-how-to-identify-your-release-automagically-13261ece13f] * [https://www.baeldung.com/spring-git-information] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-519) Ability to delete an employee
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-519: Labels: beginner functional gsoc p2 starter (was: gsoc p2) > Ability to delete an employee > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Priority: Major > Labels: beginner, functional, gsoc, p2, starter > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-490) Loans & Savings Summary data
[ https://issues.apache.org/jira/browse/FINERACT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081772#comment-17081772 ] Michael Vorburger commented on FINERACT-490: This used to be a sub-task under FINERACT-488, but I've turned it into a standalone bug (and closed FINERACT-488). > Loans & Savings Summary data > - > > Key: FINERACT-490 > URL: https://issues.apache.org/jira/browse/FINERACT-490 > Project: Apache Fineract > Issue Type: Bug >Reporter: Nazeer Shaik >Priority: Major > > Loans: > • # of missed payments = ( unknown ) > • Days in Arrears = ( unknown ) > • Amount due ( as of dd/mm/yy) = ( unknown ) > Savings: > • # of deposits = ( unknown ) > • Amount as collateral = ( unknown ) > • Savings Goal % = (unknown) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-488) Fineract support for GSOC tasks
[ https://issues.apache.org/jira/browse/FINERACT-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-488: --- Fix Version/s: 1.1.0 > Fineract support for GSOC tasks > --- > > Key: FINERACT-488 > URL: https://issues.apache.org/jira/browse/FINERACT-488 > Project: Apache Fineract > Issue Type: Task >Reporter: Nazeer Shaik >Assignee: Nazeer Shaik >Priority: Major > Fix For: 1.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-488) Fineract support for GSOC tasks
[ https://issues.apache.org/jira/browse/FINERACT-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger closed FINERACT-488. -- Resolution: Auto Closed > Fineract support for GSOC tasks > --- > > Key: FINERACT-488 > URL: https://issues.apache.org/jira/browse/FINERACT-488 > Project: Apache Fineract > Issue Type: Task >Reporter: Nazeer Shaik >Assignee: Nazeer Shaik >Priority: Major > Fix For: 1.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-490) Loans & Savings Summary data
[ https://issues.apache.org/jira/browse/FINERACT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-490: -- Assignee: (was: Nazeer Shaik) > Loans & Savings Summary data > - > > Key: FINERACT-490 > URL: https://issues.apache.org/jira/browse/FINERACT-490 > Project: Apache Fineract > Issue Type: Bug >Reporter: Nazeer Shaik >Priority: Major > > Loans: > • # of missed payments = ( unknown ) > • Days in Arrears = ( unknown ) > • Amount due ( as of dd/mm/yy) = ( unknown ) > Savings: > • # of deposits = ( unknown ) > • Amount as collateral = ( unknown ) > • Savings Goal % = (unknown) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-490) Loans & Savings Summary data
[ https://issues.apache.org/jira/browse/FINERACT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-490: --- Parent: (was: FINERACT-488) Issue Type: Bug (was: Sub-task) > Loans & Savings Summary data > - > > Key: FINERACT-490 > URL: https://issues.apache.org/jira/browse/FINERACT-490 > Project: Apache Fineract > Issue Type: Bug >Reporter: Nazeer Shaik >Assignee: Nazeer Shaik >Priority: Major > > Loans: > • # of missed payments = ( unknown ) > • Days in Arrears = ( unknown ) > • Amount due ( as of dd/mm/yy) = ( unknown ) > Savings: > • # of deposits = ( unknown ) > • Amount as collateral = ( unknown ) > • Savings Goal % = (unknown) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-36) User defined Templates do not work when Tomcat is behind a proxy
[ https://issues.apache.org/jira/browse/FINERACT-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-36: -- Labels: p3 technical (was: p3) > User defined Templates do not work when Tomcat is behind a proxy > > > Key: FINERACT-36 > URL: https://issues.apache.org/jira/browse/FINERACT-36 > Project: Apache Fineract > Issue Type: Bug > Components: System > Environment: Linux, Nginx that proxy passes to Tomcat, OpenJDK7 >Reporter: James Rowe >Priority: Major > Labels: p3, technical > > Related to https://mifosforge.jira.com/browse/MIFOSX-2322 This issue was > raised by our client and the fix provided did not actually resolve the root > issue. As mentioned in the Environment section, our server is a multitenant > server and has Nginx set up to proxy requests to Tomcat. Because of this > setup though, User defined templates do not work. Looking through the code > (https://github.com/openMF/mifosx/blob/develop/fineract-provider/src/main/java/org/apache/fineract/template/service/TemplateMergeService.java) > I have found out that the TemplateMergeService uses the HTTP API to return > the results for the templates. The issue is it tries to connect to the wrong > port and with the wrong tenant. The tomcat server is running on port 8008 and > 8443 and the template merge service attempts to connect on port 80/433. Nginx > will receive the request and ignore them because of how my routing rules are > set up. Our server is setup to give a subdomain to each tenant and nginx uses > this subdomain name to set the Fineract-Platform-Id header on the request. > Because the API tries to connect on localhost (without any subdomain), the > requests made from the API to the API fail to connect. It doesn't really > matter in the end, since the service grabs the wrong tenant information. I'm > not sure where it gets the tenant identifier from, but it chose "default" as > the tenant when it should have used the name of our client instead. (As a > precaution, our default tenant is a completely empty tenant) > In summary, the TemplateMergeService attempts to make calls to the API, but > fails to ascertain the correct settings to connect to the API. It fails to > choose the correct tenant identifier (uses default, when that is not > correct), connects on the wrong port (80 instead of 8008), and doesn't use > the right server name for the port it connects to. The last two issues are > very related as a proper fix would be to either change the port or change the > server name. I hope this is enough information to write a fix, but if you > need any more information let me know. I'll be glad to help however I can. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-830) Use distroless base image instead of bitnami/tomcat in container
[ https://issues.apache.org/jira/browse/FINERACT-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-830: --- Labels: kubernetes (was: ) > Use distroless base image instead of bitnami/tomcat in container > > > Key: FINERACT-830 > URL: https://issues.apache.org/jira/browse/FINERACT-830 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Labels: kubernetes > > Rohit Verma on the mailing list raised using a "more hardened base image like > distroless". > I'll admit that I'm personally not a huge fan of "FROM bitnami/tomcat:7.0.94" > myself! Any contributions you'd like to make on this front would be very very > welcome, from my side. > https://github.com/GoogleContainerTools/distroless is a great alternative. > (BTW > https://access.redhat.com/containers/?tab=images#/registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift > is a another great choice, if you're into something supported.) > Your mission, should you choose to accept it and work on this issue, would be > to raise a PR modifying our Dockerfile, but then still have the related test > at the end of .travis.yml pass - everything (container, Docker Compose, > Kubernetes) should, obviously, still "work as is", even if you go for > changing the base image. Makes sense and sounds fair? > > PS: What we really should do at some point is move away from 1990s style > WAR-in-Tomcat, and make java -jar fineract.war work instead (and then use > that in the container)... people working on this could also contribute, > before or after, to FINERACT-730. (On a related front, there's also > FINERACT-764, but both are probably independent enough from each other to be > tackled separately.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-858) Errors (JobExecutionException) in Cron Jobs loose exception rot cause details
[
https://issues.apache.org/jira/browse/FINERACT-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger resolved FINERACT-858.
Resolution: Fixed
> Errors (JobExecutionException) in Cron Jobs loose exception rot cause details
> -
>
> Key: FINERACT-858
> URL: https://issues.apache.org/jira/browse/FINERACT-858
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The way that the {{@CronTarget}} annotated cron job methods {{catch
> (Exception e)}} and then do {{throws JobExecutionException}} looses the root
> cause(s). This makes fully understanding and debugging e.g. (one of) the
> problem shown in FINERACT-857, for a solution like FINERACT-859, more
> difficult.
> I'll try to fix this in this issue (just the error logging, not the actual
> problem).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-860) java.util.NoSuchElementException: No value present at java.util.Optional.get(Optional.java:135) at org.apache.fineract.interoperation.service.InteropServiceImpl.findId
[
https://issues.apache.org/jira/browse/FINERACT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger resolved FINERACT-860.
Resolution: Fixed
> java.util.NoSuchElementException: No value present at
> java.util.Optional.get(Optional.java:135) at
> org.apache.fineract.interoperation.service.InteropServiceImpl.findIdentifier(InteropServiceImpl.java:453)
>
>
> Key: FINERACT-860
> URL: https://issues.apache.org/jira/browse/FINERACT-860
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The integration test logs (e.g. in FINERACT-857) sometimes show:
> {noformat}
> 3:56:44.508 [http-bio-8443-exec-37] ERROR o.s.b.w.s.support.ErrorPageFilter -
> Forwarding to error page from request
> [/api/v1/interoperation/parties/MSISDN/bc45cf3c-1e17-41a7-83d8-9ee80ebbb806]
> due to exception [No value present]
> java.util.NoSuchElementException: No value present
> at java.util.Optional.get(Optional.java:135)
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl.findIdentifier(InteropServiceImpl.java:453)
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl.getAccountByIdentifier(InteropServiceImpl.java:180){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-877) Release Apache Fineract v1.3.1
[ https://issues.apache.org/jira/browse/FINERACT-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081767#comment-17081767 ] Michael Vorburger commented on FINERACT-877: [~vishwasbabu] OK, I see. So what we really should be doing then is to "properly" release 1.3.1, huh? :P I'll rename this from "Clarify Fineract Version 1.3.1" to "Release Apache Fineract v1.3.1" and we'll see if someone wants to do this. > Release Apache Fineract v1.3.1 > -- > > Key: FINERACT-877 > URL: https://issues.apache.org/jira/browse/FINERACT-877 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > > In JIRA, there is a 1.3.1 version, but it was never released. > I doubt a 1.3.1 will be released (anyone?) - if anything, a 1.4.0, see > FINERACT-873. > There were 3 issues marked Fixed Version 1.3.1 today: FINERACT-755, and > FINERACT-848 & FINERACT-832. The latter two have no PRs and so certainly > never were for 1.3.1, the Report must have just not known which Fix Version > to set; so I've just removed 1.3.1 from those two. > The FINERACT-755 is more interesting - I don't fully understand yet is that > is also in develop, or not. > Shall we delete the 1.3.1 version in JIRA? And in git, after clarifying > FINERACT-755 ? > [~vishwasbabu] [~angelboxes] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-877) Release Apache Fineract v1.3.1
[ https://issues.apache.org/jira/browse/FINERACT-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-877: --- Summary: Release Apache Fineract v1.3.1 (was: Clarify Fineract Version 1.3.1) > Release Apache Fineract v1.3.1 > -- > > Key: FINERACT-877 > URL: https://issues.apache.org/jira/browse/FINERACT-877 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > > In JIRA, there is a 1.3.1 version, but it was never released. > I doubt a 1.3.1 will be released (anyone?) - if anything, a 1.4.0, see > FINERACT-873. > There were 3 issues marked Fixed Version 1.3.1 today: FINERACT-755, and > FINERACT-848 & FINERACT-832. The latter two have no PRs and so certainly > never were for 1.3.1, the Report must have just not known which Fix Version > to set; so I've just removed 1.3.1 from those two. > The FINERACT-755 is more interesting - I don't fully understand yet is that > is also in develop, or not. > Shall we delete the 1.3.1 version in JIRA? And in git, after clarifying > FINERACT-755 ? > [~vishwasbabu] [~angelboxes] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-867) Scalability & Performance Enhancements for Supporting Millions of Clients, High TPS, and Concurrent Users
[ https://issues.apache.org/jira/browse/FINERACT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081748#comment-17081748 ] Michael Vorburger commented on FINERACT-867: I agree this is somewhat vague to be directly actionable as is, but perhaps it's useful to have an umbrella issue to coordinate related work if we have e.g. a GSOC student, or other contributor, willing to pick up this important area. There was some write-up on [https://mifosforge.jira.com/wiki/spaces/RES/pages/1118175247/Google+Summer+of+Code+2020+Ideas#GoogleSummerofCode2020Ideas-Scalability,HighTPS,andConcurrentUsers]. I've found 5 earlier issue I've just linked here, contributions to all of those can be considered as progress towards this. The [Performance & Scalability page on the Wiki|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=133632146] also has some thoughts. I think other than what's already in those issues and Wiki page, what this basically boils down to is conducting real world load testing on Fineract by 1. asking on the list for scenarios, 2. script such stress testing using some REST API load simulation tool which can "hammer" Fineract, 3. optimize any SQL queries which jump out, 4. do Java level code profiling to identify bottle necks - I expect FINERACT-135 to be the first obvious candidate jumping out. > Scalability & Performance Enhancements for Supporting Millions of Clients, > High TPS, and Concurrent Users > - > > Key: FINERACT-867 > URL: https://issues.apache.org/jira/browse/FINERACT-867 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Sanyam Goel >Priority: Major > Labels: gsoc, gsoc2020, perfomance > > |*Overview & Objectives* > As Mifos X has matured as a core banking platform, it's been adopted and used > by larger institutions serving hundreds of thousands and even millions of > clients. Partners operating cloud-hosted subscription models are also > supporting hundreds of thousands of clients across their multi-tenant > installations. Most recently, more and more digital-first fintechs are using > the platforms for highly scalable wallet accounts needing hundreds and > thousands of TPS. We need to benchmark, analyze and improve the performance > and scalability of the system.| > |*Description* > Enhancements to the back-end platform will include parallelization of all the > jobs with a configurable amount of concurrency, look at the explain plans of > the queries being used in the jobs, paginate input queries for jobs, put lazy > fetching where required, node-aware scheduler and cache, office-wise > configurable jobs to distribute job-load across servers and write some tests > to prove that the concurrency will work for a decent amount of scale. > In addition, you'll provide some metrics which can help mid-sized MFIs (those > having around a million active loans) in adopting Mifos X. > | > |*Helpful Skills* > Java, Javascript, Spring, JAX-RS, JPA,| > |*Impact* > Higher outreach to the unbanked by supporting larger institutions and scaling > more rapidly.| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-698) Ability to associate a GUID with every request
[ https://issues.apache.org/jira/browse/FINERACT-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-698: --- Labels: gsoc2019 technical (was: gsoc2019) > Ability to associate a GUID with every request > -- > > Key: FINERACT-698 > URL: https://issues.apache.org/jira/browse/FINERACT-698 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Madhukar Lingala >Priority: Minor > Labels: gsoc2019, technical > Time Spent: 20m > Remaining Estimate: 0h > > 1) Ability to associate a GUID with every request. The Client is responsible > for generating and passing the GUID with every request. As far as the > platform is concerned, we assume that the GUID is unique. We do not add any > constraint checks on the database to ensure that there is no impact on > performance. > 2) New API to query on the result of a request by passing the GUID as the > parameter. > 3) If the request was successful, the API returns the same response that the > successful original API call would have returned. If the original request has > failed, the API returns a resource not found response (since errors are not > logged into the system). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-291) A Loan has to be in Overdue state before it is classified as a NPA
[ https://issues.apache.org/jira/browse/FINERACT-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-291: --- Labels: confirm functional p2 (was: confirm p2) > A Loan has to be in Overdue state before it is classified as a NPA > -- > > Key: FINERACT-291 > URL: https://issues.apache.org/jira/browse/FINERACT-291 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: Santosh Math >Priority: Minor > Labels: confirm, functional, p2 > Attachments: Loan Status.jpeg, Wrong NPA flag.png > > > Reported by Sughosh at https://mifosforge.jira.com/browse/MIFOSX-1743 > Original Description: > Steps to reproduce the issue. > Create a loan product with the following options. > Number of days a loan may be overdue before moving into arrears : 2 > Maximum number of days a loan may be overdue before becoming a NPA (non > performing asset) :1. > Disburse a loan whose first repayment date is 2 days prior to current date. > Run the NPA batch job. > The loan still does not go to overdue state, which is fine. > But, it is updated as NPA in the database. > According to the definition, the loan should go to Overdue state. > And one day after it is over due, it should be marked as NPA. > In my example, the system date is 11-Dec-2014, > First Repayment date is 09-Dec-2014. > The loan is not over due according to my product definition. > But it is NPA. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-95) Reversal of interest accrued for NPAs
[ https://issues.apache.org/jira/browse/FINERACT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-95: -- Labels: functional (was: ) > Reversal of interest accrued for NPAs > - > > Key: FINERACT-95 > URL: https://issues.apache.org/jira/browse/FINERACT-95 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Emmanuel Nnaa >Priority: Major > Labels: functional > > any income accrued on loans classified as non-performing (normally 30 days), > should be reversed using the following booking: > Dr. Interest Income > Cr. Suspended Interest > Whenever a loan that was non-performing starts repayment on time and is > therefore no longer non-performing, then the Suspended Interest should be > booked back into the Interest Income Account. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account
[ https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-38: -- Labels: functional (was: ) > Period Close feature where inc & exp booked to retained earnings account > > > Key: FINERACT-38 > URL: https://issues.apache.org/jira/browse/FINERACT-38 > Project: Apache Fineract > Issue Type: Improvement > Components: Accounting >Reporter: Dayna Harp >Priority: Major > Labels: functional > Time Spent: 40m > Remaining Estimate: 0h > > https://mifosforge.jira.com/browse/MIFOSX-2337 > Relates to: https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments > and narrative) > financial year end to be user definable and to have the full effect of > closing off the year with initialization of the profit and loss account. Year > end process should be run as/when the institution is ready to close their > books and may not necessarily happen exactly > Musoni is implementing and sharing the following: > Ability to close a financial year from an accounting perspective (booking off > income and expense accounts against your retained earnings equity account). > The high-level spec of this feature is: > * When a user performs a financial close period (existing feature) we have > added various parameters to the call that allow you to also book off the > income and expenses generated in that period. > * Once you submit this request the various balances will be pulled out and > the difference between all expenses and income accounts will be booked off > against a (specified) equity account. > * The journal entry that is generated to perform this booking will be stored > with the close period so that it can be reversed again if a close period is > reopened. > * There is a preview/template API endpoint that allows you to preview the > booking that is going to be performed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-762) Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) is sub-optimal for performance
[ https://issues.apache.org/jira/browse/FINERACT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081743#comment-17081743 ] Michael Vorburger commented on FINERACT-762: Given that we cannot distribute Fineract on [http://fineract.apache.org|http://fineract.apache.org/] with the MariaDB or MySQL JDBC driver instead of Drizzle, I think what we should do here is to create (an) alternative Docker image(s), which remove Drizzle and configure the other driver(s) instead. We could either distribute those on Apache Docker Hub, or do this outside of the Apache project, and just have a small repo with the Dockerfile on [https://github.com/openMF/] and distribute it there (similarly to https://github.com/openMF/community-app/issues/3112). > Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) > is sub-optimal for performance > > > Key: FINERACT-762 > URL: https://issues.apache.org/jira/browse/FINERACT-762 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: performance > > Creating this issue to clarify that while FINERACT-761 is focused on (only) > the build time use of the Drizzle JDBC driver (which does not lead to it > being included in the final Fineract end-user distribution), this is re. the > use of it at run-time, which is packaged in the distribution. > The two uses are technically unrelated. While the use of Drizzle instead of > Connector/J in the build is a a blocking issue, the use at run-time is not a > blocking problem, currently. It's perhaps still not ideal to maintain on a > completely unmaintained library (Drizzle) for database access, e.g. for > performance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-762) Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) is sub-optimal for performance
[ https://issues.apache.org/jira/browse/FINERACT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-762: --- Labels: performance technical (was: performance) > Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) > is sub-optimal for performance > > > Key: FINERACT-762 > URL: https://issues.apache.org/jira/browse/FINERACT-762 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: performance, technical > > Creating this issue to clarify that while FINERACT-761 is focused on (only) > the build time use of the Drizzle JDBC driver (which does not lead to it > being included in the final Fineract end-user distribution), this is re. the > use of it at run-time, which is packaged in the distribution. > The two uses are technically unrelated. While the use of Drizzle instead of > Connector/J in the build is a a blocking issue, the use at run-time is not a > blocking problem, currently. It's perhaps still not ideal to maintain on a > completely unmaintained library (Drizzle) for database access, e.g. for > performance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-762) Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) is sub-optimal for performance
[ https://issues.apache.org/jira/browse/FINERACT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-762: --- Labels: performance (was: ) > Use of (unmaintained) Drizzle JDBC driver in Fineract at run-time (not build) > is sub-optimal for performance > > > Key: FINERACT-762 > URL: https://issues.apache.org/jira/browse/FINERACT-762 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > Labels: performance > > Creating this issue to clarify that while FINERACT-761 is focused on (only) > the build time use of the Drizzle JDBC driver (which does not lead to it > being included in the final Fineract end-user distribution), this is re. the > use of it at run-time, which is packaged in the distribution. > The two uses are technically unrelated. While the use of Drizzle instead of > Connector/J in the build is a a blocking issue, the use at run-time is not a > blocking problem, currently. It's perhaps still not ideal to maintain on a > completely unmaintained library (Drizzle) for database access, e.g. for > performance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-854) Use prepared statements instead of string concatenated SQL everywhere
[
https://issues.apache.org/jira/browse/FINERACT-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-854:
---
Labels: beginner performance starer starter (was: beginner starer)
> Use prepared statements instead of string concatenated SQL everywhere
> -
>
> Key: FINERACT-854
> URL: https://issues.apache.org/jira/browse/FINERACT-854
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Major
> Labels: beginner, performance, starer, starter
>
> The Fineract code base in many places creates SQL statements through String
> concatenation. This is prone to SQL injection. This is mitigated by the use
> of helpers utilities such as
> {{org.apache.fineract.infrastructure.core.api.ApiParameterHelper.sqlEncodeString(String)}}
> and
> {{org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput(String)}}
> but I opine that those are workarounds... the better solution, both for
> security and likely also helping with performance (at least a little bit,
> knowing how much would require measuring it...), would be to use JDBC
> prepared statements with '?' placeholders and passing all raw arguments,
> instead of embedding them in the query String.
> FINERACT-808 root cause analysis brought this up, and I'm about to raise a PR
> for FINERACT-808 which makes a start; the goal of this issue is to use the
> new {{org.apache.fineract.infrastructure.security.utils.SQLBuilder}}
> everywhere, and eventually be able to get completely rid of
> {{ApiParameterHelper}} and {{SQLInjectionValidator}}.
> This issue should also include work to scan the code base for places where
> SQL Strings are concatenated without even using the existing helpers.
> FINERACT-853 could potentially help with that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-867) Scalability & Performance Enhancements for Supporting Millions of Clients, High TPS, and Concurrent Users
[ https://issues.apache.org/jira/browse/FINERACT-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-867: --- Labels: gsoc gsoc2020 perfomance (was: gsoc gsoc2020) > Scalability & Performance Enhancements for Supporting Millions of Clients, > High TPS, and Concurrent Users > - > > Key: FINERACT-867 > URL: https://issues.apache.org/jira/browse/FINERACT-867 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Sanyam Goel >Priority: Major > Labels: gsoc, gsoc2020, perfomance > > |*Overview & Objectives* > As Mifos X has matured as a core banking platform, it's been adopted and used > by larger institutions serving hundreds of thousands and even millions of > clients. Partners operating cloud-hosted subscription models are also > supporting hundreds of thousands of clients across their multi-tenant > installations. Most recently, more and more digital-first fintechs are using > the platforms for highly scalable wallet accounts needing hundreds and > thousands of TPS. We need to benchmark, analyze and improve the performance > and scalability of the system.| > |*Description* > Enhancements to the back-end platform will include parallelization of all the > jobs with a configurable amount of concurrency, look at the explain plans of > the queries being used in the jobs, paginate input queries for jobs, put lazy > fetching where required, node-aware scheduler and cache, office-wise > configurable jobs to distribute job-load across servers and write some tests > to prove that the concurrency will work for a decent amount of scale. > In addition, you'll provide some metrics which can help mid-sized MFIs (those > having around a million active loans) in adopting Mifos X. > | > |*Helpful Skills* > Java, Javascript, Spring, JAX-RS, JPA,| > |*Impact* > Higher outreach to the unbanked by supporting larger institutions and scaling > more rapidly.| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-880) Fineract Caches & Kubernetes Deployment
[ https://issues.apache.org/jira/browse/FINERACT-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081739#comment-17081739 ] Michael Vorburger commented on FINERACT-880: FINERACT-135 seems directly relevant to this, and should be considered a pre-requisite to this. > Fineract Caches & Kubernetes Deployment > --- > > Key: FINERACT-880 > URL: https://issues.apache.org/jira/browse/FINERACT-880 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Labels: kubernetes, scalability, technical > > The Kubernetes deployment contributed in FINERACT-783 by default creates a > Kubernetes Deployment with a single Pod (based on Fineract's Docker Compose > set-up). > The goal of this issue is to investigate what is missing to make it possible > to "scale horizontally" by increasing the number of replicas. > For example, I believe Fineract code caches certain things? I'm not clear if > they are enabled or disabled by default. Such caches typically do not "just > work" if you scale the Kubernetes deployment, because they will cause "cache > inconsistencies", unless the caches collaborate to invalidate entries when > appropriate. This probably need some configuration. Some references: > * Log about some EhCache configuration when Fineract starts > * > [cache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/cache.xml] > and > [ehcache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/ehcache.xml] > in Fineract source code > * [package > org.apache.fineract.infrastructure.cache|https://github.com/apache/fineract/tree/develop/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache] > in Fineract source code > * [~kumaranath_fernando] ([~kumaranathfernando] ?)'s GSOC 2018 > [proposal|https://cwiki.apache.org/confluence/display/FINERACT/Google+Summer+Code+2018+-+Scalability+and+performance+improvements] > and [final > report|https://cwiki.apache.org/confluence/display/FINERACT/GSOC+2018+Final+Report-+Scalability+and+performance+improvements] > * [~apremalal]'s GSOC 2013 work about caching: [YouTube > demo|https://www.youtube.com/watch?v=30X-uHo5MDg], [Mifos.org > blog|https://mifos.org/blog/meet-2013-google-summer-code-class-interns/], > * "Data Layer" on > [https://cwiki.apache.org/confluence/display/FINERACT/Key+Design+Principles] > I personally do not know the details about caching in Fineract. We should > either fine existing create new documentation about this. It would be worth > to reach out to the mailing list to start a discussion and get input on what > is required to make this work. > FYI [~xurror], [~awasum], [~angeh] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true
[ https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-72: -- Labels: performance (was: ) > Speed up the retrieval of journal entries when "transactionDetails" is set to > true > -- > > Key: FINERACT-72 > URL: https://issues.apache.org/jira/browse/FINERACT-72 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Emmanuel Nnaa >Priority: Major > Labels: performance > > It takes a little over 3 minutes to retrieve about 360 journal entries if the > "transactionDetails" parameter is set to true. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-272) Undo Loan transaction is not affecting the accrual accounting even if the loan is under " Non Performing Assets" (NPA) state
[ https://issues.apache.org/jira/browse/FINERACT-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-272: --- Labels: beginner fineract-gci functional p2 (was: fineract-gci p2) > Undo Loan transaction is not affecting the accrual accounting even if the > loan is under " Non Performing Assets" (NPA) state > > > Key: FINERACT-272 > URL: https://issues.apache.org/jira/browse/FINERACT-272 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: Santosh Math >Assignee: Markus Geiss >Priority: Minor > Labels: beginner, fineract-gci, functional, p2 > Attachments: 3.png > > > As posted by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-1153 > Original Description: > 1. Create a loan product with periodic accrual accounting and NPA as 10 days. > 2. Create a client and attach the above mentioned loan product to that client. > 3. Submit a new loan application on 01 April 2014 approve and disburse on the > same date. > 4. Click on system -> Scheduler job -> Run the job "Update Non Performing > Assets". > (In database m_loan table in "is_npa" column the status displayed as "1") > 4. Again Run the job " Add Accrual Transactions". > 5. Click on the Transaction button in the above created loan account in which > accrual accounting entries are not created because of loan under NPA state. > 6. Make repayments on 08 April 2014 and 15 April 2014. > 7. Click on system -> Scheduler job -> Run the job "Update Non Performing > Assets". > (In database m_loan table in "is_npa" column the status displayed as "0") > 8. Again Run the job " Add Accrual Transactions". > 9. Click on the Transaction button in the above created loan account in which > accrual accrual accounting entries are created. > 10. In the same transaction page delete the transaction on 15 April 2014. > 11. Again Run the job " Add Accrual Transactions" and "Update Non Performing > Assets". > Expected Result: > Accrual entries created after NPA should get deleted in transaction page of > loan account. > Actual Result: > Accrual entries created after NPA staus is not getting deleted. > (even In database m_loan table in "is_npa" column the status displayed as "1") -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-127) Journal entry performance improvement
[
https://issues.apache.org/jira/browse/FINERACT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-127:
---
Labels: performance technical (was: )
> Journal entry performance improvement
> -
>
> Key: FINERACT-127
> URL: https://issues.apache.org/jira/browse/FINERACT-127
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Priority: Major
> Labels: performance, technical
>
> The improvements will make the "accounting running balance update" job more
> efficient in handling the update of journal entries.
> If you reset the "is_running_balance_calculated" property to 0 for all
> journal entries, running the following SQL statement will update the running
> balances much faster than the "accounting running balance update" job:
> {code}
> SET @running_balance := 0;
> SET @account_id := 0;
> update acc_gl_journal_entry as je
> SET
> organization_running_balance = if(@account_id = je.account_id,
> @running_balance := @running_balance + IF(type_enum =
> 1, IF(je.account_id IN (SELECT id from acc_gl_account where `account_usage`
> IN (1,5)), amount * -1, amount), IF(je.account_id IN (SELECT id from
> acc_gl_account where `account_usage` IN (1,5)), amount, amount * -1)),
> @running_balance := IF(type_enum = 1, IF(je.account_id
> IN (SELECT id from acc_gl_account where `account_usage` IN (1,5)), amount *
> -1, amount), IF(je.account_id IN (SELECT id from acc_gl_account where
> `account_usage` IN (1,5)), amount, amount * -1))),
> account_id = IF(@account_id <> je.account_id,
> @account_id:=account_id, account_id)
> order by account_id, entry_date, id;
> COMMIT;
> UNLOCK TABLES;
> SET @running_balance := 0;
> SET @account_id := 0;
> SET @office_id := 0;
> UPDATE acc_gl_journal_entry as je SET office_running_balance =
> if( @office_id = je.office_id AND @account_id = je.account_id,
> @running_balance := @running_balance + IF(type_enum = 1, IF(je.account_id IN
> (SELECT id from acc_gl_account where `account_usage` IN (1,5)), amount * -1,
> amount), IF(je.account_id IN (SELECT id from acc_gl_account where
> `account_usage` IN (1,5)), amount, amount * -1)),
> @running_balance := IF(type_enum = 1, IF(je.account_id IN (SELECT id from
> acc_gl_account where `account_usage` IN (1,5)), amount * -1, amount),
> IF(je.account_id IN (SELECT id from acc_gl_account where `account_usage` IN
> (1,5)), amount, amount * -1))),
> account_id = IF(@account_id <> je.account_id, @account_id:=account_id,
> account_id),
> office_id = IF(@office_id <> je.office_id, @office_id:=office_id, office_id)
> order by office_id, account_id, entry_date, id;
> COMMIT;
> update acc_gl_journal_entry set is_running_balance_calculated = 1;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-127) Journal entry performance improvement
[
https://issues.apache.org/jira/browse/FINERACT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-127:
---
Labels: beginner performance technical (was: performance technical)
> Journal entry performance improvement
> -
>
> Key: FINERACT-127
> URL: https://issues.apache.org/jira/browse/FINERACT-127
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Priority: Major
> Labels: beginner, performance, technical
>
> The improvements will make the "accounting running balance update" job more
> efficient in handling the update of journal entries.
> If you reset the "is_running_balance_calculated" property to 0 for all
> journal entries, running the following SQL statement will update the running
> balances much faster than the "accounting running balance update" job:
> {code}
> SET @running_balance := 0;
> SET @account_id := 0;
> update acc_gl_journal_entry as je
> SET
> organization_running_balance = if(@account_id = je.account_id,
> @running_balance := @running_balance + IF(type_enum =
> 1, IF(je.account_id IN (SELECT id from acc_gl_account where `account_usage`
> IN (1,5)), amount * -1, amount), IF(je.account_id IN (SELECT id from
> acc_gl_account where `account_usage` IN (1,5)), amount, amount * -1)),
> @running_balance := IF(type_enum = 1, IF(je.account_id
> IN (SELECT id from acc_gl_account where `account_usage` IN (1,5)), amount *
> -1, amount), IF(je.account_id IN (SELECT id from acc_gl_account where
> `account_usage` IN (1,5)), amount, amount * -1))),
> account_id = IF(@account_id <> je.account_id,
> @account_id:=account_id, account_id)
> order by account_id, entry_date, id;
> COMMIT;
> UNLOCK TABLES;
> SET @running_balance := 0;
> SET @account_id := 0;
> SET @office_id := 0;
> UPDATE acc_gl_journal_entry as je SET office_running_balance =
> if( @office_id = je.office_id AND @account_id = je.account_id,
> @running_balance := @running_balance + IF(type_enum = 1, IF(je.account_id IN
> (SELECT id from acc_gl_account where `account_usage` IN (1,5)), amount * -1,
> amount), IF(je.account_id IN (SELECT id from acc_gl_account where
> `account_usage` IN (1,5)), amount, amount * -1)),
> @running_balance := IF(type_enum = 1, IF(je.account_id IN (SELECT id from
> acc_gl_account where `account_usage` IN (1,5)), amount * -1, amount),
> IF(je.account_id IN (SELECT id from acc_gl_account where `account_usage` IN
> (1,5)), amount, amount * -1))),
> account_id = IF(@account_id <> je.account_id, @account_id:=account_id,
> account_id),
> office_id = IF(@office_id <> je.office_id, @office_id:=office_id, office_id)
> order by office_id, account_id, entry_date, id;
> COMMIT;
> update acc_gl_journal_entry set is_running_balance_calculated = 1;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-272) Undo Loan transaction is not affecting the accrual accounting even if the loan is under " Non Performing Assets" (NPA) state
[ https://issues.apache.org/jira/browse/FINERACT-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-272: -- Assignee: (was: Markus Geiss) > Undo Loan transaction is not affecting the accrual accounting even if the > loan is under " Non Performing Assets" (NPA) state > > > Key: FINERACT-272 > URL: https://issues.apache.org/jira/browse/FINERACT-272 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: Santosh Math >Priority: Minor > Labels: beginner, fineract-gci, functional, p2 > Attachments: 3.png > > > As posted by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-1153 > Original Description: > 1. Create a loan product with periodic accrual accounting and NPA as 10 days. > 2. Create a client and attach the above mentioned loan product to that client. > 3. Submit a new loan application on 01 April 2014 approve and disburse on the > same date. > 4. Click on system -> Scheduler job -> Run the job "Update Non Performing > Assets". > (In database m_loan table in "is_npa" column the status displayed as "1") > 4. Again Run the job " Add Accrual Transactions". > 5. Click on the Transaction button in the above created loan account in which > accrual accounting entries are not created because of loan under NPA state. > 6. Make repayments on 08 April 2014 and 15 April 2014. > 7. Click on system -> Scheduler job -> Run the job "Update Non Performing > Assets". > (In database m_loan table in "is_npa" column the status displayed as "0") > 8. Again Run the job " Add Accrual Transactions". > 9. Click on the Transaction button in the above created loan account in which > accrual accrual accounting entries are created. > 10. In the same transaction page delete the transaction on 15 April 2014. > 11. Again Run the job " Add Accrual Transactions" and "Update Non Performing > Assets". > Expected Result: > Accrual entries created after NPA should get deleted in transaction page of > loan account. > Actual Result: > Accrual entries created after NPA staus is not getting deleted. > (even In database m_loan table in "is_npa" column the status displayed as "1") -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-880) Fineract Caches & Kubernetes Deployment
[ https://issues.apache.org/jira/browse/FINERACT-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-880: --- Description: The Kubernetes deployment contributed in FINERACT-783 by default creates a Kubernetes Deployment with a single Pod (based on Fineract's Docker Compose set-up). The goal of this issue is to investigate what is missing to make it possible to "scale horizontally" by increasing the number of replicas. For example, I believe Fineract code caches certain things? I'm not clear if they are enabled or disabled by default. Such caches typically do not "just work" if you scale the Kubernetes deployment, because they will cause "cache inconsistencies", unless the caches collaborate to invalidate entries when appropriate. This probably need some configuration. Some references: * Log about some EhCache configuration when Fineract starts * [cache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/cache.xml] and [ehcache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/ehcache.xml] in Fineract source code * [package org.apache.fineract.infrastructure.cache|https://github.com/apache/fineract/tree/develop/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache] in Fineract source code * [~kumaranath_fernando] ([~kumaranathfernando] ?)'s GSOC 2018 [proposal|https://cwiki.apache.org/confluence/display/FINERACT/Google+Summer+Code+2018+-+Scalability+and+performance+improvements] and [final report|https://cwiki.apache.org/confluence/display/FINERACT/GSOC+2018+Final+Report-+Scalability+and+performance+improvements] * [~apremalal]'s GSOC 2013 work about caching: [YouTube demo|https://www.youtube.com/watch?v=30X-uHo5MDg], [Mifos.org blog|https://mifos.org/blog/meet-2013-google-summer-code-class-interns/], * "Data Layer" on [https://cwiki.apache.org/confluence/display/FINERACT/Key+Design+Principles] I personally do not know the details about caching in Fineract. We should either fine existing create new documentation about this. It would be worth to reach out to the mailing list to start a discussion and get input on what is required to make this work. FYI [~xurror], [~awasum], [~angeh] was: The Kubernetes deployment contributed in FINERACT-783 by default creates a Kubernetes Deployment with a single Pod (based on Fineract's Docker Compose set-up). The goal of this issue is to investigate what is missing to make it possible to "scale horizontally" by increasing the number of replicas. For example, I believe Fineract code caches certain things? I'm not clear if they are enabled or disabled by default. Such caches typically do not "just work" if you scale the Kubernetes deployment, because they will cause "cache inconsistencies", unless they caches collaborate to invalidate entries when appropriate, and thus probably need some configuration... some references: * Log about some EhCache configuration when Fineract starts * [cache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/cache.xml] and [ehcache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/ehcache.xml] in Fineract source code * [package org.apache.fineract.infrastructure.cache|https://github.com/apache/fineract/tree/develop/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache] in Fineract source code * [~kumaranath_fernando] ([~kumaranathfernando] ?)'s GSOC 2018 [proposal|https://cwiki.apache.org/confluence/display/FINERACT/Google+Summer+Code+2018+-+Scalability+and+performance+improvements] and [final report|https://cwiki.apache.org/confluence/display/FINERACT/GSOC+2018+Final+Report-+Scalability+and+performance+improvements] * [~apremalal]'s GSOC 2013 work about caching: [YouTube demo|https://www.youtube.com/watch?v=30X-uHo5MDg], [Mifos.org blog|https://mifos.org/blog/meet-2013-google-summer-code-class-interns/], * "Data Layer" on [https://cwiki.apache.org/confluence/display/FINERACT/Key+Design+Principles] I personally do not know the details about caching in Fineract. We should either fine existing create new documentation about this. It would be worth to reach out to the mailing list to start a discussion and get input on what is required to make this work. FYI [~xurror], [~awasum], [~angeh] > Fineract Caches & Kubernetes Deployment > --- > > Key: FINERACT-880 > URL: https://issues.apache.org/jira/browse/FINERACT-880 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Labels: kubernetes, scalability, technical > > The Kubernetes deployment
[jira] [Comment Edited] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081708#comment-17081708
]
Michael Vorburger edited comment on FINERACT-783 at 4/12/20, 10:16 AM:
---
[PR #748|https://github.com/apache/fineract/pull/748] (which was [PR
#651|https://github.com/apache/fineract/pull/651] resurrected) just got merged,
that's a great start! – [~xurror] thank you for this great contribution!
I have a number of ideas for improvements, and will create separate issues for
each of those, and add a _kubernetes_ label to those new JIRAs.
was (Author: vorburger):
[PR #651|https://github.com/apache/fineract/pull/651] just merged, that's a
great start!
I have a number of ideas for improvements, and will create separate issues for
each of those, and add a _kubernetes_ label to those new JIRAs.
[~xurror] thank you for this great contribution!
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081726#comment-17081726
]
Michael Vorburger edited comment on FINERACT-783 at 4/12/20, 10:15 AM:
---
PS: [PR #754|https://github.com/apache/fineract/pull/754] proposed some minor
README clean up related to this, and there are a few proposed follow-up issue
tagged 'kubernetes', e.g. FINERACT-881, FINERACT-882, FINERACT-880.
was (Author: vorburger):
PS: [https://github.com/apache/fineract/pull/748] proposed some minor README
clean up related to this, and there are [a few proposed follow-up issue tagged
'kubernetes'|https://jira.apache.org/jira/browse/?jql=labels %3D kubernetes AND
project %3D "Apache Fineract"%20], e.g. FINERACT-881, FINERACT-882,
FINERACT-880.
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081726#comment-17081726
]
Michael Vorburger edited comment on FINERACT-783 at 4/12/20, 10:13 AM:
---
PS: [https://github.com/apache/fineract/pull/748] proposed some minor README
clean up related to this, and there are [a few proposed follow-up issue tagged
'kubernetes'|https://jira.apache.org/jira/browse/?jql=labels %3D kubernetes AND
project %3D "Apache Fineract"%20], e.g. FINERACT-881, FINERACT-882,
FINERACT-880.
was (Author: vorburger):
PS: [https://github.com/apache/fineract/pull/748] proposed some minor README
clean up related to this, and there are a few proposed follow-up issue tagged
'kubernetes', e.g. FINERACT-881, FINERACT-882, FINERACT-880.
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081726#comment-17081726
]
Michael Vorburger commented on FINERACT-783:
PS: [https://github.com/apache/fineract/pull/748] proposed some minor README
clean up related to this, and there are a few proposed follow-up issue tagged
'kubernetes', e.g. FINERACT-881, FINERACT-882, FINERACT-880.
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081725#comment-17081725
]
Awasum Yannick commented on FINERACT-783:
-
Maybe sending an email to the mailing list will help sell this and inform
people to test this especially in production, as you usually do [~vorburger]
for major features.
Thank you both [~vorburger] and [~xurror] for working to resolve this.
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-881) Remove all hard-coded default passwords from Kubernetes Deployment
[
https://issues.apache.org/jira/browse/FINERACT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-881:
---
Summary: Remove all hard-coded default passwords from Kubernetes Deployment
(was: Remove all hard-coded passwords from Kubernetes Deployment)
> Remove all hard-coded default passwords from Kubernetes Deployment
> --
>
> Key: FINERACT-881
> URL: https://issues.apache.org/jira/browse/FINERACT-881
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Major
> Labels: kubernetes, security, technical
>
> The Kubernetes deployment contributed in FINERACT-783 by creates a Kubernetes
> Deployment using 2 passwords hard-coded in YAML, for the tenants and demo DB
> (based on Fineract's Docker Compose set-up).
> One of the passwords is in a Kubernetes Secret, so it shouldn't be able to
> see it at runtime, but that is kind of pointless because unless someone
> changes the default, its default can be seen in source.
> The other password is in a -D Java property in the YAML, and not even in a
> secret.
> The goal of this issue is to:
> (a) replace the password in the -D Java property by a Kubernetes secret...
> This may require some Java code changes to be able to pass it as an
> Environment Variable instead of a Java System Property; I think since we've
> done FINERACT-796, this should be relatively easy, now that we don't use
> Tomcat XML for a JNDI DS anymore.
> (b) remove the hard-coded default value from the Secret YAML, and instead
> during installation create the database passwords as secrets randomly.
> Research on the web re. best practices how to do this (reach out to see if
> Fineract CN may have already solve this?). At the simplest, you could imagine
> just doing something like [https://stackoverflow.com/a/59678911/421602] in
> our {{kubernetes/kubectl-startup.sh}}.
> FYI [~xurror], [~awasum], [~angeh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FINERACT-882) Include UI in Fineract Docker Compose and Kubernetes deployments
Michael Vorburger created FINERACT-882: -- Summary: Include UI in Fineract Docker Compose and Kubernetes deployments Key: FINERACT-882 URL: https://issues.apache.org/jira/browse/FINERACT-882 Project: Apache Fineract Issue Type: New Feature Reporter: Michael Vorburger The Kubernetes deployment contributed in FINERACT-783 runs the Apache Fineract back-end (based on Fineract's Docker Compose set-up). What would be really neat, for both the Kubernetes as well as the Docker Compose set ups, would be if they would include a UI for Fineract as well! We should probably start with the (old) https://github.com/openMF/community-app/ and later add the (new) https://github.com/openMF/web-app/. The idea would be to build these UIs in Docker containers, and include them in the Kubernetes deployment / Docker Compose YAMLs. The UI should obviously be pre-configured to "just work" for the back-end, so there may be some work to change the URL the UI uses by default to talk to the REST services. There was some related work which would likely need to be completed as part of this issue: * https://github.com/openMF/community-app/issues/3106 * https://github.com/openMF/community-app/pull/3107 * https://github.com/openMF/community-app/issues/3112 FYI [~xurror], [~awasum], [~angeh] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-881) Remove all hard-coded passwords from Kubernetes Deployment
Michael Vorburger created FINERACT-881:
--
Summary: Remove all hard-coded passwords from Kubernetes Deployment
Key: FINERACT-881
URL: https://issues.apache.org/jira/browse/FINERACT-881
Project: Apache Fineract
Issue Type: Bug
Reporter: Michael Vorburger
The Kubernetes deployment contributed in FINERACT-783 by creates a Kubernetes
Deployment using 2 passwords hard-coded in YAML, for the tenants and demo DB
(based on Fineract's Docker Compose set-up).
One of the passwords is in a Kubernetes Secret, so it shouldn't be able to see
it at runtime, but that is kind of pointless because unless someone changes the
default, its default can be seen in source.
The other password is in a -D Java property in the YAML, and not even in a
secret.
The goal of this issue is to:
(a) replace the password in the -D Java property by a Kubernetes secret... This
may require some Java code changes to be able to pass it as an Environment
Variable instead of a Java System Property; I think since we've done
FINERACT-796, this should be relatively easy, now that we don't use Tomcat XML
for a JNDI DS anymore.
(b) remove the hard-coded default value from the Secret YAML, and instead
during installation create the database passwords as secrets randomly. Research
on the web re. best practices how to do this (reach out to see if Fineract CN
may have already solve this?). At the simplest, you could imagine just doing
something like [https://stackoverflow.com/a/59678911/421602] in our
{{kubernetes/kubectl-startup.sh}}.
FYI [~xurror], [~awasum], [~angeh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FINERACT-880) Fineract Caches & Kubernetes Deployment
Michael Vorburger created FINERACT-880: -- Summary: Fineract Caches & Kubernetes Deployment Key: FINERACT-880 URL: https://issues.apache.org/jira/browse/FINERACT-880 Project: Apache Fineract Issue Type: Improvement Reporter: Michael Vorburger The Kubernetes deployment contributed in FINERACT-783 by default creates a Kubernetes Deployment with a single Pod (based on Fineract's Docker Compose set-up). The goal of this issue is to investigate what is missing to make it possible to "scale horizontally" by increasing the number of replicas. For example, I believe Fineract code caches certain things? I'm not clear if they are enabled or disabled by default. Such caches typically do not "just work" if you scale the Kubernetes deployment, because they will cause "cache inconsistencies", unless they caches collaborate to invalidate entries when appropriate, and thus probably need some configuration... some references: * Log about some EhCache configuration when Fineract starts * [cache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/cache.xml] and [ehcache.xml|https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/META-INF/spring/ehcache.xml] in Fineract source code * [package org.apache.fineract.infrastructure.cache|https://github.com/apache/fineract/tree/develop/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache] in Fineract source code * [~kumaranath_fernando] ([~kumaranathfernando] ?)'s GSOC 2018 [proposal|https://cwiki.apache.org/confluence/display/FINERACT/Google+Summer+Code+2018+-+Scalability+and+performance+improvements] and [final report|https://cwiki.apache.org/confluence/display/FINERACT/GSOC+2018+Final+Report-+Scalability+and+performance+improvements] * [~apremalal]'s GSOC 2013 work about caching: [YouTube demo|https://www.youtube.com/watch?v=30X-uHo5MDg], [Mifos.org blog|https://mifos.org/blog/meet-2013-google-summer-code-class-interns/], * "Data Layer" on [https://cwiki.apache.org/confluence/display/FINERACT/Key+Design+Principles] I personally do not know the details about caching in Fineract. We should either fine existing create new documentation about this. It would be worth to reach out to the mailing list to start a discussion and get input on what is required to make this work. FYI [~xurror], [~awasum], [~angeh] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-872) Use a ConfigMap to setup initdb for kubernetes
[ https://issues.apache.org/jira/browse/FINERACT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser resolved FINERACT-872. -- Resolution: Fixed > Use a ConfigMap to setup initdb for kubernetes > -- > > Key: FINERACT-872 > URL: https://issues.apache.org/jira/browse/FINERACT-872 > Project: Apache Fineract > Issue Type: Task >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Trivial > Fix For: 1.4.0 > > > Instead of mounting a directory into the VM for kubernetes, it would be > better to use a configMap for this. This would also allow support for other > VM like KVM and hyperkit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-872) Use a ConfigMap to setup initdb for kubernetes
[ https://issues.apache.org/jira/browse/FINERACT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINERACT-872: - Fix Version/s: 1.4.0 > Use a ConfigMap to setup initdb for kubernetes > -- > > Key: FINERACT-872 > URL: https://issues.apache.org/jira/browse/FINERACT-872 > Project: Apache Fineract > Issue Type: Task >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Trivial > Fix For: 1.4.0 > > > Instead of mounting a directory into the VM for kubernetes, it would be > better to use a configMap for this. This would also allow support for other > VM like KVM and hyperkit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081708#comment-17081708
]
Michael Vorburger commented on FINERACT-783:
[PR #651|https://github.com/apache/fineract/pull/651] just merged, that's a
great start!
I have a number of ideas for improvements, and will create separate issues for
each of those, and add a _kubernetes_ label to those new JIRAs.
[~xurror] thank you for this great contribution!
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (FINERACT-872) Use a ConfigMap to setup initdb for kubernetes
[ https://issues.apache.org/jira/browse/FINERACT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reopened FINERACT-872: -- > Use a ConfigMap to setup initdb for kubernetes > -- > > Key: FINERACT-872 > URL: https://issues.apache.org/jira/browse/FINERACT-872 > Project: Apache Fineract > Issue Type: Task >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Trivial > > Instead of mounting a directory into the VM for kubernetes, it would be > better to use a configMap for this. This would also allow support for other > VM like KVM and hyperkit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-783:
--
Assignee: Michael Vorburger (was: Yemdjih Kaze Nasser)
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger resolved FINERACT-783.
Resolution: Fixed
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-783:
---
Labels: kubernetes (was: )
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Labels: kubernetes
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-783:
---
Fix Version/s: 1.4.0
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-872) Use a ConfigMap to setup initdb for kubernetes
[ https://issues.apache.org/jira/browse/FINERACT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081696#comment-17081696 ] Awasum Yannick commented on FINERACT-872: - Issue is usually closed and resolved when it has being merged into develop. We usually also indicate the right fixed version(s). So I think we might need to reopen this until the PR is merged. Which PR implements this? attache it here..please > Use a ConfigMap to setup initdb for kubernetes > -- > > Key: FINERACT-872 > URL: https://issues.apache.org/jira/browse/FINERACT-872 > Project: Apache Fineract > Issue Type: Task >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Trivial > > Instead of mounting a directory into the VM for kubernetes, it would be > better to use a configMap for this. This would also allow support for other > VM like KVM and hyperkit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reassigned FINERACT-822: Assignee: (was: Yemdjih Kaze Nasser) > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-872) Use a ConfigMap to setup initdb for kubernetes
[ https://issues.apache.org/jira/browse/FINERACT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser closed FINERACT-872. Resolution: Fixed > Use a ConfigMap to setup initdb for kubernetes > -- > > Key: FINERACT-872 > URL: https://issues.apache.org/jira/browse/FINERACT-872 > Project: Apache Fineract > Issue Type: Task >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Trivial > > Instead of mounting a directory into the VM for kubernetes, it would be > better to use a configMap for this. This would also allow support for other > VM like KVM and hyperkit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-804) Use OkHTTP v3 instead of 2.0.0
[ https://issues.apache.org/jira/browse/FINERACT-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick reassigned FINERACT-804: --- Assignee: (was: Yemdjih Kaze Nasser) > Use OkHTTP v3 instead of 2.0.0 > -- > > Key: FINERACT-804 > URL: https://issues.apache.org/jira/browse/FINERACT-804 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > > This came up during (the review of) FINERACT-797: > [The Spring Boot > BOM|https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-dependencies/pom.xml] > uses OkHTTP v3, whereas Fineract currently has a fixed 2.0.0. > The goal of this issue would be to drop the version number of OkHTTP in > Fineract's Gradle dependencies list, so that we simply inherit whichever > (latest) one our use of Spring Boot BOM, introduced in FINERACT-797, gives us. > It's possible that the change from OkHTTP v2 to v3 requires some code changes > (not checked). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081689#comment-17081689 ] Awasum Yannick commented on FINERACT-713: - Key point in the description: the need to parallelize unrelated tests so they run abit faster. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-725) Measure current code coverage
[ https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick resolved FINERACT-725. - Resolution: Fixed Thanks [~Manthan] > Measure current code coverage > - > > Key: FINERACT-725 > URL: https://issues.apache.org/jira/browse/FINERACT-725 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Assignee: Manthan Surkar >Priority: Major > Labels: beginner, starter > Fix For: 1.4.0 > > > Integrate a plugin like > [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate > the code coverage report for running integration tests on Fineract. > Using this report, we can quickly determine which package have low code > coverage and work on remediating the same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-725) Measure current code coverage
[ https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-725: Labels: beginner starter (was: ) > Measure current code coverage > - > > Key: FINERACT-725 > URL: https://issues.apache.org/jira/browse/FINERACT-725 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Assignee: Manthan Surkar >Priority: Major > Labels: beginner, starter > Fix For: 1.4.0 > > > Integrate a plugin like > [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate > the code coverage report for running integration tests on Fineract. > Using this report, we can quickly determine which package have low code > coverage and work on remediating the same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081687#comment-17081687 ] Awasum Yannick commented on FINERACT-713: - [~vorburger], then I can go ahead and close that issue. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-725) Measure current code coverage
[ https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-725: Fix Version/s: 1.4.0 > Measure current code coverage > - > > Key: FINERACT-725 > URL: https://issues.apache.org/jira/browse/FINERACT-725 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > > Integrate a plugin like > [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate > the code coverage report for running integration tests on Fineract. > Using this report, we can quickly determine which package have low code > coverage and work on remediating the same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-725) Measure current code coverage
[ https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081685#comment-17081685 ] Awasum Yannick commented on FINERACT-725: - [~Manthan], [~vorburger], Is this already done via: [https://github.com/apache/fineract/pull/742] ? Maybe we close this? > Measure current code coverage > - > > Key: FINERACT-725 > URL: https://issues.apache.org/jira/browse/FINERACT-725 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Assignee: Manthan Surkar >Priority: Major > > Integrate a plugin like > [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate > the code coverage report for running integration tests on Fineract. > Using this report, we can quickly determine which package have low code > coverage and work on remediating the same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-804) Use OkHTTP v3 instead of 2.0.0
[ https://issues.apache.org/jira/browse/FINERACT-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081683#comment-17081683 ] Awasum Yannick commented on FINERACT-804: - [~xurror], Are you working on this issue? > Use OkHTTP v3 instead of 2.0.0 > -- > > Key: FINERACT-804 > URL: https://issues.apache.org/jira/browse/FINERACT-804 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > > This came up during (the review of) FINERACT-797: > [The Spring Boot > BOM|https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-dependencies/pom.xml] > uses OkHTTP v3, whereas Fineract currently has a fixed 2.0.0. > The goal of this issue would be to drop the version number of OkHTTP in > Fineract's Gradle dependencies list, so that we simply inherit whichever > (latest) one our use of Spring Boot BOM, introduced in FINERACT-797, gives us. > It's possible that the change from OkHTTP v2 to v3 requires some code changes > (not checked). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081681#comment-17081681 ] Awasum Yannick commented on FINERACT-822: - [~xurror], Are you working on this? > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081680#comment-17081680 ] Awasum Yannick commented on FINERACT-821: - [~xurror], Are you still working on this? If not, you may want to liberate it lets know which issues are still available. I see you are focused on completely your PRs so they can be merged and may not have time for this. > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-336) Fund Mapping page Points to Advanced Search page
[ https://issues.apache.org/jira/browse/FINERACT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081674#comment-17081674 ] Awasum Yannick commented on FINERACT-336: - Is this a UI or Backend issue? Maybe we move this to the front end issue tracker? > Fund Mapping page Points to Advanced Search page > > > Key: FINERACT-336 > URL: https://issues.apache.org/jira/browse/FINERACT-336 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization >Reporter: Santosh Math >Priority: Critical > Labels: gsoc, large, p1 > Fix For: 1.5.0 > > Attachments: fundmapping.png > > > Reported by Ed Cable at https://mifosforge.jira.com/browse/MIFOSX-2795 > Original Description: > Hi all, > I think this bug has been existent for several months now as we actually > documented it as intended functionality at > https://mifosforge.jira.com/wiki/display/docs/Fund+Mapping > If you got to Admin >> Organization >> Fund Mapping, clicking the link takes > you to > https://demo4.openmf.org/#/advsearch > rather than the intended page on fund mapping (i'm not sure which it is). > On a similar note, I don't think this advance search link is accessible from > the search menu although it should be there or in the quick links. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-878) Not able to create a loan application
[ https://issues.apache.org/jira/browse/FINERACT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081650#comment-17081650 ] bharath gowda commented on FINERACT-878: [~xurror] thank you for looking it this issue, me and [~awasum] were able to reproduce before, and of-course we had filled in all the mandatory fields, even if we had missed, the error would have been different as it is being handled. check screenshot if (image.png attached) However, i am able to create loans at ease now. i am not sure what the issue was earlier, i suspect some configuration change would be affecting it(not 100% sure) , so some changes made recently could be allowing us to create loan again. This issue might popup in future again, and we shall study the log properly at that time. Thanks again for your time on this issue. > Not able to create a loan application > - > > Key: FINERACT-878 > URL: https://issues.apache.org/jira/browse/FINERACT-878 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: bharath gowda >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Attachments: Screenshot_20200412_041159.png, > image-2020-04-09-15-50-39-678.png, image.png > > > Reproducing step > go to the staging server [https://staging.mifos.io/] > credentials: mifos/password > Go to any client and try to add a loan account to the client with any loan > product > > Steps i followed > 1.went to client named "Jack Spray" client ID "1" > 2. click on add a loan account and select the loan product "short term loan" > 3 fill all the loan details and submit. > > System will just keep loading and stop on the screen > > i am not sure of the fineract version which is there on staging server. but > the release version is as below > Release Version: 19.12.01.RELEASE | Mifos X Release Date: 25/11/2019 > > as per the release date the affected version could be 1.3 or 1.4 > > !image-2020-04-09-15-50-39-678.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-878) Not able to create a loan application
[ https://issues.apache.org/jira/browse/FINERACT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bharath gowda closed FINERACT-878. -- Resolution: Cannot Reproduce > Not able to create a loan application > - > > Key: FINERACT-878 > URL: https://issues.apache.org/jira/browse/FINERACT-878 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: bharath gowda >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Attachments: Screenshot_20200412_041159.png, > image-2020-04-09-15-50-39-678.png, image.png > > > Reproducing step > go to the staging server [https://staging.mifos.io/] > credentials: mifos/password > Go to any client and try to add a loan account to the client with any loan > product > > Steps i followed > 1.went to client named "Jack Spray" client ID "1" > 2. click on add a loan account and select the loan product "short term loan" > 3 fill all the loan details and submit. > > System will just keep loading and stop on the screen > > i am not sure of the fineract version which is there on staging server. but > the release version is as below > Release Version: 19.12.01.RELEASE | Mifos X Release Date: 25/11/2019 > > as per the release date the affected version could be 1.3 or 1.4 > > !image-2020-04-09-15-50-39-678.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-878) Not able to create a loan application
[ https://issues.apache.org/jira/browse/FINERACT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bharath gowda updated FINERACT-878: --- Attachment: image.png > Not able to create a loan application > - > > Key: FINERACT-878 > URL: https://issues.apache.org/jira/browse/FINERACT-878 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Reporter: bharath gowda >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Attachments: Screenshot_20200412_041159.png, > image-2020-04-09-15-50-39-678.png, image.png > > > Reproducing step > go to the staging server [https://staging.mifos.io/] > credentials: mifos/password > Go to any client and try to add a loan account to the client with any loan > product > > Steps i followed > 1.went to client named "Jack Spray" client ID "1" > 2. click on add a loan account and select the loan product "short term loan" > 3 fill all the loan details and submit. > > System will just keep loading and stop on the screen > > i am not sure of the fineract version which is there on staging server. but > the release version is as below > Release Version: 19.12.01.RELEASE | Mifos X Release Date: 25/11/2019 > > as per the release date the affected version could be 1.3 or 1.4 > > !image-2020-04-09-15-50-39-678.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
