[GitHub] fineract issue #341: FINERACT-241
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/341 @nazeer1100126, I got it working now. Thank you for guiding me You can close this PR as i send a new working PR with all the necessary changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #341: FINERACT-241
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/341 @Ippezrobert You need to add that note parameter to SavingsApiConstants.SAVINGS_ACCOUNT_TRANSACTION_REQUEST_DATA_PARAMETERS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #341: FINERACT-241
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/341 ah got it. He didn't add noteParamName in supported parameter list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #341: FINERACT-241
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/341 @Ippezrobert can you give some more details? What validations should we do in SavingsAccountTransactionDataValidator ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #341: FINERACT-241
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/341 @nazeer1100126 , how about validation in SavingsAccountTransactionDataValidator class? Not necessary? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #341: FINERACT-241
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/341 Changes are OK. But it is having two commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
