[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/359
@Ippezrobert I believe we need to implement savings transaction note
similar to loan transaction note.
1) Add a new column in m_note table for savings transaction id
'savings_transaction_id'
@ManyToOne
@JoinColumn(name = "savings_transaction_id", nullable = true)
private SavingsAccountTransaction savingsTransaction;
2) Add a new note type in NoteType -> SAVINGS_TRANSACTION(800,
"noteType.loan.transaction", "loanTransactions")
3) Create savings transaction note with newly created savings account
transaction.
public static Note savingsTransactionNote(final SavingsAccount
savingsAccount, final SavingsAccountTransaction savingsTransaction, final
String note) {
return new Note(savingsAccount, savingsTransaction, note);
}
4) Write the queries which are similar to loan transaction notes for
savings transaction notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/359 @Ippezrobert can we discuss on Skype ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/359 @nazeer1100126 , you can guide me of which changes or files are affected and i can add it as before and send a PR. Waiting for your guidance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/359 @nazeer1100126 , Yes i get it. Indeed we need to show it in th above UI and i was thinking also in transaction tab https://demo.openmf.org/#/viewsavingaccount/790 as in this https://mifosforge.jira.com/secure/attachment/32487/Savings%20Trans%23%20View.png and https://mifosforge.jira.com/secure/attachment/32488/Loan%20Trans%23%20View.png --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/359 @Ippezrobert in this screen https://demo.openmf.org/#/viewsavingtrxn/790/trxnId/9212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/359 @nazeer1100126 , there is a PR i sent for the UI https://github.com/openMF/community-app/pull/2191. Hope this is what you meant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] fineract issue #359: (FINERACT-241) Include "Add Note" to Deposit and Withdr...
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/359 @Ippezrobert Don't we require to show this note in the UI when user is selecting these transactions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
