[jira] [Commented] (FLINK-3191) WordCount without fileOutput - execute is missing

[Simone Robutti (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071145#comment-15071145
 ] 

Simone Robutti commented on FLINK-3191:
---

It was a version problem. I was using the 0.8.0. With the 0.10.0 it works as 
intended. Sorry for the inconvenience.

> WordCount without fileOutput - execute is missing
> -
>
> Key: FLINK-3191
> URL: https://issues.apache.org/jira/browse/FLINK-3191
> Project: Flink
>  Issue Type: Bug
>  Components: Examples
>Reporter: Simone Robutti
>Priority: Trivial
>  Labels: newbie
>
> The WordCount example, if there's no file output specified, is supposed to 
> print the result to the console. In the branch that calls the print, the 
> execute is missing and therefore the computation doesn't start. Adding the 
> execute to the "else" branch does fix the problem. I assume that the execute 
> should be after the if/else statement. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (FLINK-3191) WordCount without fileOutput - execute is missing

[Simone Robutti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simone Robutti closed FLINK-3191.
-
Resolution: Fixed

> WordCount without fileOutput - execute is missing
> -
>
> Key: FLINK-3191
> URL: https://issues.apache.org/jira/browse/FLINK-3191
> Project: Flink
>  Issue Type: Bug
>  Components: Examples
>Reporter: Simone Robutti
>Priority: Trivial
>  Labels: newbie
>
> The WordCount example, if there's no file output specified, is supposed to 
> print the result to the console. In the branch that calls the print, the 
> execute is missing and therefore the computation doesn't start. Adding the 
> execute to the "else" branch does fix the problem. I assume that the execute 
> should be after the if/else statement. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request:

[hash-X]

Github user hash-X commented on the pull request:


https://github.com/apache/flink/commit/c923fb3c1c1d61462e1079198ae9fb735bb0acf2#commitcomment-15155284
  
In 
flink-java/src/main/java/org/apache/flink/api/java/sampling/PoissonSampler.java:
In 
flink-java/src/main/java/org/apache/flink/api/java/sampling/PoissonSampler.java 
on line 147:
This line of code ```while (input.hasNext()){``` don't have a good style, 
it should be like this ```while (input.hasNext()) {```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Update PoissonSampler.java

[hash-X]

GitHub user hash-X opened a pull request:

https://github.com/apache/flink/pull/1476

Update PoissonSampler.java

Change the format of a code to a more specification format

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hash-X/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1476


commit 8bc0e6444c5186528e87185f4a752baccfb1cfac
Author: zhangminglei 
Date:   2015-12-24T16:20:02Z

Update PoissonSampler.java

Change the format of a code to a more specification format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070831#comment-15070831
 ] 

ASF GitHub Bot commented on FLINK-1994:
---

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1397#issuecomment-167079605
  
Hi @rawkintrevo, I think you should rebase your branch instead of merging 
master branch. Could you update your branch? Note that you should force push 
(`git push -f origin flink-1994`) after rebasing your branch.


> Add different gain calculation schemes to SGD
> -
>
> Key: FLINK-1994
> URL: https://issues.apache.org/jira/browse/FLINK-1994
> Project: Flink
>  Issue Type: Improvement
>  Components: Machine Learning Library
>Reporter: Till Rohrmann
>Assignee: Trevor Grant
>Priority: Minor
>  Labels: ML, Starter
>
> The current SGD implementation uses as gain for the weight updates the 
> formula {{stepsize/sqrt(iterationNumber)}}. It would be good to make the gain 
> calculation configurable and to provide different strategies for that. For 
> example:
> * stepsize/(1 + iterationNumber)
> * stepsize*(1 + regularization * stepsize * iterationNumber)^(-3/4)
> See also how to properly select the gains [1].
> Resources:
> [1] http://arxiv.org/pdf/1107.2490.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

[chiwanpark]

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1397#issuecomment-167079605
  
Hi @rawkintrevo, I think you should rebase your branch instead of merging 
master branch. Could you update your branch? Note that you should force push 
(`git push -f origin flink-1994`) after rebasing your branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (FLINK-3191) WordCount without fileOutput - execute is missing

[Simone Robutti (JIRA)]

Simone Robutti created FLINK-3191:
-

 Summary: WordCount without fileOutput - execute is missing
 Key: FLINK-3191
 URL: https://issues.apache.org/jira/browse/FLINK-3191
 Project: Flink
  Issue Type: Bug
  Components: Examples
Reporter: Simone Robutti
Priority: Trivial


The WordCount example, if there's no file output specified, is supposed to 
print the result to the console. In the branch that calls the print, the 
execute is missing and therefore the computation doesn't start. Adding the 
execute to the "else" branch does fix the problem. I assume that the execute 
should be after the if/else statement. 





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3191) WordCount without fileOutput - execute is missing

[Chiwan Park (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071067#comment-15071067
 ] 

Chiwan Park commented on FLINK-3191:


Hi [~chobeat], thanks for reporting issues.

But current examples seem okay to me. Which version of flink are you using? 
Could you attach a link of wrong example?

> WordCount without fileOutput - execute is missing
> -
>
> Key: FLINK-3191
> URL: https://issues.apache.org/jira/browse/FLINK-3191
> Project: Flink
>  Issue Type: Bug
>  Components: Examples
>Reporter: Simone Robutti
>Priority: Trivial
>  Labels: newbie
>
> The WordCount example, if there's no file output specified, is supposed to 
> print the result to the console. In the branch that calls the print, the 
> execute is missing and therefore the computation doesn't start. Adding the 
> execute to the "else" branch does fix the problem. I assume that the execute 
> should be after the if/else statement. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3191) WordCount without fileOutput - execute is missing

[Chesnay Schepler (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071095#comment-15071095
 ] 

Chesnay Schepler commented on FLINK-3191:
-

in newer Flink versions "print()" serves the same purpose as "execute()".

> WordCount without fileOutput - execute is missing
> -
>
> Key: FLINK-3191
> URL: https://issues.apache.org/jira/browse/FLINK-3191
> Project: Flink
>  Issue Type: Bug
>  Components: Examples
>Reporter: Simone Robutti
>Priority: Trivial
>  Labels: newbie
>
> The WordCount example, if there's no file output specified, is supposed to 
> print the result to the console. In the branch that calls the print, the 
> execute is missing and therefore the computation doesn't start. Adding the 
> execute to the "else" branch does fix the problem. I assume that the execute 
> should be after the if/else statement. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)