[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125306507) * b8dc475b7766026ebda4f778209616357a42c98f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125307444) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125306507) * b8dc475b7766026ebda4f778209616357a42c98f : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125307444) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125306507) * b8dc475b7766026ebda4f778209616357a42c98f : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9562: [FLINK-13898] Migrate restart stratey config constants to ConfigOptions
flinkbot edited a comment on issue #9562: [FLINK-13898] Migrate restart stratey config constants to ConfigOptions URL: https://github.com/apache/flink/pull/9562#issuecomment-526200719 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 96b6d32e7167de22549cdbbcc5f1cc5cbe6ad7e0 (Sat Aug 31 04:15:42 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #9562: [FLINK-13898] Migrate restart stratey config constants to ConfigOptions
zhuzhurk commented on a change in pull request #9562: [FLINK-13898] Migrate
restart stratey config constants to ConfigOptions
URL: https://github.com/apache/flink/pull/9562#discussion_r319710651
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.annotation.docs.ConfigGroup;
+import org.apache.flink.annotation.docs.ConfigGroups;
+import org.apache.flink.configuration.description.Description;
+
+import static org.apache.flink.configuration.description.LinkElement.link;
+import static org.apache.flink.configuration.description.TextElement.code;
+import static org.apache.flink.configuration.description.TextElement.text;
+
+/**
+ * Config options for restart strategies.
+ */
+@PublicEvolving
+@ConfigGroups(groups = {
+ @ConfigGroup(name = "FixedDelayRestartStrategy", keyPrefix =
"restart-strategy.fixed-delay"),
+ @ConfigGroup(name = "FailureRateRestartStrategy", keyPrefix =
"restart-strategy.failure-rate")
+})
+public class RestartStrategyOptions {
+
+ public static final ConfigOption RESTART_STRATEGY =
ConfigOptions
+ .key("restart-strategy")
+ .noDefaultValue()
+ .withDescription(
+ Description.builder()
+ .text("Defines the restart strategy to use in
case of job failures.")
+ .linebreak()
+ .text("Accepted values are:")
+ .list(
+ text("%s, %s, %s: No restart
strategy.", code("none"), code("off"), code("disable")),
+ text(
+ "%s, %s: Fixed delay restart
strategy. More details can be found %s.",
+ code("fixeddelay"),
+ code("fixed-delay"),
+
link("../dev/task_failure_recovery.html#fixed-delay-restart-strategy", "here")),
+ text(
+ "%s, %s: Failure rate restart
strategy. More details can be found %s.",
+ code("failurerate"),
+ code("failure-rate"),
+
link("../dev/task_failure_recovery.html#failure-rate-restart-strategy",
"here")),
+ text(
+ "%s: Fully qualified name of %s
factory which has has a method %s.",
+
code("org.foobar.MyRestartStrategyFactoryFactory"),
+ code("RestartStrategyFactory"),
+ code("RestartStrategyFactory
createFactory(Configuration configuration)"))
+ )
+ .text(
+ "If checkpointing is disabled, the
default value is %s. " +
+ "If checkpointing is enabled,
the default value is %s with %s restart attempts and '%s' delay.",
+ code("none"),
+ code("fixed-delay"),
+ code("Integer.MAX_VALUE"),
+ code("0 s"))
+ .build());
+
+ public static final ConfigOption
RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS = ConfigOptions
+ .key("restart-strategy.fixed-delay.attempts")
+ .defaultValue(1)
+ .withDescription(
+ Description.builder()
+ .text(
+ "The number of times that Flink retries
the execution before the job is declared as
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526703428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b8dc475b7766026ebda4f778209616357a42c98f (Sat Aug 31 04:10:38 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125306507) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125306507) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9571: [FLINK-13922][docs] Translate headings of task_failure_recovery.zh.md into English
flinkbot edited a comment on issue #9571: [FLINK-13922][docs] Translate headings of task_failure_recovery.zh.md into English URL: https://github.com/apache/flink/pull/9571#issuecomment-526591967 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1996dd218fc2ffcea8a00f8d70619f8b867365c5 (Sat Aug 31 03:38:03 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #9571: [FLINK-13922][docs] Translate headings of task_failure_recovery.zh.md into English
zhuzhurk commented on issue #9571: [FLINK-13922][docs] Translate headings of task_failure_recovery.zh.md into English URL: https://github.com/apache/flink/pull/9571#issuecomment-526795918 Thanks Till for fixing it. Manually verified it and the anchors in zh docs are working as expected. So +1 for merging it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) * 334ade297027c3ed1d7ad7666e4b957206ea0c33 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
xuefuz commented on a change in pull request #9580: [FLINK-13930][hive] Support
Hive version 3.1.x
URL: https://github.com/apache/flink/pull/9580#discussion_r319709229
##
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/functions/hive/HiveSimpleUDFTest.java
##
@@ -121,30 +124,30 @@ public void testUDFJson() {
assertEquals(null, udf.eval(json, pattern));
}
- @Test
- public void testUDFMinute() {
+// @Test Disabled because in HIve 3.1.0 UDFMinute is no long a simple UDF.
Review comment:
Ok. I will remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526703428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 334ade297027c3ed1d7ad7666e4b957206ea0c33 (Sat Aug 31 03:09:33 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125282063) * ca8f65756da270da937077a2553a9506066b36bc : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125303705) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-13932) PyTest ExecutionConfigTests.test_equals_and_hash fail
TisonKun created FLINK-13932:
Summary: PyTest ExecutionConfigTests.test_equals_and_hash fail
Key: FLINK-13932
URL: https://issues.apache.org/jira/browse/FLINK-13932
Project: Flink
Issue Type: Bug
Components: API / Python
Reporter: TisonKun
Not yet found at master, but independent pull requests even trivial fix fail on
the same case
{code:java}
=== FAILURES ===
__ ExecutionConfigTests.test_equals_and_hash ___
self =
def test_equals_and_hash(self):
config1 = ExecutionEnvironment.get_execution_environment().get_config()
config2 = ExecutionEnvironment.get_execution_environment().get_config()
self.assertEqual(config1, config2)
> self.assertEqual(hash(config1), hash(config2))
E AssertionError: 897378335 != 1596606912
pyflink/common/tests/test_execution_config.py:277: AssertionError
=== warnings summary ===
.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13
/home/travis/build/flink-ci/flink/flink-python/.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13:
DeprecationWarning: Using or importing the ABCs from 'collections' instead of
from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import (
{code}
https://api.travis-ci.com/v3/job/229672435/log.txt
https://api.travis-ci.com/v3/job/229721832/log.txt
cc [~sunjincheng121] [~dian.fu]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125282063) * ca8f65756da270da937077a2553a9506066b36bc : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125303705) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125282063) * ca8f65756da270da937077a2553a9506066b36bc : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit ca8f65756da270da937077a2553a9506066b36bc (Sat Aug 31 01:10:19 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13864).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526703428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9fcdfdece0af746c7d88a42cb512b2c44c75039c (Sat Aug 31 00:10:15 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive]
Support Hive version 3.1.x
URL: https://github.com/apache/flink/pull/9580#discussion_r319702224
##
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/functions/hive/HiveSimpleUDFTest.java
##
@@ -121,30 +124,30 @@ public void testUDFJson() {
assertEquals(null, udf.eval(json, pattern));
}
- @Test
- public void testUDFMinute() {
+// @Test Disabled because in HIve 3.1.0 UDFMinute is no long a simple UDF.
Review comment:
I'm fine just removing this test or replace it with another Hive UDF,
instead of disabling it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#discussion_r319692490 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java ## @@ -109,4 +112,53 @@ void alterPartition(IMetaStoreClient client, String databaseName, String tableNa */ SimpleGenericUDAFParameterInfo createUDAFParameterInfo(ObjectInspector[] params, boolean isWindowing, boolean distinct, boolean allColumns); + + /** +* Get the class of Hive's MetaStoreUtils because its package name was changed in Hive 3.1.0. +* +* @return MetaStoreUtils class +*/ + Class getMetaStoreUtilsClass(); + + /** +* Get the class of Hive's HiveMetaStoreUtils as it was split from MetaStoreUtils class in Hive 3.1.0. +* +* @return HiveMetaStoreUtils class +*/ + Class getHiveMetaStoreUtilsClass(); + + /** +* Hive Date data type class was changed in Hive 3.1.0. +* +* @return Hive's Date class +*/ + Class getDateDataTypeClass(); + + /** +* Hive Timestamp data type class was changed in Hive 3.1.0. +* +* @return Hive's Date class Review comment: ```suggestion * @return Hive's Timestamp class ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive]
Support Hive version 3.1.x
URL: https://github.com/apache/flink/pull/9580#discussion_r319694805
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveRelectionUtils.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.util;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+import org.apache.flink.table.catalog.hive.client.HiveShim;
+import org.apache.flink.table.functions.hive.FlinkHiveUDFException;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.metastore.api.FieldSchema;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.serde2.Deserializer;
+import org.apache.hadoop.hive.serde2.SerDeException;
+import
org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaConstantDateObjectInspector;
+import
org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaConstantTimestampObjectInspector;
+
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+/**
+ * Utilities for accessing Hive class or methods via Java reflection.
+ *
+ * They are put here not for code sharing. Rather, this is a boiler place
for managing similar code that involves
+ * reflection. (In fact, they could be just private method in their respective
calling class.)
+ *
+ * Relevant Hive methods cannot be called directly because shimming is
required to support different, possibly
+ * incompatible Hive versions.
+ */
+public class HiveRelectionUtils {
Review comment:
```suggestion
public class HiveReflectionUtils {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
bowenli86 commented on a change in pull request #9580: [FLINK-13930][hive]
Support Hive version 3.1.x
URL: https://github.com/apache/flink/pull/9580#discussion_r319701907
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSimpleUDF.java
##
@@ -127,9 +130,10 @@ public DataType getHiveResultType(Object[]
constantArguments, DataType[] argType
.getResolver().getEvalMethod(argTypeInfo).getReturnType();
return HiveInspectors.toFlinkType(
- HiveInspectors.getObjectInspector(returnType));
+ HiveInspectors.getObjectInspector(hiveShim,
returnType));
} catch (UDFArgumentException e) {
throw new FlinkHiveUDFException(e);
}
}
+
Review comment:
revert？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526714275 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit e3d3a3f0d280c213920f2e918c4b1445ad92b8c9 (Fri Aug 30 22:53:50 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] asfgit closed pull request #9584: [FLINK-13903][hive] Support Hive version 2.3.6
asfgit closed pull request #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13903) Support Hive version 2.3.6
[ https://issues.apache.org/jira/browse/FLINK-13903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-13903. Resolution: Fixed merged in master: edf1f7d610c75adb228b8bc8262eb1865a91e362 > Support Hive version 2.3.6 > -- > > Key: FLINK-13903 > URL: https://issues.apache.org/jira/browse/FLINK-13903 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive >Reporter: Xuefu Zhang >Assignee: Xuefu Zhang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Hive 2.3.6 is released a few days ago. We can trivially support this version > as well, as we have already provided support for previous 2.3.x releases. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13931) Support Hive version 2.0.x
[ https://issues.apache.org/jira/browse/FLINK-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13931: Attachment: FLINK-13931.patch > Support Hive version 2.0.x > -- > > Key: FLINK-13931 > URL: https://issues.apache.org/jira/browse/FLINK-13931 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive >Reporter: Xuefu Zhang >Assignee: Xuefu Zhang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Attachments: FLINK-13931.patch > > > Including 2.0.0 and 2.0.1. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13931) Support Hive version 2.0.x
[ https://issues.apache.org/jira/browse/FLINK-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13931: Description: Including 2.0.0 and 2.0.1. (was: Including 3.1.0, 3.1.1, and 3.1.2.) > Support Hive version 2.0.x > -- > > Key: FLINK-13931 > URL: https://issues.apache.org/jira/browse/FLINK-13931 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive >Reporter: Xuefu Zhang >Assignee: Xuefu Zhang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > > Including 2.0.0 and 2.0.1. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-13931) Support Hive version 2.0.x
Xuefu Zhang created FLINK-13931: --- Summary: Support Hive version 2.0.x Key: FLINK-13931 URL: https://issues.apache.org/jira/browse/FLINK-13931 Project: Flink Issue Type: Improvement Components: Connectors / Hive Reporter: Xuefu Zhang Assignee: Xuefu Zhang Fix For: 1.10.0 Including 3.1.0, 3.1.1, and 3.1.2. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-523025067 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 80162452561c4138af760fe82596807f7b998f28 (Fri Aug 30 22:30:24 UTC 2019) **Warnings:** * **3 pom.xml files were touched**: Check for build and licensing issues. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
bowenli86 edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-526768489 Merged. Thanks everyone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
bowenli86 commented on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-526768489 Merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-523025067 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 80162452561c4138af760fe82596807f7b998f28 (Fri Aug 30 22:28:21 UTC 2019) **Warnings:** * **3 pom.xml files were touched**: Check for build and licensing issues. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-12847) Update Kinesis Connectors to latest Apache licensed libraries
[ https://issues.apache.org/jira/browse/FLINK-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12847. Resolution: Fixed merged in master: 08d446c2176ff586e3c74c61af3f6797614f051e > Update Kinesis Connectors to latest Apache licensed libraries > - > > Key: FLINK-12847 > URL: https://issues.apache.org/jira/browse/FLINK-12847 > Project: Flink > Issue Type: Improvement > Components: Connectors / Kinesis >Reporter: Dyana Rose >Assignee: Dyana Rose >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently the referenced Kinesis Client Library and Kinesis Producer Library > code in the flink-connector-kinesis is licensed under the Amazon Software > License which is not compatible with the Apache License. This then requires a > fair amount of work in the CI pipeline and for users who want to use the > flink-connector-kinesis. > The Kinesis Client Library v2.x and the AWS Java SDK v2.x both are now on the > Apache 2.0 license. > [https://github.com/awslabs/amazon-kinesis-client/blob/master/LICENSE.txt] > [https://github.com/aws/aws-sdk-java-v2/blob/master/LICENSE.txt] > There is a PR for the Kinesis Producer Library to update it to the Apache 2.0 > license ([https://github.com/awslabs/amazon-kinesis-producer/pull/256]) > The task should include, but not limited to, upgrading KCL/KPL to new > versions of Apache 2.0 license, changing licenses and NOTICE files in > flink-connector-kinesis, and adding flink-connector-kinesis to build, CI and > artifact publishing pipeline, updating the build profiles, updating > documentation that references the license incompatibility > The expected outcome of this issue is that the flink-connector-kinesis will > be included with the standard build artifacts and will no longer need to be > built separately by users. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] asfgit closed pull request #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
asfgit closed pull request #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition … URL: https://github.com/apache/flink/pull/9502#issuecomment-523777539 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 69012717a4b8820f9ebeb97287124aa336bdf137 (Fri Aug 30 22:22:15 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-13814: - Fix Version/s: (was: 1.9.1) > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Affects Versions: 1.9.0 >Reporter: Rui Li >Assignee: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Closed] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-13814. Resolution: Fixed merged in master: 07dfffec8248788630bff5e99afe9866d8b50487 > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Affects Versions: 1.9.0 >Reporter: Rui Li >Assignee: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0, 1.9.1 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] asfgit closed pull request #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
asfgit closed pull request #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition … URL: https://github.com/apache/flink/pull/9502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125282063) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5893967f343a3d2e3b4c92122303e00b01b0f8ff (Fri Aug 30 21:49:37 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13864).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526760217 PTAL @kl0u This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526759603 PTAL @kailashhd @tweise This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5893967f343a3d2e3b4c92122303e00b01b0f8ff (Fri Aug 30 21:46:33 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13864).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526759603 meow @kailashhd @tweise This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526759603 PTAL @kailashhd @tweise This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13864) StreamingFileSink: Allow inherited classes to extend StreamingFileSink correctly
[ https://issues.apache.org/jira/browse/FLINK-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919902#comment-16919902 ] Ying Xu commented on FLINK-13864: - HI [~kkl0u] , this is Ying and I have been working with [~kailashhd] on this feature. Posted a PR [https://github.com/apache/flink/pull/9581] where you can find more details. We've tested a customized StreamingfileSink built on top of the new interface, and it was working fine. Would love your comments there. > StreamingFileSink: Allow inherited classes to extend StreamingFileSink > correctly > > > Key: FLINK-13864 > URL: https://issues.apache.org/jira/browse/FLINK-13864 > Project: Flink > Issue Type: Improvement > Components: Connectors / FileSystem >Reporter: Kailash Hassan Dayanand >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently the StreamingFileSink can't be extended correctly as there are a > few issues [PR |[https://github.com/apache/flink/pull/8469]] merged for this > [Jira|https://issues.apache.org/jira/browse/FLINK-12539] > Mailing list discussion: > [http://mail-archives.apache.org/mod_mbox/flink-dev/201908.mbox/%3CCACGLQUAxXjr2mBOf-6hbXcwmWoH5ib_0YEy-Vyjj%3DEPyQ25Qiw%40mail.gmail.com%3E] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526719331 ## CI report: * e3d3a3f0d280c213920f2e918c4b1445ad92b8c9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125279078) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB
flinkbot edited a comment on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB URL: https://github.com/apache/flink/pull/9583#issuecomment-526715510 ## CI report: * 6e904b5c61931e1cc84215ac297d1f3254b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277398) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526608245 ## CI report: * b511754c50bd15675d802e3e60294b2a6ffed65a : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125236425) * 767a16a955fe26f97c7b1b9843e584580c6ffe89 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125250326) * 2a9f08e0ecf8e763b8957663fe8e1ce937689726 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125253972) * fbee7a0b2ea300670828fefd99d277fe4d42bba5 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125258395) * 383fa710ebdaddcd15595fd32bbf72c81b93664e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125260105) * 1dbfa45dc7f8815d3ec7f63874ee80fda6177493 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125274573) * 9ddb9f33d79adca82b70ff99fd224d963a8a63fc : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125275935) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125282063) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) * 5893967f343a3d2e3b4c92122303e00b01b0f8ff : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot edited a comment on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526719331 ## CI report: * e3d3a3f0d280c213920f2e918c4b1445ad92b8c9 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125279078) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5893967f343a3d2e3b4c92122303e00b01b0f8ff (Fri Aug 30 19:32:10 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13864).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526719331 ## CI report: * e3d3a3f0d280c213920f2e918c4b1445ad92b8c9 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB
flinkbot edited a comment on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB URL: https://github.com/apache/flink/pull/9583#issuecomment-526715510 ## CI report: * 6e904b5c61931e1cc84215ac297d1f3254b8 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125277398) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125277359) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB
flinkbot commented on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB URL: https://github.com/apache/flink/pull/9583#issuecomment-526715510 ## CI report: * 6e904b5c61931e1cc84215ac297d1f3254b8 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582#issuecomment-526715481 ## CI report: * cf8ca4230e985f45cd8b42002ab9a027c9dadc0d : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526715445 ## CI report: * dc9cdc1364b9050c3d2f3cba062310ff68d83b8e : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526608245 ## CI report: * b511754c50bd15675d802e3e60294b2a6ffed65a : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125236425) * 767a16a955fe26f97c7b1b9843e584580c6ffe89 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125250326) * 2a9f08e0ecf8e763b8957663fe8e1ce937689726 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125253972) * fbee7a0b2ea300670828fefd99d277fe4d42bba5 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125258395) * 383fa710ebdaddcd15595fd32bbf72c81b93664e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125260105) * 1dbfa45dc7f8815d3ec7f63874ee80fda6177493 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125274573) * 9ddb9f33d79adca82b70ff99fd224d963a8a63fc : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125275935) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot edited a comment on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582#issuecomment-526712729 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cf8ca4230e985f45cd8b42002ab9a027c9dadc0d (Fri Aug 30 19:07:43 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6
xuefuz commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582#issuecomment-526714322 Close this PR as the wrong branch was chosen. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz closed pull request #9582: [FLINK-13903][hive] Support Hive version 2.3.6
xuefuz closed pull request #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526714275 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit e3d3a3f0d280c213920f2e918c4b1445ad92b8c9 (Fri Aug 30 19:05:46 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6
xuefuz commented on issue #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584#issuecomment-526713859 cc: @bowenli86 @lirui-apache @zjuwangg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz opened a new pull request #9584: [FLINK-13903][hive] Support Hive version 2.3.6
xuefuz opened a new pull request #9584: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9584 ## What is the purpose of the change Support Hive 2.3.6, which was released a few days ago. ## Brief change log - Added a new shim for this version ## Verifying this change This change is already covered by existing tests, and manually ran the tests for the version. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB
flinkbot commented on issue #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB URL: https://github.com/apache/flink/pull/9583#issuecomment-526713253 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 6e904b5c61931e1cc84215ac297d1f3254b8 (Fri Aug 30 19:02:27 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6
flinkbot commented on issue #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582#issuecomment-526712729 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cf8ca4230e985f45cd8b42002ab9a027c9dadc0d (Fri Aug 30 19:00:50 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
flinkbot commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit dc9cdc1364b9050c3d2f3cba062310ff68d83b8e (Fri Aug 30 19:00:52 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13864).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz opened a new pull request #9582: [FLINK-13903][hive] Support Hive version 2.3.6
xuefuz opened a new pull request #9582: [FLINK-13903][hive] Support Hive version 2.3.6 URL: https://github.com/apache/flink/pull/9582 ## What is the purpose of the change Support Hive 2.3.6, which was released a few days ago. ## Brief change log - Added a new shim for this version ## Verifying this change This change is already covered by existing tests, and manually ran the tests for the version. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the
StreamingFileSink Builder interface to allow for easier subclassing of
StreamingFileSink
URL: https://github.com/apache/flink/pull/9581#issuecomment-526712227
**Example subclass interface**
```
public class CustomizedStreamingFileSink extends StreamingFileSink
{
private CustomizedStreamingFileSink(
final BulkFormatBuilder bucketsBuilder, final long
bucketCheckInterval) {
super(bucketsBuilder, bucketCheckInterval);
...
}
// Retrieve a new bulk format builder
public static StreamingFileSink.BulkFormatBuilder>
forBulkFormat(Path basePath, Factory writerFactory) {
...
return new CustomizedBulkFormatBuilder(...)
}
.
.
.
public static class CustomizedBulkFormatBuilder> extends
StreamingFileSink.BulkFormatBuilder {
public CustomizedBulkFormatBuilder(
Path basePath, Factory writerFactory, BucketAssigner assigner) {
super(basePath, writerFactory, assigner);
}
public CustomizedStreamingFileSink build() {
return new CustomizedStreamingFileSink(this, bucketCheckInterval);
}
}
}
```
One alternative is to make `private` members in
`StreamingFileSink.BulkFormatBuilder` (or `StreamingFileSink.RowFormatBuilder`)
`public` or `protected`, which is more hackish.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (FLINK-13864) StreamingFileSink: Allow inherited classes to extend StreamingFileSink correctly
[ https://issues.apache.org/jira/browse/FLINK-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13864: --- Labels: pull-request-available (was: ) > StreamingFileSink: Allow inherited classes to extend StreamingFileSink > correctly > > > Key: FLINK-13864 > URL: https://issues.apache.org/jira/browse/FLINK-13864 > Project: Flink > Issue Type: Improvement > Components: Connectors / FileSystem >Reporter: Kailash Hassan Dayanand >Priority: Minor > Labels: pull-request-available > > Currently the StreamingFileSink can't be extended correctly as there are a > few issues [PR |[https://github.com/apache/flink/pull/8469]] merged for this > [Jira|https://issues.apache.org/jira/browse/FLINK-12539] > Mailing list discussion: > [http://mail-archives.apache.org/mod_mbox/flink-dev/201908.mbox/%3CCACGLQUAxXjr2mBOf-6hbXcwmWoH5ib_0YEy-Vyjj%3DEPyQ25Qiw%40mail.gmail.com%3E] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] TisonKun opened a new pull request #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB
TisonKun opened a new pull request #9583: [hotfix][configuration] Remove usages of deprecated options TASK_MANAGER_HEAP_MEMORY_MB and JOB_MANAGER_HEAP_MEMORY_MB URL: https://github.com/apache/flink/pull/9583 ## What is the purpose of the change Logic about deprecated key should be carefully handled by `ConfigOption`. We should never use deprecated key anywhere outside. ## Verifying this change This change is a trivial code cleanup without any new test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes, add deprecated key instead of handle deprecation logic inline) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) cc @twalthr @dawidwys This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yxu-valleytider opened a new pull request #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink
yxu-valleytider opened a new pull request #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581 ## What is the purpose of the change This patch makes it easier to extend `StreamingFileSink`, which adopts the builder pattern as a way to construct a new `StreamingFileSink` object. It follows the technique of "recurring generic pattern" which is documented in [[1](https://community.oracle.com/blogs/emcmanus/2010/10/24/using-builder-pattern-subclasses)] and [[2](https://stackoverflow.com/questions/17164375/subclassing-a-java-builder-class)]. ## Brief change log **StreamingFileSink** - Added the builder type as the class signature for `BucketsBuilder`, `RowFormatBuilder` and `BulkFormatBuilder`. - Added a `self()` method inside `BucketsBuilder` to return the proper builder type for base classes and subclasses in the path of inheritance. - Change the construction methods to return the builder object (`self()`), instead of a new instance of the builder. - Removed `final` for a few variables as they are now set by the construction methods. ## Verifying this change This change is merely an interface change and is already covered by existing tests, such as *LocalStreamingFileSinkTest* and *BulkWriterTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (yes) it affects *StreamingFileSink* but merely an interface change. ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526608245 ## CI report: * b511754c50bd15675d802e3e60294b2a6ffed65a : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125236425) * 767a16a955fe26f97c7b1b9843e584580c6ffe89 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125250326) * 2a9f08e0ecf8e763b8957663fe8e1ce937689726 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125253972) * fbee7a0b2ea300670828fefd99d277fe4d42bba5 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125258395) * 383fa710ebdaddcd15595fd32bbf72c81b93664e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125260105) * 1dbfa45dc7f8815d3ec7f63874ee80fda6177493 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125274573) * 9ddb9f33d79adca82b70ff99fd224d963a8a63fc : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot edited a comment on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125274599) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526605083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9ddb9f33d79adca82b70ff99fd224d963a8a63fc (Fri Aug 30 18:47:24 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#discussion_r319635226 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ## @@ -513,12 +509,8 @@ private void validateClusterSpecification(ClusterSpecification clusterSpecificat yarnApplication, validClusterSpecification); - String host = report.getHost(); - int port = report.getRpcPort(); - - // Correctly initialize the Flink config - flinkConfiguration.setString(JobManagerOptions.ADDRESS, host); - flinkConfiguration.setInteger(JobManagerOptions.PORT, port); Review comment: Reverted removals and create FLINK-13929 for further discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#discussion_r319634038 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ## @@ -513,12 +509,8 @@ private void validateClusterSpecification(ClusterSpecification clusterSpecificat yarnApplication, validClusterSpecification); - String host = report.getHost(); - int port = report.getRpcPort(); - - // Correctly initialize the Flink config - flinkConfiguration.setString(JobManagerOptions.ADDRESS, host); - flinkConfiguration.setInteger(JobManagerOptions.PORT, port); Review comment: Aha! Even I found a reason that we "need" these stmts because when build HAService at client-side we have to build one just like on cluster client thus if `JobManagerOption` not set it will fail with ``` Test testPerJobMode(org.apache.flink.yarn.YARNITCase) failed with: org.apache.flink.client.deployment.ClusterDeploymentException: Could not deploy Yarn job cluster. at org.apache.flink.yarn.YarnClusterDescriptor.deployJobCluster(YarnClusterDescriptor.java:82) at org.apache.flink.yarn.YARNITCase.lambda$testPerJobMode$0(YARNITCase.java:109) at org.apache.flink.yarn.YarnTestBase.runTest(YarnTestBase.java:229) at org.apache.flink.yarn.YARNITCase.testPerJobMode(YARNITCase.java:69) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) Suppressed: java.lang.AssertionError: There is at least one application on the cluster that is not finished.[App application_1567190598292_0001 is in state RUNNING.] at org.junit.Assert.fail(Assert.java:88) at org.apache.flink.yarn.YarnTestBase$CleanupYarnApplication.close(YarnTestBase.java:257) at org.apache.flink.yarn.YarnTestBase.runTest(YarnTestBase.java:230) ... 31 more Caused by: org.apache.flink.util.ConfigurationException: Config parameter 'Key: 'jobmanager.rpc.address' , default: null (fallback keys: [])' is missing (hostname/address of JobManager to connect to). at org.apache.flink.runtime.highavailability.HighAvailabilityServicesUtils.getJobManagerAddress(HighAvailabilityServicesUtils.java:150) at
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526605083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9ddb9f33d79adca82b70ff99fd224d963a8a63fc (Fri Aug 30 18:43:20 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526707203 ## CI report: * 9fcdfdece0af746c7d88a42cb512b2c44c75039c : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
TisonKun commented on a change in pull request #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#discussion_r319634038 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ## @@ -513,12 +509,8 @@ private void validateClusterSpecification(ClusterSpecification clusterSpecificat yarnApplication, validClusterSpecification); - String host = report.getHost(); - int port = report.getRpcPort(); - - // Correctly initialize the Flink config - flinkConfiguration.setString(JobManagerOptions.ADDRESS, host); - flinkConfiguration.setInteger(JobManagerOptions.PORT, port); Review comment: Aha! Even I found a reason that we "need" these stmts because when build HAService at client-side we have to build one just like on cluster client thus if `JobManagerOption` not set it will fail with ``` org.apache.flink.client.deployment.ClusterDeploymentException: Could not deploy Yarn job cluster. at org.apache.flink.yarn.YARNITCase.lambda$testPerJobMode$0(YARNITCase.java:109) at org.apache.flink.yarn.YARNITCase.testPerJobMode(YARNITCase.java:69) Caused by: org.apache.flink.util.ConfigurationException: Config parameter 'Key: 'jobmanager.rpc.address' , default: null (fallback keys: [])' is missing (hostname/address of JobManager to connect to). at org.apache.flink.yarn.YARNITCase.lambda$testPerJobMode$0(YARNITCase.java:109) at org.apache.flink.yarn.YARNITCase.testPerJobMode(YARNITCase.java:69) ``` this is what FLINK-13750 want to resolve, i.e., do not instance service that is never needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526608245 ## CI report: * b511754c50bd15675d802e3e60294b2a6ffed65a : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125236425) * 767a16a955fe26f97c7b1b9843e584580c6ffe89 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125250326) * 2a9f08e0ecf8e763b8957663fe8e1ce937689726 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125253972) * fbee7a0b2ea300670828fefd99d277fe4d42bba5 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125258395) * 383fa710ebdaddcd15595fd32bbf72c81b93664e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125260105) * 1dbfa45dc7f8815d3ec7f63874ee80fda6177493 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526605083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9ddb9f33d79adca82b70ff99fd224d963a8a63fc (Fri Aug 30 18:40:16 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-523030190 ## CI report: * 394dfe73e75cf9db8dcbbb96ead65ba5130e3e0c : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/123898225) * cb912bb2b7358c5c01ed702b64ddd2f4c9b0a0ca : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123909324) * a622fc55f05b38912b83ab7b6424a0b2d6ac2375 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124174020) * 7bf48d8eac338f9494db333229307ae0cc45c695 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124760490) * 8e70b4f2c96109f83f6aa42a11ba42afe1b3924f : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124765153) * 5af3517a366a5efc85358dfabed7c1bbcafd560e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125025233) * f047437e3886dd5e4f945ee5fb946f373ea60382 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125185847) * 322b7f9b7db6e6e12f07ed612dc9f025dc019383 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125227452) * 80162452561c4138af760fe82596807f7b998f28 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125263063) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526605083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1dbfa45dc7f8815d3ec7f63874ee80fda6177493 (Fri Aug 30 18:34:12 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
flinkbot edited a comment on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526605083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 383fa710ebdaddcd15595fd32bbf72c81b93664e (Fri Aug 30 18:31:08 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo
TisonKun commented on issue #9575: [FLINK-13912][client] Remove ClusterClient#getClusterConnectionInfo URL: https://github.com/apache/flink/pull/9575#issuecomment-526703548 @sunjincheng121 python profile fails as below. I have no idea on what happened. Could you please figure out why tests failed? ``` === FAILURES === __ ExecutionConfigTests.test_equals_and_hash ___ self = def test_equals_and_hash(self): config1 = ExecutionEnvironment.get_execution_environment().get_config() config2 = ExecutionEnvironment.get_execution_environment().get_config() self.assertEqual(config1, config2) > self.assertEqual(hash(config1), hash(config2)) E AssertionError: 897378335 != 1596606912 pyflink/common/tests/test_execution_config.py:277: AssertionError === warnings summary === .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13 .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13 .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13 .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13 .tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13 /home/travis/build/TisonKun/flink/flink-python/.tox/py37/lib/python3.7/site-packages/py4j/java_collections.py:13: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working from collections import ( -- Docs: https://docs.pytest.org/en/latest/warnings.html ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
flinkbot commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526703428 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9fcdfdece0af746c7d88a42cb512b2c44c75039c (Fri Aug 30 18:29:49 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x
xuefuz commented on issue #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580#issuecomment-526702887 cc: @bowenli86 @lirui-apache @zjuwangg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz opened a new pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x
xuefuz opened a new pull request #9580: [FLINK-13930][hive] Support Hive version 3.1.x URL: https://github.com/apache/flink/pull/9580 ## What is the purpose of the change Support Hive 3.1.x versions, including 3.1.0, 3.1.1, and 3.1.2 ## Brief change log - Added new shims for each version - Made inheritance relationships between the shims - Shimmed methods to deal with API difference ## Verifying this change This change is already covered by existing tests, and manually ran the tests for all versions. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9579: [FLINK-13925] use current thread's context classloader as parent of flink classloader
flinkbot edited a comment on issue #9579: [FLINK-13925] use current thread's context classloader as parent of flink classloader URL: https://github.com/apache/flink/pull/9579#issuecomment-526655483 ## CI report: * 5fee587d205bb76d1733b98ee00ee10566467dcf : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125255866) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13930) Support Hive version 3.1.x
[ https://issues.apache.org/jira/browse/FLINK-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13930: Description: Including 3.1.0, 3.1.1, and 3.1.2. (was: Hive 2.3.6 is released a few days ago. We can trivially support this version as well, as we have already provided support for previous 2.3.x releases.) > Support Hive version 3.1.x > -- > > Key: FLINK-13930 > URL: https://issues.apache.org/jira/browse/FLINK-13930 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive >Reporter: Xuefu Zhang >Assignee: Xuefu Zhang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > > Including 3.1.0, 3.1.1, and 3.1.2. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-13930) Support Hive version 3.1.x
Xuefu Zhang created FLINK-13930: --- Summary: Support Hive version 3.1.x Key: FLINK-13930 URL: https://issues.apache.org/jira/browse/FLINK-13930 Project: Flink Issue Type: Improvement Components: Connectors / Hive Reporter: Xuefu Zhang Assignee: Xuefu Zhang Fix For: 1.10.0 Hive 2.3.6 is released a few days ago. We can trivially support this version as well, as we have already provided support for previous 2.3.x releases. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9404: [FLINK-13667][ml] Add the utility class for the Table
flinkbot edited a comment on issue #9404: [FLINK-13667][ml] Add the utility class for the Table URL: https://github.com/apache/flink/pull/9404#issuecomment-519872127 ## CI report: * 4a726770daa19b1a587c5f8d9221a95e08387592 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/122573104) * cd4cfbe81b4d511ec985bc4ad55a5dad82722863 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124368074) * 6efbedf230f6fdeec96b9802d296629269a230ab : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125253936) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-523030190 ## CI report: * 394dfe73e75cf9db8dcbbb96ead65ba5130e3e0c : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/123898225) * cb912bb2b7358c5c01ed702b64ddd2f4c9b0a0ca : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123909324) * a622fc55f05b38912b83ab7b6424a0b2d6ac2375 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124174020) * 7bf48d8eac338f9494db333229307ae0cc45c695 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124760490) * 8e70b4f2c96109f83f6aa42a11ba42afe1b3924f : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124765153) * 5af3517a366a5efc85358dfabed7c1bbcafd560e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125025233) * f047437e3886dd5e4f945ee5fb946f373ea60382 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125185847) * 322b7f9b7db6e6e12f07ed612dc9f025dc019383 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125227452) * 80162452561c4138af760fe82596807f7b998f28 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/125263063) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9565: [FLINK-12501] Use SpecificRecord.getSchema in AvroFactory
flinkbot edited a comment on issue #9565: [FLINK-12501] Use SpecificRecord.getSchema in AvroFactory URL: https://github.com/apache/flink/pull/9565#issuecomment-526519069 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 0533cc9722194964f630a7de8b9ffd7a2dac5809 (Fri Aug 30 17:00:28 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] debasishg commented on a change in pull request #9565: [FLINK-12501] Use SpecificRecord.getSchema in AvroFactory
debasishg commented on a change in pull request #9565: [FLINK-12501] Use
SpecificRecord.getSchema in AvroFactory
URL: https://github.com/apache/flink/pull/9565#discussion_r319598469
##
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroFactory.java
##
@@ -94,7 +94,8 @@ static Schema parseSchemaString(@Nullable String
schemaString) {
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
private static AvroFactory fromSpecific(Class type,
ClassLoader cl, Optional previousSchema) {
SpecificData specificData = new SpecificData(cl);
- Schema newSchema = specificData.getSchema(type);
+ Optional newSchemaOptional = tryExtractAvroSchema(type);
+ Schema newSchema =
newSchemaOptional.orElse(specificData.getSchema(type));
Review comment:
I faced a problem here which comes from the use of `Optional.orElse`. It's a
known gotcha with `orElse`. Even though `newSchemaOptional` is non-empty,
`orElse` will evaluate the argument passed as default. Hence it tries to
evaluate `specificData.getSchema(type))` and fails with the earlier exception.
The workaround is to change `orElse` to `orElseGet` and pass a lambda instead ..
```java
Schema newSchema = newSchemaOptional.orElseGet(() ->
specificData.getSchema(type));
```
This fixes the problem and runs ok. There are a few other invocations of
`orElse` in this class which you may want to change to `orElseGet` as well ..
I cherrypicked your commit into the `release-1.9` branch and did a build
which runs fine. Thanks for the help.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
