[jira] [Commented] (FLINK-12501) AvroTypeSerializer does not work with types generated by avrohugger
[
https://issues.apache.org/jira/browse/FLINK-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927297#comment-16927297
]
Gary Yao commented on FLINK-12501:
--
What's the state here with respect to 1.9?
> AvroTypeSerializer does not work with types generated by avrohugger
> ---
>
> Key: FLINK-12501
> URL: https://issues.apache.org/jira/browse/FLINK-12501
> Project: Flink
> Issue Type: Bug
> Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The main problem is that the code in {{SpecificData.createSchema()}} tries to
> reflectively read the {{SCHEMA$}} field, that is normally there in Avro
> generated classes. However, avrohugger generates this field in a companion
> object, which the reflective Java code will therefore not find.
> This is also described in these ML threads:
> *
> [https://lists.apache.org/thread.html/5db58c7d15e4e9aaa515f935be3b342fe036e97d32e1fb0f0d1797ee@%3Cuser.flink.apache.org%3E]
> *
> [https://lists.apache.org/thread.html/cf1c5b8fa7f095739438807de9f2497e04ffe55237c5dea83355112d@%3Cuser.flink.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests
flinkbot edited a comment on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests URL: https://github.com/apache/flink/pull/9669#issuecomment-530242754 ## CI report: * 461b51b151b85f68f5df546f4389fd179f7a52d1 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126938504) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530214499 ## CI report: * 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126930200) * 5d39c66f65f649f710b7d6100ca10fa2874da5ce : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126938493) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14048) Flink client hangs after trying to kill Yarn Job during deployment
Gyula Fora created FLINK-14048: -- Summary: Flink client hangs after trying to kill Yarn Job during deployment Key: FLINK-14048 URL: https://issues.apache.org/jira/browse/FLINK-14048 Project: Flink Issue Type: Improvement Components: Client / Job Submission, Deployment / YARN Reporter: Gyula Fora If we kill the flink client run command from the terminal while deploying to YARN (let's say we realize we used the wrong parameters), the YARN application will be killed immediately but the client won't shut down. We get the following messages over and over: 19/09/10 23:35:55 INFO retry.RetryInvocationHandler: java.io.IOException: The client is stopped, while invoking ApplicationClientProtocolPBClientImpl.forceKillApplication over null after 14 failover attempts. Trying to failover after sleeping for 16296ms. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests
flinkbot commented on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests URL: https://github.com/apache/flink/pull/9669#issuecomment-530242754 ## CI report: * 461b51b151b85f68f5df546f4389fd179f7a52d1 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530214499 ## CI report: * 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126930200) * 5d39c66f65f649f710b7d6100ca10fa2874da5ce : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5d39c66f65f649f710b7d6100ca10fa2874da5ce (Wed Sep 11 06:25:51 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests
flinkbot commented on issue #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests URL: https://github.com/apache/flink/pull/9669#issuecomment-530239523 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 461b51b151b85f68f5df546f4389fd179f7a52d1 (Wed Sep 11 06:24:14 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yangjf2019 commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
yangjf2019 commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530239388 @flinkbot Please rebuild again,Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13382) Port DecimalITCase to unit tests
[
https://issues.apache.org/jira/browse/FLINK-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-13382:
---
Labels: pull-request-available (was: )
> Port DecimalITCase to unit tests
>
>
> Key: FLINK-13382
> URL: https://issues.apache.org/jira/browse/FLINK-13382
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Reporter: Jark Wu
>Assignee: Leonard Xu
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.10.0
>
>
> There are 81 query tests in
> {{org.apache.flink.table.runtime.batch.sql.DecimalITCase}} and 67 query tests
> in {{org.apache.flink.table.runtime.batch.table.DecimalITCase}}.
> Note that each query will be executed on a MiniCluster which will consume a
> lot of testing time. However, decimals can be tested as unit tests similar to
> other Scalar functions tests.
> So I would suggest to move Decimal IT cases to unit tests
> {{org.apache.flink.table.expressions.DecimalTypeTest}}. This should save much
> testing time.
> In the meanwhile, IMO, this is not required by 1.9 release.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] leonardBang opened a new pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests
leonardBang opened a new pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests URL: https://github.com/apache/flink/pull/9669 ## What is the purpose of the change Reduce Blink planner testing time by replacing decimal ITCase with unit tests. ## Brief change log - Delete 55 tests from org.apache.flink.table.runtime.batch.sql.DecimalITCase and 45 tests org.apache.flink.table.runtime.batch.table.DecimalITCase, all of these tests can replace with table API tests. - Add corresponding API tests in org.apache.flink.table.expressions.DecimalTypeTest. - Add testSqlCalResNullable()、testTableCalResNullable()function in ExpressionTestBase for testing the result of expression(eg f0 +f1) is nullable or not rather than using 'CASE WHEN (f0 +f1) is null THEN 'null' ELSE 'not null' END' in function testSqlNullable() and testTableNullable() . Function testSqlNullable() and testTableNullable() were turned out to be wrong in some cases in FLINK-14030 ## Verifying this change This change is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): ( no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no ) - The S3 file system connector: ( no ) ## Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5d39c66f65f649f710b7d6100ca10fa2874da5ce (Wed Sep 11 06:16:42 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 (Wed Sep 11 06:11:35 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yangjf2019 commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
yangjf2019 commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#discussion_r323072597 ## File path: docs/flinkDev/building.md ## @@ -128,7 +128,7 @@ mvn clean install -Dhadoop.version=2.6.5-custom After this step is complete, follow the steps for [Pre-bundled versions](#pre-bundled-versions). To build Flink against a vendor specific Hadoop version, additionally activate -Pvendor-repos` profile when building -`flink-shaded`. +`flink-shaded: Review comment: Thanks ,I will update it . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yangjf2019 commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
yangjf2019 commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#discussion_r323072569 ## File path: docs/flinkDev/building.md ## @@ -128,7 +128,7 @@ mvn clean install -Dhadoop.version=2.6.5-custom After this step is complete, follow the steps for [Pre-bundled versions](#pre-bundled-versions). To build Flink against a vendor specific Hadoop version, additionally activate -Pvendor-repos` profile when building Review comment: Thanks ,I will update it . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530214499 ## CI report: * 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126930200) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-12362) Remove legacy container number config option for Flink on yarn
[
https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang updated FLINK-12362:
-
Summary: Remove legacy container number config option for Flink on yarn
(was: Remove container number config option for Flink on yarn job cluster mode)
> Remove legacy container number config option for Flink on yarn
> --
>
> Key: FLINK-12362
> URL: https://issues.apache.org/jira/browse/FLINK-12362
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> The {{-n}} config option for Flink on YARN has been deprecated and removed
> from documentation. However, there are still some legacy code exists in the
> codebase. We need to clean up them.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 (Wed Sep 11 05:42:06 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
wuchong commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#discussion_r323066568 ## File path: docs/flinkDev/building.md ## @@ -128,7 +128,7 @@ mvn clean install -Dhadoop.version=2.6.5-custom After this step is complete, follow the steps for [Pre-bundled versions](#pre-bundled-versions). To build Flink against a vendor specific Hadoop version, additionally activate -Pvendor-repos` profile when building -`flink-shaded`. +`flink-shaded: Review comment: ```suggestion flink-shaded: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
wuchong commented on a change in pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#discussion_r323066535 ## File path: docs/flinkDev/building.md ## @@ -128,7 +128,7 @@ mvn clean install -Dhadoop.version=2.6.5-custom After this step is complete, follow the steps for [Pre-bundled versions](#pre-bundled-versions). To build Flink against a vendor specific Hadoop version, additionally activate -Pvendor-repos` profile when building Review comment: ```suggestion To build Flink against a vendor specific Hadoop version, additionally activate `-Pvendor-repos` profile when building ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution
flinkbot edited a comment on issue #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution URL: https://github.com/apache/flink/pull/9653#issuecomment-529523535 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9b9156b15508efd40c5a8e5427a8cddb469913f9 (Wed Sep 11 05:34:58 UTC 2019) **Warnings:** * **2 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunct
hequn8128 commented on a change in pull request #9653: [FLINK-14014][python]
Introduce PythonScalarFunctionRunner to handle the communication with Python
worker for Python ScalarFunction execution
URL: https://github.com/apache/flink/pull/9653#discussion_r323050334
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonEnv.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.functions.python;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Python execution environments.
+ */
+public final class PythonEnv implements Serializable {
Review comment:
Add `@Internal`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunct
hequn8128 commented on a change in pull request #9653: [FLINK-14014][python]
Introduce PythonScalarFunctionRunner to handle the communication with Python
worker for Python ScalarFunction execution
URL: https://github.com/apache/flink/pull/9653#discussion_r323051548
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonEnv.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.functions.python;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Python execution environments.
+ */
+public final class PythonEnv implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final String pythonExec;
Review comment:
Add comment for these member variables? It would be easier to understand
these variables
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunct
hequn8128 commented on a change in pull request #9653: [FLINK-14014][python]
Introduce PythonScalarFunctionRunner to handle the communication with Python
worker for Python ScalarFunction execution
URL: https://github.com/apache/flink/pull/9653#discussion_r323050847
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonEnv.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.functions.python;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Python execution environments.
+ */
+public final class PythonEnv implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private final String pythonExec;
+
+ private final String pipExec;
+
+ private final String pythonWorkerCmd;
+
+ private final ExecType execType;
+
+ public PythonEnv(
+ String pythonExec,
+ String pipExec,
+ String pythonWorkerCmd,
+ ExecType execType) {
+ this.pythonExec = Preconditions.checkNotNull(pythonExec);
+ this.pipExec = Preconditions.checkNotNull(pipExec);
+ this.pythonWorkerCmd =
Preconditions.checkNotNull(pythonWorkerCmd);
+ this.execType = Preconditions.checkNotNull(execType);
+ }
+
+ public String getPythonExec() {
+ return pythonExec;
+ }
+
+ public String getPipExec() {
+ return pipExec;
+ }
+
+ public String getPythonWorkerCmd() {
+ return pythonWorkerCmd;
+ }
+
+ public ExecType getExecType() {
+ return execType;
+ }
+
+ /**
+* The Execution type specifies how to execute the Python function.
+*/
+ public enum ExecType {
+ // python function is executed in a separate process
+ PROCESS,
+
+ // python function is executed in a docker container
+ DOCKER,
+
+ // python function is executed in an external non-managed
process
+ EXTERNAL,
+
+ UNKNOWN,
Review comment:
Remove the `,` after UNKNOWN
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunct
hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution URL: https://github.com/apache/flink/pull/9653#discussion_r323065018 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonFunctionInfo.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions.python; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.util.Preconditions; + +import java.io.Serializable; + +/** + * PythonFunctionInfo contains the execution information of a Python function, such as: + * the actual Python function, the input arguments, the input types, the result type, etc. Review comment: Should we make the comment consistent with the implementation of the class? It seems this class only contains the python function and it's input indexes, i.e., does not contain input types, result type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530214499 ## CI report: * 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126930200) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530214499 ## CI report: * 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
flinkbot commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1871c0fd4afb239a9515b38b4b2cab5b0144bc57 (Wed Sep 11 04:20:50 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yangjf2019 opened a new pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)
yangjf2019 opened a new pull request #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668 ## What is the purpose of the change * Fix the wrong characters in the document(building.md,building.zh.md) ## Brief change log *I modified the "docs/flinkDev/building.md" and "docs/flinkDev/building.zh.md" file .* ## Verifying this change *I have verified the changes by starting the build script in preview mode.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) Hi, @wuchong @zentol Please take a look .Thank you very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521082590 ## CI report: * d78dad6818e94f70666df4d7fca91c71b717bf3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123139009) * 9f196705610a4b48715dcff37610dee4438fc010 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126182907) * 53ef1e19a913ec0096a1687582050db3c3875097 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126925028) * 8ff9bc99f7e8d567b710f3b00823127843a80c36 : UNKNOWN * 1446d682e9d959330a6ff9164e54c0d05322cf07 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126927673) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521082590 ## CI report: * d78dad6818e94f70666df4d7fca91c71b717bf3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123139009) * 9f196705610a4b48715dcff37610dee4438fc010 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126182907) * 53ef1e19a913ec0096a1687582050db3c3875097 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126925028) * 8ff9bc99f7e8d567b710f3b00823127843a80c36 : UNKNOWN * 1446d682e9d959330a6ff9164e54c0d05322cf07 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] josh0yeh commented on a change in pull request #9587: [FLINK-13685][yarn] Validate YARN deployment against YARN scheduler maximum vcore size
josh0yeh commented on a change in pull request #9587: [FLINK-13685][yarn]
Validate YARN deployment against YARN scheduler maximum vcore size
URL: https://github.com/apache/flink/pull/9587#discussion_r323049936
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##
@@ -83,6 +83,17 @@
code("org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler"))
.build());
+ /**
+* The scheduler maximum-allocation-vcores exposed by YARN. This is a
global property of the Yarn scheduler."
+*/
+ public static final ConfigOption SCHEDULER_MAX_VCORE =
Review comment:
Thanks for catching this. I was experimenting something else(overwrite).
Removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9587: [FLINK-13685][yarn] Validate YARN deployment against YARN scheduler maximum vcore size
flinkbot edited a comment on issue #9587: [FLINK-13685][yarn] Validate YARN deployment against YARN scheduler maximum vcore size URL: https://github.com/apache/flink/pull/9587#issuecomment-526995997 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 8481a73c9846795ba4baa13ca641e9ab90d8d80b (Wed Sep 11 03:55:19 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] josh0yeh commented on a change in pull request #9587: [FLINK-13685][yarn] Validate YARN deployment against YARN scheduler maximum vcore size
josh0yeh commented on a change in pull request #9587: [FLINK-13685][yarn]
Validate YARN deployment against YARN scheduler maximum vcore size
URL: https://github.com/apache/flink/pull/9587#discussion_r323049833
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##
@@ -536,12 +538,20 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
protected ClusterSpecification validateClusterResources(
ClusterSpecification clusterSpecification,
int yarnMinAllocationMB,
+ int yarnSchedulerMaxVcores,
Resource maximumResourceCapability,
ClusterResourceDescription freeClusterResources) throws
YarnDeploymentException {
int taskManagerCount =
clusterSpecification.getNumberTaskManagers();
int jobManagerMemoryMb =
clusterSpecification.getMasterMemoryMB();
int taskManagerMemoryMb =
clusterSpecification.getTaskManagerMemoryMB();
+ int slotsPerTaskManager =
clusterSpecification.getSlotsPerTaskManager();
Review comment:
yarn.appmaster.vcores and yarn.containers.vcores are checked in
isReadyForDeployment()
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Assigned] (FLINK-10231) Add a view SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li reassigned FLINK-10231:
Assignee: Danny Chan (was: TANG Wen-hui)
> Add a view SQL DDL
> --
>
> Key: FLINK-10231
> URL: https://issues.apache.org/jira/browse/FLINK-10231
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Timo Walther
>Assignee: Danny Chan
>Priority: Critical
> Fix For: 1.10.0
>
>
> FLINK-10163 added initial view support for the SQL Client. However, for
> supporting the [full definition of
> views|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView]
> (with schema, comments, etc.) we need to support native support for views in
> the Table API.
> {code}
> CREATE VIEW [IF NOT EXISTS] [catalog_name.db_name.]view_name [COMMENT
> comment] AS SELECT ;
> DROP VIEW[IF EXISTS] [catalog_name.db_name.]view_name;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name AS SELECT ;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name RENAME TO ;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name SET COMMENT = ;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-10231) Add a view SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927224#comment-16927224
]
Bowen Li commented on FLINK-10231:
--
Hi [~winipanda], I'll assign this to [~danny0405] since it's been idle for a
long time and I haven't heard from you. Danny already has a PoC now.
[~QiLuo] thanks for the offering. I'll assign Danny for this time. Please feel
free to take other tickets!
> Add a view SQL DDL
> --
>
> Key: FLINK-10231
> URL: https://issues.apache.org/jira/browse/FLINK-10231
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Timo Walther
>Assignee: TANG Wen-hui
>Priority: Critical
> Fix For: 1.10.0
>
>
> FLINK-10163 added initial view support for the SQL Client. However, for
> supporting the [full definition of
> views|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView]
> (with schema, comments, etc.) we need to support native support for views in
> the Table API.
> {code}
> CREATE VIEW [IF NOT EXISTS] [catalog_name.db_name.]view_name [COMMENT
> comment] AS SELECT ;
> DROP VIEW[IF EXISTS] [catalog_name.db_name.]view_name;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name AS SELECT ;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name RENAME TO ;
> ALTER VIEW [IF EXISTS] [catalog_name.db_name.]view_name SET COMMENT = ;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521082590 ## CI report: * d78dad6818e94f70666df4d7fca91c71b717bf3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123139009) * 9f196705610a4b48715dcff37610dee4438fc010 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126182907) * 53ef1e19a913ec0096a1687582050db3c3875097 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126925028) * 8ff9bc99f7e8d567b710f3b00823127843a80c36 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521081788 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1446d682e9d959330a6ff9164e54c0d05322cf07 (Wed Sep 11 03:40:03 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @docete * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-530206036 Updated to revert unnecessary changes. @bowenli86 Please take a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521081788 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1446d682e9d959330a6ff9164e54c0d05322cf07 (Wed Sep 11 03:35:58 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @docete * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521081788 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 8ff9bc99f7e8d567b710f3b00823127843a80c36 (Wed Sep 11 03:26:50 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @docete * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521082590 ## CI report: * d78dad6818e94f70666df4d7fca91c71b717bf3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123139009) * 9f196705610a4b48715dcff37610dee4438fc010 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126182907) * 53ef1e19a913ec0096a1687582050db3c3875097 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126925028) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521082590 ## CI report: * d78dad6818e94f70666df4d7fca91c71b717bf3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123139009) * 9f196705610a4b48715dcff37610dee4438fc010 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126182907) * 53ef1e19a913ec0096a1687582050db3c3875097 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-12362) Remove container number config option for Flink on yarn job cluster mode
[
https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang updated FLINK-12362:
-
Description: The {{-n}} config option for Flink on YARN has been deprecated
and removed from documentation. However, there are still some legacy code
exists in the codebase. We need to clean up them. (was: Recently, the {{-n}}
config option has been removed from the document, the commit is here:
[https://github.com/apache/flink/commit/60507b8baf5fba999b7c2c45c150914f38f5ce38#diff-8ae07fac4c1f4137fc1ef062aef70115L100]
I can understand that maybe this option is useless for Flink session. But for
job cluster mode, remove this option would confuse the users:
* the {{-n}} has been deprecated and replaced with {{-p}}?
* {{-p}} means the job level parallelism, but if users want to set a single
operator's parallelism? how to calculate the number of containers
* the {{-n}} option still exists in {{FlinkYarnSessionCli}}
* we have customized the source code which broken the rule: one container one
slot, so the {{-n}} is still useful
)
> Remove container number config option for Flink on yarn job cluster mode
>
>
> Key: FLINK-12362
> URL: https://issues.apache.org/jira/browse/FLINK-12362
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> The {{-n}} config option for Flink on YARN has been deprecated and removed
> from documentation. However, there are still some legacy code exists in the
> codebase. We need to clean up them.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-470819951 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 398ca435074d507f529d2ec016abc9979be3a94d (Wed Sep 11 02:32:53 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] Myasuka removed a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
Myasuka removed a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-530009365 @AHeise Thanks for your review, already address your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-530193864 @AHeise Thanks for your review, already address your comments and squash all commits into one commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution
flinkbot edited a comment on issue #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution URL: https://github.com/apache/flink/pull/9653#issuecomment-529523535 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9b9156b15508efd40c5a8e5427a8cddb469913f9 (Wed Sep 11 01:59:16 UTC 2019) **Warnings:** * **2 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunct
hequn8128 commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution URL: https://github.com/apache/flink/pull/9653#discussion_r323030969 ## File path: pom.xml ## @@ -1667,7 +1669,7 @@ under the License. org.apache.maven.plugins maven-shade-plugin - 3.0.0 + 3.1.0 Review comment: Should we bump it to 3.2.1? see FLINK-13453. And would be great if we also update the document about maven-shade-plugin in [dependencies.md](https://ci.apache.org/projects/flink/flink-docs-master/dev/projectsetup/dependencies.html) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14031) flink-examples-table should add the blink planner dependency
[
https://issues.apache.org/jira/browse/FLINK-14031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927175#comment-16927175
]
Leonard Xu commented on FLINK-14031:
Well，sounds good。
> flink-examples-table should add the blink planner dependency
>
>
> Key: FLINK-14031
> URL: https://issues.apache.org/jira/browse/FLINK-14031
> Project: Flink
> Issue Type: Bug
> Components: Examples
>Affects Versions: 1.9.0
>Reporter: Jimmy Wong
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The flink-examples-table module is missing blink planner dependency. If I run
> a blink example with Intellij IDEA, have error:
>
> {code:java}
> Exception in thread "main" org.apache.flink.table.api.TableException: Could
> not instantiate the executor. Make sure a planner module is on the
> classpathException in thread "main"
> org.apache.flink.table.api.TableException: Could not instantiate the
> executor. Make sure a planner module is on the classpath at
> org.apache.flink.table.api.java.internal.StreamTableEnvironmentImpl.lookupExecutor(StreamTableEnvironmentImpl.java:140)
> at
> org.apache.flink.table.api.java.internal.StreamTableEnvironmentImpl.create(StreamTableEnvironmentImpl.java:110)
> at
> org.apache.flink.table.api.java.StreamTableEnvironment.create(StreamTableEnvironment.java:112)
> at
> org.apache.flink.table.examples.java.BlinkStreamSQL.main(BlinkStreamSQL.java:19)Caused
> by: org.apache.flink.table.api.NoMatchingTableFactoryException: Could not
> find a suitable table factory for
> 'org.apache.flink.table.delegation.ExecutorFactory' inthe classpath.
> {code}
> *But*, once I add blink planner dependency, it'll work well.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (FLINK-14031) flink-examples-table should add the blink planner dependency
[
https://issues.apache.org/jira/browse/FLINK-14031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927175#comment-16927175
]
Leonard Xu edited comment on FLINK-14031 at 9/11/19 1:28 AM:
-
Well，sounds good。[~GatsbyNewton]
was (Author: leonard xu):
Well，sounds good。
> flink-examples-table should add the blink planner dependency
>
>
> Key: FLINK-14031
> URL: https://issues.apache.org/jira/browse/FLINK-14031
> Project: Flink
> Issue Type: Bug
> Components: Examples
>Affects Versions: 1.9.0
>Reporter: Jimmy Wong
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The flink-examples-table module is missing blink planner dependency. If I run
> a blink example with Intellij IDEA, have error:
>
> {code:java}
> Exception in thread "main" org.apache.flink.table.api.TableException: Could
> not instantiate the executor. Make sure a planner module is on the
> classpathException in thread "main"
> org.apache.flink.table.api.TableException: Could not instantiate the
> executor. Make sure a planner module is on the classpath at
> org.apache.flink.table.api.java.internal.StreamTableEnvironmentImpl.lookupExecutor(StreamTableEnvironmentImpl.java:140)
> at
> org.apache.flink.table.api.java.internal.StreamTableEnvironmentImpl.create(StreamTableEnvironmentImpl.java:110)
> at
> org.apache.flink.table.api.java.StreamTableEnvironment.create(StreamTableEnvironment.java:112)
> at
> org.apache.flink.table.examples.java.BlinkStreamSQL.main(BlinkStreamSQL.java:19)Caused
> by: org.apache.flink.table.api.NoMatchingTableFactoryException: Could not
> find a suitable table factory for
> 'org.apache.flink.table.delegation.ExecutorFactory' inthe classpath.
> {code}
> *But*, once I add blink planner dependency, it'll work well.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9644: [FLINK-13931][hive] Support Hive version 2.0.x
flinkbot edited a comment on issue #9644: [FLINK-13931][hive] Support Hive version 2.0.x URL: https://github.com/apache/flink/pull/9644#issuecomment-529009260 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1472dbd78a06bc5897aa4922adfb66e82cd01f40 (Wed Sep 11 00:59:12 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9644: [FLINK-13931][hive] Support Hive version 2.0.x
xuefuz commented on issue #9644: [FLINK-13931][hive] Support Hive version 2.0.x URL: https://github.com/apache/flink/pull/9644#issuecomment-530175160 @bowenli86 @lirui-apache do you have more comments/questions? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14035) Introduce/Change some log for snapshot to better analysis checkpoint problem
[
https://issues.apache.org/jira/browse/FLINK-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927134#comment-16927134
]
vinoyang commented on FLINK-14035:
--
[~klion26] Sounds reasonable. +1
> Introduce/Change some log for snapshot to better analysis checkpoint problem
>
>
> Key: FLINK-14035
> URL: https://issues.apache.org/jira/browse/FLINK-14035
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
>Affects Versions: 1.10.0
>Reporter: Congxian Qiu(klion26)
>Priority: Major
>
> Currently, the information for checkpoint are mostly debug log (especially on
> TM side). If we want to track where the checkpoint steps and consume time
> during each step when we have a failed checkpoint or the checkpoint time is
> too long, we need to restart the job with enabling debug log, this issue
> wants to improve this situation, wants to change some exist debug log from
> debug to info, and add some more debug log. we have changed this log level
> in our production in Alibaba, and it seems no problem until now.
>
> Detail
> {{change the log below from debug level to info}}
> * log about \{{Starting checkpoint xxx }} in TM side
> * log about Sync complete in TM side
> * log about async compete in TM side
> Add debug log
> * log about receiving the barrier for exactly once mode - align from at
> lease once mode
>
> If this issue is valid, then I'm happy to contribute it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-13748) Streaming File Sink s3 end-to-end test failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926807#comment-16926807
]
Kostas Kloudas commented on FLINK-13748:
Thanks for digging into it [~carp84]! I will also have a look tomorrow to see
if I can reproduce it locally.
> Streaming File Sink s3 end-to-end test failed on Travis
> ---
>
> Key: FLINK-13748
> URL: https://issues.apache.org/jira/browse/FLINK-13748
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Kostas Kloudas
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
> Attachments: image-2019-09-11-01-29-25-634.png
>
>
> The {{Streaming File Sink s3 end-to-end test}} failed on Travis because it
> did not produce any output for 10 minutes.
> https://api.travis-ci.org/v3/job/572255913/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
flinkbot edited a comment on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521081788 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9f196705610a4b48715dcff37610dee4438fc010 (Tue Sep 10 17:40:12 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @docete * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-514122911 ## CI report: * 79c5fa63ef124c0b099b420690ef39174e85d4d7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120145161) * 72ed7023dff939b01be68c9436e858a9ea8e947a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125396084) * 0c9299f1ac0102c17941c7b0635005b48af2c243 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125572149) * 398ca435074d507f529d2ec016abc9979be3a94d : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126648457) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
bowenli86 commented on a change in pull request #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#discussion_r322874678 ## File path: flink-table/flink-sql-client/src/test/resources/test-sql-client-catalogs.yaml ## @@ -28,49 +28,22 @@ tables: type: source-table $VAR_UPDATE_MODE schema: - - name: IntegerField1 -type: INT - - name: StringField1 + - name: dec +type: DECIMAL + - name: vch type: VARCHAR connector: type: filesystem path: "$VAR_SOURCE_PATH1" format: type: csv fields: -- name: IntegerField1 - type: INT -- name: StringField1 +- name: dec + type: DECIMAL +- name: vch type: VARCHAR line-delimiter: "\n" comment-prefix: "#" - - name: TestView1 Review comment: Yeah, let's revert them. They are not used in queries, but are registered when sql cli bootstraps to test registration logic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926800#comment-16926800
]
Bowen Li commented on FLINK-7151:
-
Hi [~ZhenqiuHuang] [~fhueske], as mentioned above, I'd prefer to split the
effort, and **have this ticket just deal with basic syntax like the examples
given in the description**, and they are much less controversial. We can assume
that the function class is already in classpath by users.
Advanced syntax like "USING JAR/FILE/ARCHIVE" will need its own FLIP to discuss
questions like those raised by Fabian.
Do you think we need a mini FLIP for just the basic syntax? [~fhueske]
> Add a function SQL DDL
> --
>
> Key: FLINK-7151
> URL: https://issues.apache.org/jira/browse/FLINK-7151
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: yuemeng
>Assignee: Shuyi Chen
>Priority: Critical
> Fix For: 1.10.0
>
>
> Based on create function and table.we can register a udf,udaf,udtf use sql:
> {code}
> CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS
> class_name [WITH (properties.)];
> DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name;
> ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO
> new_name;
> {code}
> {code}
> CREATE function 'TOPK' AS
> 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF';
> INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP
> BY id;
> {code}
> This ticket can assume that the function class is already loaded in classpath
> by users. Advanced syntax like to how to dynamically load udf libraries from
> external locations can be on a separate ticket.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-13748) Streaming File Sink s3 end-to-end test failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926799#comment-16926799
]
Yu Li commented on FLINK-13748:
---
!image-2019-09-11-01-29-25-634.png|width=634,height=302!
From the build history, 536ccd7 was the last green cron build and e0759c3 was
the first failure, there're only another prometheus related commit between
these two, so I think e0759c3 is the most questionable.
> Streaming File Sink s3 end-to-end test failed on Travis
> ---
>
> Key: FLINK-13748
> URL: https://issues.apache.org/jira/browse/FLINK-13748
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Kostas Kloudas
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
> Attachments: image-2019-09-11-01-29-25-634.png
>
>
> The {{Streaming File Sink s3 end-to-end test}} failed on Travis because it
> did not produce any output for 10 minutes.
> https://api.travis-ci.org/v3/job/572255913/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (FLINK-13748) Streaming File Sink s3 end-to-end test failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated FLINK-13748:
--
Attachment: image-2019-09-11-01-29-25-634.png
> Streaming File Sink s3 end-to-end test failed on Travis
> ---
>
> Key: FLINK-13748
> URL: https://issues.apache.org/jira/browse/FLINK-13748
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Kostas Kloudas
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
> Attachments: image-2019-09-11-01-29-25-634.png
>
>
> The {{Streaming File Sink s3 end-to-end test}} failed on Travis because it
> did not produce any output for 10 minutes.
> https://api.travis-ci.org/v3/job/572255913/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9667: [FLINK-13619] Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
flinkbot edited a comment on issue #9667: [FLINK-13619] Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint URL: https://github.com/apache/flink/pull/9667#issuecomment-529953758 ## CI report: * d56a6ff167bccb8797766ee6419c3516c1bc37c5 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126626177) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14047) Hide secret values when displaying user configuration/global job parameters in web UI
Till Rohrmann created FLINK-14047:
-
Summary: Hide secret values when displaying user
configuration/global job parameters in web UI
Key: FLINK-14047
URL: https://issues.apache.org/jira/browse/FLINK-14047
Project: Flink
Issue Type: New Feature
Components: Runtime / REST, Runtime / Web Frontend
Affects Versions: 1.9.0, 1.8.1, 1.10.0
Reporter: Till Rohrmann
A user requested the feature to hide secret values when displaying the user
configuration/global job parameters in the web UI. Ideally, there is a way to
denote keys which contain secret values so that the {{JobConfigHandler}}
excludes them from the response.
For the cluster level configuration Flink supports a similar functionality. The
{{ClusterConfigHandler}} replaces the values of all keys which contain one of
the strings specified in {{GlobalConfiguration.SENSITIVE_KEYS}}, which is
currently defined as {{["password", "secret"]}}, with
{{GlobalConfiguration.HIDDEN_CONTENT}}. That way Flink hides the sensitive
information.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#issuecomment-526487220 ## CI report: * 3c6c3d69983136fb8bfa11b28a7ba783dfe61e52 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125188905) * a9d65d8fabd938d47abd801a4686cb185f2fcf68 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125206763) * 1bbbce7f1f81598cb5a454f0e4d25adae6ed75b4 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125425831) * d68aa63cea98320f14ff9bbe483776c8873a77ca : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125431268) * 097e1ec9e9e64ad6e9e1de16bc2937acb84ab42e : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125726843) * 9bc0b14a50cf03c23eb4203aa2637130572047f9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125739773) * ee6669575eb9481fd7181c3a9be52e615f613e8f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125755445) * 712fdb428e78fc0d47262c6c755429a37a6be3eb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125860362) * 16bac68a7fd82876d0ad2d56c8e7c199dc816d04 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125884245) * aeb427b0c486080e894d9753b9cfe1e385bdbd95 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126422558) * 589b8dcc5219d83ecbbbf0d79a511e440bb36e9f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126424947) * 180592d9ea193b9f95af525c16804a0e9d411ca2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126607060) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState
flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-515868641 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit de863750b7262d091d2e7dd82767b8f9b2e2c52a (Tue Sep 10 16:40:01 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❗ 3. Needs [attention] from. - Needs attention by @aljoscha [PMC], @wuchong [committer] * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState
carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-530020615 That's fine @Myasuka , just attach the patch here if anyone would like to try reproducing the result. Since this one claims to be a performance enhancement, I believe it's better to show some detailed data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13748) Streaming File Sink s3 end-to-end test failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926760#comment-16926760
]
Yu Li commented on FLINK-13748:
---
Almost all e2e-misc related part failed (except for e2e-misc-jdk11) in this
nightly run including the last instance Till posted:
https://travis-ci.org/apache/flink/builds/582875546
>From the output we could see below line, which possibly indicating some
>checkpoint related problem:
{noformat}
Waiting for job (xxx) to have at least 3 completed checkpoints ...
No output has been received in the last 10m0s
{noformat}
> Streaming File Sink s3 end-to-end test failed on Travis
> ---
>
> Key: FLINK-13748
> URL: https://issues.apache.org/jira/browse/FLINK-13748
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Kostas Kloudas
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The {{Streaming File Sink s3 end-to-end test}} failed on Travis because it
> did not produce any output for 10 minutes.
> https://api.travis-ci.org/v3/job/572255913/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-514122911 ## CI report: * 79c5fa63ef124c0b099b420690ef39174e85d4d7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120145161) * 72ed7023dff939b01be68c9436e858a9ea8e947a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125396084) * 0c9299f1ac0102c17941c7b0635005b48af2c243 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125572149) * 398ca435074d507f529d2ec016abc9979be3a94d : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126648457) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-470819951 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 398ca435074d507f529d2ec016abc9979be3a94d (Tue Sep 10 16:11:28 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-530009365 @AHeise Thanks for your review, already address your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9665: [BP-1.9][FLINK-14043] Speed up SavepointMigrationTestBase sub classes
flinkbot edited a comment on issue #9665: [BP-1.9][FLINK-14043] Speed up SavepointMigrationTestBase sub classes URL: https://github.com/apache/flink/pull/9665#issuecomment-529945752 ## CI report: * 7a9640f2638da3f6b400a207f89dabae3c28cdaf : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126622810) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9666: [BP-1.8][FLINK-14043] Speed up SavepointMigrationTestBase sub classes
flinkbot edited a comment on issue #9666: [BP-1.8][FLINK-14043] Speed up SavepointMigrationTestBase sub classes URL: https://github.com/apache/flink/pull/9666#issuecomment-529945839 ## CI report: * 7d7c395bd231c77fb688b2626f987fd6a88ae172 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126622907) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-514122911 ## CI report: * 79c5fa63ef124c0b099b420690ef39174e85d4d7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120145161) * 72ed7023dff939b01be68c9436e858a9ea8e947a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125396084) * 0c9299f1ac0102c17941c7b0635005b48af2c243 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125572149) * 398ca435074d507f529d2ec016abc9979be3a94d : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9664: [FLINK-14043] Speed up SavepointMigrationTestBase sub classes
flinkbot edited a comment on issue #9664: [FLINK-14043] Speed up SavepointMigrationTestBase sub classes URL: https://github.com/apache/flink/pull/9664#issuecomment-529945670 ## CI report: * 25245d8b8a95f00476f5287e6f7280e6fd61e404 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126622788) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529769037 ## CI report: * cdfb2bf661da8fd51ce52843a0a8d3bac8b78170 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126555210) * 94215849e6feb86c731a8ac931d750645ab446ef : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126635876) * 8af897961d37bb27adaec80f119a0837cc1a1cb8 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126639160) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
flinkbot edited a comment on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-470819951 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 398ca435074d507f529d2ec016abc9979be3a94d (Tue Sep 10 15:49:03 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529768266 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 8af897961d37bb27adaec80f119a0837cc1a1cb8 (Tue Sep 10 15:36:48 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14031).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] GatsbyNewton closed pull request #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
GatsbyNewton closed pull request #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529769037 ## CI report: * cdfb2bf661da8fd51ce52843a0a8d3bac8b78170 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126555210) * 94215849e6feb86c731a8ac931d750645ab446ef : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126635876) * 8af897961d37bb27adaec80f119a0837cc1a1cb8 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126639160) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926733#comment-16926733
]
Fabian Hueske commented on FLINK-7151:
--
Hi [~ZhenqiuHuang], thanks for sharing the proposal!
Just a few remarks:
* the proposal assumes that the client side (the one submitting the SQL / Table
API query) can access the external library. It would first be downloaded to the
client and from there shipped to the Flink master and from there distributed
via the blob service
* downloading external code (possibly from a public network) is a security
risk. We should probably add a switch to disable this feature.
* Do we need to think about how to load libraries (JARs) from external catalogs
(like Metastore) or is this is a separate discussion?
Thanks, Fabian
> Add a function SQL DDL
> --
>
> Key: FLINK-7151
> URL: https://issues.apache.org/jira/browse/FLINK-7151
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: yuemeng
>Assignee: Shuyi Chen
>Priority: Critical
> Fix For: 1.10.0
>
>
> Based on create function and table.we can register a udf,udaf,udtf use sql:
> {code}
> CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS
> class_name [WITH (properties.)];
> DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name;
> ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO
> new_name;
> {code}
> {code}
> CREATE function 'TOPK' AS
> 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF';
> INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP
> BY id;
> {code}
> This ticket can assume that the function class is already loaded in classpath
> by users. Advanced syntax like to how to dynamically load udf libraries from
> external locations can be on a separate ticket.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/126616886) * 166b8777fcc896f3f6ef7008133af35dbb554204 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126619729) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529769037 ## CI report: * cdfb2bf661da8fd51ce52843a0a8d3bac8b78170 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126555210) * 94215849e6feb86c731a8ac931d750645ab446ef : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126635876) * 8af897961d37bb27adaec80f119a0837cc1a1cb8 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14046) DDL property 'format.fields.#.type' should ignore case
hailong wang created FLINK-14046:
Summary: DDL property 'format.fields.#.type' should ignore case
Key: FLINK-14046
URL: https://issues.apache.org/jira/browse/FLINK-14046
Project: Flink
Issue Type: Improvement
Components: Table SQL / API
Affects Versions: 1.9.0
Reporter: hailong wang
Fix For: 1.10.0
When define DDL as follow:
{code:java}
create table RubberOrders(
b int
) with (
'connector.type' = 'filesystem',
'format.type' = 'csv',
'connector.path' = '##',
'format.fields.0.name' = 'b',
'format.fields.0.type' = 'int'
)
{code}
It has an exception:
{code:java}
Could not parse type information at position 0: Unsupported type: int
Input type string: int
at
org.apache.flink.table.utils.TypeStringUtils$TokenConverter.parsingError(TypeStringUtils.java:491)
at
org.apache.flink.table.utils.TypeStringUtils$TokenConverter.convertType(TypeStringUtils.java:318)
at
org.apache.flink.table.utils.TypeStringUtils$TokenConverter.convert(TypeStringUtils.java:261)
at
org.apache.flink.table.utils.TypeStringUtils.readTypeInfo(TypeStringUtils.java:169)
at
org.apache.flink.table.descriptors.DescriptorProperties.lambda$validateType$32(DescriptorProperties.java:1149)
at
org.apache.flink.table.descriptors.DescriptorProperties.validateOptional(DescriptorProperties.java:1357)
at
org.apache.flink.table.descriptors.DescriptorProperties.validateType(DescriptorProperties.java:1143)
at
org.apache.flink.table.descriptors.DescriptorProperties.lambda$validateTableSchema$26(DescriptorProperties.java:1011)
at
org.apache.flink.table.descriptors.DescriptorProperties.validateFixedIndexedProperties(DescriptorProperties.java:998)
at
org.apache.flink.table.descriptors.DescriptorProperties.validateTableSchema(DescriptorProperties.java:1017)
{code}
For the reason we did not ignore case in TypeStringUtils.convertType method.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529768266 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 8af897961d37bb27adaec80f119a0837cc1a1cb8 (Tue Sep 10 15:09:19 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14031).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (FLINK-14045) Rewrite DefaultExecutionSlotAllocator to use SlotProviderStrategy
[ https://issues.apache.org/jira/browse/FLINK-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-14045: Assignee: (was: Gary Yao) > Rewrite DefaultExecutionSlotAllocator to use SlotProviderStrategy > - > > Key: FLINK-14045 > URL: https://issues.apache.org/jira/browse/FLINK-14045 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Coordination >Reporter: Gary Yao >Priority: Major > Fix For: 1.10.0 > > > Currently DefaultExecutionSlotAllocator uses the SlotProvider directly. This > ticket is about rewriting DefaultExecutionSlotAllocator to use > SlotProviderStrategy. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-14045) Rewrite DefaultExecutionSlotAllocator to use SlotProviderStrategy
Gary Yao created FLINK-14045: Summary: Rewrite DefaultExecutionSlotAllocator to use SlotProviderStrategy Key: FLINK-14045 URL: https://issues.apache.org/jira/browse/FLINK-14045 Project: Flink Issue Type: Sub-task Components: Runtime / Coordination Reporter: Gary Yao Assignee: Gary Yao Fix For: 1.10.0 Currently DefaultExecutionSlotAllocator uses the SlotProvider directly. This ticket is about rewriting DefaultExecutionSlotAllocator to use SlotProviderStrategy. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 166b8777fcc896f3f6ef7008133af35dbb554204 (Tue Sep 10 15:04:13 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime]
Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r322797213
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SubmissionTrackingTaskManagerGateway.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.deployment.TaskDeploymentDescriptor;
+import org.apache.flink.runtime.executiongraph.TaskInformation;
+import
org.apache.flink.runtime.executiongraph.utils.SimpleAckingTaskManagerGateway;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.messages.Acknowledge;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.LinkedBlockingDeque;
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+class SubmissionTrackingTaskManagerGateway extends
SimpleAckingTaskManagerGateway {
Review comment:
I think this could be replaced by a test implementation of
`ExecutionVertexOperations`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#issuecomment-526487220 ## CI report: * 3c6c3d69983136fb8bfa11b28a7ba783dfe61e52 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125188905) * a9d65d8fabd938d47abd801a4686cb185f2fcf68 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125206763) * 1bbbce7f1f81598cb5a454f0e4d25adae6ed75b4 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125425831) * d68aa63cea98320f14ff9bbe483776c8873a77ca : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125431268) * 097e1ec9e9e64ad6e9e1de16bc2937acb84ab42e : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/125726843) * 9bc0b14a50cf03c23eb4203aa2637130572047f9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125739773) * ee6669575eb9481fd7181c3a9be52e615f613e8f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125755445) * 712fdb428e78fc0d47262c6c755429a37a6be3eb : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125860362) * 16bac68a7fd82876d0ad2d56c8e7c199dc816d04 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/125884245) * aeb427b0c486080e894d9753b9cfe1e385bdbd95 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126422558) * 589b8dcc5219d83ecbbbf0d79a511e440bb36e9f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126424947) * 180592d9ea193b9f95af525c16804a0e9d411ca2 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126607060) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#issuecomment-526484775 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 180592d9ea193b9f95af525c16804a0e9d411ca2 (Tue Sep 10 15:01:11 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-12958).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529769037 ## CI report: * cdfb2bf661da8fd51ce52843a0a8d3bac8b78170 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126555210) * 94215849e6feb86c731a8ac931d750645ab446ef : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
AHeise commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r322795467
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/Emitter.java
##
@@ -80,9 +88,14 @@ public void run() {
try {
while (running) {
LOG.debug("Wait for next completed async stream
element result.");
- AsyncResult streamElementEntry =
streamElementQueue.peekBlockingly();
-
- output(streamElementEntry);
+ AsyncResult asyncResult =
streamElementQueue.peekBlockingly();
+ executor.submit(() -> {
+ try {
+ output(asyncResult);
+ } catch (InterruptedException e) {
Review comment:
https://issues.apache.org/jira/browse/FLINK-14044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (FLINK-14044) Reducing synchronization in AsyncWaitOperator
[
https://issues.apache.org/jira/browse/FLINK-14044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arvid Heise updated FLINK-14044:
Component/s: Runtime / Task
> Reducing synchronization in AsyncWaitOperator
> -
>
> Key: FLINK-14044
> URL: https://issues.apache.org/jira/browse/FLINK-14044
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Task
>Reporter: Arvid Heise
>Priority: Major
>
> Currently, AsyncWaitOperator receives computed results from a user thread and
> puts it in {{StreamElementQueue}}. This queue is synchronized as the emitter
> thread pulls available elements in a blocking fashion. With the recent
> migration to mailbox model, these elements are then put into a letter to be
> outputted in the mailbox thread.
> If we directly send the results from the user thread to the mailbox, we can
> get rid of any synchronization as everything happens in the user thread. That
> will slim down the code heavily.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (FLINK-14044) Reducing synchronization in AsyncWaitOperator
Arvid Heise created FLINK-14044:
---
Summary: Reducing synchronization in AsyncWaitOperator
Key: FLINK-14044
URL: https://issues.apache.org/jira/browse/FLINK-14044
Project: Flink
Issue Type: Improvement
Reporter: Arvid Heise
Currently, AsyncWaitOperator receives computed results from a user thread and
puts it in {{StreamElementQueue}}. This queue is synchronized as the emitter
thread pulls available elements in a blocking fashion. With the recent
migration to mailbox model, these elements are then put into a letter to be
outputted in the mailbox thread.
If we directly send the results from the user thread to the mailbox, we can get
rid of any synchronization as everything happens in the user thread. That will
slim down the code heavily.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table.
flinkbot edited a comment on issue #9656: [FLINK-14031][examples][table]Added the blink planner dependency and a example which use blink planner to flink-examples-table. URL: https://github.com/apache/flink/pull/9656#issuecomment-529768266 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 94215849e6feb86c731a8ac931d750645ab446ef (Tue Sep 10 14:46:54 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14031).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
flinkbot edited a comment on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#issuecomment-526484775 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 180592d9ea193b9f95af525c16804a0e9d411ca2 (Tue Sep 10 14:44:53 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-12958).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9662: [FLINK-13631] Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint
flinkbot edited a comment on issue #9662: [FLINK-13631] Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint URL: https://github.com/apache/flink/pull/9662#issuecomment-529912596 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 3255ece7ca1a488a57265927c5c35a21b431d557 (Tue Sep 10 14:43:51 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] 1u0 commented on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator
1u0 commented on issue #9564: [FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox for timer triggers, checkpoints and AsyncWaitOperator URL: https://github.com/apache/flink/pull/9564#issuecomment-529969126 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13631) Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint
[
https://issues.apache.org/jira/browse/FLINK-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-13631.
-
Resolution: Done
Done via 0a405251b297109fde1f9a155eff14be4d943887
> Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint
> --
>
> Key: FLINK-13631
> URL: https://issues.apache.org/jira/browse/FLINK-13631
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kinesis, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Update {{FlinkKinesisConsumerMigrationTest}} to restore from 1.9 savepoint.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] tillrohrmann closed pull request #9662: [FLINK-13631] Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint
tillrohrmann closed pull request #9662: [FLINK-13631] Update FlinkKinesisConsumerMigrationTest to restore from 1.9 savepoint URL: https://github.com/apache/flink/pull/9662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
