[GitHub] [flink] curcur edited a comment on pull request #15420: [FLINK-21356] Implement incremental checkpointing and recovery using state changelog

2021-06-20 Thread GitBox


curcur edited a comment on pull request #15420:
URL: https://github.com/apache/flink/pull/15420#issuecomment-864750211


   Mark:
   
   For recovery: Sync offline: did not see non-materialized part applied to the 
delegated state backend. Double confirm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] curcur edited a comment on pull request #15420: [FLINK-21356] Implement incremental checkpointing and recovery using state changelog

2021-06-20 Thread GitBox


curcur edited a comment on pull request #15420:
URL: https://github.com/apache/flink/pull/15420#issuecomment-864750211


   Mark:
   
   For recovery: Sync offline: did not see non-materialized part be applied to 
the delegated state backend. Double confirm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] curcur commented on pull request #15420: [FLINK-21356] Implement incremental checkpointing and recovery using state changelog

2021-06-20 Thread GitBox


curcur commented on pull request #15420:
URL: https://github.com/apache/flink/pull/15420#issuecomment-864750211


   Mark:
   
   Sync offline: did not see non-materialized part be applied to the delegated 
state backend. Double confirm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Issue Comment Deleted] (FLINK-16095) Translate "Modules" page of "Table API & SQL" into Chinese

2021-06-20 Thread zhangzhl (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhangzhl updated FLINK-16095:
-
Comment: was deleted

(was: hi [~jark]

I'm willing to translate this page. Could you assign it to me ?:D)

> Translate "Modules" page of "Table API & SQL" into Chinese
> --
>
> Key: FLINK-16095
> URL: https://issues.apache.org/jira/browse/FLINK-16095
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Priority: Major
>  Labels: auto-unassigned, pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/modules.html
> The markdown file is located in {{flink/docs/dev/table/modules.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (FLINK-16152) Translate "Operator/index" into Chinese

2021-06-20 Thread zhangzhl (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhangzhl updated FLINK-16152:
-
Comment: was deleted

(was: hi,[~jark],

I'm willing to translate this page. Could you assign it to me ?:D)

> Translate "Operator/index" into Chinese
> ---
>
> Key: FLINK-16152
> URL: https://issues.apache.org/jira/browse/FLINK-16152
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Yun Gao
>Priority: Major
>  Labels: auto-unassigned, pull-request-available
> Fix For: 1.14.0
>
>
> The page is located at _docs/dev/stream/operators/index.zh.md_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FLINK-17647) Improve new connector options exception in old planner

2021-06-20 Thread Jira


 [ 
https://issues.apache.org/jira/browse/FLINK-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ingo Bürk closed FLINK-17647.
-
Resolution: Won't Do

I'll take the liberty to close this issue since the legacy planner has been 
removed.

> Improve new connector options exception in old planner
> --
>
> Key: FLINK-17647
> URL: https://issues.apache.org/jira/browse/FLINK-17647
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Legacy Planner
>Reporter: Jark Wu
>Priority: Major
>
> Currently, if users use new factory in old planner, the exception is 
> misleading. We should improve the excecption in old planner to tell users 
> "maybe should use blink planner". 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (FLINK-17647) Improve new connector options exception in old planner

2021-06-20 Thread Jira


 [ 
https://issues.apache.org/jira/browse/FLINK-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ingo Bürk updated FLINK-17647:
--
Comment: was deleted

(was: I'll take the liberty to close this issue since the legacy planner has 
been removed.)

> Improve new connector options exception in old planner
> --
>
> Key: FLINK-17647
> URL: https://issues.apache.org/jira/browse/FLINK-17647
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Legacy Planner
>Reporter: Jark Wu
>Priority: Major
>
> Currently, if users use new factory in old planner, the exception is 
> misleading. We should improve the excecption in old planner to tell users 
> "maybe should use blink planner". 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17647) Improve new connector options exception in old planner

2021-06-20 Thread Jira


[ 
https://issues.apache.org/jira/browse/FLINK-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366387#comment-17366387
 ] 

Ingo Bürk commented on FLINK-17647:
---

I'll take the liberty to close this issue since the legacy planner has been 
removed.

> Improve new connector options exception in old planner
> --
>
> Key: FLINK-17647
> URL: https://issues.apache.org/jira/browse/FLINK-17647
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Legacy Planner
>Reporter: Jark Wu
>Priority: Major
>
> Currently, if users use new factory in old planner, the exception is 
> misleading. We should improve the excecption in old planner to tell users 
> "maybe should use blink planner". 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #16141: [FLINK-22970][docs] The documentation for `TO_TIMESTAMP` UDF has an incorrect description

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16141:
URL: https://github.com/apache/flink/pull/16141#issuecomment-859291183


   
   ## CI report:
   
   * 07736d279cca52434c2f4ee87f508231eaa33e6c Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18906)
 
   * 84822265932ad5984e5521bbff9bb7d670f863ae UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #16213: [FLINK-22788][table-planner-blink] Support equalisers for many fields

2021-06-20 Thread GitBox


flinkbot commented on pull request #16213:
URL: https://github.com/apache/flink/pull/16213#issuecomment-864743785


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit bdaa7c50db5cb9ef1942e5cbe08c88ab82172561 (Mon Jun 21 
05:40:31 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-22788) Code of equals method grows beyond 64 KB

2021-06-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-22788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-22788:
---
Labels: pull-request-available  (was: )

> Code of equals method grows beyond 64 KB
> 
>
> Key: FLINK-22788
> URL: https://issues.apache.org/jira/browse/FLINK-22788
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Runtime
>Affects Versions: 1.12.2
>Reporter: Maciej Bryński
>Assignee: Ingo Bürk
>Priority: Major
>  Labels: pull-request-available
>
> I'm getting following exception when running SQL with many (more than 500) 
> columns
> {code:java}
> java.lang.RuntimeException: Could not instantiate generated class 
> 'GroupAggValueEqualiser$38011'
> at 
> org.apache.flink.table.runtime.generated.GeneratedClass.newInstance(GeneratedClass.java:56)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.operators.aggregate.GroupAggFunction.open(GroupAggFunction.java:112)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.api.common.functions.util.FunctionUtils.openFunction(FunctionUtils.java:34)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]at 
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.open(AbstractUdfStreamOperator.java:102)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.api.operators.KeyedProcessOperator.open(KeyedProcessOperator.java:55)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain.initializeStateAndOpenOperators(OperatorChain.java:428)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.lambda$beforeInvoke$2(StreamTask.java:543)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.runThrowing(StreamTaskActionExecutor.java:50)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.beforeInvoke(StreamTask.java:533)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:573)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:755) 
> ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:570) 
> ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_282]
> Caused by: org.apache.flink.util.FlinkRuntimeException: 
> org.apache.flink.api.common.InvalidProgramException: Table program cannot be 
> compiled. This is a bug. Please file an issue.
> at 
> org.apache.flink.table.runtime.generated.CompileUtils.compile(CompileUtils.java:76)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.generated.GeneratedClass.compile(GeneratedClass.java:77)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.generated.GeneratedClass.newInstance(GeneratedClass.java:50)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> ... 12 more
> Caused by: 
> org.apache.flink.shaded.guava18.com.google.common.util.concurrent.UncheckedExecutionException:
>  org.apache.flink.api.common.InvalidProgramException: Table program cannot be 
> compiled. This is a bug. Please file an issue.
> at 
> org.apache.flink.shaded.guava18.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2203)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.shaded.guava18.com.google.common.cache.LocalCache.get(LocalCache.java:3937)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]at 
> org.apache.flink.shaded.guava18.com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4739)
>  ~[flink-dist_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.generated.CompileUtils.compile(CompileUtils.java:74)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.generated.GeneratedClass.compile(GeneratedClass.java:77)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> at 
> org.apache.flink.table.runtime.generated.GeneratedClass.newInstance(GeneratedClass.java:50)
>  ~[flink-table-blink_2.12-1.12.2-stream2.jar:1.12.2-stream2]
> ... 12 more
> Caused by: 

[GitHub] [flink] Airblader opened a new pull request #16213: [FLINK-22788][table-planner-blink] Support equalisers for many fields

2021-06-20 Thread GitBox


Airblader opened a new pull request #16213:
URL: https://github.com/apache/flink/pull/16213


   ## What is the purpose of the change
   
   When working with hundreds of fields, equalisers can fail to compile
   because the method body grows beyond 64kb. With this change, instead of
   generating all code into one method, we generate a dedicated method per
   field and then call all of those methods. This doesn't entirely remove
   the problem, but supports roughly a factor of 10 more fields and is
   currently deemed sufficient.
   
   ## Brief change log
   
   - Adjust `EqualiserCodeGenerator` to generate one method per field and call 
those methods.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `EqualiserCodeGeneratorTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): yes
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread Xintong Song (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xintong Song closed FLINK-23042.

Resolution: Fixed

Subsumed by #16162

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, pull-request-available, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] xintongsong closed pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


xintongsong closed pull request #16212:
URL: https://github.com/apache/flink/pull/16212


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] xintongsong commented on pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


xintongsong commented on pull request #16212:
URL: https://github.com/apache/flink/pull/16212#issuecomment-864740564


   Hi @RollsBean, thanks for preparing the PR.
   
   It seems another contributor has also noticed the problem and fixed it a 
couple hours ago. So this PR is no longer necessary.
   
   Additionally, the PR itself does not fix the problem in a proper way. It is 
preferred not to hardcode the version-specific absolute path in the markdown 
files.
   
   Thanks for you contribution anyway. I'm closing this PR, as well as the 
corresponding jira ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16163: [FLINK-22994][Table SQL / Planner] improve the performace of invoking…

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16163:
URL: https://github.com/apache/flink/pull/16163#issuecomment-861284972


   
   ## CI report:
   
   * 00f7cd34fc503db8cc116dd201bcc7f54a4b6f20 UNKNOWN
   * da303c24e513b0678794526c6351003b6e76cb6d UNKNOWN
   * 3fbfde5408130b93d98979dc2fcc4fa10563c9fc Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19073)
 
   * f09df165b7b7c129c2c1ead44f934d3ced8deb65 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19192)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16212:
URL: https://github.com/apache/flink/pull/16212#issuecomment-864708536


   
   ## CI report:
   
   * 3177431ef14291ae912b37f27983049d48158a02 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19190)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864682204


   
   ## CI report:
   
   * ac28fa57c35305feb56c9825f360bc32d0547db9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19182)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16163: [FLINK-22994][Table SQL / Planner] improve the performace of invoking…

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16163:
URL: https://github.com/apache/flink/pull/16163#issuecomment-861284972


   
   ## CI report:
   
   * 00f7cd34fc503db8cc116dd201bcc7f54a4b6f20 UNKNOWN
   * da303c24e513b0678794526c6351003b6e76cb6d UNKNOWN
   * 3fbfde5408130b93d98979dc2fcc4fa10563c9fc Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19073)
 
   * f09df165b7b7c129c2c1ead44f934d3ced8deb65 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16161: [FLINK-22993][filesystem] Fix the issue that CompactFileWriter won't emit EndCheckpoint with Long.MAX_VALUE checkpointId even though

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16161:
URL: https://github.com/apache/flink/pull/16161#issuecomment-861259205


   
   ## CI report:
   
   * 742e4e8c3622802e1dcf7cf5fb020a5bd656a40d Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18985)
 
   * d1b195acf8fe2af08c5f3c8fdb7c13a4a0ed3c31 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19189)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16148: [FLINK-22617][Hive]Add log for hive source that use native or mapred reader

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16148:
URL: https://github.com/apache/flink/pull/16148#issuecomment-859467607


   
   ## CI report:
   
   * 86e49e125d78c43cdc415f15ee7056ffd770da54 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18926)
 
   * dcba2c6078b67085c19dfe506d0597d3448bbde6 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19188)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #15410: [FLINK-22008][runtime/checkpointing] add commit logic for checkpoint

2021-06-20 Thread GitBox


Myasuka commented on pull request #15410:
URL: https://github.com/apache/flink/pull/15410#issuecomment-864713425


   @zhougit86 Shall we close this PR now and have more discussion in 
https://issues.apache.org/jira/browse/FLINK-17808
   ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


Myasuka commented on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864710557


   > > Thanks for the contribution, I wonder only three lines in the 
documentation have typos?
   > 
   > No, there are tons of typos. I don't have enough time to fix all of them. 
you can run a full typo check by yourself.
   > 
   > checker I wrote: https://www.github.com/raywill/codetypo
   
   If you decided to fix typos in Flink docs, why not try your best to fix them 
all? This PR includes three typos and others could create more PRs with 
different number fix of typos, which actually makes the progress endless.
   We can try to fix all typos at some intervals but only fixing three lines 
sometimes, especially we know there exist many typos, would waste reviewer's 
energy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


flinkbot commented on pull request #16212:
URL: https://github.com/apache/flink/pull/16212#issuecomment-864708536


   
   ## CI report:
   
   * 3177431ef14291ae912b37f27983049d48158a02 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16161: [FLINK-22993][filesystem] Fix the issue that CompactFileWriter won't emit EndCheckpoint with Long.MAX_VALUE checkpointId even though

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16161:
URL: https://github.com/apache/flink/pull/16161#issuecomment-861259205


   
   ## CI report:
   
   * 742e4e8c3622802e1dcf7cf5fb020a5bd656a40d Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18985)
 
   * d1b195acf8fe2af08c5f3c8fdb7c13a4a0ed3c31 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16153: [FLINK-22678] Configurations and user APIs for ChangelogStateBackend

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16153:
URL: https://github.com/apache/flink/pull/16153#issuecomment-861162068


   
   ## CI report:
   
   * 50b2100f9a62e662d6cb4a7ec111d3e73b9cd843 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19165)
 
   * 1ef3786ca933d1bf675706d2f4f204314f3b540b Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19186)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16148: [FLINK-22617][Hive]Add log for hive source that use native or mapred reader

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16148:
URL: https://github.com/apache/flink/pull/16148#issuecomment-859467607


   
   ## CI report:
   
   * 86e49e125d78c43cdc415f15ee7056ffd770da54 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18926)
 
   * dcba2c6078b67085c19dfe506d0597d3448bbde6 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

2021-06-20 Thread GitBox


Myasuka commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-864707829


   I have closed FLINK-23012 and also pick your PR to release-1.13 branch with 
removal of adding previous docs link in 3964761b80d2dce532d04704d1a3f4b097a8c5eb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] raywill commented on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


raywill commented on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864705138


   > Thanks for the contribution, I wonder only three lines in the 
documentation have typos?
   
   No, there are tons of typos. I don't have enough time to fix all of them. 
you can run a full typo check by yourself.
   
   checker I wrote: https://www.github.com/raywill/codetypo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (FLINK-23012) Add v1.13 docs link in "Pick Docs Version" for master branch

2021-06-20 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang resolved FLINK-23012.
--
Resolution: Fixed

> Add v1.13 docs link in "Pick Docs Version" for master branch
> 
>
> Key: FLINK-23012
> URL: https://issues.apache.org/jira/browse/FLINK-23012
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 1.14.0
>Reporter: Jark Wu
>Priority: Major
> Fix For: 1.14.0
>
> Attachments: image-2021-06-17-10-26-29-125.png
>
>
> https://ci.apache.org/projects/flink/flink-docs-master/
>  !image-2021-06-17-10-26-29-125.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23012) Add v1.13 docs link in "Pick Docs Version" for master branch

2021-06-20 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang updated FLINK-23012:
-
Fix Version/s: 1.14.0

> Add v1.13 docs link in "Pick Docs Version" for master branch
> 
>
> Key: FLINK-23012
> URL: https://issues.apache.org/jira/browse/FLINK-23012
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 1.14.0
>Reporter: Jark Wu
>Priority: Major
> Fix For: 1.14.0
>
> Attachments: image-2021-06-17-10-26-29-125.png
>
>
> https://ci.apache.org/projects/flink/flink-docs-master/
>  !image-2021-06-17-10-26-29-125.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23012) Add v1.13 docs link in "Pick Docs Version" for master branch

2021-06-20 Thread Yun Tang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366363#comment-17366363
 ] 

Yun Tang commented on FLINK-23012:
--

Fixed by a hotfix: 73b3d10613d95a399f60c982f94a740b4e777b3d

> Add v1.13 docs link in "Pick Docs Version" for master branch
> 
>
> Key: FLINK-23012
> URL: https://issues.apache.org/jira/browse/FLINK-23012
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 1.14.0
>Reporter: Jark Wu
>Priority: Major
> Fix For: 1.14.0
>
> Attachments: image-2021-06-17-10-26-29-125.png
>
>
> https://ci.apache.org/projects/flink/flink-docs-master/
>  !image-2021-06-17-10-26-29-125.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread kevin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366362#comment-17366362
 ] 

kevin edited comment on FLINK-23042 at 6/21/21, 3:50 AM:
-

Thanks a lot [~xintongsong], PR created, number: #16212, from: 
RollsBean:FLINK-23042


was (Author: rollsbean):
Thanks a lot [~xintongsong]

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, pull-request-available, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] tony810430 commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

2021-06-20 Thread GitBox


tony810430 commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-864703592


   Hi @Myasuka 
   
   Thanks for the reviewing. I will remember to create a JIRA ticket next time.
   besides, I think 
[FLINK-23012](https://issues.apache.org/jira/browse/FLINK-23012) is also 
addressed in this PR. could you help to close this issue as well? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka merged pull request #16162: [hotfix][docs] fix img links and previous docs link

2021-06-20 Thread GitBox


Myasuka merged pull request #16162:
URL: https://github.com/apache/flink/pull/16162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread kevin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366362#comment-17366362
 ] 

kevin commented on FLINK-23042:
---

Thanks a lot [~xintongsong]

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, pull-request-available, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


flinkbot commented on pull request #16212:
URL: https://github.com/apache/flink/pull/16212#issuecomment-864702375


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 3177431ef14291ae912b37f27983049d48158a02 (Mon Jun 21 
03:44:06 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-15024) System classloader memory leak after loading too many codegen classes.

2021-06-20 Thread Yingjie Cao (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingjie Cao updated FLINK-15024:

Labels:   (was: stale-major)

> System classloader memory leak after loading too many codegen classes.
> --
>
> Key: FLINK-15024
> URL: https://issues.apache.org/jira/browse/FLINK-15024
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Runtime
>Reporter: Yingjie Cao
>Priority: Major
>
> We are using Flink session cluster as a service for ad-hoc queries. After 
> running some queries, we found that the memory usage of TaskManager grows and 
> cannot be garbage collected. Eventually, we found that it was the object 
> (class name and lock object) in parallelLockMap of AppClassloader and 
> ExtClassloader cannot be recycled. And we found the classes were generated 
> ones and should be never loaded by system classloader.
> The codegen classes are loaded by org.codehaus.janino.ByteArrayClassLoader 
> which is a parent first classloader and will rely  on its parent classloader, 
> e.g. Flink user classloader to load the class first, flink user classloader 
> will also try to load the class with its parent classloader, and finally it 
> will reach AppClassloader and ExtClassloader. Both the AppClassloader and 
> ExtClassloader are SecureClassLoader and will add class name and a lock 
> object to the parallelLockMap when loading a new class.
> I think we should never let the system classloader try to load the generated 
> classes which is doomed to fail. We need to prune the process of loading 
> codegen classes and avoid those classes reaching the system classloader. Two 
> ways can achieve that:
>  # We give a special prefix to codegen class name and filter class with those 
> prefix in Flink user classloader.
>  # We implement a new child first classloader which filters the codegen class 
> and never loads the codegen class with Flink user classloader and set this 
> class loader as the parent classloader of 
> org.codehaus.janino.ByteArrayClassLoader instead of the Flink user 
> classloader.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-23042:
---
Labels: docs documentation-update pull-request-available zh_CN  (was: docs 
documentation-update zh_CN)

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, pull-request-available, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-06-20 Thread Yingjie Cao (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingjie Cao updated FLINK-21788:

Labels: pull-request-available  (was: pull-request-available stale-assigned)

> Throw PartitionNotFoundException if the partition file has been lost for 
> blocking shuffle
> -
>
> Key: FLINK-21788
> URL: https://issues.apache.org/jira/browse/FLINK-21788
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.9.3, 1.10.3, 1.11.3, 1.12.2
>Reporter: Yingjie Cao
>Assignee: Yingjie Cao
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently, if the partition file has been lost for blocking shuffle, 
> FileNotFoundException will be thrown and the partition data is not 
> regenerated, so failover can not recover the job. It should throw 
> PartitionNotFoundException instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] RollsBean opened a new pull request #16212: [FLINK-23042][docs-zh] Correct docs-zh picture fraud-transactions.svg…

2021-06-20 Thread GitBox


RollsBean opened a new pull request #16212:
URL: https://github.com/apache/flink/pull/16212


   … src
   
   
   
   ## What is the purpose of the change
   
   *(This pull request fix Flink Chinese doc 
[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/learn-flink/datastream_api/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/learn-flink/datastream_api/)
 DataStream API picture display issue.)*
   
   
   ## Brief change log
   
   *(doc-zh:)*
 - *Display the correct picture in doc-zh DataStream API*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   Following the Flink contribute-documentation, I run **build_docs.sh** in 
local using hugo and checked the documentation page.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16211: [FLINK-16952][Connectors/Parquet] Parquet file format support filter push down.

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16211:
URL: https://github.com/apache/flink/pull/16211#issuecomment-864689257


   
   ## CI report:
   
   * 33aec918ba974f8c0a0ccfd4ed3ceb9a91a6fdb5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19185)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16153: [FLINK-22678] Configurations and user APIs for ChangelogStateBackend

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16153:
URL: https://github.com/apache/flink/pull/16153#issuecomment-861162068


   
   ## CI report:
   
   * 50b2100f9a62e662d6cb4a7ec111d3e73b9cd843 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19165)
 
   * 1ef3786ca933d1bf675706d2f4f204314f3b540b UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366357#comment-17366357
 ] 

Yun Gao edited comment on FLINK-22085 at 6/21/21, 3:38 AM:
---

I checked the last several cases, it seems they are all hang at 
testMultipleSourcesOnePartition(org.apache.flink.connector.kafka.source.KafkaSourceLegacyITCase)
 with the last log shows
{code:java}
01:34:47,793 [Checkpoint Timer] INFO  
org.apache.flink.runtime.checkpoint.CheckpointCoordinator[] - Failed to 
trigger checkpoint for job d9229593ea3e8c25751e0b146ba62ee1 since some tasks of 
job d9229593ea3e8c25751e0b146ba62ee1 has been finished, abort the checkpoint 
Failure reason: Not all required tasks are currently running.
{code}
I'll first focus on this issue.


was (Author: gaoyunhaii):
I checked the last several cases, it seems they are all failed at 
testMultipleSourcesOnePartition(org.apache.flink.connector.kafka.source.KafkaSourceLegacyITCase)
  with the last log shows

{code:java}
01:34:47,793 [Checkpoint Timer] INFO  
org.apache.flink.runtime.checkpoint.CheckpointCoordinator[] - Failed to 
trigger checkpoint for job d9229593ea3e8c25751e0b146ba62ee1 since some tasks of 
job d9229593ea3e8c25751e0b146ba62ee1 has been finished, abort the checkpoint 
Failure reason: Not all required tasks are currently running.
{code}

I'll first focus on this issue.

> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to 

[GitHub] [flink] curcur commented on a change in pull request #15420: [FLINK-21356] Implement incremental checkpointing and recovery using state changelog

2021-06-20 Thread GitBox


curcur commented on a change in pull request #15420:
URL: https://github.com/apache/flink/pull/15420#discussion_r654946468



##
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##
@@ -114,13 +128,33 @@
 
 private final StateChangelogWriter stateChangelogWriter;
 
+private long lastCheckpointId = -1L;
+
 /** last accessed partitioned state. */
 @SuppressWarnings("rawtypes")
 private InternalKvState lastState;
 
 /** For caching the last accessed partitioned state. */
 private String lastName;
 
+/** Updated initially on restore and later upon materialization (after 
FLINK-21356). */
+private final List materialized = new ArrayList<>();

Review comment:
   this should be changeable right, after each time after materialization 
finishes.
   remove final?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Dong Lin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366359#comment-17366359
 ] 

Dong Lin commented on FLINK-22085:
--

[~gaoyunhaii] Thanks for the investigation. Previously I have looked into this 
particular INFO message. From what I know, it appears to be expected by this 
test.

What happens is that some subtask (e.g. 7 out of 8 subtasks) have finished 
correctly when the checkpoint is triggered. And Flink would not take the 
checkpoint if any subtask has finished.

The issue here is that a subtask never finishes. According to the logic of this 
particular test, this could be because the sink of this subtask never received 
the expected number of messages, which I could not find any explanation so far.


> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to this channel if it is called on 
> this channel again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] luoyuxia commented on pull request #16161: [FLINK-22993][filesystem] Fix the issue that CompactFileWriter won't emit EndCheckpoint with Long.MAX_VALUE checkpointId even though the inp

2021-06-20 Thread GitBox


luoyuxia commented on pull request #16161:
URL: https://github.com/apache/flink/pull/16161#issuecomment-864698057


   @JingsongLi Now, I have added test to check emiting EndCheckpoint with 
Long.MAX_VALUE when end of input in CompactFileWriterTest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] hehuiyuan edited a comment on pull request #16148: [FLINK-22617][Hive]Add log for hive source that use native or mapred reader

2021-06-20 Thread GitBox


hehuiyuan edited a comment on pull request #16148:
URL: https://github.com/apache/flink/pull/16148#issuecomment-864694544


   > Thanks @hehuiyuan for working on this. Since a reader is created for every 
split, will it be more useful if we also print the split in the logs? Besides, 
maybe it's better to print at DEBUG level. Big jobs can easily have thousands 
of splits. Printing a message for each of them at INFO level seems too verbose 
to me.
   
   Hi @lirui-apache ,  yes, there are many unuseful log.
   Originally, I was going to use debug,  but I'll revise it after you confirm 
and reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] hehuiyuan commented on pull request #16148: [FLINK-22617][Hive]Add log for hive source that use native or mapred reader

2021-06-20 Thread GitBox


hehuiyuan commented on pull request #16148:
URL: https://github.com/apache/flink/pull/16148#issuecomment-864694544


   > Thanks @hehuiyuan for working on this. Since a reader is created for every 
split, will it be more useful if we also print the split in the logs? Besides, 
maybe it's better to print at DEBUG level. Big jobs can easily have thousands 
of splits. Printing a message for each of them at INFO level seems too verbose 
to me.
   
   Hi @lirui-apache ,  yes, it is many unuseful log.
   Originally, I was going to use debug,  but I'll revise it after you confirm 
and reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-23052) cron_snapshot_deployment_maven unstable on maven

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23052:


 Summary: cron_snapshot_deployment_maven unstable on maven
 Key: FLINK-23052
 URL: https://issues.apache.org/jira/browse/FLINK-23052
 Project: Flink
  Issue Type: Improvement
  Components: Test Infrastructure
Reporter: Xintong Song


{{cron_snapshot_deployment_maven}}, the cron build on azure that deploys 
snapshot artifacts to maven central repository, has become unstable recently.

The failures fall into two categories.
- Maven failed to upload/download an artifact
- The stage overall takes too long time.

As far as I can see, the instability starts being observed since June 18th.

Observed instances:

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19152=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19154=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19167=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19169=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19176=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19175=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19177=logs=eca6b3a6-1600-56cc-916a-c549b3cde3ff=e9844b5e-5aa3-546b-6c3e-5395c7c0cac7



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-23051) Savepoint an application for source of cdc-kafka, then restart the application from the savepoint, offset not be recovered.

2021-06-20 Thread Carl (Jira)
Carl created FLINK-23051:


 Summary: Savepoint an application for source of cdc-kafka, then 
restart the application from the savepoint, offset not be recovered.  
 Key: FLINK-23051
 URL: https://issues.apache.org/jira/browse/FLINK-23051
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Checkpointing, Table SQL / Client
Affects Versions: 1.12.1
 Environment: flink 1.12.1
Reporter: Carl
 Fix For: 1.14.0
 Attachments: image-2021-06-21-10-51-10-104.png, 
image-2021-06-21-10-51-27-105.png, image-2021-06-21-10-52-07-814.png, 
image-2021-06-21-10-52-45-724.png, image-2021-06-21-10-53-03-384.png, 
image-2021-06-21-10-53-14-940.png, image-2021-06-21-10-54-30-241.png, 
image-2021-06-21-10-57-11-824.png, image-2021-06-21-11-09-48-975.png, 
image-2021-06-21-11-10-32-942.png

1. source: custom ogg-kafka

2. transform: group agg

3. sink: hbase

Program as follows:

!image-2021-06-21-10-54-30-241.png!

!image-2021-06-21-11-09-48-975.png!

!image-2021-06-21-10-52-07-814.png!

 

Execute the command in turn:

!image-2021-06-21-10-57-11-824.png!

 

What puzzles me is that Flink Kafka consumers don't consume source from 
savepoint: 

!image-2021-06-21-11-10-32-942.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] Zakelly commented on a change in pull request #16153: [FLINK-22678] Configurations and user APIs for ChangelogStateBackend

2021-06-20 Thread GitBox


Zakelly commented on a change in pull request #16153:
URL: https://github.com/apache/flink/pull/16153#discussion_r655046921



##
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##
@@ -607,6 +612,53 @@ public StateBackend getStateBackend() {
 return defaultStateBackend;
 }
 
+/**
+ * Enable the change log for current state backend. this changelog allows 
operators to persist
+ * state changes in a very fine-grained manner, as described below:
+ *
+ * Stateful operators write the state changes to that log (logging the 
state), in addition to
+ * applying them to the state tables in RocksDB or the in-mem Hashtable.
+ *
+ * An operator can acknowledge a checkpoint as soon as the changes in 
the log have reached
+ * the durable checkpoint storage.
+ *
+ * The state tables are persisted periodically, independent of the 
checkpoints. We call this
+ * the materialization of the state on the checkpoint storage.
+ *
+ * Once the state is materialized on checkpoint storage, the state 
changelog can be truncated
+ * to the corresponding point.
+ *
+ * It establish a way to drastically reduce the checkpoint interval for 
streaming
+ * applications across state backends. For more details please check the 
FLIP-158.
+ *
+ * If this method is not called explicitly, it means no preference for 
enabling the change
+ * log. Configs for change log enabling will override in different config 
levels
+ * (job/local/cluster).
+ *
+ * @param enabled true if enable the change log for state backend 
explicitly, otherwise disable
+ * the change log.
+ * @return This StreamExecutionEnvironment itself, to allow chaining of 
function calls.
+ * @see #isChangelogStateBackendEnabled()
+ */
+@PublicEvolving
+public StreamExecutionEnvironment enableChangelogStateBackend(boolean 
enabled) {

Review comment:
   Sure thing, at 
[1ef3786](https://github.com/apache/flink/pull/16153/commits/1ef3786ca933d1bf675706d2f4f204314f3b540b).
   And as for the python datastream API, I left it unimplemented. I'll create 
another PR for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366357#comment-17366357
 ] 

Yun Gao commented on FLINK-22085:
-

I checked the last several cases, it seems they are all failed at 
testMultipleSourcesOnePartition(org.apache.flink.connector.kafka.source.KafkaSourceLegacyITCase)
  with the last log shows

{code:java}
01:34:47,793 [Checkpoint Timer] INFO  
org.apache.flink.runtime.checkpoint.CheckpointCoordinator[] - Failed to 
trigger checkpoint for job d9229593ea3e8c25751e0b146ba62ee1 since some tasks of 
job d9229593ea3e8c25751e0b146ba62ee1 has been finished, abort the checkpoint 
Failure reason: Not all required tasks are currently running.
{code}

I'll first focus on this issue.

> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to this channel if it is called on 
> this channel again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FLINK-23050) Add Chinese version of documentation of unaligned checkpoint

2021-06-20 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang reassigned FLINK-23050:


Assignee: Han Yin

> Add Chinese version of documentation of unaligned checkpoint
> 
>
> Key: FLINK-23050
> URL: https://issues.apache.org/jira/browse/FLINK-23050
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Runtime / Checkpointing
>Reporter: Yun Tang
>Assignee: Han Yin
>Priority: Major
> Fix For: 1.14.0
>
>
> Currently, the part of Chinese version documentation of unaligned checkpoint 
> is missing. As FLINK-23037 gives limitations of unaligned checkpoint, the PR 
> of this ticket should also include the content of that ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #16211: [FLINK-16952][Connectors/Parquet] Parquet file format support filter push down.

2021-06-20 Thread GitBox


flinkbot commented on pull request #16211:
URL: https://github.com/apache/flink/pull/16211#issuecomment-864689257


   
   ## CI report:
   
   * 33aec918ba974f8c0a0ccfd4ed3ceb9a91a6fdb5 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864682204


   
   ## CI report:
   
   * ac28fa57c35305feb56c9825f360bc32d0547db9 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19182)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16179: [TESTING] Try to reproduce FLINK-22891

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16179:
URL: https://github.com/apache/flink/pull/16179#issuecomment-863055916


   
   ## CI report:
   
   * 1fddc9fa74da8400c9869aeea87038bcec3257fe Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19108)
 
   * 7e7b0c0d820d70a132c4c2f78d955bb1693c0ff8 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19181)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-23044) fix typos in docs

2021-06-20 Thread Huang Yu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Yu updated FLINK-23044:
-
Description: 
using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
typos in Flink documents.

Some are false alarms, some are real typos which need to be fixed.

 

 

 

{color:#505f79}[xiaochu.yh ~/tools/codetypo] (main) $python checker.py 
flink/docs/{color}

{color:#505f79}flink/docs/README.md{color}
 {color:#505f79} ommitted (suggestion: omitted){color}
 {color:#505f79} groupd (suggestion: group){color}
 {color:#505f79} artfiact (suggestion: artifact){color}
 {color:#505f79} sometab (suggestion: sometag){color}
 {color:#505f79} verison (suggestion: verion){color}
 {color:#505f79} pgenerate (suggestion: generate){color}
 {color:#505f79} harnesses (suggestion: harnessed){color}
 {color:#505f79} flavored (suggestion: favored){color}
 {color:#505f79} shortcode (suggestion: sortcode){color}
 {color:#505f79} flinks (suggestion: blinks){color}

{color:#505f79}flink/docs/assets/github.css{color}
 {color:#505f79} lntable (suggestion: ntable){color}
 {color:#505f79} affix (suggestion: affin){color}
 {color:#505f79} cc (suggestion: fffcc){color}
 {color:#505f79} subheading (suggestion: subheadings){color}

{color:#505f79}flink/docs/assets/_fonts.scss{color}
 {color:#505f79} lucida (suggestion: lucina){color}
 {color:#505f79} arial (suggestion: ariel){color}

{color:#505f79}flink/docs/layouts/partials/docs/simple-title.html{color}
 {color:#505f79} sytling (suggestion: styling){color}

{color:#505f79}flink/docs/layouts/partials/docs/inject/menu-after.html{color}
 {color:#505f79} dictonary (suggestion: dictionary){color}

{color:#505f79}flink/docs/layouts/shortcodes/version.html{color}
 {color:#505f79} parmeters (suggestion: pameters){color}
 {color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79}flink/docs/layouts/shortcodes/beta.html{color}
 {color:#505f79} guaruntees (suggestion: guarantees){color}

{color:#505f79}flink/docs/layouts/shortcodes/stable.html{color}
 {color:#505f79} parmeters (suggestion: pameters){color}
 {color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79} {color}

 

BTW: Codetypo can also check code typos. I just have no time to run over it.

 

 

  was:
using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
typos in Flink documents.

 

 

{color:#505f79}[xiaochu.yh ~/tools/codetypo] (main) $python checker.py 
flink/docs/{color}

{color:#505f79}flink/docs/README.md{color}
{color:#505f79} ommitted (suggestion: omitted){color}
{color:#505f79} groupd (suggestion: group){color}
{color:#505f79} artfiact (suggestion: artifact){color}
{color:#505f79} sometab (suggestion: sometag){color}
{color:#505f79} verison (suggestion: verion){color}
{color:#505f79} pgenerate (suggestion: generate){color}
{color:#505f79} harnesses (suggestion: harnessed){color}
{color:#505f79} flavored (suggestion: favored){color}
{color:#505f79} shortcode (suggestion: sortcode){color}
{color:#505f79} flinks (suggestion: blinks){color}

{color:#505f79}flink/docs/assets/github.css{color}
{color:#505f79} lntable (suggestion: ntable){color}
{color:#505f79} affix (suggestion: affin){color}
{color:#505f79} cc (suggestion: fffcc){color}
{color:#505f79} subheading (suggestion: subheadings){color}

{color:#505f79}flink/docs/assets/_fonts.scss{color}
{color:#505f79} lucida (suggestion: lucina){color}
{color:#505f79} arial (suggestion: ariel){color}

{color:#505f79}flink/docs/layouts/partials/docs/simple-title.html{color}
{color:#505f79} sytling (suggestion: styling){color}

{color:#505f79}flink/docs/layouts/partials/docs/inject/menu-after.html{color}
{color:#505f79} dictonary (suggestion: dictionary){color}

{color:#505f79}flink/docs/layouts/shortcodes/version.html{color}
{color:#505f79} parmeters (suggestion: pameters){color}
{color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79}flink/docs/layouts/shortcodes/beta.html{color}
{color:#505f79} guaruntees (suggestion: guarantees){color}

{color:#505f79}flink/docs/layouts/shortcodes/stable.html{color}
{color:#505f79} parmeters (suggestion: pameters){color}
{color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79} {color}

 

Some false alarm, some are real typos which need to be fixed.

Codetypo can also check code typos. I just have no time to run over it.

 

 


> fix typos in docs
> -
>
> Key: FLINK-23044
> URL: https://issues.apache.org/jira/browse/FLINK-23044
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Huang Yu
>Priority: Minor
>  Labels: pull-request-available, typo
> Fix For: 1.14.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons 

[jira] [Created] (FLINK-23050) Add Chinese version of documentation of unaligned checkpoint

2021-06-20 Thread Yun Tang (Jira)
Yun Tang created FLINK-23050:


 Summary: Add Chinese version of documentation of unaligned 
checkpoint
 Key: FLINK-23050
 URL: https://issues.apache.org/jira/browse/FLINK-23050
 Project: Flink
  Issue Type: Bug
  Components: Documentation, Runtime / Checkpointing
Reporter: Yun Tang
 Fix For: 1.14.0


Currently, the part of Chinese version documentation of unaligned checkpoint is 
missing. As FLINK-23037 gives limitations of unaligned checkpoint, the PR of 
this ticket should also include the content of that ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366353#comment-17366353
 ] 

Xintong Song commented on FLINK-23042:
--

Usually, you only need to open PRs on the master branch. Once the PR is merged, 
the committer should backport it to other branches if needed.

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23018) State factories should handle extended state descriptors

2021-06-20 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang updated FLINK-23018:
-
Fix Version/s: 1.13.2

> State factories should handle extended state descriptors
> 
>
> Key: FLINK-23018
> URL: https://issues.apache.org/jira/browse/FLINK-23018
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0, 1.13.2
>
>
> Currently, {{TtlStateFactory}} and other state factories can only handle 
> fixed type of state descriptors. As {{ValueStateDescriptor}} is not a final 
> class and user could still extend it, however, {{TtlStateFactory}} cannot 
> recognize the extending class.
>  {{TtlStateFactory}} should use {{StateDescriptor#Type}} to check what kind 
> of state is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (FLINK-23018) State factories should handle extended state descriptors

2021-06-20 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang resolved FLINK-23018.
--
Resolution: Fixed

> State factories should handle extended state descriptors
> 
>
> Key: FLINK-23018
> URL: https://issues.apache.org/jira/browse/FLINK-23018
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently, {{TtlStateFactory}} and other state factories can only handle 
> fixed type of state descriptors. As {{ValueStateDescriptor}} is not a final 
> class and user could still extend it, however, {{TtlStateFactory}} cannot 
> recognize the extending class.
>  {{TtlStateFactory}} should use {{StateDescriptor#Type}} to check what kind 
> of state is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23018) State factories should handle extended state descriptors

2021-06-20 Thread Yun Tang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366351#comment-17366351
 ] 

Yun Tang commented on FLINK-23018:
--

Merged
master: 73c103b6b117fe3996eedfb9d04e926f00c70996
release-1.13: b4f1a41b1c7564f4966567fbaf6e47c390874700

> State factories should handle extended state descriptors
> 
>
> Key: FLINK-23018
> URL: https://issues.apache.org/jira/browse/FLINK-23018
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Reporter: Yun Tang
>Assignee: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently, {{TtlStateFactory}} and other state factories can only handle 
> fixed type of state descriptors. As {{ValueStateDescriptor}} is not a final 
> class and user could still extend it, however, {{TtlStateFactory}} cannot 
> recognize the extending class.
>  {{TtlStateFactory}} should use {{StateDescriptor#Type}} to check what kind 
> of state is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22480) KafkaChangelogTableITCase hangs on Azure

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366350#comment-17366350
 ] 

Xintong Song commented on FLINK-22480:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19177=logs=72d4811f-9f0d-5fd0-014a-0bc26b72b642=c1d93a6a-ba91-515d-3196-2ee8019fbda7=6895

> KafkaChangelogTableITCase hangs on Azure
> 
>
> Key: FLINK-22480
> URL: https://issues.apache.org/jira/browse/FLINK-22480
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines, Connectors / Kafka
>Affects Versions: 1.13.0
>Reporter: Dawid Wysakowicz
>Priority: Major
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17215=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=6605
> {code}
> Apr 26 11:12:51 "main" #1 prio=5 os_prio=0 tid=0x7f48a000b000 nid=0x34db 
> runnable [0x7f48a99e2000]
> Apr 26 11:12:51java.lang.Thread.State: RUNNABLE
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.Buffer.indexOf(Buffer.java:1475)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.RealBufferedSource.indexOf(RealBufferedSource.java:352)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.java:230)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.java:224)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.http1.Http1ExchangeCodec$ChunkedSource.readChunkSize(Http1ExchangeCodec.java:489)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.http1.Http1ExchangeCodec$ChunkedSource.read(Http1ExchangeCodec.java:471)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.Util.skipAll(Util.java:204)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.Util.discard(Util.java:186)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.http1.Http1ExchangeCodec$ChunkedSource.close(Http1ExchangeCodec.java:511)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.ForwardingSource.close(ForwardingSource.java:43)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.connection.Exchange$ResponseBodySource.close(Exchange.java:313)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okio.RealBufferedSource.close(RealBufferedSource.java:476)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.internal.Util.closeQuietly(Util.java:139)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.ResponseBody.close(ResponseBody.java:192)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.okhttp3.Response.close(Response.java:290)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.com.github.dockerjava.okhttp.OkDockerHttpClient$OkResponse.close(OkDockerHttpClient.java:285)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$null$0(DefaultInvocationBuilder.java:272)
> Apr 26 11:12:51   at 
> org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder$$Lambda$342/1189672232.close(Unknown
>  Source)
> Apr 26 11:12:51   at 
> com.github.dockerjava.api.async.ResultCallbackTemplate.close(ResultCallbackTemplate.java:77)
> Apr 26 11:12:51   at 
> org.testcontainers.utility.ResourceReaper.start(ResourceReaper.java:202)
> Apr 26 11:12:51   at 
> org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:205)
> Apr 26 11:12:51   - locked <0xe80e4568> (a [Ljava.lang.Object;)
> Apr 26 11:12:51   at 
> org.testcontainers.LazyDockerClient.getDockerClient(LazyDockerClient.java:14)
> Apr 26 11:12:51   at 
> org.testcontainers.LazyDockerClient.authConfig(LazyDockerClient.java:12)
> Apr 26 11:12:51   at 
> org.testcontainers.containers.GenericContainer.start(GenericContainer.java:310)
> Apr 26 11:12:51   at 
> org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1029)
> Apr 26 11:12:51   at 
> org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:29)
> Apr 26 11:12:51   at 
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> Apr 26 11:12:51   at 
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> Apr 26 11:12:51   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> Apr 26 11:12:51   at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> Apr 26 11:12:51   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> Apr 26 11:12:51   at 
> 

[jira] [Commented] (FLINK-18634) FlinkKafkaProducerITCase.testRecoverCommittedTransaction failed with "Timeout expired after 60000milliseconds while awaiting InitProducerId"

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366349#comment-17366349
 ] 

Xintong Song commented on FLINK-18634:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19175=logs=ce8f3cc3-c1ea-5281-f5eb-df9ebd24947f=f266c805-9429-58ed-2f9e-482e7b82f58b=6628

> FlinkKafkaProducerITCase.testRecoverCommittedTransaction failed with "Timeout 
> expired after 6milliseconds while awaiting InitProducerId"
> 
>
> Key: FLINK-18634
> URL: https://issues.apache.org/jira/browse/FLINK-18634
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka, Tests
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Dian Fu
>Priority: Major
>  Labels: auto-unassigned, test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=4590=logs=c5f0071e-1851-543e-9a45-9ac140befc32=684b1416-4c17-504e-d5ab-97ee44e08a20
> {code}
> 2020-07-17T11:43:47.9693015Z [ERROR] Tests run: 12, Failures: 0, Errors: 1, 
> Skipped: 0, Time elapsed: 269.399 s <<< FAILURE! - in 
> org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerITCase
> 2020-07-17T11:43:47.9693862Z [ERROR] 
> testRecoverCommittedTransaction(org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerITCase)
>   Time elapsed: 60.679 s  <<< ERROR!
> 2020-07-17T11:43:47.9694737Z org.apache.kafka.common.errors.TimeoutException: 
> org.apache.kafka.common.errors.TimeoutException: Timeout expired after 
> 6milliseconds while awaiting InitProducerId
> 2020-07-17T11:43:47.9695376Z Caused by: 
> org.apache.kafka.common.errors.TimeoutException: Timeout expired after 
> 6milliseconds while awaiting InitProducerId
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-23049) UnalignedCheckpointCompatibilityITCase hangs on azure

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23049:


 Summary: UnalignedCheckpointCompatibilityITCase hangs on azure
 Key: FLINK-23049
 URL: https://issues.apache.org/jira/browse/FLINK-23049
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Checkpointing
Affects Versions: 1.14.0
Reporter: Xintong Song
 Fix For: 1.14.0


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19175=logs=219e462f-e75e-506c-3671-5017d866ccf6=4c5dc768-5c82-5ab0-660d-086cb90b76a0=6390

{code}
"main" #1 prio=5 os_prio=0 tid=0x7f521000b800 nid=0x3735 waiting on 
condition [0x7f5217938000]
   java.lang.Thread.State: TIMED_WAITING (sleeping)
at java.lang.Thread.sleep(Native Method)
at 
org.apache.flink.test.checkpointing.UnalignedCheckpointCompatibilityITCase.waitForChild(UnalignedCheckpointCompatibilityITCase.java:188)
at 
org.apache.flink.test.checkpointing.UnalignedCheckpointCompatibilityITCase.runAndTakeExternalCheckpoint(UnalignedCheckpointCompatibilityITCase.java:166)
at 
org.apache.flink.test.checkpointing.UnalignedCheckpointCompatibilityITCase.test(UnalignedCheckpointCompatibilityITCase.java:133)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23042) Flink Chinese docs Fraud Detection with the DataStream API page picture display issue

2021-06-20 Thread kevin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366347#comment-17366347
 ] 

kevin commented on FLINK-23042:
---

Hi [~xintongsong], 

 

Both branch *release-1.13* and *master* have issue, can you tell me which 
branch I based on?

Also I checked Flink docs How to Contribute am it said :
 * Make sure your change has been rebased to the latest commits in your base 
branch.

But still confused.

 

Thanks,

Kevin

> Flink Chinese docs Fraud Detection with the DataStream API page picture 
> display issue
> -
>
> Key: FLINK-23042
> URL: https://issues.apache.org/jira/browse/FLINK-23042
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.14.0, 1.13.1
>Reporter: kevin
>Assignee: kevin
>Priority: Major
>  Labels: docs, documentation-update, zh_CN
> Fix For: 1.14.0, 1.13.1
>
> Attachments: image-2021-06-20-12-45-36-749.png, 
> image-2021-06-20-12-48-22-229.png
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Flink chinese docs: [基于 DataStream API 
> 实现欺诈测|[https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/|https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/](https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/try-flink/datastream/)]]
>  picture `fraud-transactions.svg` can't display becase the link is incorrect.
>  
> *Screenshot* as below:
>  
> !image-2021-06-20-12-45-36-749.png!
>  
> *Reason*: the src should be a http link not a path.
> !image-2021-06-20-12-48-22-229.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] Myasuka merged pull request #16178: [FLINK-23018][state] Enable TTL state factory to handle extended state descriptors

2021-06-20 Thread GitBox


Myasuka merged pull request #16178:
URL: https://github.com/apache/flink/pull/16178


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366346#comment-17366346
 ] 

Xintong Song commented on FLINK-22085:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19175=logs=1fc6e7bf-633c-5081-c32a-9dea24b05730=80a658d1-f7f6-5d93-2758-53ac19fd5b19=6687

> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to this channel if it is called on 
> this channel again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #16211: [FLINK-16952][Connectors/Parquet] Parquet file format support filter push down.

2021-06-20 Thread GitBox


flinkbot commented on pull request #16211:
URL: https://github.com/apache/flink/pull/16211#issuecomment-864684011


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 33aec918ba974f8c0a0ccfd4ed3ceb9a91a6fdb5 (Mon Jun 21 
02:48:47 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-16952) Parquet file system format support filter pushdown

2021-06-20 Thread luoyuxia (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366345#comment-17366345
 ] 

luoyuxia commented on FLINK-16952:
--

[~lzljs3620320] Look forward your review.

> Parquet file system format support filter pushdown
> ---
>
> Key: FLINK-16952
> URL: https://issues.apache.org/jira/browse/FLINK-16952
> Project: Flink
>  Issue Type: Sub-task
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Reporter: Jingsong Lee
>Assignee: luoyuxia
>Priority: Major
>  Labels: auto-unassigned, pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> We can create the conversion between Flink Expression(NOTE: should be new 
> Expression instead of PlannerExpression) and parquet FilterPredicate.
> And apply to Parquet file system format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-23048) GroupWindowITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane fails due to akka timeout

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23048:


 Summary: 
GroupWindowITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane
 fails due to akka timeout
 Key: FLINK-23048
 URL: https://issues.apache.org/jira/browse/FLINK-23048
 Project: Flink
  Issue Type: Bug
  Components: Table SQL / Runtime
Affects Versions: 1.12.4
Reporter: Xintong Song
 Fix For: 1.12.5


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19176=logs=56781494-ebb0-5eae-f732-b9c397ec6ede=6568c985-5fcc-5b89-1ebd-0385b8088b14=7957

{code}
[ERROR] Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 48.296 
s <<< FAILURE! - in 
org.apache.flink.table.runtime.stream.table.GroupWindowITCase
[ERROR] 
testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane(org.apache.flink.table.runtime.stream.table.GroupWindowITCase)
  Time elapsed: 40.358 s  <<< ERROR!
org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
at 
org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:144)
at 
org.apache.flink.runtime.minicluster.MiniClusterJobClient.lambda$getJobExecutionResult$2(MiniClusterJobClient.java:117)
at 
java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)
at 
java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
at 
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
at 
org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler.lambda$invokeRpc$0(AkkaInvocationHandler.java:237)
at 
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
at 
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
at 
org.apache.flink.runtime.concurrent.FutureUtils$1.onComplete(FutureUtils.java:1061)
at akka.dispatch.OnComplete.internal(Future.scala:264)
at akka.dispatch.OnComplete.internal(Future.scala:261)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:191)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:188)
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:36)
at 
org.apache.flink.runtime.concurrent.Executors$DirectExecutionContext.execute(Executors.java:73)
at 
scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:44)
at 
scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:252)
at akka.pattern.PromiseActorRef.$bang(AskSupport.scala:572)
at 
akka.pattern.PipeToSupport$PipeableFuture$$anonfun$pipeTo$1.applyOrElse(PipeToSupport.scala:22)
at 
akka.pattern.PipeToSupport$PipeableFuture$$anonfun$pipeTo$1.applyOrElse(PipeToSupport.scala:21)
at scala.concurrent.Future$$anonfun$andThen$1.apply(Future.scala:436)
at scala.concurrent.Future$$anonfun$andThen$1.apply(Future.scala:435)
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:36)
at 
akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55)
at 
akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply$mcV$sp(BatchingExecutor.scala:91)
at 
akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply(BatchingExecutor.scala:91)
at 
akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply(BatchingExecutor.scala:91)
at 
scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:72)
at 
akka.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:90)
at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
at 
akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:44)
at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at 
akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at 
akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: org.apache.flink.runtime.JobException: Recovery is suppressed by 
NoRestartBackoffTimeStrategy
at 
org.apache.flink.runtime.executiongraph.failover.flip1.ExecutionFailureHandler.handleFailure(ExecutionFailureHandler.java:118)
at 
org.apache.flink.runtime.executiongraph.failover.flip1.ExecutionFailureHandler.getFailureHandlingResult(ExecutionFailureHandler.java:80)
at 

[jira] [Updated] (FLINK-16952) Parquet file system format support filter pushdown

2021-06-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-16952:
---
Labels: auto-unassigned pull-request-available stale-assigned  (was: 
auto-unassigned stale-assigned)

> Parquet file system format support filter pushdown
> ---
>
> Key: FLINK-16952
> URL: https://issues.apache.org/jira/browse/FLINK-16952
> Project: Flink
>  Issue Type: Sub-task
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Reporter: Jingsong Lee
>Assignee: luoyuxia
>Priority: Major
>  Labels: auto-unassigned, pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> We can create the conversion between Flink Expression(NOTE: should be new 
> Expression instead of PlannerExpression) and parquet FilterPredicate.
> And apply to Parquet file system format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] luoyuxia opened a new pull request #16211: [FLINK-16952][Connectors/Parquet] Parquet file format support filter push down.

2021-06-20 Thread GitBox


luoyuxia opened a new pull request #16211:
URL: https://github.com/apache/flink/pull/16211


   
   
   ## What is the purpose of the change
   
   *Support filter push down for parquet format*
   
   
   ## Brief change log
   
   **
 - *Add ParquetFilters to convert expression to FilterPredicate for parquet 
format*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added ParquetFiltersTest  for testing Parquet Filter*
 - *Add testParquetFilterPushDown in ParquetFileSystemITCase to cover 
integration test for pushing down filter in parquet format*
 
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


flinkbot commented on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864682204


   
   ## CI report:
   
   * ac28fa57c35305feb56c9825f360bc32d0547db9 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #16179: [TESTING] Try to reproduce FLINK-22891

2021-06-20 Thread GitBox


flinkbot edited a comment on pull request #16179:
URL: https://github.com/apache/flink/pull/16179#issuecomment-863055916


   
   ## CI report:
   
   * 1fddc9fa74da8400c9869aeea87038bcec3257fe Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19108)
 
   * 7e7b0c0d820d70a132c4c2f78d955bb1693c0ff8 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-23047) CassandraConnectorITCase.testCassandraBatchTupleFormat fails on azure

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23047:


 Summary: CassandraConnectorITCase.testCassandraBatchTupleFormat 
fails on azure
 Key: FLINK-23047
 URL: https://issues.apache.org/jira/browse/FLINK-23047
 Project: Flink
  Issue Type: Bug
  Components: Connectors / Cassandra
Affects Versions: 1.12.4
Reporter: Xintong Song
 Fix For: 1.12.5


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19176=logs=d44f43ce-542c-597d-bf94-b0718c71e5e8=03dca39c-73e8-5aaf-601d-328ae5c35f20=13995

{code}
[ERROR] Tests run: 17, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 157.28 
s <<< FAILURE! - in 
org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase
[ERROR] 
testCassandraBatchTupleFormat(org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase)
  Time elapsed: 12.052 s  <<< ERROR!
com.datastax.driver.core.exceptions.NoHostAvailableException: All host(s) tried 
for query failed (tried: /127.0.0.1:9042 
(com.datastax.driver.core.exceptions.OperationTimedOutException: [/127.0.0.1] 
Timed out waiting for server response))
at 
com.datastax.driver.core.exceptions.NoHostAvailableException.copy(NoHostAvailableException.java:84)
at 
com.datastax.driver.core.exceptions.NoHostAvailableException.copy(NoHostAvailableException.java:37)
at 
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:37)
at 
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:245)
at 
com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:63)
at 
com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:39)
at 
org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase.createTable(CassandraConnectorITCase.java:234)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: com.datastax.driver.core.exceptions.NoHostAvailableException: All 
host(s) tried for query failed (tried: /127.0.0.1:9042 
(com.datastax.driver.core.exceptions.OperationTimedOutException: [/127.0.0.1] 
Timed out waiting for server response))
at 
com.datastax.driver.core.RequestHandler.reportNoMoreHosts(RequestHandler.java:218)
at 

[jira] [Commented] (FLINK-22890) Few tests fail in HiveTableSinkITCase

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366343#comment-17366343
 ] 

Xintong Song commented on FLINK-22890:
--

Failed again on master, with the fixing commit included.
cc [~lirui]

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19167=logs=8fd975ef-f478-511d-4997-6f15fe8a1fd3=ac0fa443-5d45-5a6b-3597-0310ecc1d2ab=25531

> Few tests fail in HiveTableSinkITCase
> -
>
> Key: FLINK-22890
> URL: https://issues.apache.org/jira/browse/FLINK-22890
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive, Table SQL / Ecosystem
>Affects Versions: 1.13.1
>Reporter: Dawid Wysakowicz
>Priority: Major
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0, 1.12.5, 1.13.2
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=18692=logs=5cae8624-c7eb-5c51-92d3-4d2dacedd221=420bd9ec-164e-562e-8947-0dacde3cec91=23189
> {code}
> Jun 05 01:22:13 [ERROR] Errors: 
> Jun 05 01:22:13 [ERROR]   HiveTableSinkITCase.testBatchAppend:138 » 
> Validation Could not execute CREATE ...
> Jun 05 01:22:13 [ERROR]   
> HiveTableSinkITCase.testDefaultSerPartStreamingWrite:156->testStreamingWrite:494
>  » Validation
> Jun 05 01:22:13 [ERROR]   
> HiveTableSinkITCase.testHiveTableSinkWithParallelismInStreaming:100->testHiveTableSinkWithParallelismBase:108
>  » Validation
> Jun 05 01:22:13 [ERROR]   
> HiveTableSinkITCase.testPartStreamingMrWrite:179->testStreamingWrite:423 » 
> Validation
> Jun 05 01:22:13 [ERROR]   
> HiveTableSinkITCase.testStreamingSinkWithTimestampLtzWatermark:360->fetchRows:384
>  » TestTimedOut
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


flinkbot commented on pull request #16210:
URL: https://github.com/apache/flink/pull/16210#issuecomment-864679930


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit ac28fa57c35305feb56c9825f360bc32d0547db9 (Mon Jun 21 
02:34:25 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-23044).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-22702) KafkaSourceITCase.testRedundantParallelism failed

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366342#comment-17366342
 ] 

Xintong Song commented on FLINK-22702:
--

[~renqs], any insights on this instability?

> KafkaSourceITCase.testRedundantParallelism failed
> -
>
> Key: FLINK-22702
> URL: https://issues.apache.org/jira/browse/FLINK-22702
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.14.0, 1.12.3
>Reporter: Guowei Ma
>Priority: Major
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=18107=logs=1fc6e7bf-633c-5081-c32a-9dea24b05730=80a658d1-f7f6-5d93-2758-53ac19fd5b19=6847
> {code:java}
> Caused by: java.lang.RuntimeException: One or more fetchers have encountered 
> exception
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcherManager.checkErrors(SplitFetcherManager.java:199)
>   at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.getNextFetch(SourceReaderBase.java:154)
>   at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.pollNext(SourceReaderBase.java:116)
>   at 
> org.apache.flink.streaming.api.operators.SourceOperator.emitNext(SourceOperator.java:275)
>   at 
> org.apache.flink.streaming.runtime.io.StreamTaskSourceInput.emitNext(StreamTaskSourceInput.java:67)
>   at 
> org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:65)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:398)
>   at 
> org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:191)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:619)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:583)
>   at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:758)
>   at org.apache.flink.runtime.taskmanager.Task.run(Task.java:573)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.RuntimeException: SplitFetcher thread 0 received 
> unexpected exception while polling the records
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.runOnce(SplitFetcher.java:146)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.run(SplitFetcher.java:101)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   ... 1 more
> Caused by: java.lang.IllegalStateException: Consumer is not subscribed to any 
> topics or assigned any partitions
>   at 
> org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1223)
>   at 
> org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1211)
>   at 
> org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader.fetch(KafkaPartitionSplitReader.java:97)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.FetchTask.run(FetchTask.java:56)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.runOnce(SplitFetcher.java:138)
>   ... 6 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22702) KafkaSourceITCase.testRedundantParallelism failed

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366341#comment-17366341
 ] 

Xintong Song commented on FLINK-22702:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19168=logs=1fc6e7bf-633c-5081-c32a-9dea24b05730=80a658d1-f7f6-5d93-2758-53ac19fd5b19=6673

> KafkaSourceITCase.testRedundantParallelism failed
> -
>
> Key: FLINK-22702
> URL: https://issues.apache.org/jira/browse/FLINK-22702
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.14.0, 1.12.3
>Reporter: Guowei Ma
>Priority: Major
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=18107=logs=1fc6e7bf-633c-5081-c32a-9dea24b05730=80a658d1-f7f6-5d93-2758-53ac19fd5b19=6847
> {code:java}
> Caused by: java.lang.RuntimeException: One or more fetchers have encountered 
> exception
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcherManager.checkErrors(SplitFetcherManager.java:199)
>   at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.getNextFetch(SourceReaderBase.java:154)
>   at 
> org.apache.flink.connector.base.source.reader.SourceReaderBase.pollNext(SourceReaderBase.java:116)
>   at 
> org.apache.flink.streaming.api.operators.SourceOperator.emitNext(SourceOperator.java:275)
>   at 
> org.apache.flink.streaming.runtime.io.StreamTaskSourceInput.emitNext(StreamTaskSourceInput.java:67)
>   at 
> org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:65)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:398)
>   at 
> org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:191)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:619)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:583)
>   at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:758)
>   at org.apache.flink.runtime.taskmanager.Task.run(Task.java:573)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.RuntimeException: SplitFetcher thread 0 received 
> unexpected exception while polling the records
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.runOnce(SplitFetcher.java:146)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.run(SplitFetcher.java:101)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   ... 1 more
> Caused by: java.lang.IllegalStateException: Consumer is not subscribed to any 
> topics or assigned any partitions
>   at 
> org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1223)
>   at 
> org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1211)
>   at 
> org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader.fetch(KafkaPartitionSplitReader.java:97)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.FetchTask.run(FetchTask.java:56)
>   at 
> org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher.runOnce(SplitFetcher.java:138)
>   ... 6 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23044) fix typos in docs

2021-06-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-23044:
---
Labels: pull-request-available typo  (was: typo)

> fix typos in docs
> -
>
> Key: FLINK-23044
> URL: https://issues.apache.org/jira/browse/FLINK-23044
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Huang Yu
>Priority: Minor
>  Labels: pull-request-available, typo
> Fix For: 1.14.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
> typos in Flink documents.
>  
>  
> {color:#505f79}[xiaochu.yh ~/tools/codetypo] (main) $python checker.py 
> flink/docs/{color}
> {color:#505f79}flink/docs/README.md{color}
> {color:#505f79} ommitted (suggestion: omitted){color}
> {color:#505f79} groupd (suggestion: group){color}
> {color:#505f79} artfiact (suggestion: artifact){color}
> {color:#505f79} sometab (suggestion: sometag){color}
> {color:#505f79} verison (suggestion: verion){color}
> {color:#505f79} pgenerate (suggestion: generate){color}
> {color:#505f79} harnesses (suggestion: harnessed){color}
> {color:#505f79} flavored (suggestion: favored){color}
> {color:#505f79} shortcode (suggestion: sortcode){color}
> {color:#505f79} flinks (suggestion: blinks){color}
> {color:#505f79}flink/docs/assets/github.css{color}
> {color:#505f79} lntable (suggestion: ntable){color}
> {color:#505f79} affix (suggestion: affin){color}
> {color:#505f79} cc (suggestion: fffcc){color}
> {color:#505f79} subheading (suggestion: subheadings){color}
> {color:#505f79}flink/docs/assets/_fonts.scss{color}
> {color:#505f79} lucida (suggestion: lucina){color}
> {color:#505f79} arial (suggestion: ariel){color}
> {color:#505f79}flink/docs/layouts/partials/docs/simple-title.html{color}
> {color:#505f79} sytling (suggestion: styling){color}
> {color:#505f79}flink/docs/layouts/partials/docs/inject/menu-after.html{color}
> {color:#505f79} dictonary (suggestion: dictionary){color}
> {color:#505f79}flink/docs/layouts/shortcodes/version.html{color}
> {color:#505f79} parmeters (suggestion: pameters){color}
> {color:#505f79} shortcode (suggestion: sortcode){color}
> {color:#505f79}flink/docs/layouts/shortcodes/beta.html{color}
> {color:#505f79} guaruntees (suggestion: guarantees){color}
> {color:#505f79}flink/docs/layouts/shortcodes/stable.html{color}
> {color:#505f79} parmeters (suggestion: pameters){color}
> {color:#505f79} shortcode (suggestion: sortcode){color}
> {color:#505f79} {color}
>  
> Some false alarm, some are real typos which need to be fixed.
> Codetypo can also check code typos. I just have no time to run over it.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] raywill opened a new pull request #16210: [FLINK-23044] fix typos in docs

2021-06-20 Thread GitBox


raywill opened a new pull request #16210:
URL: https://github.com/apache/flink/pull/16210


   
   
   ## What is the purpose of the change
   
   Fix typo.
   
   Found some typos using the tool provided by 
[https://github.com/raywill/codetypo](https://github.com/raywill/codetypo)
   
   
   ## Brief change log
   
   fix typos in `flink/docs/README.md`.
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-23046) OperatorEventSendingCheckpointITCase.testOperatorEventLostNoReaderFailure fails on azure

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23046:


 Summary: 
OperatorEventSendingCheckpointITCase.testOperatorEventLostNoReaderFailure fails 
on azure
 Key: FLINK-23046
 URL: https://issues.apache.org/jira/browse/FLINK-23046
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Checkpointing
Affects Versions: 1.13.1
Reporter: Xintong Song
 Fix For: 1.14.0, 1.13.2


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19154=logs=219e462f-e75e-506c-3671-5017d866ccf6=4c5dc768-5c82-5ab0-660d-086cb90b76a0=4742

{code}
Jun 18 23:22:05 [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time 
elapsed: 19.599 s <<< FAILURE! - in 
org.apache.flink.runtime.operators.coordination.OperatorEventSendingCheckpointITCase
Jun 18 23:22:05 [ERROR] 
testOperatorEventLostNoReaderFailure(org.apache.flink.runtime.operators.coordination.OperatorEventSendingCheckpointITCase)
  Time elapsed: 3.348 s  <<< FAILURE!
Jun 18 23:22:05 java.lang.AssertionError: expected:<[1, 2, 3, 4, 5, 6, 7, 8, 9, 
10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 
30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 
50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 
70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 
90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100]> but was:<[1, 2, 3, 4, 5, 6, 7, 8, 
9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 
29, 30, 31, 32, 33, 34, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 
82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100]>
Jun 18 23:22:05 at org.junit.Assert.fail(Assert.java:88)
Jun 18 23:22:05 at org.junit.Assert.failNotEquals(Assert.java:834)
Jun 18 23:22:05 at org.junit.Assert.assertEquals(Assert.java:118)
Jun 18 23:22:05 at org.junit.Assert.assertEquals(Assert.java:144)
Jun 18 23:22:05 at 
org.apache.flink.runtime.operators.coordination.OperatorEventSendingCheckpointITCase.runTest(OperatorEventSendingCheckpointITCase.java:233)
Jun 18 23:22:05 at 
org.apache.flink.runtime.operators.coordination.OperatorEventSendingCheckpointITCase.testOperatorEventLostNoReaderFailure(OperatorEventSendingCheckpointITCase.java:120)
Jun 18 23:22:05 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Jun 18 23:22:05 at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Jun 18 23:22:05 at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Jun 18 23:22:05 at java.lang.reflect.Method.invoke(Method.java:498)
Jun 18 23:22:05 at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Jun 18 23:22:05 at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Jun 18 23:22:05 at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Jun 18 23:22:05 at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Jun 18 23:22:05 at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Jun 18 23:22:05 at 
org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Jun 18 23:22:05 at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Jun 18 23:22:05 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Jun 18 23:22:05 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
Jun 18 23:22:05 at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
Jun 18 23:22:05 at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
Jun 18 23:22:05 at 
org.junit.runners.ParentRunner.run(ParentRunner.java:363)
Jun 18 23:22:05 at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
Jun 18 23:22:05 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
Jun 18 23:22:05 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
Jun 18 23:22:05 at 

[jira] [Commented] (FLINK-23013) Introduce faker source connector

2021-06-20 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366339#comment-17366339
 ] 

Jingsong Lee commented on FLINK-23013:
--

+1

> Introduce faker source connector
> 
>
> Key: FLINK-23013
> URL: https://issues.apache.org/jira/browse/FLINK-23013
> Project: Flink
>  Issue Type: New Feature
>  Components: Table SQL / API
>Reporter: Jingsong Lee
>Priority: Major
>
> We already have datagen connector.
> But sometimes, we need a more real datagen connector which can produce more 
> natural random records.
> We can integrate [https://github.com/DiUS/java-faker] and introduce a 
> built-in faker connector.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-22781) Incorrect result for group window aggregate when mini-batch is enabled

2021-06-20 Thread Jingsong Lee (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingsong Lee updated FLINK-22781:
-
Labels:   (was: stale-assigned)

> Incorrect result for group window aggregate when mini-batch is enabled
> --
>
> Key: FLINK-22781
> URL: https://issues.apache.org/jira/browse/FLINK-22781
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.14.0
>Reporter: godfrey he
>Assignee: JING ZHANG
>Priority: Critical
> Fix For: 1.14.0
>
>
> We can reproduce this issue through adding the following code to 
> {{GroupWindowITCase#testWindowAggregateOnUpsertSource}} method:
> {code:java}
> tEnv.getConfig.getConfiguration.setBoolean(
>   ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED, true)
> tEnv.getConfig.getConfiguration.set(
>   ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY, 
> Duration.ofSeconds(1))
> tEnv.getConfig.getConfiguration.setLong(
>   ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 10L)
> {code}
> The reason is the group window without any data (the data may be retracted) 
> should not send any record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22719) WindowJoinUtil.containsWindowStartEqualityAndEndEquality should not throw exception

2021-06-20 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366337#comment-17366337
 ] 

Jingsong Lee commented on FLINK-22719:
--

[~qingru zhang] is right, they are different problems. In some cases(select 
rowtime field in downstream join),  FLINK-10211 is the blocker of FLINK-22719. 
But in other cases(select window start/end and not select rowtime field in 
downstream join),  FLINK-10211 is not the blocker of FLINK-22719.

But yes, it is good to fix FLINK-10211 too~

> WindowJoinUtil.containsWindowStartEqualityAndEndEquality should not throw 
> exception
> ---
>
> Key: FLINK-22719
> URL: https://issues.apache.org/jira/browse/FLINK-22719
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Reporter: Jingsong Lee
>Assignee: JING ZHANG
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> This will broke regular join sql.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-23044) fix typos in docs

2021-06-20 Thread Huang Yu (Jira)
Huang Yu created FLINK-23044:


 Summary: fix typos in docs
 Key: FLINK-23044
 URL: https://issues.apache.org/jira/browse/FLINK-23044
 Project: Flink
  Issue Type: Improvement
  Components: Documentation
Reporter: Huang Yu
 Fix For: 1.14.0


using [codetypo](https://www.github.com/raywill/codetypo) I can find tons of 
typos in documents.

 

```

[xiaochu.yh ~/tools/codetypo] (main) $python checker.py flink/docs/

flink/docs/README.md
 ommitted (suggestion: omitted)
 groupd (suggestion: group)
 artfiact (suggestion: artifact)
 sometab (suggestion: sometag)
 verison (suggestion: verion)
 pgenerate (suggestion: generate)
 harnesses (suggestion: harnessed)
 flavored (suggestion: favored)
 shortcode (suggestion: sortcode)
 flinks (suggestion: blinks)

flink/docs/assets/github.css
 lntable (suggestion: ntable)
 affix (suggestion: affin)
 cc (suggestion: fffcc)
 subheading (suggestion: subheadings)

flink/docs/assets/_fonts.scss
 lucida (suggestion: lucina)
 arial (suggestion: ariel)

flink/docs/layouts/partials/docs/simple-title.html
 sytling (suggestion: styling)

flink/docs/layouts/partials/docs/inject/menu-after.html
 dictonary (suggestion: dictionary)

flink/docs/layouts/shortcodes/version.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

flink/docs/layouts/shortcodes/beta.html
 guaruntees (suggestion: guarantees)

flink/docs/layouts/shortcodes/stable.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

```

 

some of them are real typos which need to be fixed.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22198) KafkaTableITCase hang.

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366336#comment-17366336
 ] 

Xintong Song commented on FLINK-22198:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19154=logs=4be4ed2b-549a-533d-aa33-09e28e360cc8=0db94045-2aa0-53fa-f444-0130d6933518=7903

> KafkaTableITCase hang.
> --
>
> Key: FLINK-22198
> URL: https://issues.apache.org/jira/browse/FLINK-22198
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.12.4
>Reporter: Guowei Ma
>Priority: Major
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=16287=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=6625
> There is no any artifacts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22198) KafkaTableITCase hang.

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366333#comment-17366333
 ] 

Xintong Song commented on FLINK-22198:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19153=logs=1fc6e7bf-633c-5081-c32a-9dea24b05730=80a658d1-f7f6-5d93-2758-53ac19fd5b19=6316

> KafkaTableITCase hang.
> --
>
> Key: FLINK-22198
> URL: https://issues.apache.org/jira/browse/FLINK-22198
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.12.4
>Reporter: Guowei Ma
>Priority: Major
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=16287=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=6625
> There is no any artifacts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23030) PartitionRequestClientFactory#createPartitionRequestClient should throw when network failure

2021-06-20 Thread Jin Xing (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jin Xing updated FLINK-23030:
-
Priority: Major  (was: Blocker)

> PartitionRequestClientFactory#createPartitionRequestClient should throw when 
> network failure
> 
>
> Key: FLINK-23030
> URL: https://issues.apache.org/jira/browse/FLINK-23030
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Reporter: Jin Xing
>Priority: Major
>  Labels: pull-request-available, stale-blocker
>
> In current _PartitionRequestClientFactory#createPartitionRequestClient_, 
> _ChannelFuture#await()_ is invoked, thus to build a connection to remote 
> synchronously.
> But with the doc of _io.netty.util.concurrent.Future_ [1] and its 
> implementation _io.netty.channel.DefaultChannelPromise_ [2], 
> _ChannelFuture#await()_ never throws when completed with failure. I guess 
> what Flink needs is _ChannelFuture#sync()._
> [1]  [https://netty.io/4.1/api/io/netty/util/concurrent/class-use/Future.html]
> [2] 
> [https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelPromise.java]
>       
> https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22545) JVM crashes when runing OperatorEventSendingCheckpointITCase.testOperatorEventAckLost

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366332#comment-17366332
 ] 

Xintong Song commented on FLINK-22545:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19153=logs=39d5b1d5-3b41-54dc-6458-1e2ddd1cdcf3=a99e99c7-21cd-5a1f-7274-585e62b72f56=4243

> JVM crashes when runing 
> OperatorEventSendingCheckpointITCase.testOperatorEventAckLost
> -
>
> Key: FLINK-22545
> URL: https://issues.apache.org/jira/browse/FLINK-22545
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Tests
>Affects Versions: 1.12.3
>Reporter: Guowei Ma
>Priority: Major
>  Labels: auto-deprioritized-critical, test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17501=logs=39d5b1d5-3b41-54dc-6458-1e2ddd1cdcf3=a99e99c7-21cd-5a1f-7274-585e62b72f56=4287



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-23044) fix typos in docs

2021-06-20 Thread Huang Yu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Yu updated FLINK-23044:
-
Description: 
using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
typos in Flink documents.

 

 

{color:#505f79}[xiaochu.yh ~/tools/codetypo] (main) $python checker.py 
flink/docs/{color}

{color:#505f79}flink/docs/README.md{color}
{color:#505f79} ommitted (suggestion: omitted){color}
{color:#505f79} groupd (suggestion: group){color}
{color:#505f79} artfiact (suggestion: artifact){color}
{color:#505f79} sometab (suggestion: sometag){color}
{color:#505f79} verison (suggestion: verion){color}
{color:#505f79} pgenerate (suggestion: generate){color}
{color:#505f79} harnesses (suggestion: harnessed){color}
{color:#505f79} flavored (suggestion: favored){color}
{color:#505f79} shortcode (suggestion: sortcode){color}
{color:#505f79} flinks (suggestion: blinks){color}

{color:#505f79}flink/docs/assets/github.css{color}
{color:#505f79} lntable (suggestion: ntable){color}
{color:#505f79} affix (suggestion: affin){color}
{color:#505f79} cc (suggestion: fffcc){color}
{color:#505f79} subheading (suggestion: subheadings){color}

{color:#505f79}flink/docs/assets/_fonts.scss{color}
{color:#505f79} lucida (suggestion: lucina){color}
{color:#505f79} arial (suggestion: ariel){color}

{color:#505f79}flink/docs/layouts/partials/docs/simple-title.html{color}
{color:#505f79} sytling (suggestion: styling){color}

{color:#505f79}flink/docs/layouts/partials/docs/inject/menu-after.html{color}
{color:#505f79} dictonary (suggestion: dictionary){color}

{color:#505f79}flink/docs/layouts/shortcodes/version.html{color}
{color:#505f79} parmeters (suggestion: pameters){color}
{color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79}flink/docs/layouts/shortcodes/beta.html{color}
{color:#505f79} guaruntees (suggestion: guarantees){color}

{color:#505f79}flink/docs/layouts/shortcodes/stable.html{color}
{color:#505f79} parmeters (suggestion: pameters){color}
{color:#505f79} shortcode (suggestion: sortcode){color}

{color:#505f79} {color}

 

Some false alarm, some are real typos which need to be fixed.

Codetypo can also check code typos. I just have no time to run over it.

 

 

  was:
using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
typos in Flink documents.

 

 

[xiaochu.yh ~/tools/codetypo] (main) $python checker.py flink/docs/

flink/docs/README.md
 ommitted (suggestion: omitted)
 groupd (suggestion: group)
 artfiact (suggestion: artifact)
 sometab (suggestion: sometag)
 verison (suggestion: verion)
 pgenerate (suggestion: generate)
 harnesses (suggestion: harnessed)
 flavored (suggestion: favored)
 shortcode (suggestion: sortcode)
 flinks (suggestion: blinks)

flink/docs/assets/github.css
 lntable (suggestion: ntable)
 affix (suggestion: affin)
 cc (suggestion: fffcc)
 subheading (suggestion: subheadings)

flink/docs/assets/_fonts.scss
 lucida (suggestion: lucina)
 arial (suggestion: ariel)

flink/docs/layouts/partials/docs/simple-title.html
 sytling (suggestion: styling)

flink/docs/layouts/partials/docs/inject/menu-after.html
 dictonary (suggestion: dictionary)

flink/docs/layouts/shortcodes/version.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

flink/docs/layouts/shortcodes/beta.html
 guaruntees (suggestion: guarantees)

flink/docs/layouts/shortcodes/stable.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

```

 

some of them are real typos which need to be fixed.

Codetypo can also check code typos. I just have no time to run over it.

 

 


> fix typos in docs
> -
>
> Key: FLINK-23044
> URL: https://issues.apache.org/jira/browse/FLINK-23044
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Huang Yu
>Priority: Minor
>  Labels: typo
> Fix For: 1.14.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
> typos in Flink documents.
>  
>  
> {color:#505f79}[xiaochu.yh ~/tools/codetypo] (main) $python checker.py 
> flink/docs/{color}
> {color:#505f79}flink/docs/README.md{color}
> {color:#505f79} ommitted (suggestion: omitted){color}
> {color:#505f79} groupd (suggestion: group){color}
> {color:#505f79} artfiact (suggestion: artifact){color}
> {color:#505f79} sometab (suggestion: sometag){color}
> {color:#505f79} verison (suggestion: verion){color}
> {color:#505f79} pgenerate (suggestion: generate){color}
> {color:#505f79} harnesses (suggestion: harnessed){color}
> {color:#505f79} flavored (suggestion: favored){color}
> {color:#505f79} shortcode (suggestion: sortcode){color}
> {color:#505f79} flinks (suggestion: blinks){color}
> {color:#505f79}flink/docs/assets/github.css{color}
> 

[jira] [Updated] (FLINK-23044) fix typos in docs

2021-06-20 Thread Huang Yu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Yu updated FLINK-23044:
-
Description: 
using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
typos in Flink documents.

 

 

[xiaochu.yh ~/tools/codetypo] (main) $python checker.py flink/docs/

flink/docs/README.md
 ommitted (suggestion: omitted)
 groupd (suggestion: group)
 artfiact (suggestion: artifact)
 sometab (suggestion: sometag)
 verison (suggestion: verion)
 pgenerate (suggestion: generate)
 harnesses (suggestion: harnessed)
 flavored (suggestion: favored)
 shortcode (suggestion: sortcode)
 flinks (suggestion: blinks)

flink/docs/assets/github.css
 lntable (suggestion: ntable)
 affix (suggestion: affin)
 cc (suggestion: fffcc)
 subheading (suggestion: subheadings)

flink/docs/assets/_fonts.scss
 lucida (suggestion: lucina)
 arial (suggestion: ariel)

flink/docs/layouts/partials/docs/simple-title.html
 sytling (suggestion: styling)

flink/docs/layouts/partials/docs/inject/menu-after.html
 dictonary (suggestion: dictionary)

flink/docs/layouts/shortcodes/version.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

flink/docs/layouts/shortcodes/beta.html
 guaruntees (suggestion: guarantees)

flink/docs/layouts/shortcodes/stable.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

```

 

some of them are real typos which need to be fixed.

Codetypo can also check code typos. I just have no time to run over it.

 

 

  was:
using [codetypo](https://www.github.com/raywill/codetypo) I can find tons of 
typos in documents.

 

```

[xiaochu.yh ~/tools/codetypo] (main) $python checker.py flink/docs/

flink/docs/README.md
 ommitted (suggestion: omitted)
 groupd (suggestion: group)
 artfiact (suggestion: artifact)
 sometab (suggestion: sometag)
 verison (suggestion: verion)
 pgenerate (suggestion: generate)
 harnesses (suggestion: harnessed)
 flavored (suggestion: favored)
 shortcode (suggestion: sortcode)
 flinks (suggestion: blinks)

flink/docs/assets/github.css
 lntable (suggestion: ntable)
 affix (suggestion: affin)
 cc (suggestion: fffcc)
 subheading (suggestion: subheadings)

flink/docs/assets/_fonts.scss
 lucida (suggestion: lucina)
 arial (suggestion: ariel)

flink/docs/layouts/partials/docs/simple-title.html
 sytling (suggestion: styling)

flink/docs/layouts/partials/docs/inject/menu-after.html
 dictonary (suggestion: dictionary)

flink/docs/layouts/shortcodes/version.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

flink/docs/layouts/shortcodes/beta.html
 guaruntees (suggestion: guarantees)

flink/docs/layouts/shortcodes/stable.html
 parmeters (suggestion: pameters)
 shortcode (suggestion: sortcode)

```

 

some of them are real typos which need to be fixed.

 


> fix typos in docs
> -
>
> Key: FLINK-23044
> URL: https://issues.apache.org/jira/browse/FLINK-23044
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Huang Yu
>Priority: Minor
>  Labels: typo
> Fix For: 1.14.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> using [codetypo|[https://www.github.com/raywill/codetypo]]  I found tons of 
> typos in Flink documents.
>  
>  
> [xiaochu.yh ~/tools/codetypo] (main) $python checker.py flink/docs/
> flink/docs/README.md
>  ommitted (suggestion: omitted)
>  groupd (suggestion: group)
>  artfiact (suggestion: artifact)
>  sometab (suggestion: sometag)
>  verison (suggestion: verion)
>  pgenerate (suggestion: generate)
>  harnesses (suggestion: harnessed)
>  flavored (suggestion: favored)
>  shortcode (suggestion: sortcode)
>  flinks (suggestion: blinks)
> flink/docs/assets/github.css
>  lntable (suggestion: ntable)
>  affix (suggestion: affin)
>  cc (suggestion: fffcc)
>  subheading (suggestion: subheadings)
> flink/docs/assets/_fonts.scss
>  lucida (suggestion: lucina)
>  arial (suggestion: ariel)
> flink/docs/layouts/partials/docs/simple-title.html
>  sytling (suggestion: styling)
> flink/docs/layouts/partials/docs/inject/menu-after.html
>  dictonary (suggestion: dictionary)
> flink/docs/layouts/shortcodes/version.html
>  parmeters (suggestion: pameters)
>  shortcode (suggestion: sortcode)
> flink/docs/layouts/shortcodes/beta.html
>  guaruntees (suggestion: guarantees)
> flink/docs/layouts/shortcodes/stable.html
>  parmeters (suggestion: pameters)
>  shortcode (suggestion: sortcode)
> ```
>  
> some of them are real typos which need to be fixed.
> Codetypo can also check code typos. I just have no time to run over it.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366331#comment-17366331
 ] 

Xintong Song commented on FLINK-22085:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19152=logs=ce8f3cc3-c1ea-5281-f5eb-df9ebd24947f=f266c805-9429-58ed-2f9e-482e7b82f58b=6601

> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to this channel if it is called on 
> this channel again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-23045) RunnablesTest.testExecutorService_uncaughtExceptionHandler fails on azure

2021-06-20 Thread Xintong Song (Jira)
Xintong Song created FLINK-23045:


 Summary: 
RunnablesTest.testExecutorService_uncaughtExceptionHandler fails on azure
 Key: FLINK-23045
 URL: https://issues.apache.org/jira/browse/FLINK-23045
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Coordination
Affects Versions: 1.14.0
Reporter: Xintong Song
 Fix For: 1.14.0


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19152=logs=3b6ec2fd-a816-5e75-c775-06fb87cb6670=2aff8966-346f-518f-e6ce-de64002a5034=6902
{code}
Jun 18 21:25:48 [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time 
elapsed: 0.402 s <<< FAILURE! - in org.apache.flink.runtime.util.RunnablesTest
Jun 18 21:25:48 [ERROR] 
testExecutorService_uncaughtExceptionHandler(org.apache.flink.runtime.util.RunnablesTest)
  Time elapsed: 0.121 s  <<< FAILURE!
Jun 18 21:25:48 java.lang.AssertionError: Expected handler to be called.
Jun 18 21:25:48 at org.junit.Assert.fail(Assert.java:89)
Jun 18 21:25:48 at org.junit.Assert.assertTrue(Assert.java:42)
Jun 18 21:25:48 at 
org.apache.flink.runtime.util.RunnablesTest.testExecutorService_uncaughtExceptionHandler(RunnablesTest.java:56)
Jun 18 21:25:48 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Jun 18 21:25:48 at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Jun 18 21:25:48 at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Jun 18 21:25:48 at java.lang.reflect.Method.invoke(Method.java:498)
Jun 18 21:25:48 at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
Jun 18 21:25:48 at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Jun 18 21:25:48 at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
Jun 18 21:25:48 at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
Jun 18 21:25:48 at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
Jun 18 21:25:48 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
Jun 18 21:25:48 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
Jun 18 21:25:48 at 
org.junit.runners.ParentRunner.run(ParentRunner.java:413)
Jun 18 21:25:48 at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
Jun 18 21:25:48 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
Jun 18 21:25:48 at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
Jun 18 21:25:48 at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
Jun 18 21:25:48 at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
Jun 18 21:25:48 at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
Jun 18 21:25:48 at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
Jun 18 21:25:48 at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] chaplinthink commented on pull request #16198: [hotfix] Improve tuple equal code logic

2021-06-20 Thread GitBox


chaplinthink commented on pull request #16198:
URL: https://github.com/apache/flink/pull/16198#issuecomment-864673718


   @lirui-apache  Could you give this pull request a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-22085) KafkaSourceLegacyITCase hangs/fails on azure

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-22085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366330#comment-17366330
 ] 

Xintong Song commented on FLINK-22085:
--

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=19124=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=6632

> KafkaSourceLegacyITCase hangs/fails on azure
> 
>
> Key: FLINK-22085
> URL: https://issues.apache.org/jira/browse/FLINK-22085
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Dawid Wysakowicz
>Assignee: Yun Gao
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.14.0
>
>
> 1) Observations
> a) The Azure pipeline would occasionally hang without printing any test error 
> information.
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15939=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5=8219]
> b) By running the test KafkaSourceLegacyITCase::testBrokerFailure() with INFO 
> level logging, the the test would hang with the following error message 
> printed repeatedly:
> {code:java}
> 20451 [New I/O boss #50] ERROR 
> org.apache.flink.networking.NetworkFailureHandler [] - Closing communication 
> channel because of an exception
> java.net.ConnectException: Connection refused: localhost/127.0.0.1:50073
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[?:1.8.0_151]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[?:1.8.0_151]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
>  ~[flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> org.apache.flink.shaded.testutils.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>  [flink-test-utils_2.11-1.13-SNAPSHOT.jar:1.13-SNAPSHOT]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [?:1.8.0_151]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_151]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]
> {code}
> *2) Root cause explanations*
> The test would hang because it enters the following loop:
>  - closeOnFlush() is called for a given channel
>  - closeOnFlush() calls channel.write(..)
>  - channel.write() triggers the exceptionCaught(...) callback
>  - closeOnFlush() is called for the same channel again.
> *3) Solution*
> Update closeOnFlush() so that, if a channel is being closed by this method, 
> then closeOnFlush() would not try to write to this channel if it is called on 
> this channel again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21440) Translate Real Time Reporting with the Table API doc and correct a spelling mistake

2021-06-20 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366329#comment-17366329
 ] 

Xintong Song commented on FLINK-21440:
--

There is already a PR opened months ago, which seems have not received 
attention from any committer.

[~guotaoli429], are you still working on this?

PS: It would be easier for a contribution get reviewed/merged if you can find a 
committer to assign you to the jira ticket before starting to work on the PR. 
If you don't know whom to ping, you can ask on the dev mailing list.

> Translate Real Time Reporting with the Table API doc and correct a spelling 
> mistake
> ---
>
> Key: FLINK-21440
> URL: https://issues.apache.org/jira/browse/FLINK-21440
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation, Table SQL / Ecosystem
>Reporter: GuotaoLi
>Priority: Major
>  Labels: pull-request-available
>
> * Translate Real Time Reporting with the Table API doc to Chinese
> * Correct Real Time Reporting with the Table API doc allong with spelling 
> mistake to along with



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] becketqin commented on a change in pull request #15531: [FLINK-22147][connector/kafka] Refactor partition discovery logic in Kafka source enumerator

2021-06-20 Thread GitBox


becketqin commented on a change in pull request #15531:
URL: https://github.com/apache/flink/pull/15531#discussion_r655026006



##
File path: 
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java
##
@@ -347,6 +347,41 @@ public void testSnapshotState() throws Throwable {
 state2.assignedPartitions());
 }
 
+@Test
+public void testPartitionChangeChecking() throws Throwable {
+final MockSplitEnumeratorContext context =
+new MockSplitEnumeratorContext<>(NUM_SUBTASKS);
+final KafkaSourceEnumerator enumerator =

Review comment:
   It looks that there is a resource leak here. Supposedly, the 
`KafkaSourceEnumerator` should be closed after the test. As you may notice the 
other test method use the try block to do this. However, the 
`MockSplitEnumeratorContext#close()` did not shutdown the `mainExecutor` and 
`workerExecutor` correctly. This is an existing bug. Would be good to fix it 
either in this patch or a followup patch. In either way, we need to close the 
`KafkaSourceEnumerator` here in the unit tests.

##
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriber.java
##
@@ -41,36 +41,12 @@
 public interface KafkaSubscriber extends Serializable {
 
 /**
- * Get the partitions changes compared to the current partition assignment.
+ * Get a set of subscribed {@link TopicPartition}s.
  *
- * Although Kafka partitions can only expand and will not shrink, the 
partitions may still
- * disappear when the topic is deleted.
- *
- * @param adminClient The admin client used to retrieve partition 
information.
- * @param currentAssignment the partitions that are currently assigned to 
the source readers.
- * @return The partition changes compared with the currently assigned 
partitions.
+ * @param adminClient The admin client used to retrieve subscribed topic 
partitions.
+ * @return A set of subscribed {@link TopicPartition}s
  */
-PartitionChange getPartitionChanges(
-AdminClient adminClient, Set currentAssignment);
-
-/** A container class to hold the newly added partitions and removed 
partitions. */
-class PartitionChange {
-private final Set newPartitions;
-private final Set removedPartitions;
-
-PartitionChange(Set newPartitions, Set 
removedPartitions) {
-this.newPartitions = newPartitions;
-this.removedPartitions = removedPartitions;
-}
-
-public Set getNewPartitions() {
-return newPartitions;
-}
-
-public Set getRemovedPartitions() {
-return removedPartitions;
-}
-}
+Set listSubscribedTopicPartitions(AdminClient adminClient);

Review comment:
   Nit: `getSubscribedTopicPartitions()` might be slightly better from 
naming consistency point of view.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   >