[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * 5a6ed6e276d92cd66fcf3c61483528883426428f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31890) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] imaffe commented on a change in pull request #18816: [FLINK-26027][pulsar] add sink metrics to pulsar sink
imaffe commented on a change in pull request #18816:
URL: https://github.com/apache/flink/pull/18816#discussion_r810455595
##
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/writer/PulsarWriter.java
##
@@ -270,5 +287,40 @@ public void flush(boolean endOfInput) throws IOException,
InterruptedException {
public void close() throws Exception {
// Close all the resources and throw the exception at last.
closeAll(metadataListener, producerRegister);
+closed = true;
+}
+
+private void setupFlinkMetrics() {
+lastMetricUpdateTimestamp = timeService.getCurrentProcessingTime();
+registerGlobalGauges();
+registerMetricUpdateTimer();
+}
+
+/**
+ * Producer is lazy initialized in Pulsar Sink. Some metrics (currently
only some gauges) can
+ * only be set after creating the producer. Those gauges are per producer
wise. Some other
+ * metrics is based aggregation of all producers or they are based on sink
implementations so
+ * they are called global gauges.
+ */
+private void registerGlobalGauges() {
+
pulsarSinkWriterMetrics.setCurrentSendTimeGauge(this::getCurrentSendTime);
+producerRegister.registerMaxSendLatencyGauges();
+}
+
+private void registerMetricUpdateTimer() {
Review comment:
Move these timer tasks to a dedicated class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (FLINK-26049) The tolerable-failed-checkpoints logic is invalid when checkpoint trigger failed
[ https://issues.apache.org/jira/browse/FLINK-26049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-26049: - Assignee: Anton Kalashnikov > The tolerable-failed-checkpoints logic is invalid when checkpoint trigger > failed > > > Key: FLINK-26049 > URL: https://issues.apache.org/jira/browse/FLINK-26049 > Project: Flink > Issue Type: Bug > Components: Runtime / Checkpointing >Affects Versions: 1.13.5, 1.14.3 >Reporter: fanrui >Assignee: Anton Kalashnikov >Priority: Major > Fix For: 1.15.0 > > Attachments: image-2022-02-09-18-08-17-868.png, > image-2022-02-09-18-08-34-992.png, image-2022-02-09-18-08-42-920.png, > image-2022-02-18-11-28-53-337.png, image-2022-02-18-11-33-28-232.png, > image-2022-02-18-11-44-52-745.png > > > After triggerCheckpoint, if checkpoint failed, flink will execute the > tolerable-failed-checkpoints logic. But if triggerCheckpoint failed, flink > won't execute the tolerable-failed-checkpoints logic. > h1. How to reproduce this issue? > In our online env, hdfs sre deletes the flink base dir by mistake, and flink > job don't have permission to create checkpoint dir. So cause flink trigger > checkpoint failed. > There are some didn't meet expectations: > * JM just log _"Failed to trigger checkpoint for job > 6f09d4a15dad42b24d52c987f5471f18 since Trigger checkpoint failure" ._ Don't > show the root cause or exception. > * user set tolerable-failed-checkpoints=0, but if triggerCheckpoint failed, > flink won't execute the tolerable-failed-checkpoints logic. > * When triggerCheckpoint failed, numberOfFailedCheckpoints is always 0 > * When triggerCheckpoint failed, we can't find checkpoint info in checkpoint > history page. > > !image-2022-02-09-18-08-17-868.png! > > !image-2022-02-09-18-08-34-992.png! > !image-2022-02-09-18-08-42-920.png! > > h3. *All metrics are normal, so the next day we found out that the checkpoint > failed, and the checkpoint has been failing for a day. it's not acceptable to > the flink user.* > I have some ideas: > # Should tolerable-failed-checkpoints logic be executed when > triggerCheckpoint fails? > # When triggerCheckpoint failed, should increase numberOfFailedCheckpoints? > # When triggerCheckpoint failed, should show checkpoint info in checkpoint > history page? > # JM just show "Failed to trigger checkpoint", should we show detailed > exception to easy find the root cause? > > Masters, could we do these changes? Please correct me if I'm wrong. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FLINK-26049) The tolerable-failed-checkpoints logic is invalid when checkpoint trigger failed
[ https://issues.apache.org/jira/browse/FLINK-26049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-26049: - Assignee: fanrui (was: Anton Kalashnikov) > The tolerable-failed-checkpoints logic is invalid when checkpoint trigger > failed > > > Key: FLINK-26049 > URL: https://issues.apache.org/jira/browse/FLINK-26049 > Project: Flink > Issue Type: Bug > Components: Runtime / Checkpointing >Affects Versions: 1.13.5, 1.14.3 >Reporter: fanrui >Assignee: fanrui >Priority: Major > Fix For: 1.15.0 > > Attachments: image-2022-02-09-18-08-17-868.png, > image-2022-02-09-18-08-34-992.png, image-2022-02-09-18-08-42-920.png, > image-2022-02-18-11-28-53-337.png, image-2022-02-18-11-33-28-232.png, > image-2022-02-18-11-44-52-745.png > > > After triggerCheckpoint, if checkpoint failed, flink will execute the > tolerable-failed-checkpoints logic. But if triggerCheckpoint failed, flink > won't execute the tolerable-failed-checkpoints logic. > h1. How to reproduce this issue? > In our online env, hdfs sre deletes the flink base dir by mistake, and flink > job don't have permission to create checkpoint dir. So cause flink trigger > checkpoint failed. > There are some didn't meet expectations: > * JM just log _"Failed to trigger checkpoint for job > 6f09d4a15dad42b24d52c987f5471f18 since Trigger checkpoint failure" ._ Don't > show the root cause or exception. > * user set tolerable-failed-checkpoints=0, but if triggerCheckpoint failed, > flink won't execute the tolerable-failed-checkpoints logic. > * When triggerCheckpoint failed, numberOfFailedCheckpoints is always 0 > * When triggerCheckpoint failed, we can't find checkpoint info in checkpoint > history page. > > !image-2022-02-09-18-08-17-868.png! > > !image-2022-02-09-18-08-34-992.png! > !image-2022-02-09-18-08-42-920.png! > > h3. *All metrics are normal, so the next day we found out that the checkpoint > failed, and the checkpoint has been failing for a day. it's not acceptable to > the flink user.* > I have some ideas: > # Should tolerable-failed-checkpoints logic be executed when > triggerCheckpoint fails? > # When triggerCheckpoint failed, should increase numberOfFailedCheckpoints? > # When triggerCheckpoint failed, should show checkpoint info in checkpoint > history page? > # JM just show "Failed to trigger checkpoint", should we show detailed > exception to easy find the root cause? > > Masters, could we do these changes? Please correct me if I'm wrong. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-26049) The tolerable-failed-checkpoints logic is invalid when checkpoint trigger failed
[ https://issues.apache.org/jira/browse/FLINK-26049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494897#comment-17494897 ] fanrui commented on FLINK-26049: Hi [~akalashnikov] . Actually, I'm working on this JIRA, I'm pleasant to do it. Could you assign to me, please? Thanks a lot. > The tolerable-failed-checkpoints logic is invalid when checkpoint trigger > failed > > > Key: FLINK-26049 > URL: https://issues.apache.org/jira/browse/FLINK-26049 > Project: Flink > Issue Type: Bug > Components: Runtime / Checkpointing >Affects Versions: 1.13.5, 1.14.3 >Reporter: fanrui >Priority: Major > Fix For: 1.15.0 > > Attachments: image-2022-02-09-18-08-17-868.png, > image-2022-02-09-18-08-34-992.png, image-2022-02-09-18-08-42-920.png, > image-2022-02-18-11-28-53-337.png, image-2022-02-18-11-33-28-232.png, > image-2022-02-18-11-44-52-745.png > > > After triggerCheckpoint, if checkpoint failed, flink will execute the > tolerable-failed-checkpoints logic. But if triggerCheckpoint failed, flink > won't execute the tolerable-failed-checkpoints logic. > h1. How to reproduce this issue? > In our online env, hdfs sre deletes the flink base dir by mistake, and flink > job don't have permission to create checkpoint dir. So cause flink trigger > checkpoint failed. > There are some didn't meet expectations: > * JM just log _"Failed to trigger checkpoint for job > 6f09d4a15dad42b24d52c987f5471f18 since Trigger checkpoint failure" ._ Don't > show the root cause or exception. > * user set tolerable-failed-checkpoints=0, but if triggerCheckpoint failed, > flink won't execute the tolerable-failed-checkpoints logic. > * When triggerCheckpoint failed, numberOfFailedCheckpoints is always 0 > * When triggerCheckpoint failed, we can't find checkpoint info in checkpoint > history page. > > !image-2022-02-09-18-08-17-868.png! > > !image-2022-02-09-18-08-34-992.png! > !image-2022-02-09-18-08-42-920.png! > > h3. *All metrics are normal, so the next day we found out that the checkpoint > failed, and the checkpoint has been failing for a day. it's not acceptable to > the flink user.* > I have some ideas: > # Should tolerable-failed-checkpoints logic be executed when > triggerCheckpoint fails? > # When triggerCheckpoint failed, should increase numberOfFailedCheckpoints? > # When triggerCheckpoint failed, should show checkpoint info in checkpoint > history page? > # JM just show "Failed to trigger checkpoint", should we show detailed > exception to easy find the root cause? > > Masters, could we do these changes? Please correct me if I'm wrong. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] imaffe commented on a change in pull request #18406: [FLINK-25686][pulsar]: add schema evolution support for pulsar source connector
imaffe commented on a change in pull request #18406:
URL: https://github.com/apache/flink/pull/18406#discussion_r810451071
##
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java
##
@@ -104,24 +104,31 @@ protected PulsarPartitionSplitReaderBase(
PulsarMessageCollector collector = new
PulsarMessageCollector<>(splitId, builder);
Deadline deadline =
Deadline.fromNow(sourceConfiguration.getMaxFetchTime());
-// Consume message from pulsar until it was woke up by flink reader.
+// Consume message from pulsar until it was woken up by flink reader.
for (int messageNum = 0;
messageNum < sourceConfiguration.getMaxFetchRecords()
&& deadline.hasTimeLeft()
&& isNotWakeup();
messageNum++) {
try {
Duration timeout = deadline.timeLeftIfAny();
-Message message = pollMessage(timeout);
+Message message = pollMessage(timeout);
if (message == null) {
break;
}
-// Deserialize message.
collector.setMessage(message);
-deserializationSchema.deserialize(message, collector);
-// Acknowledge message if need.
+// Deserialize message by DeserializationSchema or Pulsar
Schema.
+if (sourceConfiguration.isEnableSchemaEvolution()) {
Review comment:
If we implement that way, we can use a different approach to support
schema evolution, in that case, users uses nativePulsarSchema(...) and pass
this `PulsarDeserializationSchema` impl to pulsar source build, and
ENABLE_SCHEMA_EVOLUTION related configs is not necessary in that case. The good
part is that the schema evolution semantics are more fine-grained.
The downside is our api turns from 3 to 4: originally only support
TypeInformation, flink and pulsar, now we have a nativePulsar (which is the
only schema that supports schema evolution)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31890) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] 2011aad commented on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails in time
2011aad commented on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1045744785 @tsreaper I've implement a test case to verify the problem is solved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 5a6ed6e276d92cd66fcf3c61483528883426428f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26191) Incorrect license in Elasticsearch connectors
[ https://issues.apache.org/jira/browse/FLINK-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494888#comment-17494888 ] Jark Wu commented on FLINK-26191: - Yes, I think so. > Incorrect license in Elasticsearch connectors > - > > Key: FLINK-26191 > URL: https://issues.apache.org/jira/browse/FLINK-26191 > Project: Flink > Issue Type: Technical Debt > Components: Connectors / ElasticSearch >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.15.0 > > > The sql-connector-elasticsearc0h 6/7 connector NOTICE lists the elasticsearch > dependencies as ASLv2, but they are nowadays (at least in part) licensed > differently (dual-licensed under elastic license 2.0 & Server Side Public > License (SSPL)). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * 60d1f1ada7a8b6f6d34f1b96ce2ca13fd786429f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31775) * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) * 6d6a9a74d05dd13be0813bb7ef8abfc1956c19f0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18851: [hotfix][docs] Unified variable naming
flinkbot edited a comment on pull request #18851: URL: https://github.com/apache/flink/pull/18851#issuecomment-1045544069 ## CI report: * 79e83225190aea96f05afd0a33ffaf2fe33c72f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31888) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] (FLINK-15133) support sql_alchemy in Flink for broader python sql integration
[ https://issues.apache.org/jira/browse/FLINK-15133 ] Tom Hutchinson deleted comment on FLINK-15133: was (Author: JIRAUSER285275): SQLAlchemy is not just an ORM. The ORM portion is optional. SQLAlchemy Core API covers basics like using JDBC and ODBC drivers, establishing connections, sending a query, etc. > support sql_alchemy in Flink for broader python sql integration > --- > > Key: FLINK-15133 > URL: https://issues.apache.org/jira/browse/FLINK-15133 > Project: Flink > Issue Type: New Feature > Components: API / Python, Table SQL / Ecosystem >Reporter: Bowen Li >Priority: Not a Priority > Labels: auto-deprioritized-major, auto-deprioritized-minor > > sql_alchemy is the standard interface for python sql ecosystem > examples of integrations requiring sql_alchemy: > - https://github.com/cloudera/hue > - https://github.com/lyft/amundsen -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * 60d1f1ada7a8b6f6d34f1b96ce2ca13fd786429f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31775) * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31889) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails
flinkbot edited a comment on pull request #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1042955765 ## CI report: * 60d1f1ada7a8b6f6d34f1b96ce2ca13fd786429f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31775) * a64f6b875fb2b00c7dd9d85a8a559d87e60e77c1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] hongshuboy commented on pull request #18851: [hotfix][docs] Unified variable naming
hongshuboy commented on pull request #18851: URL: https://github.com/apache/flink/pull/18851#issuecomment-104554 **Session Window Join and other examples** the variable names are named `first` and `second` https://user-images.githubusercontent.com/40915465/154781641-11b54922-c6a4-4a25-b38f-7c140b8a935e.png;> **Interval Join Example** the variable names are named `left` and `right` https://user-images.githubusercontent.com/40915465/154781678-e0894629-98fc-4cf9-a013-fcddc87113b7.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18851: [hotfix][docs] Unified variable naming
flinkbot commented on pull request #18851: URL: https://github.com/apache/flink/pull/18851#issuecomment-1045549518 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 79e83225190aea96f05afd0a33ffaf2fe33c72f8 (Sat Feb 19 02:01:20 UTC 2022) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18851: [hotfix][docs] Unified variable naming
flinkbot edited a comment on pull request #18851: URL: https://github.com/apache/flink/pull/18851#issuecomment-1045544069 ## CI report: * 79e83225190aea96f05afd0a33ffaf2fe33c72f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31888) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18851: [hotfix][docs] Unified variable naming
flinkbot commented on pull request #18851: URL: https://github.com/apache/flink/pull/18851#issuecomment-1045544069 ## CI report: * 79e83225190aea96f05afd0a33ffaf2fe33c72f8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] hongshuboy opened a new pull request #18851: [hotfix][docs] Unified variable naming
hongshuboy opened a new pull request #18851: URL: https://github.com/apache/flink/pull/18851 ## What is the purpose of the change In page [joining](https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/datastream/operators/joining/#interval-join), the variable names are named `first` and `second`, but in the example of `Interval Join`, the variable names are named `left` and `right`, we should unified variable naming ## Brief change log Unified variable naming on page joining ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26255) SplitAggregateITCase.testAggWithJoin failed on azure
[
https://issues.apache.org/jira/browse/FLINK-26255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494833#comment-17494833
]
Roman Khachatryan commented on FLINK-26255:
---
Likely a duplicate of FLINK-26231.
> SplitAggregateITCase.testAggWithJoin failed on azure
>
>
> Key: FLINK-26255
> URL: https://issues.apache.org/jira/browse/FLINK-26255
> Project: Flink
> Issue Type: Bug
> Components: Runtime / State Backends
>Affects Versions: 1.15.0
>Reporter: Roman Khachatryan
>Assignee: Roman Khachatryan
>Priority: Blocker
> Fix For: 1.15.0
>
>
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=31850=logs=0c940707-2659-5648-cbe6-a1ad63045f0a=075c2716-8010-5565-fe08-3c4bb45824a4=10497]
> Acknowledge of a checkpoint failed, then the checkpoint expired, then
> checkpoint failure threshold was reached and job failed.
> {code}
> Randomly selected true for execution.checkpointing.unaligned
> Randomly selected PT2S for execution.checkpointing.alignment-timeout
> Randomly selected true for state.backend.changelog.enabled
> Randomly selected PT0.1S for
> state.backend.changelog.periodic-materialize.interval
> {code}
> {code}
> [ERROR] Tests run: 64, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 700.545 s <<< FAILURE! - in
> org.apache.flink.table.planner.runtime.stream.sql.SplitAggregateITCase
> [ERROR] SplitAggregateITCase.testAggWithJoin Time elapsed: 601.77 s <<<
> ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:144)
> at
> org.apache.flink.runtime.minicluster.MiniClusterJobClient.lambda$getJobExecutionResult$3(MiniCl
> usterJobClient.java:141)
> at
> java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)
> at
> java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
> at
> java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
> at
> java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
> at
> org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler.lambda$invokeRpc$1(AkkaInvocationHandle
> r.java:259)
> at
> java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
> at
> java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
> at
> java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
> at
> java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
> at
> org.apache.flink.util.concurrent.FutureUtils.doForward(FutureUtils.java:1389)
> at
> org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.lambda$null$1(ClassLoadingUtils.java
> :93)
> at
> org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.runWithContextClassLoader(ClassLoadi
> ngUtils.java:68)
> at
> org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.lambda$guardCompletionWithContextCla
> ssLoader$2(ClassLoadingUtils.java:92)
> at
> java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
> at
> java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
> at
> java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
> at
> java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
> at
> org.apache.flink.runtime.concurrent.akka.AkkaFutureUtils$1.onComplete(AkkaFutureUtils.java:47)
> at akka.dispatch.OnComplete.internal(Future.scala:300)
> at akka.dispatch.OnComplete.internal(Future.scala:297)
> at akka.dispatch.japi$CallbackBridge.apply(Future.scala:224)
> at akka.dispatch.japi$CallbackBridge.apply(Future.scala:221)
> at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60)
> at
> org.apache.flink.runtime.concurrent.akka.AkkaFutureUtils$DirectExecutionContext.execute(AkkaFut
> ureUtils.java:65)
> at
> scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:68)
> at
> scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1(Promise.scala:284)
> at
> scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1$adapted(Promise.scala:284)
> at
> scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:284)
> ...
> Caused by: org.apache.flink.util.FlinkRuntimeException: Exceeded checkpoint
> tolerable failure threshold.
> at
> org.apache.flink.runtime.checkpoint.CheckpointFailureManager.checkFailureAgainstCounter(Checkpo
> intFailureManager.java:160)
> at
> org.apache.flink.runtime.checkpoint.CheckpointFailureManager.handleJobLevelCheckpointException(
>
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * d2793da2669462117d17c825648eede9c343da96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31884) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18846: [FLINK-26223] Enables INFO logging for ZooKeeper into separate file
flinkbot edited a comment on pull request #18846: URL: https://github.com/apache/flink/pull/18846#issuecomment-1044512809 ## CI report: * 7087074578534ca446a89c453a09657b8dc37cd5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31882) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * b9afe8cee1a1886bcb43e314ee66d064627bcaa6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31883) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error
JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810298689
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##
@@ -35,12 +35,20 @@
implements SinkWriterMetricGroup {
private final Counter numRecordsOutErrors;
+private final Counter numRecordsWritten;
+private final Counter numBytesWritten;
private final OperatorIOMetricGroup operatorIOMetricGroup;
private InternalSinkWriterMetricGroup(
MetricGroup parentMetricGroup, OperatorIOMetricGroup
operatorIOMetricGroup) {
super(parentMetricGroup);
numRecordsOutErrors =
parentMetricGroup.counter(MetricNames.NUM_RECORDS_OUT_ERRORS);
+numRecordsWritten =
+parentMetricGroup.counter(
+
org.apache.flink.runtime.metrics.MetricNames.IO_NUM_RECORDS_OUT);
Review comment:
hmm, thanks for pointing it out. I have two questions.
First question, Which counter with the same name do you mean? Do you mean
the one within the `operatorIOMetricGroup`? Both of them have the same name but
belong to different metricGroups. It is intended to define the second counter
for the same records output purpose. This one is used for SinkWriter and the
other one within the `operatorIOMetricGroup` is used for the
`SinkWriterOperator `.
Second question, What do you mean "never exported"? Is there anything else
should be done to make ti be exported? Do we have tech guide somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error
JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810298689
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##
@@ -35,12 +35,20 @@
implements SinkWriterMetricGroup {
private final Counter numRecordsOutErrors;
+private final Counter numRecordsWritten;
+private final Counter numBytesWritten;
private final OperatorIOMetricGroup operatorIOMetricGroup;
private InternalSinkWriterMetricGroup(
MetricGroup parentMetricGroup, OperatorIOMetricGroup
operatorIOMetricGroup) {
super(parentMetricGroup);
numRecordsOutErrors =
parentMetricGroup.counter(MetricNames.NUM_RECORDS_OUT_ERRORS);
+numRecordsWritten =
+parentMetricGroup.counter(
+
org.apache.flink.runtime.metrics.MetricNames.IO_NUM_RECORDS_OUT);
Review comment:
hmm, thanks for pointing it out. I have two questions.
First question, Which counter with the same name do you mean? Do you mean
the one within the `operatorIOMetricGroup`? Both of them have the same name but
belong to different metricGroups. It is intended to define the second counter
for the same purpose. This one is used for SinkWriter and the other one within
the `operatorIOMetricGroup` is used for the `SinkWriterOperator `.
Second question, What do you mean "never exported"? Is there anything else
should be done to make ti be exported? Do we have tech guide somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error
JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810298689
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##
@@ -35,12 +35,20 @@
implements SinkWriterMetricGroup {
private final Counter numRecordsOutErrors;
+private final Counter numRecordsWritten;
+private final Counter numBytesWritten;
private final OperatorIOMetricGroup operatorIOMetricGroup;
private InternalSinkWriterMetricGroup(
MetricGroup parentMetricGroup, OperatorIOMetricGroup
operatorIOMetricGroup) {
super(parentMetricGroup);
numRecordsOutErrors =
parentMetricGroup.counter(MetricNames.NUM_RECORDS_OUT_ERRORS);
+numRecordsWritten =
+parentMetricGroup.counter(
+
org.apache.flink.runtime.metrics.MetricNames.IO_NUM_RECORDS_OUT);
Review comment:
hmm, thanks for pointing it out. I have two questions.
First question, Which counter with the same name do you mean? Do you mean
the one within the `operatorIOMetricGroup`? Both of them have the same name but
belong to different metricGroup. It is intended to define the second counter
for the same purpose. This one is used for SinkWriter and the other one within
the `operatorIOMetricGroup` is used for the `SinkWriterOperator `.
Second question, What do you mean "never exported"? Is there anything else
should be done to make ti be exported? Do we have tech guide somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18850: [FLINK-26146][FLINK-26176] Native snapshot test coverage and test fix
flinkbot edited a comment on pull request #18850: URL: https://github.com/apache/flink/pull/18850#issuecomment-1044782524 ## CI report: * 941b3ebf8810adab424ae84c60380c20d4958fe8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31881) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error
JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810286891
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##
@@ -71,6 +79,16 @@ public Counter getNumRecordsOutErrorsCounter() {
return numRecordsOutErrors;
}
+@Override
+public org.apache.flink.metrics.Counter getNumRecordsWrittenCounter() {
Review comment:
ops, I have changed the IDEA settings for other issues. I will change it
back. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-web] sjwiesman commented on a change in pull request #508: [blog] Scala Free in One Fifteen
sjwiesman commented on a change in pull request #508:
URL: https://github.com/apache/flink-web/pull/508#discussion_r810273744
##
File path: _posts/2022-02-22-scala-free.md
##
@@ -0,0 +1,77 @@
+---
+layout: post
+title: "Scala Free in One Fifteen"
+date: 2022-02-22 00:00:00
+authors:
+- sjwiesman:
+ name: "Seth Wiesman"
+ twitter: "sjwiesman"
+excerpt: Apache Flink's runtime is now Scala free, allowing users to leverage
any Scala version in their user code - including Scala 3!
+---
+
+Flink 1.15 is right around the corner, and among the many improvements is a
Scala free classpath.
+Users can now leverage the Java API from any Scala version, including Scala 3!
+
+
+
+ Fig.1 Flink
1.15 Scala 3 Example
+
+
+This blog will discuss what has historically made supporting multiple Scala
versions so complex, how we achieved this milestone, and the future of Scala in
Apache Flink.
+
+{% toc %}
+
+## The Classpath and Scala
+
+If you have worked with a JVM-based application, you have probably heard the
term classpath.
+The classpath defines where the JVM will search for a given classfile when it
needs to be loaded.
+There may only be one instance of a classfile on each classpath, forcing any
dependency Flink exposes onto users.
+That is why the Flink community works hard to keep our classpath "clean" - or
free of unnecessary dependencies.
+We achieve this through a combination of [shaded
dependencies](https://github.com/apache/flink-shaded), [child first class
loading](https://nightlies.apache.org/flink/flink-docs-stable/docs/ops/debugging/debugging_classloading/#inverted-class-loading-and-classloader-resolution-order),
and a [plugins
abstraction](https://nightlies.apache.org/flink/flink-docs-stable/docs/deployment/filesystems/plugins/)
for optional components.
+
+The Apache Flink runtime is primarily written in Java but contains critical
components that forced Scala on the default classpath.
+And because Scala does not maintain binary compatibility across minor
releases, this historically required cross-building components for all versions
of Scala.
+But due to many reasons - [breaking changes in the
compiler](https://github.com/scala/scala/releases/tag/v2.12.8), [a new standard
library](https://www.scala-lang.org/news/2.13.0), and [a reworked macro
system](https://docs.scala-lang.org/scala3/guides/macros/macros.html) - this
was easier said than done.
+
+## Hiding Scala
+
+As mentioned above, Flink uses Scala in a few key components; Mesos
integration, the serialization stack, RPC, and the table planner.
+Instead of removing these dependencies or finding ways to cross-build them,
the community hid Scala.
+It still exists in the codebase but no longer leaks into the user code
classloader.
+
+In 1.14, we took our first steps in hiding Scala from our users.
+In 1.14, we took our first steps in hiding Scala from our users. We dropped
the support for Apache Mesos, partially implemented in Scala, which Kubernetes
very much eclipsed in terms of adoption.
Review comment:
```suggestion
We dropped the support for Apache Mesos, partially implemented in Scala,
which Kubernetes very much eclipsed in terms of adoption.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18847: [FLINK-26252][runtime][test-utils] Refactor MiniClusterExtension to support JUnit 5 parallel tests
flinkbot edited a comment on pull request #18847: URL: https://github.com/apache/flink/pull/18847#issuecomment-1044577413 ## CI report: * 76e62e9c69b2835af3c30fd43413b0ac72915a90 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31880) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18544: [FLINK-25851][Connectors][Cassandra][test] support dynamic tables names for POJOs
flinkbot edited a comment on pull request #18544: URL: https://github.com/apache/flink/pull/18544#issuecomment-1023467704 ## CI report: * a05d36144df2891726cbf8dea17bff7bf5398c28 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31876) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18813: [FLINK-26125][docs][table] Add new documentation for the CAST changes in 1.15
flinkbot edited a comment on pull request #18813: URL: https://github.com/apache/flink/pull/18813#issuecomment-1042696330 ## CI report: * 377059ed8fa8c70af0614294e14703b6d5d9b631 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31878) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18770: [FLINK-26132][table-planner] Now anonymous tables serialization won't use the flag CatalogPlanCompilation anymore
flinkbot edited a comment on pull request #18770: URL: https://github.com/apache/flink/pull/18770#issuecomment-1039994674 ## CI report: * 0f103ca99b3669fafc6c514f31a2799ec97b96fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31875) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18751: [FLINK-26120][tests] Relax CheckpointIDCounterTestBase assertions
flinkbot edited a comment on pull request #18751: URL: https://github.com/apache/flink/pull/18751#issuecomment-1038987093 ## CI report: * 390b90a7e040e58097b48579455fe57017599e82 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31870) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
flinkbot edited a comment on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1041224101 ## CI report: * 4b81605fceb3782214b3aa28bfa9097ae0bdf6b0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31762) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tiraffe closed pull request #18563: Fix the java example in interval-join
tiraffe closed pull request #18563: URL: https://github.com/apache/flink/pull/18563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18848: [FLINK-26251][akka] Migrate test to JUnit5
flinkbot edited a comment on pull request #18848: URL: https://github.com/apache/flink/pull/18848#issuecomment-1044585789 ## CI report: * 1e81141b802b4209edaf323761e2b0254e3729e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31866) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * 1a32563b7691d8e8d795fd1adbbc830d283fd3d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31873) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18812: [FLINK-25129][docs] Improvements to the table-planner-loader related docs
flinkbot edited a comment on pull request #18812: URL: https://github.com/apache/flink/pull/18812#issuecomment-1042692210 ## CI report: * cf002165ae8ec31a2ff61f503baf075a191dbf11 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31871) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) * d2793da2669462117d17c825648eede9c343da96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31884) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * b9afe8cee1a1886bcb43e314ee66d064627bcaa6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31883) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) * d2793da2669462117d17c825648eede9c343da96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * b9afe8cee1a1886bcb43e314ee66d064627bcaa6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26236) Track and cap retries in ReconciliationStatus
[
https://issues.apache.org/jira/browse/FLINK-26236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494727#comment-17494727
]
Gyula Fora commented on FLINK-26236:
Seems like the operator SDK provides an out of the box logic for retrying
errors and setting a custom status by implementing a simple interface.
We should probably use this and instead if catching the errors and setting the
error status, use this directly:
[https://javaoperatorsdk.io/docs/features]
{{public interface ErrorStatusHandler {}}
> Track and cap retries in ReconciliationStatus
> -
>
> Key: FLINK-26236
> URL: https://issues.apache.org/jira/browse/FLINK-26236
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Gyula Fora
>Priority: Major
>
> At the moment we retry errors again and again indefinitely. As suggested by
> [~t...@apache.org] we should cap the number of retries (or the time spent
> retrying).
> For this we can include a retrycount in the reconciliiation status,
> Also we should distinguish fatal (like config errors) and recoverable errors
> with a different exception type and those should not be retried.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26191) Incorrect license in Elasticsearch connectors
[ https://issues.apache.org/jira/browse/FLINK-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494725#comment-17494725 ] Chesnay Schepler commented on FLINK-26191: -- So essentially we either need to go back to a previous version, or get rid of the rest-high-level-client. > Incorrect license in Elasticsearch connectors > - > > Key: FLINK-26191 > URL: https://issues.apache.org/jira/browse/FLINK-26191 > Project: Flink > Issue Type: Technical Debt > Components: Connectors / ElasticSearch >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.15.0 > > > The sql-connector-elasticsearc0h 6/7 connector NOTICE lists the elasticsearch > dependencies as ASLv2, but they are nowadays (at least in part) licensed > differently (dual-licensed under elastic license 2.0 & Server Side Public > License (SSPL)). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #18846: [FLINK-26223] Enables INFO logging for ZooKeeper into separate file
flinkbot edited a comment on pull request #18846: URL: https://github.com/apache/flink/pull/18846#issuecomment-1044512809 ## CI report: * 4bdffdc6f92d967b29d1b31c97f32d053dcf4c53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31860) * 7087074578534ca446a89c453a09657b8dc37cd5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31882) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
flinkbot edited a comment on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1041224101 ## CI report: * 4b81605fceb3782214b3aa28bfa9097ae0bdf6b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31762) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) * d2793da2669462117d17c825648eede9c343da96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18846: [FLINK-26223] Enables INFO logging for ZooKeeper into separate file
flinkbot edited a comment on pull request #18846: URL: https://github.com/apache/flink/pull/18846#issuecomment-1044512809 ## CI report: * 4bdffdc6f92d967b29d1b31c97f32d053dcf4c53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31860) * 7087074578534ca446a89c453a09657b8dc37cd5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
flinkbot edited a comment on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1041224101 ## CI report: * 4b81605fceb3782214b3aa28bfa9097ae0bdf6b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31762) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * b9afe8cee1a1886bcb43e314ee66d064627bcaa6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-26257) Document metrics configuration for Prometheus
[ https://issues.apache.org/jira/browse/FLINK-26257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-26257: --- Component/s: Kubernetes Operator > Document metrics configuration for Prometheus > - > > Key: FLINK-26257 > URL: https://issues.apache.org/jira/browse/FLINK-26257 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Matyas Orhidi >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-26191) Incorrect license in Elasticsearch connectors
[ https://issues.apache.org/jira/browse/FLINK-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494720#comment-17494720 ] Chesnay Schepler commented on FLINK-26191: -- Reading through the license text the elastic license 2.0 is also quite problematic; it also contains the whole "you can't use this for a managed service" point (that I thought was exclusive to SSPL). I'd currently categorize it as category X, meaning that we can't release the connector. > Incorrect license in Elasticsearch connectors > - > > Key: FLINK-26191 > URL: https://issues.apache.org/jira/browse/FLINK-26191 > Project: Flink > Issue Type: Technical Debt > Components: Connectors / ElasticSearch >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.15.0 > > > The sql-connector-elasticsearc0h 6/7 connector NOTICE lists the elasticsearch > dependencies as ASLv2, but they are nowadays (at least in part) licensed > differently (dual-licensed under elastic license 2.0 & Server Side Public > License (SSPL)). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] XComp commented on pull request #18846: [FLINK-26223] Enables INFO logging for ZooKeeper into separate file
XComp commented on pull request #18846: URL: https://github.com/apache/flink/pull/18846#issuecomment-1044820482 Rebased to fix the architecturial test failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1044819809 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-26257) Document metrics configuration for Prometheus
Matyas Orhidi created FLINK-26257: - Summary: Document metrics configuration for Prometheus Key: FLINK-26257 URL: https://issues.apache.org/jira/browse/FLINK-26257 Project: Flink Issue Type: Sub-task Reporter: Matyas Orhidi -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] gaborgsomogyi commented on pull request #18796: [FLINK-26166][runtime-web] Add auto newline detection to prettier formatter
gaborgsomogyi commented on pull request #18796: URL: https://github.com/apache/flink/pull/18796#issuecomment-1044817068 Oh gosh, tests are super flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FLINK-26183) Support kubernetes-operator metrics using the Flink metric system
[ https://issues.apache.org/jira/browse/FLINK-26183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora resolved FLINK-26183. Resolution: Fixed Merged: abf3a09757a2fa187bffc439fd280c4bfd661e99 > Support kubernetes-operator metrics using the Flink metric system > - > > Key: FLINK-26183 > URL: https://issues.apache.org/jira/browse/FLINK-26183 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Gyula Fora >Assignee: Matyas Orhidi >Priority: Major > Labels: pull-request-available > > We should leverage the existing Metric and Reporter infrastructure of Flink > to expose metrics of the Flink operator. > Users should be able to pass configuration to the operator that will control > the metric registry (like for regular Flink jobs) and should be able to > access the built in metric reporter plugins. > > Initially we should expose standard JVM metrics, and later we can add > operator specific metric groups if needed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-26191) Incorrect license in Elasticsearch connectors
[ https://issues.apache.org/jira/browse/FLINK-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494716#comment-17494716 ] Jark Wu commented on FLINK-26191: - [~chesnay], sorry, ASLv2 is compabible with Elastic License 2.0? > Incorrect license in Elasticsearch connectors > - > > Key: FLINK-26191 > URL: https://issues.apache.org/jira/browse/FLINK-26191 > Project: Flink > Issue Type: Technical Debt > Components: Connectors / ElasticSearch >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.15.0 > > > The sql-connector-elasticsearc0h 6/7 connector NOTICE lists the elasticsearch > dependencies as ASLv2, but they are nowadays (at least in part) licensed > differently (dual-licensed under elastic license 2.0 & Server Side Public > License (SSPL)). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * d0b4755daebc1d2fc71d6df890b5920c76b9b273 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18610: [FLINK-23843][runtime] Properly fail the job when SplitEnumeratorContext.runInCoordinatorThread() throws an exception
flinkbot edited a comment on pull request #18610: URL: https://github.com/apache/flink/pull/18610#issuecomment-1028011200 ## CI report: * 30b57a6f44a6e8f68ec182570e43508018c4bd1d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31879) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) * d2793da2669462117d17c825648eede9c343da96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18849: [FLINK-24407][doc-zh]Pulsar connector chinese document link to Pulsar document location incorrectly.
flinkbot edited a comment on pull request #18849: URL: https://github.com/apache/flink/pull/18849#issuecomment-1044604605 ## CI report: * 4d288fe3e1fcf5e4c7ff31b85ab671e502bef1ab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31869) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18850: [FLINK-26146][FLINK-26176] Native snapshot test coverage and test fix
flinkbot edited a comment on pull request #18850: URL: https://github.com/apache/flink/pull/18850#issuecomment-1044782524 ## CI report: * 941b3ebf8810adab424ae84c60380c20d4958fe8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31881) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18847: [FLINK-26252][runtime][test-utils] Refactor MiniClusterExtension to support JUnit 5 parallel tests
flinkbot edited a comment on pull request #18847: URL: https://github.com/apache/flink/pull/18847#issuecomment-1044577413 ## CI report: * 7f3404d3e6392329775d41b35459783ad33eb880 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31864) * 76e62e9c69b2835af3c30fd43413b0ac72915a90 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31880) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18846: [FLINK-26223] Enables INFO logging for ZooKeeper into separate file
flinkbot edited a comment on pull request #18846: URL: https://github.com/apache/flink/pull/18846#issuecomment-1044512809 ## CI report: * 4bdffdc6f92d967b29d1b31c97f32d053dcf4c53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31860) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * d0b4755daebc1d2fc71d6df890b5920c76b9b273 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18058: [FLINK-24571][connectors/elasticsearch] Supports a system time function(now() and current_timestamp) in index pattern
flinkbot edited a comment on pull request #18058: URL: https://github.com/apache/flink/pull/18058#issuecomment-988949831 ## CI report: * 93c33001cf55690369281de939bd79bb3727ad9a UNKNOWN * 47b985560b3efeb6b084c62e67ab56c2eb2cd7a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31705) * d2793da2669462117d17c825648eede9c343da96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18850: [FLINK-26146][FLINK-26176] Native snapshot test coverage and test fix
flinkbot commented on pull request #18850: URL: https://github.com/apache/flink/pull/18850#issuecomment-1044786218 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 941b3ebf8810adab424ae84c60380c20d4958fe8 (Fri Feb 18 16:23:46 UTC 2022) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-26176).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18850: [FLINK-26146][FLINK-26176] Native snapshot test coverage and test fix
flinkbot commented on pull request #18850: URL: https://github.com/apache/flink/pull/18850#issuecomment-1044782524 ## CI report: * 941b3ebf8810adab424ae84c60380c20d4958fe8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18847: [FLINK-26252][runtime][test-utils] Refactor MiniClusterExtension to support JUnit 5 parallel tests
flinkbot edited a comment on pull request #18847: URL: https://github.com/apache/flink/pull/18847#issuecomment-1044577413 ## CI report: * 7f3404d3e6392329775d41b35459783ad33eb880 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31864) * 76e62e9c69b2835af3c30fd43413b0ac72915a90 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18844: [FLINK-26121] Adds queue cleanup to `ZooKeeperLeaderRetrievalConnectionHandlingTest`
flinkbot edited a comment on pull request #18844: URL: https://github.com/apache/flink/pull/18844#issuecomment-1044321269 ## CI report: * 077519751b15c99cfbe480ee3949f7dc2fe99a29 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31855) * 9c2bfb7db225aa07377dd0f10a570a58fbd6e115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31877) * a327e1f21236eefb1eb4936fd5d2c3d538dec423 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-26146) Add test coverage for native format flink upgrades (minor versions)
[ https://issues.apache.org/jira/browse/FLINK-26146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26146: --- Labels: pull-request-available (was: ) > Add test coverage for native format flink upgrades (minor versions) > --- > > Key: FLINK-26146 > URL: https://issues.apache.org/jira/browse/FLINK-26146 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Checkpointing, Tests >Reporter: Piotr Nowojski >Assignee: Sebastian Mattheis >Priority: Major > Labels: pull-request-available > > Check test coverage for: > Flink minor (1.x → 1.y) version upgrade > Parametrised SavepointMigrationTestBase to work on: > canonical savepoints > native savepoints > aligned (retained) checkpoints > Assignee should contact release managers and decided whether to already > create 1.15 (snapshot) artefacts for native savepoints and aligned > checkpoints. If we do so, we might make release manager work more > complicated. However if we don’t, the test will be a dead code until release > manager creates those artefacts, which can also make the release manager work > more difficult if test explodes during RC creation. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] smattheis opened a new pull request #18850: [FLINK-26146][FLINK-26176] Native snapshot test coverage and test fix
smattheis opened a new pull request #18850: URL: https://github.com/apache/flink/pull/18850 ## What is the purpose of the change * This PR extends integration test cases that test migration of state savepoints between Flink versions, e.g., store savepoint in 1.x and restore in 1.y (with 1.x < 1.y). The extension is that now also savepoints in native format and checkpoints are tested. * During implementation, a bug was discovered in the respective scala integration tests (see [FLINK-26176]) which is fixed with this PR. ## Brief change log No feature changes. This PR only addresses integration tests in flink-tests. ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing This change added tests and can be verified as follows: - *Added test coverage to verify that savepoints (in canonical and native format) as well as checkpoints can be restored across Flink versions.* - *A separate branch (that is not to be merged) emulates release version 1.15 with new created artifacts only to verify that the test logic is correct: see https://github.com/smattheis/flink/pull/2* ## Does this pull request potentially affect one of the following parts: - Release management: As part of a release, two aspects must be considered: - test artifacts (resources) need to be generated and pushed on the release branch (The artifacts are snapshots created with the release version that are supposed to be tested in any later version to verify restoring snapshots is working for snapshots of previous versions.) - current version variables must be incremented to the new release version ## Documentation - Does this pull request introduce a new feature? (yes / __no__) - If yes, how is the feature documented? (__not applicable__ / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] XComp commented on pull request #18751: [FLINK-26120][tests] Relax CheckpointIDCounterTestBase assertions
XComp commented on pull request #18751: URL: https://github.com/apache/flink/pull/18751#issuecomment-1044771825 > How would a manual executor allow interleaving operations? I didn't think that through. The `ExecutorService` is not used internally but only utilized in test itself. So, it doesn't make it difference. Forget what I said. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18845: [FLINK-25958][runtime] Report completed checkpoint to statistic only after the completed checkpoint is added to the store.
flinkbot edited a comment on pull request #18845: URL: https://github.com/apache/flink/pull/18845#issuecomment-1044482798 ## CI report: * 43d56cff06dc2c1cdbd113ee8a16bacffac5dcdc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31859) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
