[jira] [Assigned] (FLINK-13310) Remove shade-plugin configuration in hive-connector
[ https://issues.apache.org/jira/browse/FLINK-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-13310: -- Assignee: Ji Liu > Remove shade-plugin configuration in hive-connector > --- > > Key: FLINK-13310 > URL: https://issues.apache.org/jira/browse/FLINK-13310 > Project: Flink > Issue Type: Improvement > Components: Build System, Connectors / Hive >Affects Versions: 1.9.0 >Reporter: Chesnay Schepler >Assignee: Ji Liu >Priority: Minor > Fix For: 1.9.0 > > > The hive connector has a shade plugin configuration but isn't doing anything > interesting. We may as well remove it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (FLINK-13147) Duplicated code in 'if' conditional statement
[
https://issues.apache.org/jira/browse/FLINK-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880277#comment-16880277
]
Ji Liu commented on FLINK-13147:
[~q977734161] Thanks for reporting this issue, I provided a PR to fix it.
> Duplicated code in 'if' conditional statement
> --
>
> Key: FLINK-13147
> URL: https://issues.apache.org/jira/browse/FLINK-13147
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.6.3, 1.6.4, 1.7.2, 1.8.0, 1.8.1
>Reporter: lixiaobao
>Assignee: Ji Liu
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.3, 1.9.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> } else if (type.equals(LogicalTypeRoot.VARBINARY)
> || type.equals(LogicalTypeRoot.BINARY)
> || type.equals(LogicalTypeRoot.BINARY)) {
> if (colStat instanceof CatalogColumnStatisticsDataBinary) {
> CatalogColumnStatisticsDataBinary binaryColumnStatsData =
> (CatalogColumnStatisticsDataBinary) colStat;
> BinaryColumnStatsData binaryColumnStats = new
> BinaryColumnStatsData(binaryColumnStatsData.getMaxLength(),
> binaryColumnStatsData.getAvgLength(), binaryColumnStatsData.getNullCount());
> return ColumnStatisticsData.binaryStats(binaryColumnStats);
> }{code}
> The class HiveStatsUtil have duplicated code in 'if' conditional statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-13147) Duplicated code in 'if' conditional statement
[
https://issues.apache.org/jira/browse/FLINK-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-13147:
--
Assignee: Ji Liu
> Duplicated code in 'if' conditional statement
> --
>
> Key: FLINK-13147
> URL: https://issues.apache.org/jira/browse/FLINK-13147
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.6.3, 1.6.4, 1.7.2, 1.8.0, 1.8.1
>Reporter: lixiaobao
>Assignee: Ji Liu
>Priority: Minor
> Fix For: 1.7.3, 1.9.0
>
>
> {code:java}
> } else if (type.equals(LogicalTypeRoot.VARBINARY)
> || type.equals(LogicalTypeRoot.BINARY)
> || type.equals(LogicalTypeRoot.BINARY)) {
> if (colStat instanceof CatalogColumnStatisticsDataBinary) {
> CatalogColumnStatisticsDataBinary binaryColumnStatsData =
> (CatalogColumnStatisticsDataBinary) colStat;
> BinaryColumnStatsData binaryColumnStats = new
> BinaryColumnStatsData(binaryColumnStatsData.getMaxLength(),
> binaryColumnStatsData.getAvgLength(), binaryColumnStatsData.getNullCount());
> return ColumnStatisticsData.binaryStats(binaryColumnStats);
> }{code}
> The class HiveStatsUtil have duplicated code in 'if' conditional statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (FLINK-13054) [Java] Support compact fixed-width vectors
[ https://issues.apache.org/jira/browse/FLINK-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu updated FLINK-13054: --- Description: was: In shuffle stage of some applications, FixedWitdhVectors may have very little non-null data. In this case, directly serialize vectors is not a good choice, generally we can compact the vector make it only holding non-null value and create a BitVector to trace the indices for non-null values so that it could be deserialized properly. > [Java] Support compact fixed-width vectors > -- > > Key: FLINK-13054 > URL: https://issues.apache.org/jira/browse/FLINK-13054 > Project: Flink > Issue Type: New Feature >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-13054) [Java] Support compact fixed-width vectors
[ https://issues.apache.org/jira/browse/FLINK-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu closed FLINK-13054. -- Resolution: Invalid > [Java] Support compact fixed-width vectors > -- > > Key: FLINK-13054 > URL: https://issues.apache.org/jira/browse/FLINK-13054 > Project: Flink > Issue Type: New Feature >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Minor > > In shuffle stage of some applications, FixedWitdhVectors may have very little > non-null data. > In this case, directly serialize vectors is not a good choice, generally we > can compact the vector make it only holding non-null value and create a > BitVector to trace the indices for non-null values so that it could be > deserialized properly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FLINK-13054) [Java] Support compact fixed-width vectors
Ji Liu created FLINK-13054: -- Summary: [Java] Support compact fixed-width vectors Key: FLINK-13054 URL: https://issues.apache.org/jira/browse/FLINK-13054 Project: Flink Issue Type: New Feature Reporter: Ji Liu Assignee: Ji Liu In shuffle stage of some applications, FixedWitdhVectors may have very little non-null data. In this case, directly serialize vectors is not a good choice, generally we can compact the vector make it only holding non-null value and create a BitVector to trace the indices for non-null values so that it could be deserialized properly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-12825) Remove deprecation from BatchTableSource/Sink
[
https://issues.apache.org/jira/browse/FLINK-12825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-12825:
--
Assignee: (was: Ji Liu)
> Remove deprecation from BatchTableSource/Sink
> -
>
> Key: FLINK-12825
> URL: https://issues.apache.org/jira/browse/FLINK-12825
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Affects Versions: 1.9.0
>Reporter: Dawid Wysakowicz
>Priority: Blocker
>
> In commits: 4946cf4d6ab0f502f065825e157c7cabde604fe1 and
> 851d27bb54596d1044a831160b09aad9f3b32316 a {{Deprecate}} annotations were
> added to {{BatchTableSink}} and {{BatchTableSource}}. This is incorrect. They
> are still valid and the only supported interfaces for legacy planner. We
> cannot deprecate them until we deprecate the whole planner and I am not aware
> of such plans for 1.9.
> Also the deprecation comment is very misleading as you cannot use the
> Output/Input format versions with legacy planner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-12825) Remove deprecation from BatchTableSource/Sink
[
https://issues.apache.org/jira/browse/FLINK-12825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-12825:
--
Assignee: Ji Liu
> Remove deprecation from BatchTableSource/Sink
> -
>
> Key: FLINK-12825
> URL: https://issues.apache.org/jira/browse/FLINK-12825
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Affects Versions: 1.9.0
>Reporter: Dawid Wysakowicz
>Assignee: Ji Liu
>Priority: Blocker
>
> In commits: 4946cf4d6ab0f502f065825e157c7cabde604fe1 and
> 851d27bb54596d1044a831160b09aad9f3b32316 a {{Deprecate}} annotations were
> added to {{BatchTableSink}} and {{BatchTableSource}}. This is incorrect. They
> are still valid and the only supported interfaces for legacy planner. We
> cannot deprecate them until we deprecate the whole planner and I am not aware
> of such plans for 1.9.
> Also the deprecation comment is very misleading as you cannot use the
> Output/Input format versions with legacy planner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (FLINK-12631) Check if proper JAR file in JobWithJars
Ji Liu created FLINK-12631: -- Summary: Check if proper JAR file in JobWithJars Key: FLINK-12631 URL: https://issues.apache.org/jira/browse/FLINK-12631 Project: Flink Issue Type: Improvement Reporter: Ji Liu Assignee: Ji Liu Currently, _checkJarFile_ checks if the file exists and canRead. Jar file is checked much later than necessary. As an intermediate solution we can check if proper jar file right in this method to early detect illegal problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-10446) Use the "guava beta checker" plugin to keep off of @Beta API
[ https://issues.apache.org/jira/browse/FLINK-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-10446: -- Assignee: (was: Ji Liu) > Use the "guava beta checker" plugin to keep off of @Beta API > > > Key: FLINK-10446 > URL: https://issues.apache.org/jira/browse/FLINK-10446 > Project: Flink > Issue Type: Task > Components: Build System >Reporter: Ted Yu >Priority: Major > > The Guava people publish an Error Prone plugin to detect when stuff that's > annotated with @Beta gets used. Those things shouldn't be used because the > project gives no promises about deprecating before removal. > plugin: > https://github.com/google/guava-beta-checker -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-12145) Host config in flink-web is incorrect
[
https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-12145:
--
Assignee: (was: Ji Liu)
> Host config in flink-web is incorrect
> -
>
> Key: FLINK-12145
> URL: https://issues.apache.org/jira/browse/FLINK-12145
> Project: Flink
> Issue Type: Bug
>Reporter: Ji Liu
>Priority: Minor
>
> In [https://flink.apache.org/improve-website.html]
> its description is "Open your browser at
> [http://localhost:4000|http://localhost:4000/] to view the website",
> but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
> case when we execute {{./build.sh -p, it will print info like this "Server
> address: http://0.0.0.0:4000/; which is actually invalid. I think the default
> host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-12349) invalid
[ https://issues.apache.org/jira/browse/FLINK-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-12349: -- Assignee: (was: Ji Liu) > invalid > --- > > Key: FLINK-12349 > URL: https://issues.apache.org/jira/browse/FLINK-12349 > Project: Flink > Issue Type: Improvement >Reporter: Ji Liu >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-12349) invalid
[ https://issues.apache.org/jira/browse/FLINK-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu updated FLINK-12349: --- Summary: invalid (was: [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount) > invalid > --- > > Key: FLINK-12349 > URL: https://issues.apache.org/jira/browse/FLINK-12349 > Project: Flink > Issue Type: Improvement >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-12349) [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount
[ https://issues.apache.org/jira/browse/FLINK-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu updated FLINK-12349: --- Description: (was: Now in _BaseValueVector#getValidityBufferSizeFromCount_ and _BitVectorHelper#getValidityBufferSize_, it uses _Math.ceil_ to calculate size which is not efficient (lots of unnecessary logic in _StrictMath#floorOrCeil_) since the value count is always not less than 0, we could simply replace Math.ceil with the following code: _return valueCount % 8 > 0 ? valueCount / 8 + 1 : valueCount / 8;_) > [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount > > > Key: FLINK-12349 > URL: https://issues.apache.org/jira/browse/FLINK-12349 > Project: Flink > Issue Type: Improvement >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-12349) [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount
[ https://issues.apache.org/jira/browse/FLINK-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu closed FLINK-12349. -- Resolution: Invalid > [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount > > > Key: FLINK-12349 > URL: https://issues.apache.org/jira/browse/FLINK-12349 > Project: Flink > Issue Type: Improvement >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Trivial > > Now in _BaseValueVector#getValidityBufferSizeFromCount_ and > _BitVectorHelper#getValidityBufferSize_, it uses _Math.ceil_ to calculate > size which is not efficient (lots of unnecessary logic in > _StrictMath#floorOrCeil_) since the value count is always not less than 0, we > could simply replace Math.ceil with the following code: > _return valueCount % 8 > 0 ? valueCount / 8 + 1 : valueCount / 8;_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FLINK-12349) [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount
Ji Liu created FLINK-12349: -- Summary: [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount Key: FLINK-12349 URL: https://issues.apache.org/jira/browse/FLINK-12349 Project: Flink Issue Type: Improvement Reporter: Ji Liu Assignee: Ji Liu Now in _BaseValueVector#getValidityBufferSizeFromCount_ and _BitVectorHelper#getValidityBufferSize_, it uses _Math.ceil_ to calculate size which is not efficient (lots of unnecessary logic in _StrictMath#floorOrCeil_) since the value count is always not less than 0, we could simply replace Math.ceil with the following code: _return valueCount % 8 > 0 ? valueCount / 8 + 1 : valueCount / 8;_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FLINK-12293) Fix some comment typos in flink-streaming-java.
Ji Liu created FLINK-12293: -- Summary: Fix some comment typos in flink-streaming-java. Key: FLINK-12293 URL: https://issues.apache.org/jira/browse/FLINK-12293 Project: Flink Issue Type: Improvement Reporter: Ji Liu Assignee: Ji Liu Some comments typos in flink-streaming-java should be fixed. I will provide a PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-10446) Use the "guava beta checker" plugin to keep off of @Beta API
[ https://issues.apache.org/jira/browse/FLINK-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-10446: -- Assignee: Ji Liu > Use the "guava beta checker" plugin to keep off of @Beta API > > > Key: FLINK-10446 > URL: https://issues.apache.org/jira/browse/FLINK-10446 > Project: Flink > Issue Type: Task > Components: Build System >Reporter: Ted Yu >Assignee: Ji Liu >Priority: Major > > The Guava people publish an Error Prone plugin to detect when stuff that's > annotated with @Beta gets used. Those things shouldn't be used because the > project gives no promises about deprecating before removal. > plugin: > https://github.com/google/guava-beta-checker -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-10446) Use the "guava beta checker" plugin to keep off of @Beta API
[ https://issues.apache.org/jira/browse/FLINK-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-10446: -- Assignee: (was: Ji Liu) > Use the "guava beta checker" plugin to keep off of @Beta API > > > Key: FLINK-10446 > URL: https://issues.apache.org/jira/browse/FLINK-10446 > Project: Flink > Issue Type: Task > Components: Build System >Reporter: Ted Yu >Priority: Major > > The Guava people publish an Error Prone plugin to detect when stuff that's > annotated with @Beta gets used. Those things shouldn't be used because the > project gives no promises about deprecating before removal. > plugin: > https://github.com/google/guava-beta-checker -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-10446) Use the "guava beta checker" plugin to keep off of @Beta API
[ https://issues.apache.org/jira/browse/FLINK-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-10446: -- Assignee: Ji Liu > Use the "guava beta checker" plugin to keep off of @Beta API > > > Key: FLINK-10446 > URL: https://issues.apache.org/jira/browse/FLINK-10446 > Project: Flink > Issue Type: Task > Components: Build System >Reporter: Ted Yu >Assignee: Ji Liu >Priority: Major > > The Guava people publish an Error Prone plugin to detect when stuff that's > annotated with @Beta gets used. Those things shouldn't be used because the > project gives no promises about deprecating before removal. > plugin: > https://github.com/google/guava-beta-checker -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9904) Allow users to control MaxDirectMemorySize
[
https://issues.apache.org/jira/browse/FLINK-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821633#comment-16821633
]
Ji Liu commented on FLINK-9904:
---
[~hroongta] ok, then I will fix this. thanks!
> Allow users to control MaxDirectMemorySize
> --
>
> Key: FLINK-9904
> URL: https://issues.apache.org/jira/browse/FLINK-9904
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Scripts
>Affects Versions: 1.4.2, 1.5.1, 1.7.2, 1.8.0, 1.9.0
>Reporter: Himanshu Roongta
>Assignee: Ji Liu
>Priority: Minor
>
> For people who use docker image and run flink in pods, currently, there is no
> way to update
> {{MaxDirectMemorySize}}
> (Well one can create a custom version of
> [taskmanager.sh|https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/bin/taskmanager.sh])
>
> As a result, it starts with a value of 8388607T . If the param
> {{taskmanager.memory.preallocate}} is set to false (default) the clean up
> will only occur when the MaxDirectMemorySize limit is hit and a gc full cycle
> kicks in. However with pods especially in kuberenete they will get killed
> because pods do not run at such a high value. (In our case we run 8GB per pod)
>
> The fix would be to allow it be configurable via {{flink-conf}}. We can still
> have a default of 8388607T to avoid a breaking change.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-9904) Allow users to control MaxDirectMemorySize
[
https://issues.apache.org/jira/browse/FLINK-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-9904:
-
Assignee: Ji Liu
> Allow users to control MaxDirectMemorySize
> --
>
> Key: FLINK-9904
> URL: https://issues.apache.org/jira/browse/FLINK-9904
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Scripts
>Affects Versions: 1.4.2, 1.5.1, 1.7.2, 1.8.0, 1.9.0
>Reporter: Himanshu Roongta
>Assignee: Ji Liu
>Priority: Minor
>
> For people who use docker image and run flink in pods, currently, there is no
> way to update
> {{MaxDirectMemorySize}}
> (Well one can create a custom version of
> [taskmanager.sh|https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/bin/taskmanager.sh])
>
> As a result, it starts with a value of 8388607T . If the param
> {{taskmanager.memory.preallocate}} is set to false (default) the clean up
> will only occur when the MaxDirectMemorySize limit is hit and a gc full cycle
> kicks in. However with pods especially in kuberenete they will get killed
> because pods do not run at such a high value. (In our case we run 8GB per pod)
>
> The fix would be to allow it be configurable via {{flink-conf}}. We can still
> have a default of 8388607T to avoid a breaking change.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10441) Don't log warning when creating upload directory
[
https://issues.apache.org/jira/browse/FLINK-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821630#comment-16821630
]
Ji Liu commented on FLINK-10441:
[~uce] Hi, thanks for opening this issue, I have submitted a PR:
[https://github.com/apache/flink/pull/8219]
> Don't log warning when creating upload directory
>
>
> Key: FLINK-10441
> URL: https://issues.apache.org/jira/browse/FLINK-10441
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / REST
>Reporter: Ufuk Celebi
>Assignee: Ji Liu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{RestServerEndpoint.createUploadDir(Path, Logger)}} logs a warning if the
> upload directory does not exist.
> {code}
> 2018-09-26 15:32:31,732 WARN
> org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint- Upload
> directory
> /var/folders/hr/cxn1_2y52qxf5nzyfq9h2scwgn/T/flink-web-2218b898-f245-4edf-b181-8f3bdc6014f3/flink-web-upload
> does not exist, or has been deleted externally. Previously uploaded files
> are no longer available.
> {code}
> I found this warning confusing as it is always logged when relying on the
> default configuration (via {{WebOptions}}) that picks a random directory.
> Ideally, our default configurations should not result in warnings to be
> logged.
> Therefore, I propose to log the creation of the web directory on {{INFO}}
> instead of the warning.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-10441) Don't log warning when creating upload directory
[
https://issues.apache.org/jira/browse/FLINK-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-10441:
--
Assignee: Ji Liu
> Don't log warning when creating upload directory
>
>
> Key: FLINK-10441
> URL: https://issues.apache.org/jira/browse/FLINK-10441
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / REST
>Reporter: Ufuk Celebi
>Assignee: Ji Liu
>Priority: Minor
>
> {{RestServerEndpoint.createUploadDir(Path, Logger)}} logs a warning if the
> upload directory does not exist.
> {code}
> 2018-09-26 15:32:31,732 WARN
> org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint- Upload
> directory
> /var/folders/hr/cxn1_2y52qxf5nzyfq9h2scwgn/T/flink-web-2218b898-f245-4edf-b181-8f3bdc6014f3/flink-web-upload
> does not exist, or has been deleted externally. Previously uploaded files
> are no longer available.
> {code}
> I found this warning confusing as it is always logged when relying on the
> default configuration (via {{WebOptions}}) that picks a random directory.
> Ideally, our default configurations should not result in warnings to be
> logged.
> Therefore, I propose to log the creation of the web directory on {{INFO}}
> instead of the warning.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9904) Allow users to control MaxDirectMemorySize
[
https://issues.apache.org/jira/browse/FLINK-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820720#comment-16820720
]
Ji Liu commented on FLINK-9904:
---
Hi [~hroongta] are you still working on this issue? If not, i would like to
provide a fix.
> Allow users to control MaxDirectMemorySize
> --
>
> Key: FLINK-9904
> URL: https://issues.apache.org/jira/browse/FLINK-9904
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Scripts
>Affects Versions: 1.4.2, 1.5.1, 1.7.2, 1.8.0, 1.9.0
>Reporter: Himanshu Roongta
>Priority: Minor
>
> For people who use docker image and run flink in pods, currently, there is no
> way to update
> {{MaxDirectMemorySize}}
> (Well one can create a custom version of
> [taskmanager.sh|https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/bin/taskmanager.sh])
>
> As a result, it starts with a value of 8388607T . If the param
> {{taskmanager.memory.preallocate}} is set to false (default) the clean up
> will only occur when the MaxDirectMemorySize limit is hit and a gc full cycle
> kicks in. However with pods especially in kuberenete they will get killed
> because pods do not run at such a high value. (In our case we run 8GB per pod)
>
> The fix would be to allow it be configurable via {{flink-conf}}. We can still
> have a default of 8388607T to avoid a breaking change.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants
[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818509#comment-16818509 ] Ji Liu commented on FLINK-3991: --- [~Zentol] Alright, thanks for replying. > Remove deprecated configuration keys from ConfigConstants > - > > Key: FLINK-3991 > URL: https://issues.apache.org/jira/browse/FLINK-3991 > Project: Flink > Issue Type: Sub-task > Components: Build System >Reporter: Robert Metzger >Priority: Major > Labels: pull-request-available > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > In > https://github.com/apache/flink/commit/b0acd97935cd21843bac3b9b5afa3662b52bb95d#diff-40616c4678c3fbfe07c0701505ce0567 > I deprecated some configuration keys. > They are unused and need to be removed with the 2.0 release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-9542) ExEnv#registerCachedFile should accept Path
[
https://issues.apache.org/jira/browse/FLINK-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-9542:
-
Assignee: Ji Liu
> ExEnv#registerCachedFile should accept Path
> ---
>
> Key: FLINK-9542
> URL: https://issues.apache.org/jira/browse/FLINK-9542
> Project: Flink
> Issue Type: Improvement
> Components: API / DataSet, API / DataStream
>Reporter: Chesnay Schepler
>Assignee: Ji Liu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, {{registerCachedFile}} accepts {{Strings}} as file-paths.
> This is undesirable because invalid paths are detected much later than
> necessary; at the moment this happens when we attempt to upload them to the
> blob store, i.e. during job submission, when ideally it should fail right
> away.
> As an intermediate solution we can modify the {{DistributedCacheEntries}} to
> contain {{Paths}} instead of {{Strings}}. This will not require API changes
> but still allow earlier detection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file
[
https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816047#comment-16816047
]
Ji Liu commented on FLINK-11619:
[~yuqi] Thanks for replying. You mean you will continue to work on this, right?
Hope to see your PR later.
> Make ScheduleMode configurable via user code or configuration file
> ---
>
> Key: FLINK-11619
> URL: https://issues.apache.org/jira/browse/FLINK-11619
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: yuqi
>Assignee: yuqi
>Priority: Major
>
> Currently, Schedule mode for stream job is always
> see StreamingJobGraphGenerator#createJobGraph
> {code:java}
> // make sure that all vertices start immediately
> jobGraph.setScheduleMode(ScheduleMode.EAGER);
> {code}
> on this point, we can make ScheduleMode configurable to user so as to adapt
> different environment. Users can set this option via env.setScheduleMode() in
> code, or make it optional in configuration.
> Anyone's help and suggestions is welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9542) ExEnv#registerCachedFile should accept Path
[
https://issues.apache.org/jira/browse/FLINK-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815362#comment-16815362
]
Ji Liu commented on FLINK-9542:
---
[~Zentol] Is this issue still open? I quickly looked into the code and it seems
that _DistributedCacheEntries_ still keeps String as file-path. I would like to
provide a fix.
> ExEnv#registerCachedFile should accept Path
> ---
>
> Key: FLINK-9542
> URL: https://issues.apache.org/jira/browse/FLINK-9542
> Project: Flink
> Issue Type: Improvement
> Components: API / DataSet, API / DataStream
>Reporter: Chesnay Schepler
>Priority: Major
>
> Currently, {{registerCachedFile}} accepts {{Strings}} as file-paths.
> This is undesirable because invalid paths are detected much later than
> necessary; at the moment this happens when we attempt to upload them to the
> blob store, i.e. during job submission, when ideally it should fail right
> away.
> As an intermediate solution we can modify the {{DistributedCacheEntries}} to
> contain {{Paths}} instead of {{Strings}}. This will not require API changes
> but still allow earlier detection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file
[
https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814217#comment-16814217
]
Ji Liu edited comment on FLINK-11619 at 4/11/19 7:13 AM:
-
+1, the default _ScheduleMode of JobGraph_ is LAZY_FROM_SOURCES, but when
_StreamingJobGraphGenerator#createJobGraph_ is invoked, the scheduleMode is set
to EAGER, and this value is passed to _ExecutionGraph_ later. So
ScheduleMode.LAZY_FROM_SOURCES doesn't seem to be used anywhere, right? [~yuqi]
was (Author: tianchen92):
The default _ScheduleMode of JobGraph_ is LAZY_FROM_SOURCES, but when
_StreamingJobGraphGenerator#createJobGraph_ is invoked, the scheduleMode is set
to EAGER, and this value is passed to _ExecutionGraph_ later. So
ScheduleMode.LAZY_FROM_SOURCES doesn't seem to be used anywhere, right? [~yuqi]
> Make ScheduleMode configurable via user code or configuration file
> ---
>
> Key: FLINK-11619
> URL: https://issues.apache.org/jira/browse/FLINK-11619
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: yuqi
>Assignee: yuqi
>Priority: Major
>
> Currently, Schedule mode for stream job is always
> see StreamingJobGraphGenerator#createJobGraph
> {code:java}
> // make sure that all vertices start immediately
> jobGraph.setScheduleMode(ScheduleMode.EAGER);
> {code}
> on this point, we can make ScheduleMode configurable to user so as to adapt
> different environment. Users can set this option via env.setScheduleMode() in
> code, or make it optional in configuration.
> Anyone's help and suggestions is welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file
[
https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815135#comment-16815135
]
Ji Liu commented on FLINK-11619:
hi, [~yuqi] if you have no opinion, I would like to prepare a PR to make
ScheduleMode configurable. If you disagree, please let me know.
> Make ScheduleMode configurable via user code or configuration file
> ---
>
> Key: FLINK-11619
> URL: https://issues.apache.org/jira/browse/FLINK-11619
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: yuqi
>Assignee: yuqi
>Priority: Major
>
> Currently, Schedule mode for stream job is always
> see StreamingJobGraphGenerator#createJobGraph
> {code:java}
> // make sure that all vertices start immediately
> jobGraph.setScheduleMode(ScheduleMode.EAGER);
> {code}
> on this point, we can make ScheduleMode configurable to user so as to adapt
> different environment. Users can set this option via env.setScheduleMode() in
> code, or make it optional in configuration.
> Anyone's help and suggestions is welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-3685) Logical error in code for DateSerializer deserialize with reuse
[
https://issues.apache.org/jira/browse/FLINK-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814379#comment-16814379
]
Ji Liu commented on FLINK-3685:
---
Since this problem is fixed in
[FLINK-3856|https://issues.apache.org/jira/browse/FLINK-3856], so this issue
can be closed.
> Logical error in code for DateSerializer deserialize with reuse
> ---
>
> Key: FLINK-3685
> URL: https://issues.apache.org/jira/browse/FLINK-3685
> Project: Flink
> Issue Type: Bug
> Components: API / Type Serialization System
>Affects Versions: 1.0.0
>Reporter: ZhengBowen
>Priority: Major
>
> There is a logical error in the following function in DateSerializer.java
> when source read '-1'
> function is:
> {code}
> public Date deserialize(Date reuse, DataInputView source) throws IOException {
> long v = source.readLong();
> if(v == -1L) {
> return null;
> }
> reuse.setTime(v);
> return reuse;
> }
> {code}
> when call this function for first time, if return null, then 'reuse' will be
> set null by caller;
> when call this function for second time,if 'v!=-1' ,reuse.setTime(v) will
> throw NPE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9385) Operators with two inputs should show "Records Received" in Web UI separately, rather than added together
[ https://issues.apache.org/jira/browse/FLINK-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814361#comment-16814361 ] Ji Liu commented on FLINK-9385: --- Hi [~joshlemer], thanks for opening this issue, but I think one could calc records number of each input by upstream output records if it's really needed, redundant information may make the UI look messy. What do you think? > Operators with two inputs should show "Records Received" in Web UI > separately, rather than added together > - > > Key: FLINK-9385 > URL: https://issues.apache.org/jira/browse/FLINK-9385 > Project: Flink > Issue Type: Task > Components: Runtime / Metrics, Runtime / Web Frontend >Reporter: Josh Lemer >Priority: Major > > In the Flink Web UI, there is a column in the Subtasks information view which > shows how many records each subtask has received. However, for subtasks such > as CoProcess operators which take two inputs, the number shown for "Records > Received" is the sum of the records received from the two upstream > datastreams. It would be much more helpful if it displayed the number of > records received from each of the two separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file
[
https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814217#comment-16814217
]
Ji Liu edited comment on FLINK-11619 at 4/10/19 9:03 AM:
-
The default _ScheduleMode of JobGraph_ is LAZY_FROM_SOURCES, but when
_StreamingJobGraphGenerator#createJobGraph_ is invoked, the scheduleMode is set
to EAGER, and this value is passed to _ExecutionGraph_ later. So
ScheduleMode.LAZY_FROM_SOURCES doesn't seem to be used anywhere, right? [~yuqi]
was (Author: tianchen92):
In default _ScheduleMod_e of _JobGraph_ is LAZY_FROM_SOURCES, but when
_StreamingJobGraphGenerator#createJobGraph_ is invoked, the scheduleMode is set
to EAGER, and this value is passed to _ExecutionGraph_ later. So
ScheduleMode.LAZY_FROM_SOURCES doesn't seem to be used anywhere, right? [~yuqi]
> Make ScheduleMode configurable via user code or configuration file
> ---
>
> Key: FLINK-11619
> URL: https://issues.apache.org/jira/browse/FLINK-11619
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: yuqi
>Assignee: yuqi
>Priority: Major
>
> Currently, Schedule mode for stream job is always
> see StreamingJobGraphGenerator#createJobGraph
> {code:java}
> // make sure that all vertices start immediately
> jobGraph.setScheduleMode(ScheduleMode.EAGER);
> {code}
> on this point, we can make ScheduleMode configurable to user so as to adapt
> different environment. Users can set this option via env.setScheduleMode() in
> code, or make it optional in configuration.
> Anyone's help and suggestions is welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file
[
https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814217#comment-16814217
]
Ji Liu commented on FLINK-11619:
In default _ScheduleMod_e of _JobGraph_ is LAZY_FROM_SOURCES, but when
_StreamingJobGraphGenerator#createJobGraph_ is invoked, the scheduleMode is set
to EAGER, and this value is passed to _ExecutionGraph_ later. So
ScheduleMode.LAZY_FROM_SOURCES doesn't seem to be used anywhere, right? [~yuqi]
> Make ScheduleMode configurable via user code or configuration file
> ---
>
> Key: FLINK-11619
> URL: https://issues.apache.org/jira/browse/FLINK-11619
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: yuqi
>Assignee: yuqi
>Priority: Major
>
> Currently, Schedule mode for stream job is always
> see StreamingJobGraphGenerator#createJobGraph
> {code:java}
> // make sure that all vertices start immediately
> jobGraph.setScheduleMode(ScheduleMode.EAGER);
> {code}
> on this point, we can make ScheduleMode configurable to user so as to adapt
> different environment. Users can set this option via env.setScheduleMode() in
> code, or make it optional in configuration.
> Anyone's help and suggestions is welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (FLINK-12145) Host config in flink-web is incorrect
[
https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu closed FLINK-12145.
--
Resolution: Won't Do
> Host config in flink-web is incorrect
> -
>
> Key: FLINK-12145
> URL: https://issues.apache.org/jira/browse/FLINK-12145
> Project: Flink
> Issue Type: Bug
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Minor
>
> In [https://flink.apache.org/improve-website.html]
> its description is "Open your browser at
> [http://localhost:4000|http://localhost:4000/] to view the website",
> but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
> case when we execute {{./build.sh -p, it will print info like this "Server
> address: http://0.0.0.0:4000/; which is actually invalid. I think the default
> host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12145) Host config in flink-web is incorrect
[
https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814202#comment-16814202
]
Ji Liu commented on FLINK-12145:
ok, I have closed this issue.
> Host config in flink-web is incorrect
> -
>
> Key: FLINK-12145
> URL: https://issues.apache.org/jira/browse/FLINK-12145
> Project: Flink
> Issue Type: Bug
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Minor
>
> In [https://flink.apache.org/improve-website.html]
> its description is "Open your browser at
> [http://localhost:4000|http://localhost:4000/] to view the website",
> but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
> case when we execute {{./build.sh -p, it will print info like this "Server
> address: http://0.0.0.0:4000/; which is actually invalid. I think the default
> host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-11799) KryoSerializer/OperatorChain ignores copy failure resulting in NullPointerException
[ https://issues.apache.org/jira/browse/FLINK-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814188#comment-16814188 ] Ji Liu commented on FLINK-11799: Agree, it's necessary to print error log when copy fails and now it dose not seems to do this. > KryoSerializer/OperatorChain ignores copy failure resulting in > NullPointerException > --- > > Key: FLINK-11799 > URL: https://issues.apache.org/jira/browse/FLINK-11799 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: 1.7.2 >Reporter: Jason Kania >Priority: Major > > I was encountering a problem with NullPointerExceptions with the deserialized > object reaching my ProcessFunction process() method implementation as a null > value. Upon investigation, I discovered two issues with the implementation of > the KryoSerializer copy(). > 1) The 'public T copy(T from)' method swallows the error if the kryo copy() > call generates an exception. The code should report the copy error at least > once as a warning to be aware that the kryo copy() is failing. I understand > that the code is there to handle the lack of a copy implementation but due to > the potential inefficiency of having to write and read the object instead of > copying it, this would seem useful information to share at the least. It is > also important to have a warning in case the cause of the copy error is > something that needs to be fixed. > 2) The call to 'kryo.readObject(input, from.getClass())' does not handle the > fact that the kryo readObject(Input input, Class aClass) method may return a > null value if there are any issues. This could be handled with a check or > warning in the OperatorChain.CopyingChainingOutput.pushToOperator() method > but is also ignored there, allowing a null value to be passed along without > providing any reason for the null value in logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-12118) Documentation in left navigation is not in step with its content
[ https://issues.apache.org/jira/browse/FLINK-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814102#comment-16814102 ] Ji Liu commented on FLINK-12118: This is because the release branch for 1.8 was already cut. Therefore the version on master is 1.9-SNAPSHOT already and at the same time 1.8 was not yet released. That's why latest stable is 1.7, whereas current snapshot is already 1.9. see [FLINK-11873|https://issues.apache.org/jira/browse/FLINK-11873] > Documentation in left navigation is not in step with its content > > > Key: FLINK-12118 > URL: https://issues.apache.org/jira/browse/FLINK-12118 > Project: Flink > Issue Type: Bug >Reporter: Yu Haidong >Priority: Major > Attachments: 图片 11.png, 图片 12.png > > > Hi Team: > A little bug I think. > The content in offical website documentation of left navigation is : > "1.8(snapshot)", > but when you click it, you will see : > "1.9-SNAPSHOT" > in the content, maybe it is a little bug. > Thank you! > > Haidong > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase
[
https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814021#comment-16814021
]
Ji Liu commented on FLINK-7916:
---
[~till.rohrmann] Absolutely, in the long run it's a better solution to create a
_benchmark_ module. I have submited a PR:
[https://github.com/apache/flink/pull/8132]
> Remove NetworkStackThroughputITCase
> ---
>
> Key: FLINK-7916
> URL: https://issues.apache.org/jira/browse/FLINK-7916
> Project: Flink
> Issue Type: Task
> Components: Runtime / Network, Tests
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Ji Liu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not
> really a test. Moreover it is marked as {{Ignored}}. I propose to remove this
> test because it is more of a benchmark. We could think about creating a
> benchmark project where we move these kind of "tests".
> In general I think we should remove ignored tests if they won't be fixed
> immediately. The danger is far too high that we forget about them and then we
> only keep the maintenance burden of it. This is especially true for the above
> mentioned test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12145) Host config in flink-web is incorrect
[
https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813986#comment-16813986
]
Ji Liu commented on FLINK-12145:
[~fhueske] alright, I raised this issue just because 0.0.0.0:4000 can't be
accessed on my machine.
> Host config in flink-web is incorrect
> -
>
> Key: FLINK-12145
> URL: https://issues.apache.org/jira/browse/FLINK-12145
> Project: Flink
> Issue Type: Bug
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Minor
>
> In [https://flink.apache.org/improve-website.html]
> its description is "Open your browser at
> [http://localhost:4000|http://localhost:4000/] to view the website",
> but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
> case when we execute {{./build.sh -p, it will print info like this "Server
> address: http://0.0.0.0:4000/; which is actually invalid. I think the default
> host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12145) Host config in flink-web is incorrect
[
https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813268#comment-16813268
]
Ji Liu commented on FLINK-12145:
cc @[~fhueske]
> Host config in flink-web is incorrect
> -
>
> Key: FLINK-12145
> URL: https://issues.apache.org/jira/browse/FLINK-12145
> Project: Flink
> Issue Type: Bug
>Reporter: Ji Liu
>Assignee: Ji Liu
>Priority: Minor
>
> In [https://flink.apache.org/improve-website.html]
> its description is "Open your browser at
> [http://localhost:4000|http://localhost:4000/] to view the website",
> but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
> case when we execute {{./build.sh -p, it will print info like this "Server
> address: http://0.0.0.0:4000/; which is actually invalid. I think the default
> host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (FLINK-12145) Host config in flink-web is incorrect
Ji Liu created FLINK-12145:
--
Summary: Host config in flink-web is incorrect
Key: FLINK-12145
URL: https://issues.apache.org/jira/browse/FLINK-12145
Project: Flink
Issue Type: Bug
Reporter: Ji Liu
Assignee: Ji Liu
In [https://flink.apache.org/improve-website.html]
its description is "Open your browser at
[http://localhost:4000|http://localhost:4000/] to view the website",
but in flink-web project, the host config in _config.yml is 0.0.0.0. In this
case when we execute {{./build.sh -p, it will print info like this "Server
address: http://0.0.0.0:4000/; which is actually invalid. I think the default
host should be replaced with "localhost".}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12128) There is a typo on the website
[ https://issues.apache.org/jira/browse/FLINK-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813242#comment-16813242 ] Ji Liu commented on FLINK-12128: [~fhueske] If nobody is working on this, I would like to provide a quick fix. > There is a typo on the website > -- > > Key: FLINK-12128 > URL: https://issues.apache.org/jira/browse/FLINK-12128 > Project: Flink > Issue Type: Bug > Components: Project Website >Reporter: Kenneth Yang >Priority: Minor > > [https://flink.apache.org/roadmap.html] > "Various of these enhancements can be taken _*form*_ the contributed code > from the [Blink fork|https://github.com/apache/flink/tree/blink].; > I think this sentence has a typo, should change the *form* to _from_ > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (FLINK-12128) There is a typo on the website
[ https://issues.apache.org/jira/browse/FLINK-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813242#comment-16813242 ] Ji Liu edited comment on FLINK-12128 at 4/9/19 10:32 AM: - [~fhueske] [~kennethlnnn] If nobody is working on this, I would like to provide a quick fix. was (Author: tianchen92): [~fhueske] If nobody is working on this, I would like to provide a quick fix. > There is a typo on the website > -- > > Key: FLINK-12128 > URL: https://issues.apache.org/jira/browse/FLINK-12128 > Project: Flink > Issue Type: Bug > Components: Project Website >Reporter: Kenneth Yang >Priority: Minor > > [https://flink.apache.org/roadmap.html] > "Various of these enhancements can be taken _*form*_ the contributed code > from the [Blink fork|https://github.com/apache/flink/tree/blink].; > I think this sentence has a typo, should change the *form* to _from_ > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-12125) Add OVH to poweredby.zh.md and index.zh.md
[
https://issues.apache.org/jira/browse/FLINK-12125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-12125:
--
Assignee: Ji Liu
> Add OVH to poweredby.zh.md and index.zh.md
> --
>
> Key: FLINK-12125
> URL: https://issues.apache.org/jira/browse/FLINK-12125
> Project: Flink
> Issue Type: Task
> Components: chinese-translation, Project Website
>Reporter: Fabian Hueske
>Assignee: Ji Liu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> OVH was added to the {{poweredby.md}} and {index.md}} pages in commits
> 55ae4426d5b91695e1e5629b1d0a16b7a1e010f0 and
> d4a160ab336c5ae1b2f772fbeff7e003478e274b. See also PR
> https://github.com/apache/flink-web/pull/193.
> The corresponding Chinese pages should be updated accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-12125) Add OVH to poweredby.zh.md and index.zh.md
[
https://issues.apache.org/jira/browse/FLINK-12125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813003#comment-16813003
]
Ji Liu commented on FLINK-12125:
Hi [~fhueske] Is there anyone work on this? if not, I would like to take it.
> Add OVH to poweredby.zh.md and index.zh.md
> --
>
> Key: FLINK-12125
> URL: https://issues.apache.org/jira/browse/FLINK-12125
> Project: Flink
> Issue Type: Task
> Components: chinese-translation, Project Website
>Reporter: Fabian Hueske
>Priority: Major
>
> OVH was added to the {{poweredby.md}} and {index.md}} pages in commits
> 55ae4426d5b91695e1e5629b1d0a16b7a1e010f0 and
> d4a160ab336c5ae1b2f772fbeff7e003478e274b. See also PR
> https://github.com/apache/flink-web/pull/193.
> The corresponding Chinese pages should be updated accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants
[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-3991: - Assignee: Ji Liu > Remove deprecated configuration keys from ConfigConstants > - > > Key: FLINK-3991 > URL: https://issues.apache.org/jira/browse/FLINK-3991 > Project: Flink > Issue Type: Sub-task > Components: Build System >Reporter: Robert Metzger >Assignee: Ji Liu >Priority: Major > Fix For: 2.0.0 > > > In > https://github.com/apache/flink/commit/b0acd97935cd21843bac3b9b5afa3662b52bb95d#diff-40616c4678c3fbfe07c0701505ce0567 > I deprecated some configuration keys. > They are unused and need to be removed with the 2.0 release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-9787) Change ExecutionConfig#getGlobalJobParameters to return an instance of GlobalJobParameters instead of null if no custom globalJobParameters are set yet
[ https://issues.apache.org/jira/browse/FLINK-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-9787: - Assignee: Ji Liu > Change ExecutionConfig#getGlobalJobParameters to return an instance of > GlobalJobParameters instead of null if no custom globalJobParameters are set > yet > --- > > Key: FLINK-9787 > URL: https://issues.apache.org/jira/browse/FLINK-9787 > Project: Flink > Issue Type: Improvement > Components: API / DataStream >Reporter: Florian Schmidt >Assignee: Ji Liu >Priority: Minor > Fix For: 2.0.0 > > > Currently when accessing ExecutionConfig#getGlobalJobParameters this will > return `null` if no globalJobParameters are set. This can easily lead to > NullPointerExceptions when used with getGlobalJobParameters.toMap() > An easy improvement for this would be to just return a new instance of > GlobalJobParameters if none is set with the empty map as the parameters > This would be a breaking change since we expose this via > RuntimeContext#getExecutionConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FLINK-7916) Remove NetworkStackThroughputITCase
[
https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-7916:
-
Assignee: Ji Liu
> Remove NetworkStackThroughputITCase
> ---
>
> Key: FLINK-7916
> URL: https://issues.apache.org/jira/browse/FLINK-7916
> Project: Flink
> Issue Type: Task
> Components: Runtime / Network, Tests
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Ji Liu
>Priority: Major
>
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not
> really a test. Moreover it is marked as {{Ignored}}. I propose to remove this
> test because it is more of a benchmark. We could think about creating a
> benchmark project where we move these kind of "tests".
> In general I think we should remove ignored tests if they won't be fixed
> immediately. The danger is far too high that we forget about them and then we
> only keep the maintenance burden of it. This is especially true for the above
> mentioned test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[
https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ji Liu reassigned FLINK-10437:
--
Assignee: Ji Liu
> Some of keys under withDeprecatedKeys aren't marked as @depreacted
> --
>
> Key: FLINK-10437
> URL: https://issues.apache.org/jira/browse/FLINK-10437
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Assignee: Ji Liu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> as title. For example {{RestOptions#BIND_ADDRESS}} is
> {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}}
> isn't marked as deprecated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-7916) Remove NetworkStackThroughputITCase
[
https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812155#comment-16812155
]
Ji Liu edited comment on FLINK-7916 at 4/8/19 10:40 AM:
Agree, I think move these tests to _org.apache.flink.test.manual_ under
_flink-tests_ is a good idea. Is this still open？[~till.rohrmann]
was (Author: tianchen92):
Agree, I think move these tests to _org.apache.flink.test.manual_ under
_flink-tests_ is a good idea.
> Remove NetworkStackThroughputITCase
> ---
>
> Key: FLINK-7916
> URL: https://issues.apache.org/jira/browse/FLINK-7916
> Project: Flink
> Issue Type: Task
> Components: Runtime / Network, Tests
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Priority: Major
>
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not
> really a test. Moreover it is marked as {{Ignored}}. I propose to remove this
> test because it is more of a benchmark. We could think about creating a
> benchmark project where we move these kind of "tests".
> In general I think we should remove ignored tests if they won't be fixed
> immediately. The danger is far too high that we forget about them and then we
> only keep the maintenance burden of it. This is especially true for the above
> mentioned test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[
https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812271#comment-16812271
]
Ji Liu edited comment on FLINK-10437 at 4/8/19 10:12 AM:
-
I have checked usages of _ConfigOption.withDeparecatedKeys_ and find only the
case mentioned above meet the requirements. Could you please help to review
this PR? thanks very much! [~rmetzger]
[[https://github.com/apache/flink/pull/8121]]
was (Author: tianchen92):
[~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_ and find
only the case mentioned above meet the requirements. Could you please help to
review this PR? thanks very much!
[PR|[https://github.com/apache/flink/pull/8121]]
> Some of keys under withDeprecatedKeys aren't marked as @depreacted
> --
>
> Key: FLINK-10437
> URL: https://issues.apache.org/jira/browse/FLINK-10437
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> as title. For example {{RestOptions#BIND_ADDRESS}} is
> {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}}
> isn't marked as deprecated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[
https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812271#comment-16812271
]
Ji Liu edited comment on FLINK-10437 at 4/8/19 9:34 AM:
[~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_ and find
only the case mentioned above meet the requirements. Could you please help to
review this PR? thanks very much!
[PR|[https://github.com/apache/flink/pull/8121]]
was (Author: tianchen92):
[~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_ and find
only the case mentioned above meet the requirements. Could please help review
this PR? thanks very much! [PR|[https://github.com/apache/flink/pull/8121]]
> Some of keys under withDeprecatedKeys aren't marked as @depreacted
> --
>
> Key: FLINK-10437
> URL: https://issues.apache.org/jira/browse/FLINK-10437
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> as title. For example {{RestOptions#BIND_ADDRESS}} is
> {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}}
> isn't marked as deprecated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted
[
https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812271#comment-16812271
]
Ji Liu commented on FLINK-10437:
[~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_ and find
only the case mentioned above meet the requirements. Could please help review
this PR? thanks very much! [PR|[https://github.com/apache/flink/pull/8121]]
> Some of keys under withDeprecatedKeys aren't marked as @depreacted
> --
>
> Key: FLINK-10437
> URL: https://issues.apache.org/jira/browse/FLINK-10437
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.7.0
>Reporter: TisonKun
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> as title. For example {{RestOptions#BIND_ADDRESS}} is
> {{withDeprecatedKeys(WebOptions.ADDRESS.key())}}, but {{WebOptions.ADDRESS}}
> isn't marked as deprecated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
