[jira] [Commented] (FLINK-5253) Remove special treatment of "dynamic properties"
[ https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080495#comment-16080495 ] Mariusz Wojakowski commented on FLINK-5253: --- Thanks for the comments! I'll take a look and update the PR. > Remove special treatment of "dynamic properties" > > > Key: FLINK-5253 > URL: https://issues.apache.org/jira/browse/FLINK-5253 > Project: Flink > Issue Type: Sub-task > Components: YARN > Environment: {{flip-6}} feature branch >Reporter: Stephan Ewen > Labels: flip-6 > > The YARN client accepts configuration keys as command line parameters. > Currently these are send to the AppMaster and TaskManager as "dynamic > properties", encoded in a special way via environment variables. > The mechanism is quite fragile. We should simplify it: > - The YARN client takes the local {{flink-conf.yaml}} as the base. > - It overwrite config entries with command line properties when preparing > the configuration to be shipped to YARN container processes (JM / TM) > - No additional handling neccessary -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-5253) Remove special treatment of "dynamic properties"
[ https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866340#comment-15866340 ] Mariusz Wojakowski commented on FLINK-5253: --- I have 2 questions: * should we store these dynamic properties in _flink-conf.yaml_ and completely remove that information from cluster descriptor? (Correct me if I'm wrong) * do we want to completely remove that special handling? I’m thinking about existing implementation that setup Flink on Yarn (’yarn-sessions’). > Remove special treatment of "dynamic properties" > > > Key: FLINK-5253 > URL: https://issues.apache.org/jira/browse/FLINK-5253 > Project: Flink > Issue Type: Sub-task > Components: YARN > Environment: {{flip-6}} feature branch >Reporter: Stephan Ewen > Labels: flip-6 > > The YARN client accepts configuration keys as command line parameters. > Currently these are send to the AppMaster and TaskManager as "dynamic > properties", encoded in a special way via environment variables. > The mechanism is quite fragile. We should simplify it: > - The YARN client takes the local {{flink-conf.yaml}} as the base. > - It overwrite config entries with command line properties when preparing > the configuration to be shipped to YARN container processes (JM / TM) > - No additional handling neccessary -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-5253) Remove special treatment of "dynamic properties"
[ https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727188#comment-15727188 ] Mariusz Wojakowski commented on FLINK-5253: --- I'd like to implement that (if you don't mind). I'm not experienced developer but it looks feasible for me. > Remove special treatment of "dynamic properties" > > > Key: FLINK-5253 > URL: https://issues.apache.org/jira/browse/FLINK-5253 > Project: Flink > Issue Type: Sub-task > Components: YARN > Environment: {{flip-6}} feature branch >Reporter: Stephan Ewen > Labels: flip-6 > > The YARN client accepts configuration keys as command line parameters. > Currently these are send to the AppMaster and TaskManager as "dynamic > properties", encoded in a special way via environment variables. > The mechanism is quite fragile. We should simplify it: > - The YARN client takes the local {{flink-conf.yaml}} as the base. > - It overwrite config entries with command line properties when preparing > the configuration to be shipped to YARN container processes (JM / TM) > - No additional handling neccessary -- This message was sent by Atlassian JIRA (v6.3.4#6332)