[jira] [Commented] (FLINK-29860) Pulsar connector bug when using Hybrid.Builder

2022-11-09 Thread Noel O'Connor (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630857#comment-17630857
 ] 

Noel O'Connor commented on FLINK-29860:
---

[~syhily] PR updated

> Pulsar connector bug when using Hybrid.Builder
> --
>
> Key: FLINK-29860
> URL: https://issues.apache.org/jira/browse/FLINK-29860
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Pulsar
>Affects Versions: 1.6.4
>Reporter: Noel O'Connor
>Assignee: Yufan Sheng
>Priority: Major
>  Labels: pull-request-available
>
> When using a HybridSource with a set of pulsar sources submitting a job to a 
> flink cluster results in the following error
> 
>  The program finished with the following exception:
> The implementation of the BlockElement is not serializable. The object 
> probably contains or references non serializable fields.
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)
>  
> I think this is related to https://issues.apache.org/jira/browse/FLINK-25444
> From a pulsar connector perspective it's simple fixed, just mark the "private 
> final InlineElement desc" attribute in 
> flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java
>  as transient to avoid the serialisation process.
>  
> I've tested this and it seems to solve the issue. I can submit a PR with this 
> fix.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29860) Pulsar connector bug when using Hybrid.Builder

2022-11-08 Thread Noel O'Connor (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630792#comment-17630792
 ] 

Noel O'Connor commented on FLINK-29860:
---

[~syhily] yep I'll do that today

> Pulsar connector bug when using Hybrid.Builder
> --
>
> Key: FLINK-29860
> URL: https://issues.apache.org/jira/browse/FLINK-29860
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Pulsar
>Affects Versions: 1.6.4
>Reporter: Noel O'Connor
>Assignee: Yufan Sheng
>Priority: Major
>  Labels: pull-request-available
>
> When using a HybridSource with a set of pulsar sources submitting a job to a 
> flink cluster results in the following error
> 
>  The program finished with the following exception:
> The implementation of the BlockElement is not serializable. The object 
> probably contains or references non serializable fields.
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)
>  
> I think this is related to https://issues.apache.org/jira/browse/FLINK-25444
> From a pulsar connector perspective it's simple fixed, just mark the "private 
> final InlineElement desc" attribute in 
> flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java
>  as transient to avoid the serialisation process.
>  
> I've tested this and it seems to solve the issue. I can submit a PR with this 
> fix.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29860) Pulsar connector bug when using Hybrid.Builder

2022-11-07 Thread Noel O'Connor (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630251#comment-17630251
 ] 

Noel O'Connor commented on FLINK-29860:
---

[~syhily] yep I do have a patch so assign me. I assume this is just for 1.17 
snapshot and not other versions ?

> Pulsar connector bug when using Hybrid.Builder
> --
>
> Key: FLINK-29860
> URL: https://issues.apache.org/jira/browse/FLINK-29860
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Pulsar
>Affects Versions: 1.6.4
>Reporter: Noel O'Connor
>Assignee: Yufan Sheng
>Priority: Major
>  Labels: pull-request-available
>
> When using a HybridSource with a set of pulsar sources submitting a job to a 
> flink cluster results in the following error
> 
>  The program finished with the following exception:
> The implementation of the BlockElement is not serializable. The object 
> probably contains or references non serializable fields.
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)
>  
> I think this is related to https://issues.apache.org/jira/browse/FLINK-25444
> From a pulsar connector perspective it's simple fixed, just mark the "private 
> final InlineElement desc" attribute in 
> flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java
>  as transient to avoid the serialisation process.
>  
> I've tested this and it seems to solve the issue. I can submit a PR with this 
> fix.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-29860) Pulsar connector bug when using Hybrid.Builder

2022-11-03 Thread Noel O'Connor (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-29860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Noel O'Connor updated FLINK-29860:
--
Description: 
When using a HybridSource with a set of pulsar sources submitting a job to a 
flink cluster results in the following error


 The program finished with the following exception:

The implementation of the BlockElement is not serializable. The object probably 
contains or references non serializable fields.
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
    
org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)

 

I think this is related to https://issues.apache.org/jira/browse/FLINK-25444

>From a pulsar connector perspective it's simple fixed, just mark the "private 
>final InlineElement desc" attribute in 
>flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java
> as transient to avoid the serialisation process.

 

I've tested this and it seems to solve the issue. I can submit a PR with this 
fix.

 

  was:
When using a HybridSource with a set of pulsar sources submitting a job to a 
flink cluster results in the following error


 The program finished with the following exception:

The implementation of the BlockElement is not serializable. The object probably 
contains or references non serializable fields.
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
    
org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)

 

I think this is related to https://issues.apache.org/jira/browse/FLINK-25444

>From a pulsar connector perspective it's simple fixed, just mark the "private 
>final InlineElement desc" attribute in 
>flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java

 

I've tested this and it seems to solve the issue. I can submit a PR with this 
fix.

 


> Pulsar connector bug when using Hybrid.Builder
> --
>
> Key: FLINK-29860
> URL: https://issues.apache.org/jira/browse/FLINK-29860
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Pulsar
>Affects Versions: 1.6.4
>Reporter: Noel O'Connor
>Priority: Major
>
> When using a HybridSource with a set of pulsar sources submitting a job to a 
> flink cluster results in the following error
> 
>  The program finished with the following exception:
> The implementation of the BlockElement is not serializable. The object 
> probably contains or references non serializable fields.
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
>     org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
>     
> org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSour

[jira] [Created] (FLINK-29860) Pulsar connector bug when using Hybrid.Builder

2022-11-03 Thread Noel O'Connor (Jira)
Noel O'Connor created FLINK-29860:
-

 Summary: Pulsar connector bug when using Hybrid.Builder
 Key: FLINK-29860
 URL: https://issues.apache.org/jira/browse/FLINK-29860
 Project: Flink
  Issue Type: Bug
  Components: Connectors / Pulsar
Affects Versions: 1.6.4
Reporter: Noel O'Connor


When using a HybridSource with a set of pulsar sources submitting a job to a 
flink cluster results in the following error


 The program finished with the following exception:

The implementation of the BlockElement is not serializable. The object probably 
contains or references non serializable fields.
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:164)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:132)
    org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:69)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:246)
    
org.apache.flink.connector.base.source.hybrid.HybridSource$HybridSourceBuilder.addSource(HybridSource.java:233)
    
org.apache.flink.connector.base.source.hybrid.HybridSource.builder(HybridSource.java:104)

 

I think this is related to https://issues.apache.org/jira/browse/FLINK-25444

>From a pulsar connector perspective it's simple fixed, just mark the "private 
>final InlineElement desc" attribute in 
>flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/CursorVerification.java

 

I've tested this and it seems to solve the issue. I can submit a PR with this 
fix.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-25444) ClosureCleaner rejects ExecutionConfig as not be Serializable due to TextElement

2022-10-27 Thread Noel O'Connor (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-25444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625018#comment-17625018
 ] 

Noel O'Connor commented on FLINK-25444:
---

I'm hitting this issue when using a {color:#00}HybridSource {color}with 
pulsar sources.

Is there an easy fix or workaround for this? 

> ClosureCleaner rejects ExecutionConfig as not be Serializable due to 
> TextElement
> 
>
> Key: FLINK-25444
> URL: https://issues.apache.org/jira/browse/FLINK-25444
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core
>Affects Versions: 1.14.0
>Reporter: Wen Zhou
>Assignee: Chesnay Schepler
>Priority: Minor
> Fix For: 1.17.0
>
>
> This should be a bug introduced by the latest flink commit of file 
> [flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java|https://github.com/apache/flink/commit/9e0e0929b86c372c9243daad9d654af9e7718708#diff-7a439abdf207cf6da8aa6c147b38c1346820fe786afbf652bc614fc377cdf238]
> Diff the file, we can find TextElement is used here where ClosureCleanerLevel 
> is is used as a memeber of Serializable ExecutionConfig.
> [TextElement in ClosureCleanerLevel|https://i.stack.imgur.com/ky3d8.png]
> The simplest way to verify the problem is running code as followings in flink 
> 1.13.5 and 1.14.x, the exception is reproduced in 1.14.x . And the diff 
> between 1.13.5 and 1.14.x is only lates commit
>  
> @Test
> public void testExecutionConfigSerializable() throws Exception {
> ExecutionConfig config = new ExecutionConfig();
> ClosureCleaner.clean(config, ExecutionConfig.ClosureCleanerLevel.RECURSIVE, 
> true);
> }
>  
> The problem can be found here 
> [https://stackoverflow.com/questions/70443743/flink-blockelement-exception-when-updating-to-version-1-14-2/70468925?noredirect=1#comment124597510_70468925]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)