[jira] [Commented] (FLINK-28851) Allow to GetTypeInfo in the HiveServer2 Endpoint
[ https://issues.apache.org/jira/browse/FLINK-28851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576494#comment-17576494 ] WeiNan Zhao commented on FLINK-28851: - hi [~fsk119] ,please assgin for me. thanks. > Allow to GetTypeInfo in the HiveServer2 Endpoint > > > Key: FLINK-28851 > URL: https://issues.apache.org/jira/browse/FLINK-28851 > Project: Flink > Issue Type: Sub-task > Components: Connectors / Hive, Table SQL / Gateway >Reporter: Shengkai Fang >Assignee: Shengkai Fang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-28793) Allow to GetInfo for HiveServer2 Endpoint
[ https://issues.apache.org/jira/browse/FLINK-28793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574996#comment-17574996 ] WeiNan Zhao commented on FLINK-28793: - hi, [~fsk119]. please assign to me . thanks. > Allow to GetInfo for HiveServer2 Endpoint > - > > Key: FLINK-28793 > URL: https://issues.apache.org/jira/browse/FLINK-28793 > Project: Flink > Issue Type: Sub-task > Components: Connectors / Hive, Table SQL / Gateway >Reporter: Shengkai Fang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-28151) Allow to cancel the Operation for the HiveServer2 Endpoint
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572748#comment-17572748 ] WeiNan Zhao commented on FLINK-28151: - hi, [~fsk119] . I want to contribute this issue. Please assign to me. Thanks. BR > Allow to cancel the Operation for the HiveServer2 Endpoint > -- > > Key: FLINK-28151 > URL: https://issues.apache.org/jira/browse/FLINK-28151 > Project: Flink > Issue Type: Sub-task > Components: Connectors / Hive, Table SQL / Gateway >Affects Versions: 1.16.0 >Reporter: Shengkai Fang >Assignee: Shengkai Fang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-22844) Add doc to introduce ExplainDetails for EXPLAIN sytnax
[ https://issues.apache.org/jira/browse/FLINK-22844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiNan Zhao updated FLINK-22844: Labels: pull-request-available (was: pull-request-available stale-assigned) > Add doc to introduce ExplainDetails for EXPLAIN sytnax > --- > > Key: FLINK-22844 > URL: https://issues.apache.org/jira/browse/FLINK-22844 > Project: Flink > Issue Type: New Feature > Components: Documentation, Table SQL / API >Affects Versions: 1.14.0 >Reporter: WeiNan Zhao >Assignee: WeiNan Zhao >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Link to FLINK-20562,add doc to introduct this new sytax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-22844) Add doc to introduce ExplainDetails for EXPLAIN sytnax
[ https://issues.apache.org/jira/browse/FLINK-22844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiNan Zhao updated FLINK-22844: Description: Link to FLINK-20562,add doc to introduct this new sytax. (was: Link to FLINK_20562,add doc to introduct this new sytax.) > Add doc to introduce ExplainDetails for EXPLAIN sytnax > --- > > Key: FLINK-22844 > URL: https://issues.apache.org/jira/browse/FLINK-22844 > Project: Flink > Issue Type: New Feature > Components: Table SQL / API >Affects Versions: 1.14.0 >Reporter: WeiNan Zhao >Priority: Major > Fix For: 1.14.0 > > > Link to FLINK-20562,add doc to introduct this new sytax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-22844) Add doc to introduce ExplainDetails for EXPLAIN sytnax
[ https://issues.apache.org/jira/browse/FLINK-22844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355477#comment-17355477 ] WeiNan Zhao commented on FLINK-22844: - please assign this job to me. > Add doc to introduce ExplainDetails for EXPLAIN sytnax > --- > > Key: FLINK-22844 > URL: https://issues.apache.org/jira/browse/FLINK-22844 > Project: Flink > Issue Type: New Feature > Components: Table SQL / API >Affects Versions: 1.14.0 >Reporter: WeiNan Zhao >Priority: Major > Fix For: 1.14.0 > > > Link to FLINK_20562,add doc to introduct this new sytax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-22844) Add doc to introduce ExplainDetails for EXPLAIN sytnax
WeiNan Zhao created FLINK-22844: --- Summary: Add doc to introduce ExplainDetails for EXPLAIN sytnax Key: FLINK-22844 URL: https://issues.apache.org/jira/browse/FLINK-22844 Project: Flink Issue Type: New Feature Components: Table SQL / API Affects Versions: 1.14.0 Reporter: WeiNan Zhao Fix For: 1.14.0 Link to FLINK_20562,add doc to introduct this new sytax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-22794) flink-sql-parser and flink-sql-hive-parser
[
https://issues.apache.org/jira/browse/FLINK-22794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
WeiNan Zhao updated FLINK-22794:
Description:
In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
failed.
and now
junit-jupiter-engine:{color:#ff}5.5.2;{color}junit-vintage-engine:{color:#ff}5.5.2.{color}
{color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion cannot
identify the version number correctly,{color}{color:#172b4d}e.g 4.13.2.{color}
{color:#172b4d}so we can update sql-parser and sql-hive-parser to 5.7.0 at
least.{color}
{color:#172b4d}below is release note:{color}
h3. JUnit Vintage
h4. Bug Fixes
* The Vintage engine no longer fails when resolving a {{MethodSelector}} for
methods of test classes that cannot be found via reflection. This allows
selecting Spock feature methods by their source code name even though they have
a generated method name in the bytecode.
h4. New Features and Improvements
* {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
that a supported version of JUnit 4 is on the classpath — now implements a
lenient version ID parsing algorithm in order to support custom version ID
formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
was:
In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
failed.
and now
junit-jupiter-engine:{color:#ff}5.5.2;{color}junit-vintage-engine:{color:#ff}5.5.2.{color}
{color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion cannot
identify the version number correctly,e.g 4.13.2 ,so we can update sql-parser
and sql-hive-parser to 5.7.0 at least.{color}
{color:#172b4d}below is release note:{color}
h3. JUnit Vintage
h4. Bug Fixes
* The Vintage engine no longer fails when resolving a {{MethodSelector}} for
methods of test classes that cannot be found via reflection. This allows
selecting Spock feature methods by their source code name even though they have
a generated method name in the bytecode.
h4. New Features and Improvements
* {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
that a supported version of JUnit 4 is on the classpath — now implements a
lenient version ID parsing algorithm in order to support custom version ID
formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
> flink-sql-parser and flink-sql-hive-parser
> ---
>
> Key: FLINK-22794
> URL: https://issues.apache.org/jira/browse/FLINK-22794
> Project: Flink
> Issue Type: Improvement
> Components: API / Core, Table SQL / API
>Affects Versions: 1.14.0
>Reporter: WeiNan Zhao
>Priority: Critical
> Fix For: 1.14.0
>
>
> In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
> failed.
> and now
> junit-jupiter-engine:{color:#ff}5.5.2;{color}junit-vintage-engine:{color:#ff}5.5.2.{color}
> {color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion
> cannot identify the version number correctly,{color}{color:#172b4d}e.g
> 4.13.2.{color}
> {color:#172b4d}so we can update sql-parser and sql-hive-parser to 5.7.0 at
> least.{color}
> {color:#172b4d}below is release note:{color}
> h3. JUnit Vintage
> h4. Bug Fixes
> * The Vintage engine no longer fails when resolving a {{MethodSelector}} for
> methods of test classes that cannot be found via reflection. This allows
> selecting Spock feature methods by their source code name even though they
> have a generated method name in the bytecode.
> h4. New Features and Improvements
> * {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
> that a supported version of JUnit 4 is on the classpath — now implements a
> lenient version ID parsing algorithm in order to support custom version ID
> formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-22794) flink-sql-parser and flink-sql-hive-parser
[
https://issues.apache.org/jira/browse/FLINK-22794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
WeiNan Zhao updated FLINK-22794:
Description:
In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
failed.
and now
junit-jupiter-engine:{color:#ff}5.5.2;{color}junit-vintage-engine:{color:#ff}5.5.2.{color}
{color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion cannot
identify the version number correctly,e.g 4.13.2 ,so we can update sql-parser
and sql-hive-parser to 5.7.0 at least.{color}
{color:#172b4d}below is release note:{color}
h3. JUnit Vintage
h4. Bug Fixes
* The Vintage engine no longer fails when resolving a {{MethodSelector}} for
methods of test classes that cannot be found via reflection. This allows
selecting Spock feature methods by their source code name even though they have
a generated method name in the bytecode.
h4. New Features and Improvements
* {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
that a supported version of JUnit 4 is on the classpath — now implements a
lenient version ID parsing algorithm in order to support custom version ID
formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
was:
In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
failed.
junit-jupiter-engine:{color:#FF}5.5.2;{color}junit-vintage-engine:{color:#FF}5.5.2
{color}
{color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion cannot
identify the version number correctly,e.g 4.13.2 ,so we can update sql-parser
and sql-hive-parser to 5.7.0{color}
{color:#172b4d}below is release note:{color}
h3. JUnit Vintage
h4. Bug Fixes
* The Vintage engine no longer fails when resolving a {{MethodSelector}} for
methods of test classes that cannot be found via reflection. This allows
selecting Spock feature methods by their source code name even though they have
a generated method name in the bytecode.
h4. New Features and Improvements
* {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
that a supported version of JUnit 4 is on the classpath — now implements a
lenient version ID parsing algorithm in order to support custom version ID
formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
> flink-sql-parser and flink-sql-hive-parser
> ---
>
> Key: FLINK-22794
> URL: https://issues.apache.org/jira/browse/FLINK-22794
> Project: Flink
> Issue Type: Improvement
> Components: API / Core, Table SQL / API
>Affects Versions: 1.14.0
>Reporter: WeiNan Zhao
>Priority: Critical
> Fix For: 1.14.0
>
>
> In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
> failed.
> and now
> junit-jupiter-engine:{color:#ff}5.5.2;{color}junit-vintage-engine:{color:#ff}5.5.2.{color}
> {color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion
> cannot identify the version number correctly,e.g 4.13.2 ,so we can update
> sql-parser and sql-hive-parser to 5.7.0 at least.{color}
> {color:#172b4d}below is release note:{color}
> h3. JUnit Vintage
> h4. Bug Fixes
> * The Vintage engine no longer fails when resolving a {{MethodSelector}} for
> methods of test classes that cannot be found via reflection. This allows
> selecting Spock feature methods by their source code name even though they
> have a generated method name in the bytecode.
> h4. New Features and Improvements
> * {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
> that a supported version of JUnit 4 is on the classpath — now implements a
> lenient version ID parsing algorithm in order to support custom version ID
> formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-22794) flink-sql-parser and flink-sql-hive-parser
WeiNan Zhao created FLINK-22794:
---
Summary: flink-sql-parser and flink-sql-hive-parser
Key: FLINK-22794
URL: https://issues.apache.org/jira/browse/FLINK-22794
Project: Flink
Issue Type: Improvement
Components: API / Core, Table SQL / API
Affects Versions: 1.14.0
Reporter: WeiNan Zhao
Fix For: 1.14.0
In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
failed.
junit-jupiter-engine:{color:#FF}5.5.2;{color}junit-vintage-engine:{color:#FF}5.5.2
{color}
{color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion cannot
identify the version number correctly,e.g 4.13.2 ,so we can update sql-parser
and sql-hive-parser to 5.7.0{color}
{color:#172b4d}below is release note:{color}
h3. JUnit Vintage
h4. Bug Fixes
* The Vintage engine no longer fails when resolving a {{MethodSelector}} for
methods of test classes that cannot be found via reflection. This allows
selecting Spock feature methods by their source code name even though they have
a generated method name in the bytecode.
h4. New Features and Improvements
* {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
that a supported version of JUnit 4 is on the classpath — now implements a
lenient version ID parsing algorithm in order to support custom version ID
formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22155) Fix EXPLAIN implementation
[ https://issues.apache.org/jira/browse/FLINK-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324680#comment-17324680 ] WeiNan Zhao commented on FLINK-22155: - please assgin to me , i will do it > Fix EXPLAIN implementation > -- > > Key: FLINK-22155 > URL: https://issues.apache.org/jira/browse/FLINK-22155 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Priority: Major > > When explain insert statement, the validator validate the whole statement > rather than validate the query. But when execute insert statement, the > planner only validate the query part of the insert statement. It may brings > the result of the explan is different from the actual plan. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-22250) flink-sql-parser model Class ParserResource lack ParserResource.properties
WeiNan Zhao created FLINK-22250: --- Summary: flink-sql-parser model Class ParserResource lack ParserResource.properties Key: FLINK-22250 URL: https://issues.apache.org/jira/browse/FLINK-22250 Project: Flink Issue Type: Improvement Components: Table SQL / API Affects Versions: 1.13.0 Reporter: WeiNan Zhao Fix For: 1.13.0 flink sql parser module lack a base message in ParserResource.properties. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-22065) Beautify the parse error exception when input invalid command in the sql client
[ https://issues.apache.org/jira/browse/FLINK-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319498#comment-17319498 ] WeiNan Zhao commented on FLINK-22065: - [~zoucao],do you mean ,change this response only on sql statement 'INVALID COMMAND'.in other sql command,We can’t tell if it’s a syntax error or an invalid command. > Beautify the parse error exception when input invalid command in the sql > client > --- > > Key: FLINK-22065 > URL: https://issues.apache.org/jira/browse/FLINK-22065 > Project: Flink > Issue Type: Bug > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: Shengkai Fang >Priority: Major > Fix For: 1.13.0 > > > !https://static.dingtalk.com/media/lALPD26eOprT2ztwzQWg_1440_112.png_720x720g.jpg?renderWidth=1440=112=1=0=im! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20813) SQL Client should create modules with user class loader
[ https://issues.apache.org/jira/browse/FLINK-20813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319473#comment-17319473 ] WeiNan Zhao commented on FLINK-20813: - cc [~fsk119],i will do it. > SQL Client should create modules with user class loader > --- > > Key: FLINK-20813 > URL: https://issues.apache.org/jira/browse/FLINK-20813 > Project: Flink > Issue Type: Bug > Components: Table SQL / Client >Reporter: Rui Li >Assignee: Shengkai Fang >Priority: Major > Fix For: 1.13.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-22065) Beautify the parse error exception when input invalid command in the sql client
[ https://issues.apache.org/jira/browse/FLINK-22065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319472#comment-17319472 ] WeiNan Zhao commented on FLINK-22065: - cc [~fsk119] ,please assign this issue to me,i will do it. > Beautify the parse error exception when input invalid command in the sql > client > --- > > Key: FLINK-22065 > URL: https://issues.apache.org/jira/browse/FLINK-22065 > Project: Flink > Issue Type: Bug > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: Shengkai Fang >Priority: Major > Fix For: 1.13.0 > > > !https://static.dingtalk.com/media/lALPD26eOprT2ztwzQWg_1440_112.png_720x720g.jpg?renderWidth=1440=112=1=0=im! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-17957) Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser
[ https://issues.apache.org/jira/browse/FLINK-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313938#comment-17313938 ] WeiNan Zhao commented on FLINK-17957: - [~fsk119]，please assgin this issue to to me , i will fix it. > Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser > > > Key: FLINK-17957 > URL: https://issues.apache.org/jira/browse/FLINK-17957 > Project: Flink > Issue Type: Bug > Components: Table SQL / API >Affects Versions: 1.11.0 >Reporter: Danny Chen >Assignee: Shengkai Fang >Priority: Major > Fix For: 1.13.0 > > > This syntax is invalid, but the parser still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21985) Support Explain Query/Modifcation syntax in Calcite Parser
[
https://issues.apache.org/jira/browse/FLINK-21985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309141#comment-17309141
]
WeiNan Zhao commented on FLINK-21985:
-
hello,please assign this issue to me,thank you!
> Support Explain Query/Modifcation syntax in Calcite Parser
> --
>
> Key: FLINK-21985
> URL: https://issues.apache.org/jira/browse/FLINK-21985
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
>
> Support statement syntax
> {code:java}
> EXPLAIN INSERT INTO ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-20562) Support ExplainDetails for EXPLAIN sytnax
[
https://issues.apache.org/jira/browse/FLINK-20562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303381#comment-17303381
]
WeiNan Zhao commented on FLINK-20562:
-
[~jark] wo can discuss explain syntax , eg .
EXPLAIN ESTIMATED_COST, CHANGELOG SELECT * FROM MyTable;
Or the syntax format supported by other databases.
> Support ExplainDetails for EXPLAIN sytnax
> -
>
> Key: FLINK-20562
> URL: https://issues.apache.org/jira/browse/FLINK-20562
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Jark Wu
>Priority: Major
> Labels: sprint
> Fix For: 1.13.0
>
>
> Currently, {{EXPLAIN}} syntax only supports to print the default AST, logical
> plan, and physical plan. However, it doesn't support to print detailed
> information such as CHANGELOG_MODE, ESTIMATED_COST, JSON_EXECUTION_PLAN which
> are defined in {{ExplainDetail}}.
> Allow users to specify the ExplainDetails in statement.
> {code:sql}
> EXPLAIN [ExplainDetail[, ExplainDetail]*]
> ExplainDetail: {
> ESTIMATED_COST,
> CHANGELOG_MODE,
> JSON_EXECUTION_PLAN
> }
> {code}
> Print the plan for the statement with specified ExplainDetails.
> ESTIMATED_COST
> generates cost information on physical node estimated by optimizer, e.g.
> TableSourceScan(..., cumulative cost = {1.0E8 rows, 1.0E8 cpu, 2.4E9 io, 0.0
> network, 0.0 memory})
> CHANGELOG_MODE
> generates changelog mode for every physical rel node. e.g.
> GroupAggregate(..., changelogMode=[I,UA,D])
> JSON_EXECUTION_PLAN
> generates the execution plan in json format of the program.
> {code:sql}
> Flink SQL> EXPLAIN ESTIMATED_COST, CHANGELOG SELECT * FROM MyTable;
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[ https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288358#comment-17288358 ] WeiNan Zhao commented on FLINK-21162: - [~jark] ok,i will do it > FLINK SQL IF function semantic incorrect > > > Key: FLINK-21162 > URL: https://issues.apache.org/jira/browse/FLINK-21162 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime >Affects Versions: 1.12.1 >Reporter: 谢波 >Assignee: WeiNan Zhao >Priority: Major > Labels: pull-request-available > > I have a job using IF() test condition. > when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok. > when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it > is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b" > ,that's amazing. > The semantic seems like inccorrect. > > my table ddl: > CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' ); > my dml : > INSERT INTO print > SELECT return_flag, > IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag > FROM header; > my test data: > 3> +I(,N) > 5> +I(X,Y) > 1> +I(null,Y) > 2> +I(,N) > 5> +I(null,Y) > 3> +I(,N) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[
https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288247#comment-17288247
]
WeiNan Zhao commented on FLINK-21162:
-
[~jark] ,Hello,when i debug,i found that when IS_NULL in OR operate ,if OR
change to SEARCH('',null) there was a major mistake,because SEARCH has three
return values (true,false,null),but OR Operate only can return (true,false),so
wo can't change (IS_NULL OR ...) to SEARCH('',null);
> FLINK SQL IF function semantic incorrect
>
>
> Key: FLINK-21162
> URL: https://issues.apache.org/jira/browse/FLINK-21162
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.12.1
>Reporter: 谢波
>Assignee: WeiNan Zhao
>Priority: Major
> Labels: pull-request-available
>
> I have a job using IF() test condition.
> when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok.
> when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it
> is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b"
> ,that's amazing.
> The semantic seems like inccorrect.
>
> my table ddl:
> CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' );
> my dml :
> INSERT INTO print
> SELECT return_flag,
> IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag
> FROM header;
> my test data:
> 3> +I(,N)
> 5> +I(X,Y)
> 1> +I(null,Y)
> 2> +I(,N)
> 5> +I(null,Y)
> 3> +I(,N)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[
https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288158#comment-17288158
]
WeiNan Zhao commented on FLINK-21162:
-
|if (!${castedNeedle.nullTerm}) {
| $resultTerm = $setTerm.contains(${castedNeedle.resultTerm});
| $nullTerm = !$resultTerm && $setTerm.containsNull();
|}else{
| // resultTerm return true, but null in set,we give nullItem = true?
| {color:#FF}$resultTerm = $setTerm.containsNull();{color}
{color:#FF}| $nullTerm = true;{color}
|}
wo can return resultTerm = true ,help if function make judgments,but make
nullTerm = true.
> FLINK SQL IF function semantic incorrect
>
>
> Key: FLINK-21162
> URL: https://issues.apache.org/jira/browse/FLINK-21162
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.12.1
>Reporter: 谢波
>Assignee: WeiNan Zhao
>Priority: Major
> Labels: pull-request-available
>
> I have a job using IF() test condition.
> when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok.
> when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it
> is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b"
> ,that's amazing.
> The semantic seems like inccorrect.
>
> my table ddl:
> CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' );
> my dml :
> INSERT INTO print
> SELECT return_flag,
> IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag
> FROM header;
> my test data:
> 3> +I(,N)
> 5> +I(X,Y)
> 1> +I(null,Y)
> 2> +I(,N)
> 5> +I(null,Y)
> 3> +I(,N)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[ https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288149#comment-17288149 ] WeiNan Zhao commented on FLINK-21162: - [~ykt836] Thanks for the investigation [~ykt836],but when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b" ,the result in uncorrectly. > FLINK SQL IF function semantic incorrect > > > Key: FLINK-21162 > URL: https://issues.apache.org/jira/browse/FLINK-21162 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime >Affects Versions: 1.12.1 >Reporter: 谢波 >Assignee: WeiNan Zhao >Priority: Major > Labels: pull-request-available > > I have a job using IF() test condition. > when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok. > when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it > is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b" > ,that's amazing. > The semantic seems like inccorrect. > > my table ddl: > CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' ); > my dml : > INSERT INTO print > SELECT return_flag, > IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag > FROM header; > my test data: > 3> +I(,N) > 5> +I(X,Y) > 1> +I(null,Y) > 2> +I(,N) > 5> +I(null,Y) > 3> +I(,N) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[
https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287869#comment-17287869
]
WeiNan Zhao commented on FLINK-21162:
-
[~jark]
[code: testSqlApi("f14 IN ('This is a test String.', 'String', 'Hello
world')","false"） in
ScalarOperatorsTest.scala|https://github.com/apache/flink/pull/14872/files#diff-1da1e565c0f5f01aec101b57d4f635320432d09785e5234bd384b668ec98d658]
file, it should expected false,Should not return null.What do you guys think.
> FLINK SQL IF function semantic incorrect
>
>
> Key: FLINK-21162
> URL: https://issues.apache.org/jira/browse/FLINK-21162
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.12.1
>Reporter: 谢波
>Assignee: WeiNan Zhao
>Priority: Major
> Labels: pull-request-available
>
> I have a job using IF() test condition.
> when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok.
> when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it
> is ok.
> when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b"
> ,that's amazing.
> The semantic seems like inccorrect.
>
> my table ddl:
> CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' );
> my dml :
> INSERT INTO print
> SELECT return_flag,
> IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag
> FROM header;
> my test data:
> 3> +I(,N)
> 5> +I(X,Y)
> 1> +I(null,Y)
> 2> +I(,N)
> 5> +I(null,Y)
> 3> +I(,N)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21278) NullpointExecption error is reported when using the evictor method to filter the data before the window calculation
[ https://issues.apache.org/jira/browse/FLINK-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279270#comment-17279270 ] WeiNan Zhao commented on FLINK-21278: - Can you provide test code and error details. > NullpointExecption error is reported when using the evictor method to filter > the data before the window calculation > --- > > Key: FLINK-21278 > URL: https://issues.apache.org/jira/browse/FLINK-21278 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.12.1 >Reporter: HunterHunter >Priority: Blocker > > When I use evictor() method to filter the data before a window is triggered, > if there is no data that meets the conditions, a nullpointExecption error > will be reported. > This problem occurs in the ReduceApplyWindowFunction.apply method. > So I think if there is no data to calculate whether it can not trigger the > calculation, or judge whether it is null before transmitting the calculation > result -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21162) FLINK SQL IF function semantic incorrect
[ https://issues.apache.org/jira/browse/FLINK-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278558#comment-17278558 ] WeiNan Zhao commented on FLINK-21162: - [~hiscat] I debug your sql and found that col is null is related to col ='', and there is no code that generates isnull. I think it may be the sqlnode that has been optimized by the parser. In fact, you can get With this result, flink only made the judgment of col ='', so you can get the answer of b > FLINK SQL IF function semantic incorrect > > > Key: FLINK-21162 > URL: https://issues.apache.org/jira/browse/FLINK-21162 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime >Affects Versions: 1.12.1 >Reporter: 谢波 >Priority: Major > > I have a job using IF() test condition. > when i use "IF(col = '', 'a', 'b'), WHEN col = '' return a ", it is ok. > when i use "IF(col IS NULL, 'a', 'b'), WHEN col = NULL return a ", it is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = ''return a", it > is ok. > when i use "IF(col = '' OR col IS NULL, 'a', 'b'),WHEN col = NULL return b" > ,that's amazing. > The semantic seems like inccorrect. > > my table ddl: > CREATE TABLE print(a STRING, b STRING) WITH ( 'connector' = 'print' ); > my dml : > INSERT INTO print > SELECT return_flag, > IF(return_flag = '' OR return_flag IS NULL, 'N', 'Y') returnFlag > FROM header; > my test data: > 3> +I(,N) > 5> +I(X,Y) > 1> +I(null,Y) > 2> +I(,N) > 5> +I(null,Y) > 3> +I(,N) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21039) Broken links in "dev/table/legacy_planner.zh.md"
[
https://issues.apache.org/jira/browse/FLINK-21039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268346#comment-17268346
]
WeiNan Zhao commented on FLINK-21039:
-
ok,I will solve this problem as soon as possible.
> Broken links in "dev/table/legacy_planner.zh.md"
>
>
> Key: FLINK-21039
> URL: https://issues.apache.org/jira/browse/FLINK-21039
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Table SQL / Ecosystem
>Affects Versions: 1.13.0
>Reporter: Huang Xingbo
>Assignee: WeiNan Zhao
>Priority: Critical
>
> dev/table/legacy_planner.zh.md contains some English links causing errors.
> {code:java}
> Liquid Exception: Could not find document 'dev/batch/index.md' in tag 'link'.
> Make sure the document exists and the path is correct. in
> dev/table/legacy_planner.zh.md
> Could not find document 'dev/batch/index.md' in tag 'link'.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-20967) Add Documentation for hbase connector new Function
WeiNan Zhao created FLINK-20967: --- Summary: Add Documentation for hbase connector new Function Key: FLINK-20967 URL: https://issues.apache.org/jira/browse/FLINK-20967 Project: Flink Issue Type: Task Components: Connectors / HBase, Documentation Affects Versions: 1.13.0 Reporter: WeiNan Zhao Fix For: 1.13.0 hbase connector version(1.4,2.2) can use 'properties.*' add configuration, need to add Documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20812) flink connector hbase(1.4,2.2) too few control parameters provided
[ https://issues.apache.org/jira/browse/FLINK-20812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259392#comment-17259392 ] WeiNan Zhao commented on FLINK-20812: - [~jark] hbase transformation code passed the flink bot scan. > flink connector hbase(1.4,2.2) too few control parameters provided > -- > > Key: FLINK-20812 > URL: https://issues.apache.org/jira/browse/FLINK-20812 > Project: Flink > Issue Type: Improvement > Components: Connectors / HBase, Table SQL / Ecosystem >Reporter: WeiNan Zhao >Assignee: WeiNan Zhao >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0 > > > When I use the cdh cluster, I need to use kerberos authentication, and I need > to add some kerberos authentication parameters of hbase, but the current > hbase connector structure does not provide this entry, I wonder if it can be > modified, if possible, I can submit for hbase connector a pr. > e.g hbase parameter > hbase.security.authentication='kerberos', > hbase.master.kerberos.principal='...', > hbase.kerberos.regionserver.principal='...', > hbase.security.auth.enable = 'true', > hbase.sasl.clientconfig = 'Client' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20817) kafka source have 798 field,Causes the class to be generated failed
[ https://issues.apache.org/jira/browse/FLINK-20817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256448#comment-17256448 ] WeiNan Zhao commented on FLINK-20817: - Thanks for your reply > kafka source have 798 field,Causes the class to be generated failed > --- > > Key: FLINK-20817 > URL: https://issues.apache.org/jira/browse/FLINK-20817 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner >Affects Versions: 1.10.2 >Reporter: WeiNan Zhao >Priority: Major > Attachments: WechatIMG44.jpeg, WechatIMG45.jpeg, WechatIMG46.jpeg > > > Too many fields of flink source cause the generated code to be too long, and > a codehaus error is reported. > Is there a way to bypass this restriction instead of changing your own SQL, > because we have many situations where the source table has many fields -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-20817) kafka source have 798 field,Causes the class to be generated failed
[ https://issues.apache.org/jira/browse/FLINK-20817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiNan Zhao updated FLINK-20817: Summary: kafka source have 798 field,Causes the class to be generated failed (was: kafka source have 200 field,Causes the class to be generated failed) > kafka source have 798 field,Causes the class to be generated failed > --- > > Key: FLINK-20817 > URL: https://issues.apache.org/jira/browse/FLINK-20817 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner >Affects Versions: 1.10.2 >Reporter: WeiNan Zhao >Priority: Major > Attachments: WechatIMG44.jpeg, WechatIMG45.jpeg, WechatIMG46.jpeg > > > Too many fields of flink source cause the generated code to be too long, and > a codehaus error is reported. > Is there a way to bypass this restriction instead of changing your own SQL, > because we have many situations where the source table has many fields -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-20817) kafka source have 200 field,Causes the class to be generated failed
[ https://issues.apache.org/jira/browse/FLINK-20817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiNan Zhao updated FLINK-20817: Attachment: WechatIMG46.jpeg WechatIMG45.jpeg WechatIMG44.jpeg > kafka source have 200 field,Causes the class to be generated failed > --- > > Key: FLINK-20817 > URL: https://issues.apache.org/jira/browse/FLINK-20817 > Project: Flink > Issue Type: Bug > Components: Table SQL / API, Table SQL / Planner >Affects Versions: 1.10.2 >Reporter: WeiNan Zhao >Priority: Major > Attachments: WechatIMG44.jpeg, WechatIMG45.jpeg, WechatIMG46.jpeg > > > Too many fields of flink source cause the generated code to be too long, and > a codehaus error is reported. > Is there a way to bypass this restriction instead of changing your own SQL, > because we have many situations where the source table has many fields -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-20817) kafka source have 200 field,Causes the class to be generated failed
WeiNan Zhao created FLINK-20817: --- Summary: kafka source have 200 field,Causes the class to be generated failed Key: FLINK-20817 URL: https://issues.apache.org/jira/browse/FLINK-20817 Project: Flink Issue Type: Bug Components: Table SQL / API, Table SQL / Planner Affects Versions: 1.10.2 Reporter: WeiNan Zhao Too many fields of flink source cause the generated code to be too long, and a codehaus error is reported. Is there a way to bypass this restriction instead of changing your own SQL, because we have many situations where the source table has many fields -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20812) flink connector hbase(1.4,2.2) too few control parameters provided
[ https://issues.apache.org/jira/browse/FLINK-20812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256297#comment-17256297 ] WeiNan Zhao commented on FLINK-20812: - I agree with your approach > flink connector hbase(1.4,2.2) too few control parameters provided > -- > > Key: FLINK-20812 > URL: https://issues.apache.org/jira/browse/FLINK-20812 > Project: Flink > Issue Type: Improvement > Components: Connectors / HBase, Table SQL / Ecosystem >Reporter: WeiNan Zhao >Priority: Major > Fix For: 1.13.0 > > > When I use the cdh cluster, I need to use kerberos authentication, and I need > to add some kerberos authentication parameters of hbase, but the current > hbase connector structure does not provide this entry, I wonder if it can be > modified, if possible, I can submit for hbase connector a pr. > e.g hbase parameter > hbase.security.authentication='kerberos', > hbase.master.kerberos.principal='...', > hbase.kerberos.regionserver.principal='...', > hbase.security.auth.enable = 'true', > hbase.sasl.clientconfig = 'Client' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-20812) flink connector hbase(1.4,2.2) too few control parameters provided
[ https://issues.apache.org/jira/browse/FLINK-20812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiNan Zhao updated FLINK-20812: Labels: flink-connector (was: ) > flink connector hbase(1.4,2.2) too few control parameters provided > -- > > Key: FLINK-20812 > URL: https://issues.apache.org/jira/browse/FLINK-20812 > Project: Flink > Issue Type: Improvement > Components: Connectors / HBase >Affects Versions: 1.10.1, 1.12.0, 1.11.3, 1.13.0 >Reporter: WeiNan Zhao >Priority: Major > Labels: flink-connector > Fix For: 1.13.0 > > > When I use the cdh cluster, I need to use kerberos authentication, and I need > to add some kerberos authentication parameters of hbase, but the current > hbase connector structure does not provide this entry, I wonder if it can be > modified, if possible, I can submit for hbase connector a pr. > e.g hbase parameter > hbase.security.authentication='kerberos', > hbase.master.kerberos.principal='...', > hbase.kerberos.regionserver.principal='...', > hbase.security.auth.enable = 'true', > hbase.sasl.clientconfig = 'Client' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-20812) flink connector hbase(1.4,2.2) too few control parameters provided
WeiNan Zhao created FLINK-20812: --- Summary: flink connector hbase(1.4,2.2) too few control parameters provided Key: FLINK-20812 URL: https://issues.apache.org/jira/browse/FLINK-20812 Project: Flink Issue Type: Improvement Components: Connectors / HBase Affects Versions: 1.11.3, 1.12.0, 1.10.1, 1.13.0 Reporter: WeiNan Zhao Fix For: 1.13.0 When I use the cdh cluster, I need to use kerberos authentication, and I need to add some kerberos authentication parameters of hbase, but the current hbase connector structure does not provide this entry, I wonder if it can be modified, if possible, I can submit for hbase connector a pr. e.g hbase parameter hbase.security.authentication='kerberos', hbase.master.kerberos.principal='...', hbase.kerberos.regionserver.principal='...', hbase.security.auth.enable = 'true', hbase.sasl.clientconfig = 'Client' -- This message was sent by Atlassian Jira (v8.3.4#803005)
