[GitHub] flink pull request #5917: [FLINK-9201] Fixed the same merge window will be f...
Github user hzyuemeng1 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5917#discussion_r187887606
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ProcessingTimeTrigger.java
---
@@ -60,7 +60,12 @@ public boolean canMerge() {
@Override
public void onMerge(TimeWindow window,
OnMergeContext ctx) {
- ctx.registerProcessingTimeTimer(window.maxTimestamp());
+ //only current wartermark less than a merge window maxtimestamp
that we regsiter a new timer for fire
+ //otherwise if will fired immediately by call onElement
+ long windowMaxTimestamp = window.maxTimestamp();
+ if (windowMaxTimestamp > ctx.getCurrentWatermark()) {
--- End diff --
thanks for your review and merge
---
[GitHub] flink pull request #5917: [FLINK-9201] Fixed the same merge window will be f...
GitHub user hzyuemeng1 opened a pull request: https://github.com/apache/flink/pull/5917 [FLINK-9201] Fixed the same merge window will be fired twice if water⦠â¦mark already passed the merge window *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) - The S3 file system connector: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/hzyuemeng1/flink FLINK-9201 Alterna
[GitHub] flink issue #5441: [FLINK-8607] [table] Add a basic embedded SQL CLI client
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/5441 @twalthr ,do we implement this base on table api such as sql -> table api -> runtime, or new plan:sql -> calcite->whole stage codegen -runtime. ---
[GitHub] flink pull request #2994: [FLINK-5324] [yarn] JVM Opitons will work for both...
GitHub user hzyuemeng1 reopened a pull request:
https://github.com/apache/flink/pull/2994
[FLINK-5324] [yarn] JVM Opitons will work for both YarnApplicationMasâ¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
â¦terRunner and YarnTaskManager with yarn mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink FLINK-5324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2994
commit 0a11b26adfac91663023aa1c5e26e2ff60d44e15
Author: hzyuemeng1 <hzyueme...@corp.netease.com>
Date: 2016-12-13T08:13:20Z
[FLINK-5324] [yarn] JVM Opitons will work for both
YarnApplicationMasterRunner and YarnTaskManager with yarn mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2994: [FLINK-5324] [yarn] JVM Opitons will work for both...
Github user hzyuemeng1 closed the pull request at: https://github.com/apache/flink/pull/2994 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2994: [FLINK-5324] [yarn] JVM Opitons will work for both YarnAp...
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2994 @wuchong ï¼can u check this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2994: [FLINK-5324] [yarn] JVM Opitons will work for both YarnAp...
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2994 @ChengXiangLi ,can u review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2994: [FLINK-5324] [yarn] JVM Opitons will work for both...
GitHub user hzyuemeng1 opened a pull request:
https://github.com/apache/flink/pull/2994
[FLINK-5324] [yarn] JVM Opitons will work for both YarnApplicationMasâ¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
â¦terRunner and YarnTaskManager with yarn mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink FLINK-5324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2994
commit 0a11b26adfac91663023aa1c5e26e2ff60d44e15
Author: hzyuemeng1 <hzyueme...@corp.netease.com>
Date: 2016-12-13T08:13:20Z
[FLINK-5324] [yarn] JVM Opitons will work for both
YarnApplicationMasterRunner and YarnTaskManager with yarn mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Github user hzyuemeng1 commented on the issue:
https://github.com/apache/flink/pull/2678
thanks for ur review,i am very interesting about Table SQL,and want to make
it better
2016-10-24
hzyuemeng1
å件人ï¼Jark <notificati...@github.com>
åéæ¶é´ï¼2016-10-24 09:57
主é¢ï¼Re: [apache/flink] [FLINK-4879] [Kafka-Connector] class
KafkaTableSource should be public just like KafkaTableSink (#2678)
æ¶ä»¶äººï¼"apache/flink"<fl...@noreply.github.com>
æéï¼"hzyuemeng1"<hzyueme...@corp.netease.com>,"Author"<aut...@noreply.github.com>
+1 to merge this. I think it's fine to make KafkaTableSource public, just
like FlinkKafkaConsumerBase.
â
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2678 @wuchong can u help me to inform someone to merge this pr,thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Github user hzyuemeng1 commented on the issue: https://github.com/apache/flink/pull/2678 @fhueske @rmetzger ,thanks all for review this pr,I am very interesting in Table SQL,can anyone merge this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSou...
GitHub user hzyuemeng1 opened a pull request:
https://github.com/apache/flink/pull/2678
[FLINK-4879] [Kafka-Connector] class KafkaTableSource should be public just
like KafkaTableSink
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink
KafkaTableSource_should_public
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2678
commit 9d2d18c5e32e4e89d9482b6b6e70c4891f551109
Author: hzyuemeng1 <hzyueme...@corp.netease.com>
Date: 2016-10-21T09:27:12Z
class KafkaTableSource should be public
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2632: [FLINK-4827][Docs] The scala example of SQL on Str...
GitHub user hzyuemeng1 opened a pull request:
https://github.com/apache/flink/pull/2632
[FLINK-4827][Docs] The scala example of SQL on Streaming Tables with wrong
variable nameâ¦
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = TableEnvironment.getTableEnvironment(env)
// read a DataStream from an external source
val ds: DataStream[(Long, String, Integer)] = env.addSource(...)
// register the DataStream under the name "Orders"
tableEnv.registerDataStream("Orders", ds, 'user, 'product, 'amount)
// run a SQL query on the Table and retrieve the result as a new Table
val result = tableEnv.sql(
"SELECT product, amount FROM Orders WHERE product LIKE '%Rubber%'")
There is no variable named tableEnv had defined ,Only tEnv defined here
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink
document_dev_tableapi_variable_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2632
commit a015a22248295041eef708e84a9d64ec4dcbbecb
Author: hzyuemeng1 <hzyueme...@corp.netease.com>
Date: 2016-10-14T05:38:59Z
The scala example of SQL on Streaming Tables with wrong variable name in
flink document
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2631: The scala example of SQL on Streaming Tables with ...
GitHub user hzyuemeng1 opened a pull request:
https://github.com/apache/flink/pull/2631
The scala example of SQL on Streaming Tables with wrong variable name in
flink document
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = TableEnvironment.getTableEnvironment(env)
// read a DataStream from an external source
val ds: DataStream[(Long, String, Integer)] = env.addSource(...)
// register the DataStream under the name "Orders"
tableEnv.registerDataStream("Orders", ds, 'user, 'product, 'amount)
// run a SQL query on the Table and retrieve the result as a new Table
val result = tableEnv.sql(
"SELECT product, amount FROM Orders WHERE product LIKE '%Rubber%'")
There is no variable named tableEnv had defined ,Only tEnv defined here
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink document_modify_variable_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2631.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2631
commit e3f010f68d68f39f62b25eb0190da25ad45c4a14
Author: hzyuemeng1 <hzyueme...@corp.netease.com>
Date: 2016-10-14T03:50:36Z
The scala example of SQL on Streaming Tables with wrong variable name in
flink document
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
