[GitHub] flink issue #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..." instea...
Github user jameslafa commented on the issue: https://github.com/apache/flink/pull/4647 @zentol I agree, it make it a lot easier to read. I just pushed the update. Thanks for your feedback. ---
[GitHub] flink issue #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..." instea...
Github user jameslafa commented on the issue: https://github.com/apache/flink/pull/4647 @zentol I pushed the changes we talk about yesterday. Let me know if it's fine for you :) Thanks for your help. ---
[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE
Github user jameslafa commented on the issue: https://github.com/apache/flink/pull/4648 As decided, we stay on 6.19. I drop the pull request. ---
[GitHub] flink pull request #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup...
Github user jameslafa closed the pull request at: https://github.com/apache/flink/pull/4648 ---
[GitHub] flink issue #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup IDE
Github user jameslafa commented on the issue: https://github.com/apache/flink/pull/4648 Hum I don't know how I missed that bulletpoint... Sorry @aljoscha, any reason to use 6.19 instead of 8.0? ---
[GitHub] flink pull request #4648: [FLINK-7584] [doc] Fix checkstyle version in Setup...
GitHub user jameslafa opened a pull request: https://github.com/apache/flink/pull/4648 [FLINK-7584] [doc] Fix checkstyle version in Setup IDE ## Problem There is a breaking change in the Checkstyle-IDEA plugin since version **8.1**. The Flink `checkstyle.xml` is working up to version **8.0**. ## Fix Changing the `checkstyle.xml` is a sensible topic so we decided to updated the documentation to stipulate that we have to use the **8.0** version instead of **8.1+**. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameslafa/flink 7584-update-documentation-setup-ide Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4648.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4648 commit 434e52089f65cfb4784e326b661ba80dfb1bb9a1 Author: James Lafa <ja...@data-artisans.com> Date: 2017-09-05T14:49:46Z [FLINK-7584] [doc] Fix checkstyle version in Setup IDE ---
[GitHub] flink pull request #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..."...
GitHub user jameslafa opened a pull request: https://github.com/apache/flink/pull/4647 [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..." instead of 0 when IO metrics are not yet retrieved ## Problem IO metrics is the web-dashboard are retrieved asynchronously. When we display a job's IO metrics for the first time, the API return "0" because values are not yet available. It's misleading. ## Fix There is now a new flag is the API called *metrics-fetched*. If its value is **false**, the dashboard displays "Fetching..." instead of 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameslafa/flink 7575-io_metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4647.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4647 commit b14f5865967bb42207b6580ae9d719c02a9ec388 Author: James Lafa <ja...@data-artisans.com> Date: 2017-09-05T09:33:34Z [FLINK-7575] [webui] Show "Fetching" instead of 0 when IO metrics are not yet retrieved commit 1ab8ef42b3fd624aa495fd009a4a2f212484eb2e Author: James Lafa <ja...@data-artisans.com> Date: 2017-09-05T10:25:40Z [FLINK-7575] [webui] Rebuild the dashboard commit be71dd93503b64c11e49ca6e8ee01a687770c3e6 Author: James Lafa <ja...@data-artisans.com> Date: 2017-09-05T12:30:35Z [FLINK-7575] [webui] Move metricsFetched to MutableIOMetrics ---
