[GitHub] flink issue #2138: [FLINK-3757] clarify JavaDoc for addAccumulator method
Github user knaufk commented on the issue: https://github.com/apache/flink/pull/2138 What about: Add this accumulator. Throws an exception if the accumulator already exists in the *same* Task. Note that the namespace of Accumulators is scoped to the Flink Job, and adding multiple accumulators with the same name *across* Tasks will still lead to unexpected behaviour. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...
Github user knaufk commented on the pull request: https://github.com/apache/flink/pull/1979#issuecomment-218819781 I was worried about this to and intially only added the method to the AbstractRuntimeUDFContext. On the other hand, are you aware of anyone who has implemented RuntimeContext? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...
Github user knaufk commented on the pull request: https://github.com/apache/flink/pull/1979#issuecomment-218815109 Hopefully, fixed the formatting stuff. If there are still missing lines or so, please just go ahead and fix it during merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...
GitHub user knaufk reopened a pull request:
https://github.com/apache/flink/pull/1979
[FLINK-3758] Add possibility to register accumulators in custom triggers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knaufk/flink FLINK-3758
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1979.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1979
commit d093fdd6bd22382cde3ae202adfd6d407caac0e8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:45:48Z
Added getOrDefaultAccumulator to RuntimeContext
commit 8fc4d39bbb5c76a1b0cc0a4e93522e59fb2135bd
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:46:17Z
Exposed getOrDefaultAccumulator in WindowContext
commit 08df4fb00a500f8a131b4364f94c264c0b51e6b8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-05T16:42:10Z
Added simple test for Accumulators in Triggers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink 3758] Add possibility to register accum...
GitHub user knaufk opened a pull request:
https://github.com/apache/flink/pull/1979
[Flink 3758] Add possibility to register accumulators in custom triggers
1 of 1
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knaufk/flink FLINK-3758
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1979.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1979
commit d093fdd6bd22382cde3ae202adfd6d407caac0e8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:45:48Z
Added getOrDefaultAccumulator to RuntimeContext
commit 8fc4d39bbb5c76a1b0cc0a4e93522e59fb2135bd
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:46:17Z
Exposed getOrDefaultAccumulator in WindowContext
commit 08df4fb00a500f8a131b4364f94c264c0b51e6b8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-05T16:42:10Z
Added simple test for Accumulators in Triggers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...
GitHub user knaufk reopened a pull request: https://github.com/apache/flink/pull/1944 Timer coalescing across keys and cleanup of unused trigger tasks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed Per timestamp only one TriggerTask is registered at the runtime context. When the first timer is registered a new TriggerTask is sheduled. When no timer is registered anymore for a specific timestamp the corresponding trigger task is canceled and hence removed. The ScheduledFutures to cancel trigger tasks are not checkpointed. So cleanup of trigger tasks will not work after a failure. You can merge this pull request into a Git repository by running: $ git pull https://github.com/knaufk/flink FLINK-3669 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1944 commit e1f7a5b0c448516e7c42bfc4938755a43e3bcae0 Author: Konstantin Knauf <konstantin.kn...@tngtech.com> Date: 2016-04-05T17:59:19Z Timer coalescing across keys and cleanup of unused trigger tasks Per timestamp only one TriggerTask is registered at the runtime context. When the first timer is registered a new TriggerTask is sheduled. When no timer is registered anymore for a specific timestamp the corresponding trigger task is canceled and hence removed. The ScheduledFutures to cancel trigger tasks are not checkpointed. So cleanup of trigger tasks will not work after a failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1944 Timer coalescing across keys and cleanup of unused trigger tasks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed Per timestamp only one TriggerTask is registered at the runtime context. When the first timer is registered a new TriggerTask is sheduled. When no timer is registered anymore for a specific timestamp the corresponding trigger task is canceled and hence removed. The ScheduledFutures to cancel trigger tasks are not checkpointed. So cleanup of trigger tasks will not work after a failure. You can merge this pull request into a Git repository by running: $ git pull https://github.com/knaufk/flink FLINK-3669 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1944 commit e1f7a5b0c448516e7c42bfc4938755a43e3bcae0 Author: Konstantin Knauf <konstantin.kn...@tngtech.com> Date: 2016-04-05T17:59:19Z Timer coalescing across keys and cleanup of unused trigger tasks Per timestamp only one TriggerTask is registered at the runtime context. When the first timer is registered a new TriggerTask is sheduled. When no timer is registered anymore for a specific timestamp the corresponding trigger task is canceled and hence removed. The ScheduledFutures to cancel trigger tasks are not checkpointed. So cleanup of trigger tasks will not work after a failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1861 [FLINK-3688] WindowOperator.trigger() does not emit Watermark anymore Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed Conflicts: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/knaufk/flink FLINK-3688 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1861.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1861 commit 0afb53afa19d6ce791367fe15729bec27d114a8b Author: Konstantin Knauf <konstantin.kn...@tngtech.com> Date: 2016-04-03T11:57:35Z [FLINK-3688] WindowOperator.trigger() does not emit Watermark anymore Conflicts: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
