[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...
Github user matadorhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/601#discussion_r28594789
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -64,15 +64,19 @@
* @return the storage directory used by a BLOB service
*/
static File initStorageDirectory(String storageDirectory) {
- File baseDir = storageDirectory != null ?
- new File(storageDirectory) :
- new File(System.getProperty("java.io.tmpdir"));
+ File baseDir;
+ if (storageDirectory == null || storageDirectory.isEmpty()) {
--- End diff --
Yeah, you are right. Thank for you notes.I have change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/601
[FLINK-1891]Add the input storageDirectory empty check
Add the input storageDirectory empty check, if input of storageDirectory is
empty, we should use tmp as the base dir
And also fix the code style proble of blank space between every ) and {
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink Fix_bug_dir_empty_check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #601
commit 90c5e380e8f2e5970a2aebc57d098f56b4f65135
Author: hongsibao
Date: 2015-04-15T10:15:27Z
Add the input storageDirectory empty check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1887]Fix the message in runtime excepti...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/599 [FLINK-1887]Fix the message in runtime exception RT, You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink fix_RuntimeExceptionMessage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit deae58893a00ca79c6ed225c47b9150e239f0022 Author: hongsibao Date: 2015-04-13T10:37:17Z Fix the message in runtime exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/569#issuecomment-89706960 OK. I accept it. I will close the PR. Thanks for your answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/569 [FLINK-1826]Remove the redundant codes never be executed in function getNumPages Remove the code never be executed in function getNumPages, because the input of numBytes has be validataion by its caller of DefaultMemoryManager(long memorySize, int numberOfSlots, int pageSize). You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink FLINK-1826 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/569.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #569 commit 40261a4519578d22c51030660323ac722e822045 Author: hongsibao Date: 2015-04-04T04:56:54Z Remove the redundant codes never be executed in function getNumPages --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1825]Fix the constructor comments with ...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/568 [FLINK-1825]Fix the constructor comments with correct parameter .The comment in DefaultMemoryManager's constructor of parameters missing 'numberOfSlots' You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink FLINK-1825 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/568.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #568 commit fb62922c00514d097019a219b0796e2b538d4bb7 Author: hongsibao Date: 2015-04-04T02:28:59Z Fix the constructor comments with correct parameter in DefaultMemoryManager --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1805]The class IOManagerAsync should us...
Github user matadorhong commented on a diff in the pull request: https://github.com/apache/flink/pull/546#discussion_r27441775 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsync.java --- @@ -43,7 +45,10 @@ /** Flag to signify that the IOManager has been shut down already */ private final AtomicBoolean isShutdown = new AtomicBoolean(); - + + /** Logging */ + protected static final Logger LOG = LoggerFactory.getLogger(IOManagerAsync.class); --- End diff -- @hsaputra Yes, private here is better. Thanks you. I have updated it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: The class IOManagerAsync should use its own Lo...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/546 The class IOManagerAsync should use its own Log instance Although class 'IOManagerAsync' is extended from 'IOManager' in package 'org.apache.flink.runtime.io.disk.iomanager', but I think it should has its own Log instance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink FLINK-1805 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #546 commit 56b9dab105a9d0884f791fbd42f62ce94bdb3042 Author: hongsibao Date: 2015-03-30T15:00:26Z The class IOManagerAsync(in org.apache.flink.runtime.io.disk.iomanager) should use its own Log instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK]Remove the redunant import code
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/538 [FLINK]Remove the redunant import code You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink RemoveRedundantImport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/538.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #538 commit 1f80c0dba830eb18e5d6e4eeebfc2e1c6f9efb43 Author: hongsibao Date: 2015-03-26T15:57:37Z Remove the redunant import code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-86050415 @StephanEwen I have fixed the code style issue and changed the PR to an "Improvement" one in jira. Finally, great thanks for your help. And I will take more time to contribute Flink. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1779]Rename the function getCurrentyAct...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/529 [FLINK-1779]Rename the function getCurrentyActiveConnections in ' org.apache.flink.runtime.blob'. I think the function name "getCurrentyActiveConnections" in ' org.apache.flink.runtime.blob' is a wrong spelling, it should be "getCurrentyActiveConnections" is more better, and also I add some comments about the function and the Tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink RenameFuctionName Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #529 commit 8423e9df32163067a794387f23b03a2fd1631a7c Author: hongsibao Date: 2015-03-24T16:04:53Z Rename the function name from getCurrentyActiveConnections to getCurrentActiveConnections in org.apache.flink.runtime.blob --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Add the class member variables with 'this'
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/510 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1774]Remove the redundant code in try{}...
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/522
[FLINK-1774]Remove the redundant code in try{} block.
Remove the redundant code of "fos.close(); fos = null;" in try block
because the fos,close() code will always executes in finally block.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink RemoveRedundantCode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #522
commit 353705fd21466f1ad09dbd7222c0f897357060ee
Author: hongsibao
Date: 2015-03-23T16:23:57Z
Remove the redundant code in try{} block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Rename the variable 'contentAdressable' to 'co...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/515 Rename the variable 'contentAdressable' to 'contentAddressable' Rename the variable 'contentAdressable' to 'contentAddressable' in order to better understanding. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink RenameVariableMoreReasonable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/515.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #515 commit 40c73123c8f6a1bce533097f7d107a131835c474 Author: hongsibao Date: 2015-03-22T16:52:22Z Rename the variable 'contentAdressable' to 'contentAddressable' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1768]Fix the bug of BlobServerConnectio...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/514 [FLINK-1768]Fix the bug of BlobServerConnection's LOG. The LOG in class of BlobServerConnection should be created by classloader of BlobServerConnection.class You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink FixLogClassLoaderError Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/514.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #514 commit 6690db637e5ab4b1a1b19841864f636fc96c6487 Author: hongsibao Date: 2015-03-22T16:18:06Z Fix the bug of BlobServerConnection's LOG. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84491491 Thanks for Ewen. That help me a lot to understand how to contribute to Flink. I will follow the guide in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84489355 Great thanks to Ewen. I will first have a study of how to format code. Then pull a request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/511 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink Bug_Flink_1776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit ab0ae5ece5e641455fa819b372a742ed607c183d Author: hongsibao Date: 2015-03-21T15:12:58Z [FLINK-1766]Fix the bug of equals function of FSKey --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Add the class member variables with 'this'
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/510 Add the class member variables with 'this' Just add the class member variables with 'this' like other class member variables in other class member function byunified format for good reading. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink fix_this_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit 99a8f4e02f735e5076b591c9ca21501cd7fcde23 Author: hongsibao Date: 2015-03-21T15:08:22Z Add the class member variables with 'this' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Add the class member variables with 'this'
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1766]Fix the bug of equals function of ...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/509 [FLINK-1766]Fix the bug of equals function of FSKey The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return True. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_equals_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #509 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 17fd72dc87ff652362bbda159f09e14130ea3e93 Author: Hong Sibao Date: 2015-03-19T07:28:43Z Merge branch 'master' of https://github.com/apache/flink commit 16e3a6c1c2d0ba4f73ed7854ce60e405791bb976 Author: hongsibao Date: 2015-03-19T15:53:24Z Merge branch 'master' of https://github.com/matadorhong/flink commit 86253a304427620b570d52abee16d6ef561f6de4 Author: hongsibao Date: 2015-03-19T15:55:17Z Merge remote-tracking branch 'upstream/master' commit 2495512d32554668efd2972866833b9f7033d7f6 Author: Hong Sibao Date: 2015-03-20T01:23:49Z Merge branch 'master' of https://github.com/apache/flink commit 80bbc423d22f437c4b3a20f28e0f4ec6866fc14d Author: Hong Sibao Date: 2015-03-20T01:24:04Z Merge branch 'master' of https://github.com/matadorhong/flink commit cd969f20eca52442bd84212757fa3842e54c6099 Author: hongsibao Date: 2015-03-20T16:42:25Z Merge remote-tracking branch 'upstream/master' commit 89d2bb56ec5c92579b073c9d963d03622f34d4bb Author: Hong Sibao Date: 2015-03-21T02:25:02Z Merge branch 'master' of https://github.com/matadorhong/flink commit 8a412681b281889a45bae96b8e129efc15625ae3 Author: Hong Sibao Date: 2015-03-21T03:52:19Z Merge remote-tracking branch 'upstream/master' commit eeb3469a2c0350e3c4251dccf5947f7458e29657 Author: Hong Sibao Date: 2015-03-21T12:49:05Z Fix the bug of equals function of FSKey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Add the class member variables with 'this'
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/507 Add the class member variables with 'this' Just add the class member variables with 'this' like other class member variables in other class member function byunified format for good reading. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_3.21 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #507 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 17fd72dc87ff652362bbda159f09e14130ea3e93 Author: Hong Sibao Date: 2015-03-19T07:28:43Z Merge branch 'master' of https://github.com/apache/flink commit 16e3a6c1c2d0ba4f73ed7854ce60e405791bb976 Author: hongsibao Date: 2015-03-19T15:53:24Z Merge branch 'master' of https://github.com/matadorhong/flink commit 86253a304427620b570d52abee16d6ef561f6de4 Author: hongsibao Date: 2015-03-19T15:55:17Z Merge remote-tracking branch 'upstream/master' commit 2495512d32554668efd2972866833b9f7033d7f6 Author: Hong Sibao Date: 2015-03-20T01:23:49Z Merge branch 'master' of https://github.com/apache/flink commit 80bbc423d22f437c4b3a20f28e0f4ec6866fc14d Author: Hong Sibao Date: 2015-03-20T01:24:04Z Merge branch 'master' of https://github.com/matadorhong/flink commit cd969f20eca52442bd84212757fa3842e54c6099 Author: hongsibao Date: 2015-03-20T16:42:25Z Merge remote-tracking branch 'upstream/master' commit 89d2bb56ec5c92579b073c9d963d03622f34d4bb Author: Hong Sibao Date: 2015-03-21T02:25:02Z Merge branch 'master' of https://github.com/matadorhong/flink commit 1e62e5154aea09dfc12acf98cc2269f30ca03c67 Author: Hong Sibao Date: 2015-03-21T02:51:58Z Fix the class variables usage with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-441] Rename Pact* and Nephele* classes ...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/492#issuecomment-83649446 As in your comment in this PR, I think you make a small spelling mistake "Renames the package org.apache.flink.compiler to org.apache.fink.optimizer", which should be "org.apache.flink.optimizer". But the codes are all OK. HAHA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Remove redundant codes which never been execut...
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Remove redundant codes which never been execut...
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/502
Remove redundant codes which never been executed
The following codes will never throw any execption, so the code of try
catch are redundant code, should be removed.
LOG.info("Loading configuration from " + cliConfig.configDir)
GlobalConfiguration.loadConfiguration(cliConfig.configDir)
GlobalConfiguration.getConfiguration()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink bug_3.19
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #502
commit 68de654200b796c45e2f250c0d359c56a3d474bc
Author: Sibao Hong
Date: 2015-03-13T07:03:51Z
Merge pull request #1 from apache/master
update
commit 07c20a40ccbfc886344bde5c26ed3605a799220a
Author: Hong Sibao
Date: 2015-03-18T09:45:49Z
Merge branch 'master' of https://github.com/apache/flink
commit 17fd72dc87ff652362bbda159f09e14130ea3e93
Author: Hong Sibao
Date: 2015-03-19T07:28:43Z
Merge branch 'master' of https://github.com/apache/flink
commit 5c218adf92538c1c50770358655ef932138d3120
Author: Hong Sibao
Date: 2015-03-19T08:45:57Z
Remove redundant codes which never been executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83238963 Have modified the port range of TaskManager in [0, 65535] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...
Github user matadorhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/499#discussion_r26695073
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1274,9 +1274,10 @@ object TaskManager {
"' is missing (hostname/address of JobManager to connect to).")
}
-if (port <= 0) {
+if (port <= 0 || port >= 65535) {
--- End diff --
Yes, It should be in [0, 65535]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/499 [FLINK-1739]Fix the bug of JobManager and TaskManager Port Check. The IPC port of JobManager and IPC port of TaskManager must be great than 0 and less than 65535. It must have check the port whether is in right range area before run the JobManager and TaskManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink bug_jobmanager_port_check Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/499.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #499 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update commit 07c20a40ccbfc886344bde5c26ed3605a799220a Author: Hong Sibao Date: 2015-03-18T09:45:49Z Merge branch 'master' of https://github.com/apache/flink commit 914f06e856e7680500a2c4c10390b701872c49fc Author: hongsibao Date: 2015-03-18T15:44:12Z Merge remote-tracking branch 'upstream/master' commit 724e2bd19b1ccd9238354af1c876a2d8c839f280 Author: hongsibao Date: 2015-03-18T17:06:06Z Fix the bug of the jobManager and TaskManager IPC Port Check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/495 Merge pull request #1 from apache/master update You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 commit 68de654200b796c45e2f250c0d359c56a3d474bc Author: Sibao Hong Date: 2015-03-13T07:03:51Z Merge pull request #1 from apache/master update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: modify the getlogger of the class
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/490 modify the getlogger of the class You can merge this pull request into a Git repository by running: $ git pull https://github.com/matadorhong/flink logclass_317 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/490.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #490 commit c23fa92f32758d57863a4d19542f4d20546267c5 Author: Hong Sibao Date: 2015-03-17T10:46:22Z modify the getlogger of the class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
