[GitHub] flink pull request #2665: [FLINK-4659]: Potential resource leak due to unclo...
GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2665 [FLINK-4659]: Potential resource leak due to unclosed InputStream in SecurityContext#populateSystemSecurityProperties() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue ([FLINK-4659]: Potential resource leak due to unclosed InputStream in SecurityContext#populateSystemSecurityProperties()) - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink FLINK-4659 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2665.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2665 commit 0f3d4e31f14258a775a2342c4bf534154c97d078 Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-10-19T00:47:20Z FLINK-4659: Closed the jassConfStream object to prevent resource leaks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 Thanks @uce, agreed, it would be a community effort indeed. I will try to help as much as possible. @ggevay, it's alright. I'll close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2642: [FLINK-3999]: Rename the `running` flag in the dri...
Github user nssalian closed the pull request at: https://github.com/apache/flink/pull/2642 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 @StephanEwen ,thanks for that, that makes sense. But it is hard for someone new to understand the problem you mention. If someone familiar with the product, could review new JIRAs for clear benefit / validity, that would encourage folks jumping on the tasks to know it better. I realize it may not be feasible but it saves time too to let them know in advance. I can certainly close the PR and make it Not a Problem. But if there is a better way to have this clearer , I would appreciate it before the effort is put in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 @ggevay they are not related.. I think it caught from me old branch on to this one. The 3 in the middle2ef4401,46d91b0,1433a5d are relevant here. Apologies for the mix up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2642: [FLINK-3999]: Rename the `running` flag in the dri...
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2642
[FLINK-3999]: Rename the `running` flag in the drivers to `canceled`
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-3999]
Rename the `running` flag in the drivers to `canceled`")
- Added the cancelled flag instead of the running flag to replace the
functionality since it was not truly "running".
- Modified the operators to have the cancelled instead of running even in
tests
- [ ] Documentation
- Modified the Example for the Loading Data where the import statement
needed to be changed.
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
- Ran a Travis build and local mvn tests as well.
@ggevay if you could help review. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-3999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2642
commit 65b3ff78f100ed1b13ec2fcc727f4869823b5918
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-09-12T22:38:06Z
FLINK-4614: Changed the version from 1.2-SNAPSHOT to 1.2 to help correct
docs in 1.2.0
commit 2ef440161699943cb3cc38eccc6ef39a1bd512a1
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T20:41:00Z
FLINK-3999: Modified the running flag for the runtime module to cancelled
to depict correctness
commit 46d91b0052971e5116c674a350ff38aa692616bb
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T23:07:45Z
FLINK-3999: Fixed Tests
commit 1433a5db5ad13aef3f76e8ab4b2fa131272fe59d
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T23:58:33Z
FLINK-3999: More changes to fix tests
commit ba4f429043f3985db5ab37a3902a6fee15a7440e
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-17T01:12:43Z
FLINK-3999: Updated config version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2641: [FLINK-4792] [Docs] Update documentation - FlinkML...
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2641
[FLINK-4792] [Docs] Update documentation - FlinkML/QuickStart Guide
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-4792]
Update documentation - FlinkML/QuickStart Guide")
- [ ] Documentation
- Modified the example to correct the import statement in Loading Data
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-4792-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2641
commit 65b3ff78f100ed1b13ec2fcc727f4869823b5918
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-09-12T22:38:06Z
FLINK-4614: Changed the version from 1.2-SNAPSHOT to 1.2 to help correct
docs in 1.2.0
commit f07e5bfaea21b6c3bf562d1f167c3ec50948773c
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-17T00:54:20Z
FLINK-4792: Changed the import statement for the Loading data example
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r82871252
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -107,10 +113,10 @@ public ContinuousFileMonitoringFunction(
@Override
@SuppressWarnings("unchecked")
public void open(Configuration parameters) throws Exception {
- LOG.info("Opening File Monitoring Source.");
-
super.open(parameters);
format.configure(parameters);
+
+ LOG.info("Opening File Monitoring Source for path: " + path +
".");
--- End diff --
I think "Opening" makes sense since it's describing an action
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2442: [FLINK-4148] incorrect calculation minDist distance in Qu...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2442 Seems good to me. @zentol do you have time to add some extra review on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2493: [FLINK-4513] [Docs]: Kafka connector documentation refers...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2493 Thanks @StephanEwen . Closing this one as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2493: [FLINK-4513] [Docs]: Kafka connector documentation...
Github user nssalian closed the pull request at: https://github.com/apache/flink/pull/2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2494: [FLINK-4614][Docs]: Changed the version from 1.2-S...
Github user nssalian closed the pull request at: https://github.com/apache/flink/pull/2494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2494: [FLINK-4614][Docs]: Changed the version from 1.2-SNAPSHOT...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2494 That helps clarify. Thanks @StephanEwen. Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2493: [FLINK-4513] [Docs]: Kafka connector documentation refers...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2493 @uce, @zentol do you have some time to help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2494: [FLINK-4614][Docs]: Changed the version from 1.2-SNAPSHOT...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2494 @uce, @zentol do you have some time to help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2494: [FLINK-4614][Docs]: Changed the version from 1.2-S...
GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2494 [FLINK-4614][Docs]: Changed the version from 1.2-SNAPSHOT to 1.2 in docs/_config.yml Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] Documentation - Modified the _config.yml file to point to 1.2 instead of 1.2-SNAPSHOT - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed â¦ect docs in 1.2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2494.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2494 commit 65b3ff78f100ed1b13ec2fcc727f4869823b5918 Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-09-12T22:38:06Z FLINK-4614: Changed the version from 1.2-SNAPSHOT to 1.2 to help correct docs in 1.2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2493: [FLINK-4513] [Docs]: Kafka connector documentation...
GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2493 [FLINK-4513] [Docs]: Kafka connector documentation refers to Flink 1.1-SNAPSHOT Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] Documentation Modified the _config.yml - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed ⦠of 1.1-SNAPSHOT You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink release-1.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2493 commit 1c22a2d1de16eea08c3cbc2d4390ee27abf234ae Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-09-12T21:35:00Z FLINK-4513: Changing the docs/_config.yml to the 1.1 release instread of 1.1-SNAPSHOT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2465: [FLINK-4447] [docs] Include NettyConfig options on Config...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2465 Hi @greghogan thanks for the PR. Took a look at it and seems good to go. The test failure doesn't seem related. Since I'm new to the community, I would probably ask someone else to have a look as well. @uce , if you can have a pass over this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2442: [FLINK-4148] incorrect calculation minDist distance in Qu...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2442 Hi @xhumanoid , thanks for the PR. Could you please check the Failure messages and fix the build? Can help review once the PR is cleanly mergable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2403: [FLINK-4278]: Unclosed FSDataOutputStream in multi...
Github user nssalian closed the pull request at: https://github.com/apache/flink/pull/2403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2403: [FLINK-4278]: Unclosed FSDataOutputStream in multiple fil...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2403 @StephanEwen, let me close this and open a new one after some testing. Will post an new PR this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2403: [FLINK-4278]: Unclosed FSDataOutputStream in multiple fil...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2403 Thanks @StephanEwen. Let me check again with the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2403: [FLINK-4278]: Unclosed FSDataOutputStream in multiple fil...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2403 Hi @rmetzger, @tedyu do you have some time to help review this? I am not sure if the failures are related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2403: [FLINK-4278]: Unclosed FSDataOutputStream in multi...
GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2403 [FLINK-4278]: Unclosed FSDataOutputStream in multiple files in the project Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - JIRA: https://issues.apache.org/jira/browse/FLINK-4278 - Added the close statements for the FSStateBackend, StringWriter and FileSystemStateStorageHelper for the unclosed FileDataOutputStream objects. - Each commit in the PR has a meaningful commit message (including the JIRA id) - [ ] Documentation - No documentation needed here. - [ ] Tests & Build - `mvn clean verify` has been executed successfully locally or a Travis build has failed but the failure does not seem related. Can do a re-run and verify on the PR itself. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink FLINK-4278 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2403.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2403 commit 844c9893045a4257630ed1ca564f67db0dee0b4a Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-08-15T21:28:36Z FLINK-4278: Added close method calls to FSDataOutputStream and FsStateBackend commit d7d1273d7fee1fa728f97aa1fca360bad96c804d Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-08-16T03:42:25Z FLINK-4278: Added close method to the FileSystemStateStorageHelper and StringWriter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2382: [FLINK-4402]: Wrong metrics parameter names in documentat...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2382 Thank you @rmetzger and @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2382: FLINK-4402: Wrong metrics parameter names in docum...
GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2382 FLINK-4402: Wrong metrics parameter names in documentation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - JIRA- https://issues.apache.org/jira/browse/FLINK-4402 - Title: Wrong metrics parameter names in documentation - [ ] Documentation - Changed the task and operator metrics in https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html to align with ConfigConstants.java - [ ] Tests & Build - `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink FLINK-4402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2382 commit 3d22950493abfdb8caae72447bb71bd6fcb8f709 Author: Neelesh Srinivas Salian <nsal...@cloudera.com> Date: 2016-08-17T18:30:06Z FLINK-4402: Changed the documentation for the metrics in the System Scope Section --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2307 Hi @aditivin , welcome to the community. Thank you for the PR as well. A few suggestions: 1) Upon opening a PR, it is best to add more information regarding testing or even checks that you have done. I believe the PR template helps add more information with regards to testing /checks. 2) I don't see much testing that can be done here, anything you see that can help testing the debug logging, @aditivin? 3) One additional point would be to enable the travis build on your repository. (As Flink comes with a travis.yml all you need to do is to go to Travis, login with your github user and hit enable on the repo.) A local build helps understand if there are issues that could occur. This link should be helpful: https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2299: [FLINK-4259]: Unclosed FSDataOutputStream in FileCache#co...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2299 Thanks @mbalassi and @zentol for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2299: [FLINK-4259]: Unclosed FSDataOutputStream in FileCache#co...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2299 Hi @mbalassi and @zentol, I ran the builds twice and both instances the PythonBinderTest passed. The 2nd build ran with a failure on 2 with: MVN exited with EXIT CODE: 1. java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar (No such file or directory) which, if I am not wrong, isn't related here. Please let me know if you need me to add anything additional. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2299: [FLINK-4259]: Unclosed FSDataOutputStream in FileC...
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2299
[FLINK-4259]: Unclosed FSDataOutputStream in FileCache#copy(): Added a â¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
Description of Changes:
Add a close statement for closing the FSDataOutputStream.
Requesting review.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-4259]
Unclosed FSDataOutputStream in FileCache#copy()")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
â¦close statement to close the FSDataOutputStream object
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-4259
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2299
commit f77780aa9c997eeac3950cfd2194b7c08851ef8d
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-07-25T20:30:42Z
FLINK-4259: Unclosed FSDataOutputStream in FileCache#copy(): Added a close
statement to close the FSDataOutputStream object
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2291: [FLINK-4226] Typo: Define Keys using Field Expressions ex...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2291 Thanks @gallenvara. I'll close in favor of #2261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2291: [FLINK-4226] Typo: Define Keys using Field Express...
Github user nssalian closed the pull request at: https://github.com/apache/flink/pull/2291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL and Strea...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2274 LGTM after the nits. But I would request someone else have a pass over it before moving forward since I am new to the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL an...
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998373
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/StreamTableExample.scala
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.examples.scala
+
+import org.apache.flink.api.scala._
+import org.apache.flink.api.scala.table._
+import org.apache.flink.api.table.TableEnvironment
+import org.apache.flink.streaming.api.scala.{DataStream,
StreamExecutionEnvironment}
+
+/**
+ * Simple example for demonstrating the use of Table API on Stream Table.
+ */
+object StreamTableExample {
+
+ case class Order(user: Long, product: String, amount: Int)
+
+ def main(args: Array[String]): Unit = {
+val env = StreamExecutionEnvironment.getExecutionEnvironment
--- End diff --
Here as well.
Would suggest to the same comment as in WordCountSQL.scala:
// set up execution environment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL an...
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998370
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/StreamSQLExample.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.examples.scala
+
+import org.apache.flink.api.scala._
+import org.apache.flink.api.scala.table._
+import org.apache.flink.api.table.TableEnvironment
+import org.apache.flink.streaming.api.scala.{DataStream,
StreamExecutionEnvironment}
+
+/**
+ * Simple example for demonstrating the use of SQL on Stream Table.
+ */
+object StreamSQLExample {
+
+ case class Order(user: Long, product: String, amount: Int)
+
+ def main(args: Array[String]): Unit = {
+val env = StreamExecutionEnvironment.getExecutionEnvironment
--- End diff --
Same here as well
Would suggest to the same comment as in WordCountSQL.scala:
// set up execution environment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL an...
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998367
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/examples/java/JavaSQLExample.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.examples.java;
+
+import org.apache.flink.api.table.Table;
+import org.apache.flink.api.java.DataSet;
+import org.apache.flink.api.java.ExecutionEnvironment;
+import org.apache.flink.api.java.table.BatchTableEnvironment;
+import org.apache.flink.api.table.TableEnvironment;
+
+/**
+ * Simple example that shows how the Batch SQL used in Java.
+ */
+public class JavaSQLExample {
+
+ public static class WC {
+ public String word;
+ public long frequency;
+
+ // Public constructor to make it a Flink POJO
+ public WC() {
+
+ }
+
+ public WC(String word, long frequency) {
+ this.word = word;
+ this.frequency = frequency;
+ }
+
+ @Override
+ public String toString() {
+ return "WC " + word + " " + frequency;
+ }
+ }
+
+ public static void main(String[] args) throws Exception {
+ ExecutionEnvironment env =
ExecutionEnvironment.getExecutionEnvironment();
--- End diff --
Would suggest to the same comment as in WordCountSQL.scala:
// set up execution environment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2291: FLINK-4226: Define Keys using Field Expressions ex...
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2291
FLINK-4226: Define Keys using Field Expressions example should use wiâ¦
Description:
val wordCounts = words.keyBy("word").reduce(/*window specification*/)
Should be:
val wordCounts = words.keyBy("word").reduce window(/window specification/)
File:
/flink/docs/apis/common/index.md
Requesting Review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-4226
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2291
commit a6bd8e2259f13b868afb97a0ba291ca39629e392
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-07-24T23:02:12Z
FLINK-4226: Define Keys using Field Expressions example should use window
and not reduce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
