[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3189 @zentol I updated the commit: the overall job status count is now displayed in medium-width (but not small or below), and I move the job status count to the right of job start/end & duration. Also, I applied the float-right fix to the "Stop" button, which I didn't notice before. You can see that the fix isn't perfect when the job name is long, but it's still better than what it was. Screenshots from Chrome 55.0.2883.95, controlling window width in the dev tool. 1200px:  1128px (you can see the top navbar wrapping down & peeking out from behind the secondary navbar:  1020px (back to normal because left navbar is collapsed):  992px (wrapping again):  991px:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3189 Thanks @uce that's helpful! Didn't think of putting screenshots in the PR. @zentol The global job state counts didn't seem like the most important thing to show when the browser is narrow, given that this view is about a particular job. So, I added these CSS classes to it ".hidden-xs .hidden-sm .hidden-md" the behavior of which is described on http://getbootstrap.com/css/#responsive-utilities I am not sure what width @uce used for the "wide" screenshots, but it probably was less than 1200px, otherwise it would show up. I can remove the ".hidden-md" class if you want it to show up in the 992px to 1200px range, too... however it does make it more likely for the other more job-specific elements (start/end, duration) to wrap & get lost. Perhaps it would be a good idea to reorder the elements? Put start/end & duration first, and overall job stats last so that it's the first one to wrap? Let me know if you have a preference. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3189: [FLINK-5608] [webfrontend] Cancel button stays vis...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/3189
[FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
- Most importantly, the Cancel button has been changed to float
right, and will only wrap downward if pushed out by the job name
- Also combined the job name and job id into a single horizontal
element, reducing the overall horizontal space taken by the main
navbar components in the job view, making the main navbar components
less likely to wrap downward and be overlapped by the secondary navbar.
- Compiled code has been rebuilt
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink
ui_job_cancel_button_layout_issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3189
commit 33e3a14ebd3d614a6e5d4eae90f5985416e0b995
Author: Shannon Carey <rehevk...@gmail.com>
Date: 2017-01-22T20:52:43Z
[FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
- Most importantly, the Cancel button has been changed to float
right, and will only wrap downward if pushed out by the job name
- Also combined the job name and job id into a single horizontal
element, reducing the overall horizontal space taken by the main
navbar components in the job view, making the main navbar components
less likely to wrap downward and be overlapped by the secondary navbar.
- Compiled code has been rebuilt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3059: [docs] Clarify restart strategy defaults set by checkpoin...
Github user rehevkor5 commented on the issue:
https://github.com/apache/flink/pull/3059
It does, thanks! I'll try to remember to include "closes #_{pr number}_" in
my commit messages which might be handy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3059: [docs] Clarify restart strategy defaults set by checkpoin...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3059 I'm curious as to how you added my commit to `master` and `release-1.2` but it doesn't show up in this PR. The whole "rehevkor5 committed with uce 5 days ago" thing. Github isn't aware that the changes in this PR were merged. If you have a moment can you describe your workflow is so I can understand what's happening behind the scenes? Is it rebase onto master + merge --ff-only or something? Maybe it's due to the fact that Github is only mirroring another repo? I'd appreciate it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3059: [docs] Clarify restart strategy defaults set by checkpoin...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3059 @uce Thanks. I didn't get an opportunity to address your comments... is there anything you want me to do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3079: [FLINK-5424] Improve Restart Strategy Logging
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/3079
[FLINK-5424] Improve Restart Strategy Logging
- Added toString for FailureRateRestartStrategy (important for
JobManager's "Using restart strategy $restartStrategy" log message)
- Added explanation in log when the restart strategy is responsible
for preventing job restart
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink FLINK-5424
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3079.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3059: [docs] Clarify restart strategy defaults set by checkpoin...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/3059 The changes so far are docs-only, so the CI failure must be unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3059: [docs] Clarify restart strategy defaults set by ch...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/3059
[docs] Clarify restart strategy defaults set by checkpointing
- Added info about checkpointing changing the default restart
strategy in places where it was missing: the config page and the
section about the fixed-delay strategy
- Replaced no-restart with "no restart" so people don't think we're
referring to a config value
- Replaced invalid html tag with
- Fixed bad link to restart strategies page from state.md
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink
clarify_retry_strategy_defaults
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3059
commit e7bba190a4d14e5e098acc077856a69839bc7d88
Author: Shannon Carey <rehevk...@gmail.com>
Date: 2017-01-04T19:20:12Z
[docs] Clarify restart strategy defaults set by checkpointing
- Added info about checkpointing changing the default restart
strategy in places where it was missing: the config page and the
section about the fixed-delay strategy
- Replaced no-restart with "no restart" so people don't think we're
referring to a config value
- Replaced invalid html tag with
- Fixed bad link to restart strategies page from state.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2383: [FLINK-4418] [client] Improve resilience when InetAddress...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2383 @StephanEwen do you want me to take a look & see what straightforward refactoring I can make, and squeeze that into this PR? I can't tell if that was a hint or not :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2383: [FLINK-4418] [client] Improve resilience when InetAddress...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2383 I don't think the Jenkins build failure was due to my changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2383: [FLINK-4418] [client] Improve resilience when Inet...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/2383
[FLINK-4418] [client] Improve resilience when InetAddress.getLocalHosâ¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
â¦t() throws UnknownHostException
- If InetAddress.getLocalHost() throws UnknownHostException when
attempting to connect with LOCAL_HOST strategy, the code will move on
to try the other strategies instead of immediately failing.
- Also made minor code style improvements for trying the different
strategies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink FLINK-4418
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2383
commit fa0f239e1e8fac721b805263ccfaa0e0cfaa6138
Author: Shannon Carey <rehevk...@gmail.com>
Date: 2016-08-18T00:35:49Z
[FLINK-4418] [client] Improve resilience when InetAddress.getLocalHost()
throws UnknownHostException
- If InetAddress.getLocalHost() throws UnknownHostException when
attempting to connect with LOCAL_HOST strategy, the code will move on
to try the other strategies instead of immediately failing.
- Also made minor code style improvements for trying the different
strategies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoop1 in q...
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2341 You got it @StephanEwen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoo...
Github user rehevkor5 closed the pull request at: https://github.com/apache/flink/pull/2341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2341: [FLINK-4334] [quickstarts] Correctly exclude hadoo...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/2341
[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink
fix_hadoop1_not_excluded_in_quickstarts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2341
commit 8cb7419a17359f0d61d632aae97f672d497ccc53
Author: Shannon Carey <rehevk...@gmail.com>
Date: 2016-08-08T20:04:23Z
[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2051: [FLINK-3779] Add support for queryable state
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2051 Hi, it's great to see that someone is working on this stuff! I just wanted to put in my two cents, to provide a different perspective that might change how you are thinking about this. On my project, we are interested in incorporating pre-computed historical time-series data into the values within a time window. Those values would need to be loaded from a distributed database such as Cassandra or DynamoDB. Also, we would like for newly computed time-series data points (produced by a Flink window pane) to be persisted externally, side-by-side with the historical data (in Cassandra/DynamoDB). In contrast with your approach, which enables querying of state from within Flink, we are more interested in querying that state from the external database. This allows the Flink job to produce time series data which can be queried ad-hoc in the database, while also allowing the Flink job to produce pre-calculated aggregates from that time series. I believe others have mentioned in this thread the need, therefore, to allow the State Store to choose the serialization approach. While serializing to byte[] works well for Memory and RocksDB State Stores, inserting into a NoSQL database requires creation of an INSERT command with data that includes primary/partition key, secondary/range key, and arbitrarily structured data (one column of byte[], or perhaps more complex based on the particular type of value). In particular, we need the timestamp of the time series point to be a top-level value in the INSERT, so that time range queries can be efficient. The interface is also important when it comes to Flink loading pre-existing data, because Flink or an integration layer will need to know how to query for the particular keys it is looking for. I hope that makes sense & gives some perspective on what some people are thinking about with regard to "queryable state". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3711][docs] Documentation of Scala fold...
GitHub user rehevkor5 opened a pull request: https://github.com/apache/flink/pull/1860 [FLINK-3711][docs] Documentation of Scala fold()() uses correct syntax Scala's KeyedStream#fold which accepts scala.Function2 is defined as a partially appliable function. The documentation, however, is written as if it is a non-partial function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rehevkor5/flink FLINK-3711 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1860.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1860 commit 516a748f108f39bc901c328b252adb3769026474 Author: Shannon Carey <sca...@expedia.com> Date: 2016-04-07T04:30:38Z [FLINK-3711][docs] Documentation of Scala fold()() uses correct syntax --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
