[GitHub] flink pull request #1121: [FLINK-2591] Add configuration parameter for defau...
Github user willmiao closed the pull request at: https://github.com/apache/flink/pull/1121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
Github user willmiao commented on the pull request:
https://github.com/apache/flink/pull/1121#issuecomment-151092573
hi @rmetzger ,
I believe I find the reason why my test failed.
A test will fail if we donât specify â-tâ argument(_which is an
optional argument_) in the command when call runWithArgs function, and we will
get exception here:
```
Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/log4j/Level
at org.apache.hadoop.mapred.JobConf.(JobConf.java:357)
```
It seems some jar files relevant to log callback are needed.
One more thing, I noticed a segment of code as follows in the file
âFlinkYarnSessionCli.javaâ:
```
File logback = new File(confDirPath + File.pathSeparator +
CONFIG_FILE_LOGBACK_NAME);
if (logback.exists()) {
shipFiles.add(logback);
flinkYarnClient.setFlinkLoggingConfigurationPath(new
Path(logback.toURI()));
}
```
And I wonder if â**File.pathSeparator**â should be
â**File.separator**â here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150919886 Hi rmetzger, I have updated this PR. I generated a flink-conf.yaml in a directory, which I then used as the configuration directory for the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150928188 Sorry for the failed tests, I'll fix them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-146371570 @rmetzger : I'm sorry for the late reply, I have been on vacation last three weeks. I failed to find a nice way to "generate a flink-conf.yaml just for the test", could you please give some tips on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
Github user willmiao closed the pull request at: https://github.com/apache/flink/pull/1107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-139531959 I'm sorry that something went wrong with my original repository. So, I open a new PR, and this one will be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1121 [FLINK-2591] Add configuration parameter for default number of yarn containers You can merge this pull request into a Git repository by running: $ git pull https://github.com/willmiao/flink FLINK-2591 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1121 commit 6c6005d6ea92177b4a99183f2509a480718dabb2 Author: Will Miao <miaoyongqi...@huawei.com> Date: 2015-09-10T23:34:35Z [FLINK-2591]Add configuration parameter for default number of yarn containers commit 154e486620469ffadb9fa9caed0f27f69fbe04ad Author: Will Miao <miaoyongqi...@huawei.com> Date: 2015-09-11T12:09:09Z [FLINK-2591] Add configuration parameter for default number of yarn containers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1107 [FLINK-2591]Add configuration parameter for default number of yarn containers https://issues.apache.org/jira/browse/FLINK-2591 Add configuration parameter for default number of yarn containers You can merge this pull request into a Git repository by running: $ git pull https://github.com/willmiao/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1107 commit c1d65cae4e301a1483929b360ddcc96ad34eff31 Author: Will Miao <miaoyongqi...@huawei.com> Date: 2015-09-08T14:58:38Z FLINK-2591 https://issues.apache.org/jira/browse/FLINK-2591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138772421 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should user have to supply the -n argument? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138774833 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should users have to supply the -n argument? I was thinking this behavior may be appropriate: If yarn.defaultNumberOfTaskManagers < 1 (not set or invalide value): users have to supply the -n argument. else if the user specified -n, the value of -n will have priority. else, yarn.defaultNumberOfTaskManagers value will be used by default. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138603922 Thanks for your advices, I'll fix it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
