[jira] [Commented] (FLINK-21742) Support REMOVE JAR statement in SQL Client
[ https://issues.apache.org/jira/browse/FLINK-21742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356772#comment-17356772 ] xiangtao commented on FLINK-21742: -- hi [~jark] I can help to implement this feature. > Support REMOVE JAR statement in SQL Client > -- > > Key: FLINK-21742 > URL: https://issues.apache.org/jira/browse/FLINK-21742 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Reporter: Jark Wu >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-22246) when use HiveCatalog create table , can't set Table owner property correctly
[
https://issues.apache.org/jira/browse/FLINK-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323850#comment-17323850
]
xiangtao commented on FLINK-22246:
--
i will write a test case and sumbit fix pr
> when use HiveCatalog create table , can't set Table owner property correctly
> -
>
> Key: FLINK-22246
> URL: https://issues.apache.org/jira/browse/FLINK-22246
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.1, 1.12.0
>Reporter: xiangtao
>Priority: Major
>
> when i use HiveCatalog create table in sql-client , i found it can't set
> Hive Table `owner` property correctly. i debug code , i found in
> `HiveCatalog.createTable` method
> {code:java}
> Table hiveTable =
> org.apache.hadoop.hive.ql.metadata.Table.getEmptyTable(
> tablePath.getDatabaseName(), tablePath.getObjectName());
> {code}
>
> this get hiveTable obj , owner field is null . beacuse it set owner through
> {code:java}
> t.setOwner(SessionState.getUserFromAuthenticator());
> {code}
>
> but SessionState is null .
> Fix this bug , we can add one code in HiveCatalog.open method .
> {code:java}
> SessionState.setCurrentSessionState(new SessionState(hiveConf));
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-22246) when use HiveCatalog create table , can't set Table owner property correctly
[
https://issues.apache.org/jira/browse/FLINK-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiangtao updated FLINK-22246:
-
Affects Version/s: 1.12.0
> when use HiveCatalog create table , can't set Table owner property correctly
> -
>
> Key: FLINK-22246
> URL: https://issues.apache.org/jira/browse/FLINK-22246
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.1, 1.12.0
>Reporter: xiangtao
>Priority: Major
>
> when i use HiveCatalog create table in sql-client , i found it can't set
> Hive Table `owner` property correctly. i debug code , i found in
> `HiveCatalog.createTable` method
> {code:java}
> Table hiveTable =
> org.apache.hadoop.hive.ql.metadata.Table.getEmptyTable(
> tablePath.getDatabaseName(), tablePath.getObjectName());
> {code}
>
> this get hiveTable obj , owner field is null . beacuse it set owner through
> {code:java}
> t.setOwner(SessionState.getUserFromAuthenticator());
> {code}
>
> but SessionState is null .
> Fix this bug , we can add one code in HiveCatalog.open method .
> {code:java}
> SessionState.setCurrentSessionState(new SessionState(hiveConf));
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-22246) when use HiveCatalog create table , can't set Table owner property correctly
xiangtao created FLINK-22246:
Summary: when use HiveCatalog create table , can't set Table
owner property correctly
Key: FLINK-22246
URL: https://issues.apache.org/jira/browse/FLINK-22246
Project: Flink
Issue Type: Bug
Components: Connectors / Hive
Affects Versions: 1.11.1
Reporter: xiangtao
when i use HiveCatalog create table in sql-client , i found it can't set Hive
Table `owner` property correctly. i debug code , i found in
`HiveCatalog.createTable` method
{code:java}
Table hiveTable =
org.apache.hadoop.hive.ql.metadata.Table.getEmptyTable(
tablePath.getDatabaseName(), tablePath.getObjectName());
{code}
this get hiveTable obj , owner field is null . beacuse it set owner through
{code:java}
t.setOwner(SessionState.getUserFromAuthenticator());
{code}
but SessionState is null .
Fix this bug , we can add one code in HiveCatalog.open method .
{code:java}
SessionState.setCurrentSessionState(new SessionState(hiveConf));
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (FLINK-15472) Support SQL Client Gateway
[ https://issues.apache.org/jira/browse/FLINK-15472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319176#comment-17319176 ] xiangtao edited comment on FLINK-15472 at 4/12/21, 9:07 AM: [~godfreyhe] , [~jark] this implement is in [https://github.com/ververica/flink-sql-gateway] ? was (Author: xiangtao): [~godfreyhe] , [~jark] this implement is in [https://github.com/ververica/flink-sql-gateway] > Support SQL Client Gateway > --- > > Key: FLINK-15472 > URL: https://issues.apache.org/jira/browse/FLINK-15472 > Project: Flink > Issue Type: New Feature > Components: Table SQL / Client >Reporter: godfrey he >Priority: Major > > FLIP-91: > https://cwiki.apache.org/confluence/display/FLINK/FLIP-91%3A+Support+SQL+Client+Gateway -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-15472) Support SQL Client Gateway
[ https://issues.apache.org/jira/browse/FLINK-15472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319176#comment-17319176 ] xiangtao commented on FLINK-15472: -- [~godfreyhe] , [~jark] this implement is in [https://github.com/ververica/flink-sql-gateway] > Support SQL Client Gateway > --- > > Key: FLINK-15472 > URL: https://issues.apache.org/jira/browse/FLINK-15472 > Project: Flink > Issue Type: New Feature > Components: Table SQL / Client >Reporter: godfrey he >Priority: Major > > FLIP-91: > https://cwiki.apache.org/confluence/display/FLINK/FLIP-91%3A+Support+SQL+Client+Gateway -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-22206) Add support server-mode submit for flink SQL. eg : FlinkServer
xiangtao created FLINK-22206: Summary: Add support server-mode submit for flink SQL. eg : FlinkServer Key: FLINK-22206 URL: https://issues.apache.org/jira/browse/FLINK-22206 Project: Flink Issue Type: New Feature Components: Table SQL / Client Reporter: xiangtao Currently , we need to encapsulation a job use `TableEnvironment` and accept input sql . then submit this job to flink runtime execute. Can we implement a server named FlinkServer that to accept sql and submit to flink-runtime like HiveServer ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319019#comment-17319019 ] xiangtao commented on FLINK-21464: -- [~fsk119] PR submitted : https://github.com/apache/flink/pull/15558 > Support ADD JAR command in sql client > - > > Key: FLINK-21464 > URL: https://issues.apache.org/jira/browse/FLINK-21464 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: xiangtao >Priority: Major > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317302#comment-17317302 ] xiangtao commented on FLINK-21464: -- Hi [~fsk119] , i've found a solution. i will submit a PR soon ~~ > Support ADD JAR command in sql client > - > > Key: FLINK-21464 > URL: https://issues.apache.org/jira/browse/FLINK-21464 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: xiangtao >Priority: Major > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-21464) Support ADD JAR command in sql client
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314917#comment-17314917 ] xiangtao edited comment on FLINK-21464 at 4/5/21, 3:05 PM: --- [~fsk119] i'm sorry , my reply is a little late . my implementation plan is as follows: # sql-client has one option `-j` that cloud add jar to sql classpath. so i can use this feature. # when execute `add jar foo.jar` , need to store this jar list to `SessionContext` as a member variable . # final when execute a select/insert/update sql , it need to load this jar to `URLClassLoader` in `ExecutionContext` because invoke sql by ` context.wrapClassLoader(() -> tEnv.executeInternal(operation))` in `ExecutionContext` but i has a question , how to support unload a jar use `remove jar` ? was (Author: xiangtao): [~fsk119] i'm sorry , my reply is a little late . my implementation plan is as follows: # sql-client has one option `-j` that cloud add jar to sql classpath. so i can use this feature. # when execute `add jar foo.jar` , need to store this jar list to `SessionContext` as a member variable . # final when execute a select/insert/update sql , it need to load this jar to `URLClassLoader` in `ExecutionContext` because invoke sql by ` context.wrapClassLoader(() -> tEnv.executeInternal(operation))` in `ExecutionContext` but i has a question , how to support unload a jar use `remove jar` ? > Support ADD JAR command in sql client > - > > Key: FLINK-21464 > URL: https://issues.apache.org/jira/browse/FLINK-21464 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: xiangtao >Priority: Major > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314917#comment-17314917 ] xiangtao commented on FLINK-21464: -- [~fsk119] i'm sorry , my reply is a little late . my implementation plan is as follows: # sql-client has one option `-j` that cloud add jar to sql classpath. so i can use this feature. # when execute `add jar foo.jar` , need to store this jar list to `SessionContext` as a member variable . # final when execute a select/insert/update sql , it need to load this jar to `URLClassLoader` in `ExecutionContext` because invoke sql by ` context.wrapClassLoader(() -> tEnv.executeInternal(operation))` in `ExecutionContext` but i has a question , how to support unload a jar use `remove jar` ? > Support ADD JAR command in sql client > - > > Key: FLINK-21464 > URL: https://issues.apache.org/jira/browse/FLINK-21464 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Assignee: xiangtao >Priority: Major > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309475#comment-17309475 ] xiangtao commented on FLINK-21464: -- [~fsk119] , [~jark] please assign to me. maybe I can try to implement this feature. > Support ADD JAR command in sql client > - > > Key: FLINK-21464 > URL: https://issues.apache.org/jira/browse/FLINK-21464 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Client >Affects Versions: 1.13.0 >Reporter: Shengkai Fang >Priority: Major > Fix For: 1.13.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306474#comment-17306474
]
xiangtao commented on FLINK-21701:
--
hi [~fsk119] , I already push a PR at
[https://github.com/apache/flink/pull/15332] , I hope you can review this PR .
thanks!
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: pull-request-available, starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305861#comment-17305861
]
xiangtao commented on FLINK-21701:
--
[~fsk119] ， Thanks for your advice. i will add more test case and submit a PR.
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305661#comment-17305661
]
xiangtao commented on FLINK-21701:
--
Hi [~fsk119],
I have finished first version . the code is located in
[https://github.com/xiangtao/flink/commit/6fe285044f1caee4d83165f0e5b76d61bbffe718
|https://github.com/xiangtao/flink/commit/6fe285044f1caee4d83165f0e5b76d61bbffe718]for
temporary use. You can review the design and the code and I will be very
happy to hear your advices.
the main implement logic is :
# Add a method resetSessionProperty(String sessionId, String key) in Executor
interface
# Add a method reset(String key) in SessionContext
I wonder if I should add methods in Executor ? because i can't get
SessionContext or DefaultContext refrence in CliClient.
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304869#comment-17304869
]
xiangtao commented on FLINK-21701:
--
[~fsk119] , thanks for you suggestion , i will try it , and implement . then
i will share my code soon.
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304268#comment-17304268
]
xiangtao edited comment on FLINK-21701 at 3/18/21, 4:36 PM:
hi [~fsk119] :
mybe i can implement this feature , my thoughts are as follows :
# need to set SqlCommand.RESET define one SINGLE_OPERAND param in
SqlCommandParser
# need to rewrite callReset method in CliClient to reset ExecutionContext for
corresponding key value , this can invoke setSessionProperty(String sessionId,
String key, String value) method in LocalExecutor
that all my idea , has any other suggestions ?
was (Author: xiangtao):
hi [~fsk119] :
mybe i can implement this feature , my thoughts are as follows :
# need to set SqlCommand.RESET define one SINGLE_OPERAND param in
SqlCommandParser
# need to rewrite callReset method to reset ExecutionContext for corresponding
key value , this can invoke setSessionProperty(String sessionId, String key,
String value) method in LocalExecutor
that all my idea , has any other suggestions ?
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-21701) Support "RESET key" statement in the SQL Client
[
https://issues.apache.org/jira/browse/FLINK-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304268#comment-17304268
]
xiangtao commented on FLINK-21701:
--
hi [~fsk119] :
mybe i can implement this feature , my thoughts are as follows :
# need to set SqlCommand.RESET define one SINGLE_OPERAND param in
SqlCommandParser
# need to rewrite callReset method to reset ExecutionContext for corresponding
key value , this can invoke setSessionProperty(String sessionId, String key,
String value) method in LocalExecutor
that all my idea , has any other suggestions ?
> Support "RESET key" statement in the SQL Client
> ---
>
> Key: FLINK-21701
> URL: https://issues.apache.org/jira/browse/FLINK-21701
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Labels: starter
>
> Allow to reset the specified key by input
> {code:java}
> // code placeholder
> RESET table.planner.type;{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18826) Support to emit and encode upsert messages to Kafka
[
https://issues.apache.org/jira/browse/FLINK-18826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210670#comment-17210670
]
xiangtao commented on FLINK-18826:
--
can it use changelog-format to encode message ?
> Support to emit and encode upsert messages to Kafka
> ---
>
> Key: FLINK-18826
> URL: https://issues.apache.org/jira/browse/FLINK-18826
> Project: Flink
> Issue Type: Sub-task
> Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Table
> SQL / Ecosystem
>Reporter: Jark Wu
>Assignee: Shengkai Fang
>Priority: Major
>
> Currently, it is not possible to emit the results of a group by query into
> Kafka. We can provide a format (e.g. {{upsert-json}}??) to encode changelogs
> to make it possible to write into Kafka. Another idea is provide an
> {{update-mode=upsert}} property, in this way, we can support upsert behavior
> for all the append-only formats (avro, avro-confluent, json, csv) without
> changing the implementation of the formats. The update-mode came from kafka
> connector [1] before 1.10, but was dropped after that.
> [1]:
> https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/table/connect.html#update-modes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-11754) Translate the "Roadmap" page into Chinese
[ https://issues.apache.org/jira/browse/FLINK-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778811#comment-16778811 ] xiangtao commented on FLINK-11754: -- How do i Assignee this task to me ? > Translate the "Roadmap" page into Chinese > - > > Key: FLINK-11754 > URL: https://issues.apache.org/jira/browse/FLINK-11754 > Project: Flink > Issue Type: Sub-task > Components: chinese-translation, Project Website > Environment: The markdown file will be located in: > flink-web/roadmap.zh.md > The url link is: https://flink.apache.org/zh/roadmap.html > Please start to work after the prior PR > https://github.com/apache/flink-web/pull/178 is merged. >Reporter: Jark Wu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
