[GitHub] [flink] KurtYoung commented on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink
KurtYoung commented on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-958645030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink
KurtYoung commented on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-958645030 If such issue already caused a bug, i'd prefer to at least add a test when we trying to fix it. Even the change itself looks tiny, but given it already causes real issue, it's still worth to add a test to prevent future risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink
KurtYoung commented on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-958645030 If such issue already caused a bug, i'd prefer to at least add a test when we trying to fix it. Even the change itself looks tiny, but given it already causes real issue, it's still worth to add a test to prevent future risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
