[GitHub] [flink] MartijnVisser commented on pull request #22438: Add method setMaxParallelism to DataStreamSink.

2023-04-25 Thread via GitHub


MartijnVisser commented on PR #22438:
URL: https://github.com/apache/flink/pull/22438#issuecomment-1522085769

   @ericxiao251 Could you change your commit messages to fit with 
https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#4-commit-naming-conventions
 ? That will also auto-link the Jira ticket and your PR together


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] MartijnVisser commented on pull request #22438: Add method setMaxParallelism to DataStreamSink.

2023-04-21 Thread via GitHub


MartijnVisser commented on PR #22438:
URL: https://github.com/apache/flink/pull/22438#issuecomment-1517405943

   @ericxiao251 Like I've mentioned in the Jira ticket, please open a 
discussion thread in the Dev mailing list first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org