[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-09 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-724420531


   @klion26 I made a little change on the branch information. Please take a 
look.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-09 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-724402907


   > @RocMarshal When I pull your branch locally, seems there are two other 
commits between 
[296c869](https://github.com/apache/flink/commit/296c869ceac85a5fd5c880a371f3bc6941f97acb)
 and 
[9793b9c](https://github.com/apache/flink/commit/9793b9c23786a99b65dbe044f84fb5d1232add20),
 I'm not sure why could this happen, could you please double-check it on your 
side?
   > 
   > And very much appreciate it if you could squash the commit into a single 
one, I'm not very familiar with merge commit into master currently :)
   > 
   > ```
   > 275378338d (HEAD -> RE_13750, R13750) Update 
docs/monitoring/checkpoint_monitoring.zh.md
   > 1ec411ddcf Update docs/monitoring/checkpoint_monitoring.zh.md
   > 9793b9c237 Update docs/monitoring/checkpoint_monitoring.zh.md
   > 726435e10d [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' 
page of 'Debugging & Monitoring' into Chinese
   > 3b9e20aafc [FLINK-17528][table] Remove ArrayData#get() API and use 
ElementGetter instead
   > debbdc66a4 [FLINK-17528][table] Remove RowData#get() API and use 
FieldGetter instead
   > 296c869cea [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' 
page of 'Debugging & Monitoring' into Chinese
   > ```
   
   @klion26 I'll check it as soon as possible. Thank you for your reply.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-11-07 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-723521553


   @dianfu 
   Could you help me to merge this PR if there is nothing inappropriate ?
   
   Thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-10-30 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-719256518


   @xccui 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-10-28 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-718102068


   @klion26 
   Thank you  for your help.
   I made some change based  on  your suggestions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-10-24 Thread GitBox 


RocMarshal commented on pull request #13750:
URL: https://github.com/apache/flink/pull/13750#issuecomment-715906722


   Hi, @klion26
   Could you help me to review this PR if you have free time?
   Thank you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org