[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-25 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-948195266


   @wuchong I really appreciate it. I make some change based on your 
suggestions.  PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-14 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-941932352


   @leonardBang @dawidwys @pnowojski  Could you help me to merge it if there 
are nothing inappropriate ? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-13 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-941932352


   @leonardBang @dawidwys Could you help me to merge it if there are nothing 
inappropriate ? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-13 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-941932352


   @leonardBang @dawidwys Could you help me to merge it if there are nothing 
inappropriate ? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-12 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-932249100


   Thanks @Airblader for the review. 
   Hi, @wuchong , @xintongsong @twalthr @rmetzger   @pnowojski @fsk119 . Could 
you help me to merge it if there are nothing inappropriate ? Thank you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-11 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-932249100


   Thanks @Airblader for the review. 
   Hi, @wuchong , @xintongsong @twalthr @dawidwys  @pnowojski @fsk119 . Could 
you help me to merge it if there are nothing inappropriate ? Thank you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-09 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-932249100


   Thanks @Airblader for the review. 
   Hi, @wuchong , @xintongsong @twalthr @tisonkun @pnowojski @fsk119 . Could 
you help me to merge it if there are nothing inappropriate ? Thank you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-08 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-932249100


   Thanks @Airblader for the review. 
   Hi, @wuchong , @xintongsong @twalthr @tisonkun @pnowojski . Could you help 
me to merge it if there are nothing inappropriate ? Thank you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-02 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-932249100


   Thanks @Airblader for the review. 
   Hi, @wuchong , @xintongsong @twalthr @tisonkun . Could you help me to merge 
it if there are nothing inappropriate ? Thank you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-09-27 Thread GitBox


RocMarshal edited a comment on pull request #17352:
URL: https://github.com/apache/flink/pull/17352#issuecomment-927206639


   @Airblader @wuchong Thank you for your comments. I made some changes based 
on your suggestions. Please let me know what's your opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org