[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-21 Thread GitBox


SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-764192618


   @zhuzhurk , I have merged these commits into two commit and CI result is 
successful. Please check it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-20 Thread GitBox


SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-764192618


   @zhuzhurk , I have merged these commits into two commit and CI result is 
successful. Please check it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-20 Thread GitBox


SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-763439100


   @zhuzhurk , I have separated the commit for removing `resetForNewExecution` 
from `ExecutionJobVertex` and modified the previous commit that only remove the 
comments in `ExecutionGraph`. Please help to review again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-19 Thread GitBox


SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-762825923


   @zhuzhurk , thanks for your detailed review. I have followed your comments 
and modified the comments and remove the `resetForNewExecution` in 
`ExecutionJobVertex`. Please help to review again if you are available.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-18 Thread GitBox


SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-762539098


   @tillrohrmann @zhuzhurk , could you please help to review the simple pull 
request?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org