[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-868302862 > Thanks for updating this PR @SteNicholas. To manage a bit your expectations, I am a bit under water these days. Hence, the review from my side might take a bit of time. Sorry for this. @tillrohrmann , how is your review progress? I have rebased the master branch and please help to review again. cc @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-847837350 @tillrohrmann , @zentol , could you please take a look at this pull request? I have already commented on the issue. Any feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-842116214 @tillrohrmann, thanks for the work of reviewing the pull request. And if you are available, please help to review again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-842116214 @tillrohrmann, thanks for the work of reviewing the pull request. And if you are available, please help to review again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-836272578 @tillrohrmann , @zentol , thanks for your detailed reivew. I have updated the constucture of `CheckpointCoordinator` to replace the `checkpointStorage` parameter with the `checkpointStorageView`, which `checkpointStorageView` is created before the creation of `ExecutionGraph`. This change could only execute to read the savepoint once. Please help to review again for this update addressing your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-829896380 @tillrohrmann , thanks for your detailed reivew. I have updated the constucture of `CheckpointCoordinator` to replace the `checkpointStorage` parameter with the `checkpointStorageView`, which `checkpointStorageView` is created before the creation of `ExecutionGraph`. This change could only execute to read the savepoint once. Please help to review again for this update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #15729: [FLINK-22234][runtime] Read savepoint before creating ExecutionGraph
SteNicholas commented on pull request #15729: URL: https://github.com/apache/flink/pull/15729#issuecomment-825402972 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
