[GitHub] [flink] StephanEwen commented on pull request #13366: [FLINK-17393][connector/common] Wakeup the SplitFetchers more elegantly.

2020-09-14 Thread GitBox 


StephanEwen commented on pull request #13366:
URL: https://github.com/apache/flink/pull/13366#issuecomment-692355604


   I incorporated this PR in a follow-up PR with some more changes and bug 
fixes: #13385



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #13366: [FLINK-17393][connector/common] Wakeup the SplitFetchers more elegantly.

2020-09-14 Thread GitBox 


StephanEwen commented on pull request #13366:
URL: https://github.com/apache/flink/pull/13366#issuecomment-692021999


   Thanks @becketqin for creating this patch.
   
   This looks pretty good to me. I will rebase this onto the latest source API 
classes and merge this.
   Will also apply some minor cleanups that are made possible now with this fix 
(like removing some interruption clearing and some exceptions from signatures).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org