[GitHub] [flink] TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient
TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935#issuecomment-544860844 Thanks Aljoscha for your review. I'm going to exclude detach from `ClusterClient` now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient
TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935#issuecomment-544464764 @aljoscha I reverted the last two hotfix as well as revert renames. I agree that we shouldn't change methods without a clear reason. However, I think we should not think too much now of users using `ClusterClient` since it is already breaks between 1.9 and 1.10 as well as we can start serving a public interface once it becomes stable instead of keeping internal method arbitrarily "compatible". See also https://lists.apache.org/x/thread.html/e6536ad385ae1fe41006309dfb3e808c12195aeb8d425c52c86d4ce6@%3Cdev.flink.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient
TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935#issuecomment-544459252 Thanks for your review @aljoscha & @kl0u . I will exclude the latest 2 hotfixes from this patch so that we focus on the remove & shift down on field. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient
TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935#issuecomment-544099034 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient
TisonKun commented on issue #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935#issuecomment-543785721 It is interesting that both `ClusterClient#getAccumulators` are used only in tests. Although we have a REST accumulator API I'm curious about the usage of `ClusterClient#getAccumulators`. IIUC accumulator is a batch only conception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
