[GitHub] [flink] WencongLiu commented on a diff in pull request #23058: Remove parameter in RichFunction#open
WencongLiu commented on code in PR #23058:
URL: https://github.com/apache/flink/pull/23058#discussion_r1289525904
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java:
##
@@ -96,7 +96,7 @@ public AbstractRowTimeUnboundedPrecedingOver(
}
@Override
-public void open(Configuration parameters) throws Exception {
+public void open(OpenContext openContext) throws Exception {
Review Comment:
Thanks for your review @lsyldliu. This pull request is not yet ready. All
classes that override the `open(Configuration parameters)` should be migrated
to `open(OpenContext openContext)`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23058: Remove parameter in RichFunction#open
WencongLiu commented on code in PR #23058:
URL: https://github.com/apache/flink/pull/23058#discussion_r1289525904
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java:
##
@@ -96,7 +96,7 @@ public AbstractRowTimeUnboundedPrecedingOver(
}
@Override
-public void open(Configuration parameters) throws Exception {
+public void open(OpenContext openContext) throws Exception {
Review Comment:
Thanks for your review @lsyldliu. This pull request is not yet ready. All
classes that override the `open(Configuration parameters)` should be migrated
to `open(OpenContext openContext)`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
