[GitHub] [flink] XComp commented on pull request #19351: [FLINK-27045][tests] Remove shared executor

2022-04-05 Thread GitBox 


XComp commented on PR #19351:
URL: https://github.com/apache/flink/pull/19351#issuecomment-1088873839

   hm, I shouldn't have approved the build, yet, considering the ci failure and 
that the ci is not done, yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] XComp commented on pull request #19351: [FLINK-27045][tests] Remove shared executor

2022-04-05 Thread GitBox 


XComp commented on PR #19351:
URL: https://github.com/apache/flink/pull/19351#issuecomment-1088626016

   ...and `JMXJobManagerMetricTest` has a compilation error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [flink] XComp commented on pull request #19351: [FLINK-27045][tests] Remove shared executor

2022-04-04 Thread GitBox 


XComp commented on PR #19351:
URL: https://github.com/apache/flink/pull/19351#issuecomment-1087575899

   We might want to switch to a `ExecutorServiceResource` that takes care of 
shutting the thread pool down at the end of the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org