[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2020-01-15 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574942577
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2020-01-15 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574942495
 
 
   travis on ce56c02 failed with `BackPressureITCase` which is tracked in 
[FLINK-15247](https://issues.apache.org/jira/browse/FLINK-15247), and rerun 
travis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2020-01-15 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-574734638
 
 
   @kl0u Thanks for your review.  In `StreamingFileSink` end-to-end test, 
`OnCheckpointRollingPolicy` ensures in-progress part files will be rolled to 
part files finally, so I think there is no need to enable inactive check. I 
update the PR, and please have a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2020-01-06 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-571470741
 
 
   @kl0u Can you help to review this PR? Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2020-01-02 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-570495127
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2019-12-26 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-569085964
 
 
   @flinkbot run azure


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink test to make it more stable and comprehensible

2019-12-25 Thread GitBox
banmoy commented on issue #10685: [FLINK-14843][e2e] Refactor bucketing sink 
test to make it more stable and comprehensible
URL: https://github.com/apache/flink/pull/10685#issuecomment-568911583
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services