[GitHub] [flink] curcur commented on pull request #15674: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

2021-04-26 Thread GitBox


curcur commented on pull request #15674:
URL: https://github.com/apache/flink/pull/15674#issuecomment-827331397


   doc checks seem to fail:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] curcur commented on pull request #15674: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

2021-04-20 Thread GitBox


curcur commented on pull request #15674:
URL: https://github.com/apache/flink/pull/15674#issuecomment-823200663


   @maver1ck Thanks for reporting and fixing this!
   
   1. Would you mind changing the commit-msg from "Fix for FLINK-22311" to 
something more informative, like
   "[FLINK-22311] [connector/jdbc] ",  same as your PR title
   
   2. I think precheck is good, but what do you think we set 
`JdbcExecutionOptions`.maxRetries = 0 directly and document it?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org