[GitHub] [flink] curcur edited a comment on pull request #15674: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink
curcur edited a comment on pull request #15674: URL: https://github.com/apache/flink/pull/15674#issuecomment-827331397 doc checks seem to fail: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17083=logs=c5d67f7d-375d-5407-4743-f9d0c4436a81=38411795-40c9-51fa-10b0-bd083cf9f5a5 Would you please try `mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests` to regenerate docs? Or I can simply put this into the doc follow-up: https://github.com/apache/flink/pull/15720/commits/e69548aec17fdffe8a60dee7a4a58d3966ee06e7 And you can finish the pre-check before 1.13 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #15674: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink
curcur edited a comment on pull request #15674: URL: https://github.com/apache/flink/pull/15674#issuecomment-823200663 @maver1ck Thanks for reporting and fixing this! 1. Would you mind changing the commit-msg from "Fix for FLINK-22311" to something more informative, like "[FLINK-22311] [connector/jdbc] ", same as your PR title 2. I think precheck is good enough, but what do you think we set `JdbcExecutionOptions`.maxRetries = 0 directly and document it? Up to you, if you fix the check style failure, I can accept the diff. You can do `mvn spotless:apply` to fix most of the check style problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
