[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on PR #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-1453759473 This connector has been moved to https://github.com/apache/flink-connector-aws/tree/main/flink-formats-aws/flink-avro-glue-schema-registry. Closing PR. Please reopen targeting flink-connector-aws -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on PR #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-1094738305 Hello @jherico, sorry for delay. Yes I concur, the test I linked is based on DataStream API. > should I refactor both to use a common base class If this is still a concern based on the recent question, yes please, removing duplicated code would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on PR #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-1087483377 @MartijnVisser we do not have capacity to pick it up right now. If we do not hear back from @jherico then we could potentially pick it up sometime before the 1.16 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-932115740 > Can you please add an e2e test for the Table API support? Bump: [Here](https://github.com/apache/flink/blob/master/flink-end-to-end-tests/flink-glue-schema-registry-avro-test/src/test/java/org/apache/flink/glue/schema/registry/test/GlueSchemaRegistryAvroKinesisITCase.java) is an example. Note that keys need to be provided via `IT_CASE_GLUE_SCHEMA_ACCESS_KEY` and `IT_CASE_GLUE_SCHEMA_SECRET_KEY`. The Flink CI provides keys to run the tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-928976369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-929000972 We will also need a documentation update similar to this: - https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/formats/avro-confluent/ If you do not have capacity to contribute this can you please raise a follow up Jira and link to this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API
dannycranmer commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-928976369 Can you please add an e2e test for the Table API support? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
