[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-559461704 @aljoscha updated the PR with the changes we talk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-559196761 I think we should be prepared to add other implementations without problem, for example the flink-sequence-files could be absorbed by this module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-559158490 @aljoscha all changes done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-559152148 Hi @aljoscha, I will do the changes.. Some points: HadoopCompressionWriters -> this was a builder because we have to set 2 fields, the extractor and the codec, making this static we multiplicate the number of combinations. Compressor -> this was to allow other implementations (initial this is using apache codecs) and SequenceFiles, that are in flink-sequence-files and for that reason removed. "no-compression" mode -> this has set to allow to change to a no-compression mode (for debug for example) without change the implementation of job This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-558528612 hi @aljoscha, any possibility of having this merged in the next release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-525004541 @flinkbot attention @kl0u This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink
eskabetxe commented on issue #9434: [FLINK-13634][Formats]: added module to compress data using StreamingFileSink URL: https://github.com/apache/flink/pull/9434#issuecomment-521182591 @kl0u could you check this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
