[GitHub] [flink] flinkbot commented on issue #8956: [FLINK-12991][python] Correct the implementation of Catalog.get_table_factory

2019-07-08 Thread GitBox
flinkbot commented on issue #8956: [FLINK-12991][python] Correct the 
implementation of Catalog.get_table_factory
URL: https://github.com/apache/flink/pull/8956#issuecomment-509323086
 
 
   CI report for commit 7e6ec160a5081dd4542806c2d0876b88f4f4b2b8: FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/118318844)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #8956: [FLINK-12991][python] Correct the implementation of Catalog.get_table_factory

2019-07-02 Thread GitBox
flinkbot commented on issue #8956: [FLINK-12991][python] Correct the 
implementation of Catalog.get_table_factory
URL: https://github.com/apache/flink/pull/8956#issuecomment-507905839
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/reviewing-prs.html) for a full explanation of 
the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services